[{"id":33606,"web_url":"https://patchwork.libcamera.org/comment/33606/","msgid":"<174223397250.3394313.18322046350557372108@ping.linuxembedded.co.uk>","date":"2025-03-17T17:52:52","subject":"Re: [PATCH] gstreamer: Add Y444 format support to the YUV list","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Antoine Bouyer (2025-03-17 16:10:50)\n> 'imx8-isi' pipeline provides support for 'YUV444' PixelFormat with YUV\n> streams, but it cannot be played with gstreamer adapter whereas\n> gstreamer's video format 'Y444' value suggests that it also supports\n> this format.\n\n'Suggests'? I think we can be a bit more confident in the wording that\nwe expect Y444 from gstreamer to be mapped to the YUV444 from libcamera.\n\nI assume you have tested this as well, so we can 'confirm' that this is\nindeed the correct format mappings ?\n\n> \n> To add support of Planar 4:4:4 YUV format in gstreamer adapter, this patch\n> maps 'Y444' gstreamer video format with 'YUV444' libcamera PixelFormat.\n> \n> Then below command example can be used to capture a stream with imx8-isi\n> pipeline:\n> \n> gst-launch-1.0 \\\n> libcamerasrc camera-name= ! \\\n> video/x-raw, format=Y444, width=1280, height=800 ! \\\n> queue ! \\\n> filesink location=/tmp/output\n\nNot always something we would have in the commit message, but I think\nclearly stating how this is tested here is useful!\n\n> \n> Signed-off-by: Antoine Bouyer \n\nOverall, that's an easy one :-)\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index a466b30..41eea7d 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -74,6 +74,7 @@ static struct {\n> { GST_VIDEO_FORMAT_I420, formats::YUV420 },\n> { GST_VIDEO_FORMAT_YV12, formats::YVU420 },\n> { GST_VIDEO_FORMAT_Y42B, formats::YUV422 },\n> + { GST_VIDEO_FORMAT_Y444, formats::YUV444 },\n> \n> /* YUV Packed */\n> { GST_VIDEO_FORMAT_UYVY, formats::UYVY },\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A562CC32FA\n\tfor ;\n\tMon, 17 Mar 2025 17:52:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67B0368942;\n\tMon, 17 Mar 2025 18:52:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FB3A617F8\n\tfor ;\n\tMon, 17 Mar 2025 18:52:55 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A954E8DB;\n\tMon, 17 Mar 2025 18:51:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iU9S2n3+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742233873;\n\tbh=gxJFxRanmbxxqYnXLDbYpPOI3T4jUi2n/HYh1wxqyW8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=iU9S2n3+ndQSVd1AafFyZic7RLGwaaVHZF6yeICo/2OYb0vbEznybajYMR5mqS2OP\n\t+IrQXaLoynBHaQCdDH/k5IHQS7dRGwWwsb+XHeGXcmISDB/D6IzFs+2AL21dJKLgqi\n\tu/Wr+y+Gj/2LvF9VzNJZvu3o+H4KGlL9EsHMuFys=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250317161050.2008382-1-antoine.bouyer@nxp.com>","References":"<20250317161050.2008382-1-antoine.bouyer@nxp.com>","Subject":"Re: [PATCH] gstreamer: Add Y444 format support to the YUV list","From":"Kieran Bingham ","Cc":"Antoine Bouyer ","To":"Antoine Bouyer ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 17 Mar 2025 17:52:52 +0000","Message-ID":"<174223397250.3394313.18322046350557372108@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33631,"web_url":"https://patchwork.libcamera.org/comment/33631/","msgid":"","date":"2025-03-18T10:56:08","subject":"Re: [EXT] Re: [PATCH] gstreamer: Add Y444 format support to the YUV\n\tlist","submitter":{"id":218,"url":"https://patchwork.libcamera.org/api/people/218/","name":"Antoine Bouyer","email":"antoine.bouyer@nxp.com"},"content":"Hi Kieran,\nThanks for your review.\n\nOn 17/03/2025 18:52, Kieran Bingham wrote:\n> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button\n> \n> \n> Quoting Antoine Bouyer (2025-03-17 16:10:50)\n>> 'imx8-isi' pipeline provides support for 'YUV444' PixelFormat with YUV\n>> streams, but it cannot be played with gstreamer adapter whereas\n>> gstreamer's video format 'Y444' value suggests that it also supports\n>> this format.\n> \n> 'Suggests'? I think we can be a bit more confident in the wording that\n> we expect Y444 from gstreamer to be mapped to the YUV444 from libcamera.\n\nShould I submit new version of the patch and rephrase commit message \naccordingly ?\n\n> \n> I assume you have tested this as well, so we can 'confirm' that this is\n> indeed the correct format mappings ?\n> \n\nYes I did. Colors are as expected.\n\n>>\n>> To add support of Planar 4:4:4 YUV format in gstreamer adapter, this patch\n>> maps 'Y444' gstreamer video format with 'YUV444' libcamera PixelFormat.\n>>\n>> Then below command example can be used to capture a stream with imx8-isi\n>> pipeline:\n>>\n>> gst-launch-1.0 \\\n>> libcamerasrc camera-name= ! \\\n>> video/x-raw, format=Y444, width=1280, height=800 ! \\\n>> queue ! \\\n>> filesink location=/tmp/output\n> \n> Not always something we would have in the commit message, but I think\n> clearly stating how this is tested here is useful!\n> \n>>\n>> Signed-off-by: Antoine Bouyer \n> \n> Overall, that's an easy one :-)\n> \n> Reviewed-by: Kieran Bingham \n> \n>> ---\n>> src/gstreamer/gstlibcamera-utils.cpp | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n>> index a466b30..41eea7d 100644\n>> --- a/src/gstreamer/gstlibcamera-utils.cpp\n>> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n>> @@ -74,6 +74,7 @@ static struct {\n>> { GST_VIDEO_FORMAT_I420, formats::YUV420 },\n>> { GST_VIDEO_FORMAT_YV12, formats::YVU420 },\n>> { GST_VIDEO_FORMAT_Y42B, formats::YUV422 },\n>> + { GST_VIDEO_FORMAT_Y444, formats::YUV444 },\n>>\n>> /* YUV Packed */\n>> { GST_VIDEO_FORMAT_UYVY, formats::UYVY },\n>> --\n>> 2.34.1\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA448C32F5\n\tfor ;\n\tTue, 18 Mar 2025 10:56:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 876E968947;\n\tTue, 18 Mar 2025 11:56:05 +0100 (CET)","from EUR05-DB8-obe.outbound.protection.outlook.com\n\t(mail-db8eur05on20611.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:2614::611])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D837687FA\n\tfor ;\n\tTue, 18 Mar 2025 11:56:04 +0100 (CET)","from GVXPR04MB9831.eurprd04.prod.outlook.com (2603:10a6:150:11c::8)\n\tby AS8PR04MB8136.eurprd04.prod.outlook.com (2603:10a6:20b:3f7::9)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.33;\n\tTue, 18 Mar 2025 10:56:01 +0000","from GVXPR04MB9831.eurprd04.prod.outlook.com\n\t([fe80::4634:3d9c:c4a:641a]) by\n\tGVXPR04MB9831.eurprd04.prod.outlook.com\n\t([fe80::4634:3d9c:c4a:641a%6]) with mapi id 15.20.8534.031;\n\tTue, 18 Mar 2025 10:55:59 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"cqjn+86Q\";\n\tdkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=iYqyMZ+U6ffsCZriiZp+jiuJMAoA2CFifRdYil4z2XxKDS/pWnfxAQErB6JZeQCgw90ukSpQ51nRa4rwVN5+3Kc6sEsw+KOSydWTuL2DTvsoqkPLvSnXRLyBmlLEDExrcsbhNcoahLAq7EzbSW+eNj4USlVv792S6RA+vQikFvY8FdS9P6yQhF2x1m6rRjclGsUsvBl8QKHqo3eZvoR3Nze0gF7HoptGtfmHtjF8wT5w3EWrboBoWI3Aq/INsphW3GnifUIVVtjvexbb2z8xip+srMrtDEzURzCbo143RsX4q1Kyt7edQFj3znkilzaBP0A6K/g7+Xdrc8D9U+2c2A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=v+WcYDkw2apHqEkoC7MOJGLFyqlnlKBk4vX9mKnNZhY=;\n\tb=bYvck6TMHEiqM1670MHmIGMuvXQrznzxiIS2A3/KZL6lNXSLdTFs6ELsD8Zanst3RU9iPTVv82nflsofia0tzcxVvbJNLrG5ZhxpeJfiAQoyvj7+hAIcO0SLhFpLKwHF+w9effskPG3IkHyEeaLQCMny0Zjtml+fp1sljUTZCELIVwkOEp++GQ+nqGnh/Of2QxP0EgbDRmqCFlxXXBNT7VKWnhFR1deM2s7qi/km1sd+/RMb/0Y+58k3CjH/r53aAmtXJj7CORSBd+RMSxjnPZDluHX0kc9OXX1xYmTJgz0AZE1G9tMpZTK4/Pn5F2I9BNmoB0HkrsuaZzJNrJ8JPg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=v+WcYDkw2apHqEkoC7MOJGLFyqlnlKBk4vX9mKnNZhY=;\n\tb=cqjn+86QdaoADcF8T8vIbscKe16mgSW3Jf1EN5i1r4ln3Sz6Ynl2dJtNWGO6KiUjmc7dxV48bXUqI3wRGLOvseEnCBxlxq3JdRpycbv6EN4PCCUPUFK1DY3zwMuRblqIlcj6/ALK8Sk+pWX9R2onhaNuSM0UGphF9adSMCmt6LBCW93UsbPTFiQPuYqu/jbEUU4e0WO07uC/plJHACEhIo3FCQaKRtc/yy9exW7Yr3IRhyHJzH9ZTZa9JrOrj9VyRB8OFKpIBXwhAEtksOttKPZioMfYhcNxItjozz8oywnBxgyLz/VE/yJDhXOaaU9lYXVyAmxCKKzWttQ8JGVkyg==","Message-ID":"","Date":"Tue, 18 Mar 2025 11:56:08 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [EXT] Re: [PATCH] gstreamer: Add Y444 format support to the YUV\n\tlist","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250317161050.2008382-1-antoine.bouyer@nxp.com>\n\t<174223397250.3394313.18322046350557372108@ping.linuxembedded.co.uk>","Content-Language":"en-US","From":"Antoine Bouyer ","In-Reply-To":"<174223397250.3394313.18322046350557372108@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"AM0PR07CA0017.eurprd07.prod.outlook.com\n\t(2603:10a6:208:ac::30) To GVXPR04MB9831.eurprd04.prod.outlook.com\n\t(2603:10a6:150:11c::8)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"GVXPR04MB9831:EE_|AS8PR04MB8136:EE_","X-MS-Office365-Filtering-Correlation-Id":"c21287a8-1c9c-45b0-343b-08dd660b776a","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0; ARA:13230040|1800799024|376014|366016|7053199007;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?ojIbpqjgCeI/nVn7jj8iv92U3Z36?=\n\t=?utf-8?q?E9Y05YyAINJex9ILa73HwQEYv/mGMXHYr7t+6karYjSfrursUnUHsXAh?=\n\t=?utf-8?q?YB8+8UAbUQ7oqlMnJ/wx7ro1a/T9F1A04tsbUD+RPN4kuCrRBkfIpVFl?=\n\t=?utf-8?q?h3rg775x1dlEyufIYjJxOfMFZzPbbhprN/GoF2qjfSJBCtwhpatS6iKf?=\n\t=?utf-8?q?ksiGoGecrGmAKH/l9eIkv2zOFmg0pXjgBhb8fpVYhnrbMsCj1+WKeAan?=\n\t=?utf-8?q?yHiA2VF9fpikAtgKcxfxnfFEqeUc+e1apfWWAurZiIoc+fXm6MkgeuVE?=\n\t=?utf-8?q?3cdC6WtAhDJiCDF+1kZbCPiKCSit7/n05LqPC4O0f3eove7ydPADOhGJ?=\n\t=?utf-8?q?LPJ0gIH77JKWd4CNeGgDiVFPA0EzVkLKIcF9lmMb8Xl4FCx480Olugsf?=\n\t=?utf-8?q?4pUdItOEOZgusZuM8z7qsPrBKFUT47bzeZQT1ZN3+WLzSm9jaSbhuJtJ?=\n\t=?utf-8?q?ze7dQd3BVM23IqJD0V9QLpbIKaLmEDBFLxfdAWyfmDlxhQM2WYW+UhXO?=\n\t=?utf-8?q?5BvwMknWP6/jT7VvK1FUix9VMaBK3fumpi7xu5OrG6VlpvNnhGDOimBe?=\n\t=?utf-8?q?O3L0D7X3VRMapMns92ViHQte+ZFCFW9wjdbo3YRHJnuVf4RUe1wGW62Q?=\n\t=?utf-8?q?CXkfWvxuq6nKnJHjnebBZDOhMNoGuLzkVQBkLS9MkSbqYfN4/wXZ+DQA?=\n\t=?utf-8?q?CP36VDlOvH63zXiGXsVo5Sr2xEJ91VlgGHqpyKZXpdb1pLWJACY1mIl9?=\n\t=?utf-8?q?e4pvJDofTSL3Nbj+5rEOkPzccwqJn0LMBdVs76/xov5CgnzfxU8xd327?=\n\t=?utf-8?q?OhQSfwbm5z+1wjdtJtSldTPcWk9XtO82pDqT02KXUtgTRPsT4dmanXU+?=\n\t=?utf-8?q?YgV0pvLV4wqyAcwAWgC5CrX6+YtvoRsti+FIK9RZWUdAazxkbMBR6z1l?=\n\t=?utf-8?q?2QsyrLFTq3cj6nd+Ux+8O5pLkJnfaDV7GaBxpabp/htOrlg0QK519r8C?=\n\t=?utf-8?q?cpB+f3/zG7+0I0GKqqnkpdn5VhOkE7yyEh15l0738KLvmO2Ui8vvYV/F?=\n\t=?utf-8?q?ABtXUka+hy92IOUy5+PiIpJZwGj/wVyr6TvWcwidCOj6GhdoWaWkHe+p?=\n\t=?utf-8?q?CNEhtYIVENFJpJLfhcgzhth/yLqxAP9y7T2OOxr/rkQb13WGn8WuTwZn?=\n\t=?utf-8?q?nsgk180AFIajU4yqu/xGaeKuyYL9f0jW2qeODZIb4/toBzhwvY2tQpkN?=\n\t=?utf-8?q?DqZVSeWhW06cL/S0ajo/S+Enz1Q3LDb1H/kUFYZ9mIfJeZ8MrkT4eaTy?=\n\t=?utf-8?q?G6JHt8EDhiOL8S0zBSwLb/ZxNDQTnAtGAYnfoF67v+yhTuqsLG8ZVUk/?=\n\t=?utf-8?q?Yw6R4UnOEse9VltGVtiGT1PRprbuKVXEUcTwP9eQWQ6QUMaMRhoqam5t?=\n\t=?utf-8?q?nP6CYnaAXpOho/O7YxbAZge9nF/XBUVakwYG?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:GVXPR04MB9831.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(1800799024)(376014)(366016)(7053199007); DIR:OUT;\n\tSFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?pPDJy5c/MBJHYQ3+7ct9b4jta?=\n\t=?utf-8?q?QOgY6hPWxey0NpDhGXGdfomaZZcH8cAl0nBkRes+eZOSH8LNRlCfH5jR?=\n\t=?utf-8?q?vvYE+A2UN07H3uft24OVZCYWYgC0ThNRQWDfufJNOE8zFOdkykVPRuiW?=\n\t=?utf-8?q?gfQ7z+7vtTfMYqweTNuuePHBHuJRdY8LsYhbIRuKOQ3anDf4g1KCAZm6?=\n\t=?utf-8?q?EgZn2HwApy9HR8jOHUoNtrJ4LB4SBcYUafzWkYVj0cOXHdFOEht0gXXx?=\n\t=?utf-8?q?jRq+9QS6K0sOsGLK1ldwn6k4Yp4dKucsuId0sDeqV3/W2vMvD3MYv7Mf?=\n\t=?utf-8?q?KsDU30M/QUR88kpQ/zmiKf0AnZRJaeJaMx5N4WXAMMdnf3PLADRiDVNj?=\n\t=?utf-8?q?QNBrnccnslY7LwDugzmrvynwhLUohyu83HY5OZH70bStautzHYNqqgcS?=\n\t=?utf-8?q?pU7sINQP9FDXyBC+TVGS9YfIh1t4b8Ngjq8Mchp3TsBxPxaj1ROYVbHs?=\n\t=?utf-8?q?Qi6W74azHTnmIHz9Mrs/vexIvOP2JYqPxbL+SWgRUgoGYjJ5BGwt1aj7?=\n\t=?utf-8?q?ZaXnVXwyjT9UoQFWhFqS8s3CV947h43AnohD6wb64YDc5CZdpQty2JHy?=\n\t=?utf-8?q?fTP7snSmSp/2xuSyUoclYgStMg12jJcSy6cvFM96yQwaAAN39Ltwh4gu?=\n\t=?utf-8?q?HjPfUAHtweoV2dgPZglmUmJRXpppSQajf32UVZNRvW2CY7t++mOV/jay?=\n\t=?utf-8?q?0yNtg7G0ToiArvIjaMbqiEnyfNeRxd+5D6nu6MOR1B8TTECWVrWjr0+3?=\n\t=?utf-8?q?M2ZaNu+QQqCPSo50WFkmNPJnaGfUyWR5iVGzW2I2AhR2IpaKS/WmJRh0?=\n\t=?utf-8?q?kB/IMSq5m/4lL1E4BurKu4oG9XKoJCcd2Xm/jVljmytl6W4BGhHgIifI?=\n\t=?utf-8?q?e4NDCXptXDV4eVEyGIqp5cnSJzN3h77aGSluQc6aVydVbdHAQXoEIKq9?=\n\t=?utf-8?q?77KmV7gcBOfVVSpHfu6J2afxteow0e97iJ9tU0LHSpj4UdmsvVgP4UKY?=\n\t=?utf-8?q?U4hrwGJutAFOG49POXSePW7JKPt6pTFsVtqk5+d/SQNRpJ+6Ww46vF3m?=\n\t=?utf-8?q?Q/o5F59dUFVfJdHHO4Q9Clgf1v3LP1vRguNRvE7YgasGHa9GaHOYZZhH?=\n\t=?utf-8?q?OtCrYos2Agyffp1YQWbeoSkuuTQoJQjIXJUHoo5SJE3XZxkGwCp0+v00?=\n\t=?utf-8?q?aCHaWtBInizgUaOXMSP+wh2N4PwfOcR2TFkbJ4X4gHlFJxoJBOtx1PDG?=\n\t=?utf-8?q?pj9ayBnxExxZo7lXrcd+h3OGTpxLV1DqGP9FapdIHqA4gTP8ErQLjeHn?=\n\t=?utf-8?q?AZAEKTvR+OOQUhNUL6gqk4FQiX8eARcNqBt7fi2seazMeeKK+yrD1nN9?=\n\t=?utf-8?q?Tz3CBuDRkVIdZsS35cGEmO2HOgD/k86/uW2cED3Qsu4lEB4UXgRpGp/N?=\n\t=?utf-8?q?Pndk429DuxF2kZGqTPz5DiLStxsZe7CPfZX3CzqFB///mjsYbwnuY0bg?=\n\t=?utf-8?q?i+fDkAy95zsbBnrmE6247CsDzaqXrICTKnPCnEXz/70mXoRxiYXSE/kL?=\n\t=?utf-8?q?55M1YPWBbUzINnjxuvgUBYCVDOWQpJdgVFTmX639/iEbqhqMpk2FagKU?=\n\t=?utf-8?q?Osa6YXVbFguT+MB5alRnHX8eDwijP5ZlLOQhc4EP7nWyhpPIpL7grEWJ?=\n\t=?utf-8?q?dMMWwGmixEiIUtetQp8R59M2o7Sow=3D=3D?=","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"c21287a8-1c9c-45b0-343b-08dd660b776a","X-MS-Exchange-CrossTenant-AuthSource":"GVXPR04MB9831.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"18 Mar 2025 10:55:59.2183\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"c6Z4Plg5lK4JIR92MOI26ZOGzCgavZlEqrTajt9H4lb5NYd/56To6VciiIFEI7u3b604LIJ99tVyTvIwfJyxeA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AS8PR04MB8136","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33632,"web_url":"https://patchwork.libcamera.org/comment/33632/","msgid":"<174229659484.1463678.16458960863489686484@ping.linuxembedded.co.uk>","date":"2025-03-18T11:16:34","subject":"Re: [EXT] Re: [PATCH] gstreamer: Add Y444 format support to the YUV\n\tlist","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Antoine Bouyer (2025-03-18 10:56:08)\n> Hi Kieran,\n> Thanks for your review.\n> \n> On 17/03/2025 18:52, Kieran Bingham wrote:\n> > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button\n> > \n> > \n> > Quoting Antoine Bouyer (2025-03-17 16:10:50)\n> >> 'imx8-isi' pipeline provides support for 'YUV444' PixelFormat with YUV\n> >> streams, but it cannot be played with gstreamer adapter whereas\n> >> gstreamer's video format 'Y444' value suggests that it also supports\n> >> this format.\n> > \n> > 'Suggests'? I think we can be a bit more confident in the wording that\n> > we expect Y444 from gstreamer to be mapped to the YUV444 from libcamera.\n> \n> Should I submit new version of the patch and rephrase commit message \n> accordingly ?\n\nNo need at the moment, I'll await a bit more time for more review (ahem,\nmostly because gitlab.freedesktop.org is down this week for migration)\nso I hope this will be collected next week, before the next libcamera\nrelease. There's nothing complex here that I would worry about for\nmerging.\n\nIf you have a more confident wording proposal, we can update the text on\napplying but it doesn't matter too much.\n\n> > I assume you have tested this as well, so we can 'confirm' that this is\n> > indeed the correct format mappings ?\n> > \n> \n> Yes I did. Colors are as expected.\n\nGreat! Thanks for confirming.\n\n--\nKieran\n\n> \n> >>\n> >> To add support of Planar 4:4:4 YUV format in gstreamer adapter, this patch\n> >> maps 'Y444' gstreamer video format with 'YUV444' libcamera PixelFormat.\n> >>\n> >> Then below command example can be used to capture a stream with imx8-isi\n> >> pipeline:\n> >>\n> >> gst-launch-1.0 \\\n> >> libcamerasrc camera-name= ! \\\n> >> video/x-raw, format=Y444, width=1280, height=800 ! \\\n> >> queue ! \\\n> >> filesink location=/tmp/output\n> > \n> > Not always something we would have in the commit message, but I think\n> > clearly stating how this is tested here is useful!\n> > \n> >>\n> >> Signed-off-by: Antoine Bouyer \n> > \n> > Overall, that's an easy one :-)\n> > \n> > Reviewed-by: Kieran Bingham \n> > \n> >> ---\n> >> src/gstreamer/gstlibcamera-utils.cpp | 1 +\n> >> 1 file changed, 1 insertion(+)\n> >>\n> >> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> >> index a466b30..41eea7d 100644\n> >> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> >> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> >> @@ -74,6 +74,7 @@ static struct {\n> >> { GST_VIDEO_FORMAT_I420, formats::YUV420 },\n> >> { GST_VIDEO_FORMAT_YV12, formats::YVU420 },\n> >> { GST_VIDEO_FORMAT_Y42B, formats::YUV422 },\n> >> + { GST_VIDEO_FORMAT_Y444, formats::YUV444 },\n> >>\n> >> /* YUV Packed */\n> >> { GST_VIDEO_FORMAT_UYVY, formats::UYVY },\n> >> --\n> >> 2.34.1\n> >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84F03BD1F1\n\tfor ;\n\tTue, 18 Mar 2025 11:16:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 545A868947;\n\tTue, 18 Mar 2025 12:16:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6EC1968940\n\tfor ;\n\tTue, 18 Mar 2025 12:16:37 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E9A8778;\n\tTue, 18 Mar 2025 12:14:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PeeF3niN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742296495;\n\tbh=WPbgWHDUP0CV7BXVC1Spzt+J9J0OzIsr81eJbhYHuOY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=PeeF3niNCg4NBQqHcIIWPbo2pDe2WILKolK+Sp8s2VFpfor4bMr9T1KUdyP+4kD32\n\tsKQtt8lI3jz38dDwEtFDeswiNg7UGTihzrMHk0CU/1KCQUKYhWicj5wfQsEBwfWZMd\n\tkADQ10oYRs6BftPk1k+neASDdl2+GPMHltilAaL0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250317161050.2008382-1-antoine.bouyer@nxp.com>\n\t<174223397250.3394313.18322046350557372108@ping.linuxembedded.co.uk>\n\t","Subject":"Re: [EXT] Re: [PATCH] gstreamer: Add Y444 format support to the YUV\n\tlist","From":"Kieran Bingham ","To":"Antoine Bouyer ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 18 Mar 2025 11:16:34 +0000","Message-ID":"<174229659484.1463678.16458960863489686484@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33642,"web_url":"https://patchwork.libcamera.org/comment/33642/","msgid":"<1b4233993d5b005b7f816e01ca0b7c107e424981.camel@ndufresne.ca>","date":"2025-03-18T17:09:44","subject":"Re: [PATCH] gstreamer: Add Y444 format support to the YUV list","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le lundi 17 mars 2025 à 17:10 +0100, Antoine Bouyer a écrit :\n> 'imx8-isi' pipeline provides support for 'YUV444' PixelFormat with\n> YUV\n> streams, but it cannot be played with gstreamer adapter whereas\n> gstreamer's video format 'Y444' value suggests that it also supports\n> this format.\n> \n> To add support of Planar 4:4:4 YUV format in gstreamer adapter, this\n> patch\n> maps 'Y444' gstreamer video format with 'YUV444' libcamera\n> PixelFormat.\n> \n> Then below command example can be used to capture a stream with imx8-\n> isi\n> pipeline:\n> \n>   gst-launch-1.0 \\\n>       libcamerasrc camera-name= ! \\\n>       video/x-raw, format=Y444, width=1280, height=800 ! \\\n>       queue ! \\\n>       filesink location=/tmp/output\n> \n> Signed-off-by: Antoine Bouyer \n> ---\n>  src/gstreamer/gstlibcamera-utils.cpp | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp\n> b/src/gstreamer/gstlibcamera-utils.cpp\n> index a466b30..41eea7d 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -74,6 +74,7 @@ static struct {\n>  \t{ GST_VIDEO_FORMAT_I420, formats::YUV420 },\n>  \t{ GST_VIDEO_FORMAT_YV12, formats::YVU420 },\n>  \t{ GST_VIDEO_FORMAT_Y42B, formats::YUV422 },\n> +\t{ GST_VIDEO_FORMAT_Y444, formats::YUV444 },\n\nThanks.\n\nReviewed-by: Nicolas Dufresne \n\n>  \n>  \t/* YUV Packed */\n>  \t{ GST_VIDEO_FORMAT_UYVY, formats::UYVY },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9D9EC326C\n\tfor ;\n\tTue, 18 Mar 2025 17:09:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6C0868947;\n\tTue, 18 Mar 2025 18:09:48 +0100 (CET)","from mail-qk1-x733.google.com (mail-qk1-x733.google.com\n\t[IPv6:2607:f8b0:4864:20::733])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EA3D68940\n\tfor ;\n\tTue, 18 Mar 2025 18:09:47 +0100 (CET)","by mail-qk1-x733.google.com with SMTP id\n\taf79cd13be357-7c0e135e953so588658385a.2\n\tfor ;\n\tTue, 18 Mar 2025 10:09:47 -0700 (PDT)","from ?IPv6:2606:6d00:11:e976::5ac? ([2606:6d00:11:e976::5ac])\n\tby smtp.gmail.com with ESMTPSA id\n\taf79cd13be357-7c573c6fafcsm744548585a.25.2025.03.18.10.09.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 18 Mar 2025 10:09:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20230601.gappssmtp.com\n\theader.i=@ndufresne-ca.20230601.gappssmtp.com\n\theader.b=\"OY6Ow8Pg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1742317786;\n\tx=1742922586; darn=lists.libcamera.org; \n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=1bO51EoY1hDAykZJUx4lLr6DisOIHtT9bed/536K9PM=;\n\tb=OY6Ow8Pg6/XAC4ppJbdRADFS7p+TLAB2hQXDnLo2NK+FiYl3y/gSxD1xIaSw1sROdv\n\t+zHGXK329gB6A1FeoBqoC988Epu7T87yq28Ji0AOCsfIKjzH5sf7WebxdHlwd4SLC9yI\n\tqQTikgWdGdxjNxc9I1DU4JnjqiUXEDGG/Fs4EKP4iHRgoVpxbTOPGP9ISdlJ6jRCidPd\n\tDfFjd7P3mkTOci5mDFMkoKQoxdUwxoypSV6fDEEwr61oq79xXkJxNpmOsYZiU2Q6UKx2\n\tOSfDOg2AWHEPbKZ5ZX8JiEXrVZwCjoKxtOWky+ZJdMM4VEEHz5/wjRfz/z+JwMmLjQvG\n\tUi6A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1742317786; x=1742922586;\n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=1bO51EoY1hDAykZJUx4lLr6DisOIHtT9bed/536K9PM=;\n\tb=bdvexkx5WP7lT+8fQcDSw5yyc+x3CBXMamSJHpJE0ls4AOmyl24jCit9+cFc3q5AVd\n\tT0P1rvOYRk0tfvJaOBvlb/YeFuGjfuOcb8+tO0eyV90ub646m3j+gvs2A0xgKu29QN8v\n\tBq7fAcSyxdPiYfh873nE7IIia4LJyDRH0CyEwKhmwbSON8gQZkz/pN5G94qcuXqPDc3S\n\tGIPl/LIgOmwhLQn9HiHdgn4D+FKvW3NimranyaG/h7qLFwp6XEoCVEeBqBQ6tTIJ+ovT\n\teiUJM8XA70YX9zy1CnwwJeu2fEGEJsxIoDnAms+w45Wv7yjXjZxvqbAd2G0c0uAPywq5\n\tPFXw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCV7w1PIlpnDzcMzIQHxtXDpJCeBxIsofQA3IYHMWMODV+DN+qaVmeNWNPgdep/Q5izJ1kclSxGRXO9zur74sro=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YyJOsT/gZ2Aspi+2RnJ853xUR+vTxy0SxcGHXTr7SQ2SGoUJf89\n\toFT+QyCfb7B2NiXe7IsXgq2qcaIPWve4M8jDTD83/UwsJI0OFgL5qZ8DXN/YPS8=","X-Gm-Gg":"ASbGncuUP24ktR6xpPC9PPveQ56XiqPHKNdKI7lDF7VLqGDbd39DiJB7Ec2OW5g+WYi\n\tI8Izc/YSJjnpQ5TfYnMr/hiljZBe0WEONE12s7JyScjrOlxc3nMesCMqu3NxGvlciVddv6gp9wx\n\tsVj7vLd0FGPunsQqauZ7HbQi6eWrOGbEzOEF5EItu7SSXhRNlmsSex8FSEcwyu4CDCU5ZZ1deSi\n\t4665ucE/ugkAB5qNa68ZPi5HG84OLhNaBYwZsi4Ze4/gxmF2Usf0w8qIVmp5f/KavZXS6ju4Ukz\n\tpRlMfPjl0Sra9H/JaZK2KwPc8aC/K/GCqmGfBNU2cOGOAaiG0Q==","X-Google-Smtp-Source":"AGHT+IEqPSAvFRH9pWGuCEERkbKJwqIiufYe5CTpKdk/kTIJFHWJuyvWYRhDLrFCdKZ/grbjWATGbw==","X-Received":"by 2002:a05:620a:454f:b0:7c5:3c0a:ab7a with SMTP id\n\taf79cd13be357-7c59b17aebcmr543608485a.3.1742317785760; \n\tTue, 18 Mar 2025 10:09:45 -0700 (PDT)","Message-ID":"<1b4233993d5b005b7f816e01ca0b7c107e424981.camel@ndufresne.ca>","Subject":"Re: [PATCH] gstreamer: Add Y444 format support to the YUV list","From":"Nicolas Dufresne ","To":"Antoine Bouyer , \n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 18 Mar 2025 13:09:44 -0400","In-Reply-To":"<20250317161050.2008382-1-antoine.bouyer@nxp.com>","References":"<20250317161050.2008382-1-antoine.bouyer@nxp.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.54.3 (3.54.3-1.fc41) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]