[{"id":33589,"web_url":"https://patchwork.libcamera.org/comment/33589/","msgid":"<4071a4ed-f765-4712-95b2-d36bad261f2a@cherry.de>","date":"2025-03-11T13:06:25","subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","submitter":{"id":202,"url":"https://patchwork.libcamera.org/api/people/202/","name":"Quentin Schulz","email":"quentin.schulz@cherry.de"},"content":"+Cc Ricardo, the original commit author, in case I'm missing something\n\nOn 3/11/25 2:01 PM, Quentin Schulz wrote:\n> [foss+libcamera@0leil.net appears similar to someone who previously sent you email, but may not be that person. Learn why this could be a risk at https://aka.ms/LearnAboutSenderIdentification ]\n> \n> From: Quentin Schulz \n> \n> The introducing commit (dff416a84b78 (\"README: Add missing package for\n> Qt5 tools\"); for Qt 5 originally) stated that without the dependency we\n> would get the following messages:\n> \n> Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n> Program lrelease-qt5 found: NO\n> Program lrelease found: NO found but need: '== 5.14.2'\n> \n> That is still the case but this actually is neither breaking the build\n> nor is it doing anything to the outcome of the build as qcam is bit to\n> bit identical with and without that package.\n> \n> Therefore, let's not mislead users to install an unnecessary package.\n> \n> Signed-off-by: Quentin Schulz \n> ---\n> This was tested within a debian:bookworm container with and without the\n> package, checked out both at master and introducing commit. qcam is bit\n> to bit identical in both cases.\n> ---\n> README.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/README.rst b/README.rst\n> index ae5126e25542a37d0c50287399486c56d2888af8..9dfef7eadb4640f77c28f82d42fadd54aa025641 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -85,7 +85,7 @@ for cam: [optional]\n> - libsdl2-dev: Enables the SDL sink\n> \n> for qcam: [optional]\n> - libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> + libtiff-dev qt6-base-dev\n> \n> for tracing with lttng: [optional]\n> liblttng-ust-dev python3-jinja2 lttng-tools\n> \n> ---\n> base-commit: 39419ce431dbd4f34d8772bd31bb7f44a3534f86\n> change-id: 20250311-qttools-unneeded-468370441a64\n> \n> Best regards,\n> --\n> Quentin Schulz \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A602EC32F2\n\tfor ;\n\tTue, 11 Mar 2025 13:06:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CDF3168779;\n\tTue, 11 Mar 2025 14:06:31 +0100 (CET)","from EUR02-DB5-obe.outbound.protection.outlook.com\n\t(mail-db5eur02on20626.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:2608::626])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F7BE61800\n\tfor ;\n\tTue, 11 Mar 2025 14:06:30 +0100 (CET)","from AS8PR04MB8897.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:42c::20)\n\tby VI0PR04MB11047.eurprd04.prod.outlook.com (2603:10a6:800:262::20)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.27;\n\tTue, 11 Mar 2025 13:06:26 +0000","from AS8PR04MB8897.eurprd04.prod.outlook.com\n\t([fe80::35f6:bc7d:633:369a]) by\n\tAS8PR04MB8897.eurprd04.prod.outlook.com\n\t([fe80::35f6:bc7d:633:369a%6]) with mapi id 15.20.8511.026;\n\tTue, 11 Mar 2025 13:06:26 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=cherry.de header.i=@cherry.de\n\theader.b=\"iedC6SCH\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=cherry.de;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=xAtfB5B5JQzbAUuNQ82Iy1q/C9YSh7rZla4QifyGLnvanLc+sAiXtS+D8EQiBarjx/Uf2R8kW5rWFEvIoBVVCwxaq1ve3HgOZjwkWZWglXf/mtAspYOhTpIL6DQV/XUTgSwqpg4mKa9DynUEAQ7niFzwYaTUkLi13u7vtIo+X/2brN7d1++PpTLu74Y6TJnEvLP0EdA6nZvcnqL088oiIZkw8687HTck49ZcnlQlRcEbqXeVtndWTKd1yCZhitygAAafkTcVgr62CdI2eX34GODf6Dw5Qjjm5hibVtyiUy0afkkQXf/DeLwCi4Kjf1s1fzl0Lh3QwCXSqwToagZC1A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=ExGKPHsebY4yYsOVHMtpIq6ddKPXG8rYp9nJ4LxXakc=;\n\tb=y2ADzCGjZovv9iWv0QvAyzYeo/p7oAYYArrVkPesxHaNpsGTASayx7ZzKyAnJ/nLJLvKXR0SvBZ1jU1E/R9inp7wkCyrDcFdLZHWw4ACpujXYBKt0NIJSQA13yi/euBVpMjV4uxHAWIp78sXtdaSOdJ33/HEg9w4NuYzGJ6st0tcLsCjEdFMY/hgRFiyqD1XiSGvbGvosYRXWEd7Ismk+SFctWaEXOalKqf9fsydN892SSJJXNJKo9kR5sLwYhm+0hH7XcOx6UHNkgz2uk59bT8At2N7wpufoKrYMaewuooGPlQW3DMUftCxiJlpQPQKVvuBmSvg3TytQLIoFklSTA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=cherry.de; dmarc=pass action=none header.from=cherry.de;\n\tdkim=pass header.d=cherry.de; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=cherry.de;\n\ts=selector1; \n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=ExGKPHsebY4yYsOVHMtpIq6ddKPXG8rYp9nJ4LxXakc=;\n\tb=iedC6SCH4HtL0WUoNFVoFNvvndtuFVUbzwRNYxqNDeObAYLh7Xl1FmRMuCzsatuAlZVLApSQ3LRcvgEtGqzdHU+1SDziIJpbVNF1u8cXOgIc6l5lk1PfBovMxC2RxuDe9WpIhOoH25ejVFkw7N04f/qKbNrUsrZW2tQUFJz0/5A=","Message-ID":"<4071a4ed-f765-4712-95b2-d36bad261f2a@cherry.de>","Date":"Tue, 11 Mar 2025 14:06:25 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","To":"Quentin Schulz ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250311-qttools-unneeded-v1-1-834c30be7e7a@cherry.de>","Content-Language":"en-US","Cc":"Ricardo Ribalda ","From":"Quentin Schulz ","In-Reply-To":"<20250311-qttools-unneeded-v1-1-834c30be7e7a@cherry.de>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"VI1PR06CA0200.eurprd06.prod.outlook.com\n\t(2603:10a6:802:2c::21) To AS8PR04MB8897.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:42c::20)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS8PR04MB8897:EE_|VI0PR04MB11047:EE_","X-MS-Office365-Filtering-Correlation-Id":"5f39082e-86e3-4e6c-dcc3-08dd609d87f0","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0; ARA:13230040|376014|366016|1800799024|7053199007;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?X9m8AZZFCstSpbsbMzAGEn272BoG?=\n\t=?utf-8?q?EO1LfnzeOmkrA562lGyUijiAtOs/FJJGsITzYe1biIt2Ck+PKc38BqF5?=\n\t=?utf-8?q?CZWWScVdwsMF+Z2NiF1rp9cGBgGvblz84ULhWaAJKPlCKRv61YgwjAOU?=\n\t=?utf-8?q?wxBeuHGwk0B+9Rc+uchfSCFMzivOTLsymXMK+9oAaaC2Vcj9Z+XkWFjz?=\n\t=?utf-8?q?VSStHmJaU6SwAsuC5/Sxi7U0XxIyXhfMGseYWyIDCWUIlfRzCXVhWoIi?=\n\t=?utf-8?q?SpAPmJvR22P/8xagSepAAg7l+dfREJYi0mA8XKKTHVOHC5AzNCjdchcl?=\n\t=?utf-8?q?dE6UNf5FtcW19uIR54DVc0wQDGiF8bYBAbw8Q/QpKaH1sFWLfvVCURNg?=\n\t=?utf-8?q?rdSuYDpcXSnBcqfM2EtCtXib45nGBGDLayW0jVYhO4tuFOpK2Sim07Ed?=\n\t=?utf-8?q?MbzcDUf8lI+9biQuCUQxf2fbfuIx0Y7aGvuk7cePE6toKnEz5R/zJHJz?=\n\t=?utf-8?q?gkbyYlu6KVL2a6HgUgzTSBdPwCxExOj84rBnI2P59ahYRHpdpCSB9cxK?=\n\t=?utf-8?q?iBITBykklz+cLhG31CfkEYyQFARVnjtp32/CAYX2bGOb5k6Rs3p4DcHO?=\n\t=?utf-8?q?t2TXOAC4UJ/FdWxlpSNEs5A5FAzH5lpjvXqDvjipYrrdBI8pK6TBLFOw?=\n\t=?utf-8?q?NhYgM8eWSSxUw4wDOkGiLjpkPo0XeqHVpGHHtuBIXP0CJYE6DDkSXcHI?=\n\t=?utf-8?q?uZkJwIX+0xNRA2D88/txRewQUygUINFjD2C8sU9asgYG63gLy/QfZFnC?=\n\t=?utf-8?q?DrUfQHawqJmiTNzxPRJV/+k58V13F7SKjbOCmXHvXxl/tZhSjYPr4rd7?=\n\t=?utf-8?q?DQdHoiSGYEcUUnZCN9SCl+KB9jI5ZWStKlCvIjZnuKB18x5NSTFbtCTz?=\n\t=?utf-8?q?vQ/eqBpQr1hE/ZQzDw5xvnV8p3ciPxwpPf+mJGXFaqlXMB4R5OgLaGZx?=\n\t=?utf-8?q?YlW3rew++xsUmwPAlGj0X48+83m2bgJSeVoomrjTKakBlcbuguZfiRRW?=\n\t=?utf-8?q?5BZwq9dxj6rbSJZ7WXKLeUrAEYIN0UNGjeqUcypYOjeALvKSX0R/yPRk?=\n\t=?utf-8?q?tWLKKYYbNk4Zdmpm6p8sCsNLpW4Obi1QxZoRZrDJNW1czEnQXdTyQzvS?=\n\t=?utf-8?q?jfrQ+Q6d46XuAXSHhLEzcwpQolPx8WiAKqqZa9Cbi6ExzK9GPM/7Fn8l?=\n\t=?utf-8?q?pUlkV9VEQTMdifKFqyzIwuxSUZ4kAH1U1KVuv8q8ycrCXtKGN4Erod5G?=\n\t=?utf-8?q?uTMIOPTubU5EzNlf1s2ccHEiFszNWrS3XO6pJVldiD/xKVr/SJ6y9tGK?=\n\t=?utf-8?q?nHt+gFgbNxCNs4smAK7H8//Ewj1gwP42Qr9MTtuRXVXTFQlWvzvuNWSz?=\n\t=?utf-8?q?9/dgI04HBhtPl+AH/EnmCcMhxxR5XtqY2e81mW7rTy9DpMLD+bvZZpvX?=\n\t=?utf-8?q?ZXrLorQH3ryq6QQNuEMwcG0/Y4BgOERAujqe?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:AS8PR04MB8897.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(376014)(366016)(1800799024)(7053199007); DIR:OUT;\n\tSFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?yZNuqt6pMXHT98TOGDpxUXlWg?=\n\t=?utf-8?q?O0VoxP+/DMnkGktvtGkbbKM80WYrcRHSi9Sp/4j3N9hvhzUbo62P71iv?=\n\t=?utf-8?q?HlOJwWIoOV54vaSqWeoRyiRrbL9CZ6QG3XUb4p67ed/hIPcLnz3u1lms?=\n\t=?utf-8?q?513gov1RCKrgt80WVFSSvYm+4CFkdJfxjH2kdTiyheMvM83NhjLcpEQA?=\n\t=?utf-8?q?NpYF814aEEU1D+3uRvYcG8ddeeIcGiVSJEs7ypsf+944mgAXIRz1TJXf?=\n\t=?utf-8?q?FIuzKFH6wroDWVpLR4TR0j6c4e15xKde8TEXzpsR27mOE6i0aRdG0GNh?=\n\t=?utf-8?q?h5XciS0JDpVnpdPmQKc2g75RnauauydUu8X5TSW0wz5mOP/86u3WUGDY?=\n\t=?utf-8?q?aEi0bMvnlHS/1/ry6oHAEFp5OJQRclLnZ35oIK1ZcFd00STAk8gYLGwv?=\n\t=?utf-8?q?KSf740i2ZEjtkfpmUWjsEPdGgfvLW6y6m3alVkAHzWbYqq1CHuR9YY25?=\n\t=?utf-8?q?a5izLZMux1vDMovElHOOyL9SKRtCrqbrYXGQQ6K8xpZs0QnAE82lNUJM?=\n\t=?utf-8?q?SF+AvzENHmbwYyeyktxwiNRDJDouYHtK59sjKXPz7oLks2rm4v/IbHZh?=\n\t=?utf-8?q?nsSLm+0f4Gh2gug1ppSD6BHQKCp0r4YNPiLZ+eZ9SiNEDgdNNyeHpVFG?=\n\t=?utf-8?q?p+QW64EdOi4VcbiGenG3/369De9ArZHBSNRpGH7sbuyTVN5YJwKQL/xU?=\n\t=?utf-8?q?Bxb3SfsI81HgdC8n0VoXWrHfCMfAEFoRhOdGwbUTmXjAiweYpCJbbQ/w?=\n\t=?utf-8?q?Ci6lHF0edF48vW3CjOygPc2SLV/T/PwwH09mhbAlgnYDt/3UQdSDD73C?=\n\t=?utf-8?q?u3VjhTMF3CyNZ+/G2NdGUY+xTl7108u8Sj0pFL0L5JlrUi6cd6aoGzVF?=\n\t=?utf-8?q?se2HOdoAX3YW8i3438KEl54S/fdXvy3kXMxzHiClWfl/m5VJZaXGiqTK?=\n\t=?utf-8?q?fYYnxY00Uj00WiPGiZWKSPZsumshHVGgwIxiKjCbc+GYDpgONyJlbRlP?=\n\t=?utf-8?q?dLgsPl+92hq1T7qeFCIk2U931BUJgLUzrVD6oIYJwmGqcSf+hfqGifrh?=\n\t=?utf-8?q?rrlIVPvBHgADivVkJb6N4/5JJYPpx2EhFBWoPCjxACl8zCJaEPidbi0n?=\n\t=?utf-8?q?mcGg/WgDcCm77fz+Afpbz6QFUiSdwFWrQD5ZyBhs2KV8KbHeB8ZBRhsK?=\n\t=?utf-8?q?zKk+hqHq9dGcBcVnYjNNPkg/u8kVDTl12PAMlp2f+THihAFJbiZyfaDz?=\n\t=?utf-8?q?1IGPZ6nHajlbi04lolkYiUN/bMo6G7hmbrBvcd7KRjZ9hiEegTfI+P7V?=\n\t=?utf-8?q?rtD2LaesqfHTVz4ENP+Kyv31eojceGTx1ADGIqO0szH7cEF5pe+nk0VM?=\n\t=?utf-8?q?WB8BH4ezG4OPz4xcOAptbY01WBmKrBAl/S3OJZ85WqcHCMidFr8b3X2x?=\n\t=?utf-8?q?AcbjuhFA66GidWnFy5b+CnOcZ6dqYDEldOfxGeDKVd2J+80NkVTlKcMG?=\n\t=?utf-8?q?iNjhxosLYa0lFrhNKX/E1Q1tvgVime2fnbv2p10OCHfwYURttjL/tTe1?=\n\t=?utf-8?q?OxkD0wH6n+9jQVCIhbWhPX00NRJRZIKraBHwMG30a1zgfORbH2flI+Kg?=\n\t=?utf-8?q?zsICjIZRKP490ASjiPtjMIWb1zGA5aZcqB9z0v0ZHqHezXyNY1u5/FJZ?=\n\t=?utf-8?q?Im5rh0b+3onoDoobXrYprStsO7ziw=3D=3D?=","X-OriginatorOrg":"cherry.de","X-MS-Exchange-CrossTenant-Network-Message-Id":"5f39082e-86e3-4e6c-dcc3-08dd609d87f0","X-MS-Exchange-CrossTenant-AuthSource":"AS8PR04MB8897.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"11 Mar 2025 13:06:26.4837\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"5e0e1b52-21b5-4e7b-83bb-514ec460677e","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"IeFo9PqopAzymhJx3IisrfKuUIapgonkc34053fqoB8cX3mXHrnVjx2vm7eqlXnC13NQvk+/aAsuZXEz0tPIOL2vPsr8rDqVvaaDNsFSh6s=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI0PR04MB11047","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33599,"web_url":"https://patchwork.libcamera.org/comment/33599/","msgid":"<174221410402.1463678.10391570271713109059@ping.linuxembedded.co.uk>","date":"2025-03-17T12:21:44","subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Quentin Schulz (2025-03-11 13:06:25)\n> +Cc Ricardo, the original commit author, in case I'm missing something\n> \n> On 3/11/25 2:01 PM, Quentin Schulz wrote:\n> > [foss+libcamera@0leil.net appears similar to someone who previously sent you email, but may not be that person. Learn why this could be a risk at https://aka.ms/LearnAboutSenderIdentification ]\n> > \n> > From: Quentin Schulz \n> > \n> > The introducing commit (dff416a84b78 (\"README: Add missing package for\n> > Qt5 tools\"); for Qt 5 originally) stated that without the dependency we\n> > would get the following messages:\n> > \n> > Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n> > Program lrelease-qt5 found: NO\n> > Program lrelease found: NO found but need: '== 5.14.2'\n> > \n> > That is still the case but this actually is neither breaking the build\n> > nor is it doing anything to the outcome of the build as qcam is bit to\n> > bit identical with and without that package.\n> > \n> > Therefore, let's not mislead users to install an unnecessary package.\n> > \n> > Signed-off-by: Quentin Schulz \n> > ---\n> > This was tested within a debian:bookworm container with and without the\n> > package, checked out both at master and introducing commit. qcam is bit\n> > to bit identical in both cases.\n\nThat's the evidence I would look for in this, so \n\nReviewed-by: Kieran Bingham \n\nIs this still the case on Qt6? I assume/infer that the reason you want\nto remove this dependency is because something has changed in qt6 ? \n\nIf so - adding that to the commit message would help clarify things, as\nyou are removing a qt6 package, but only discussing qt5 in the commit.\n\n\n\n> > ---\n> > README.rst | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/README.rst b/README.rst\n> > index ae5126e25542a37d0c50287399486c56d2888af8..9dfef7eadb4640f77c28f82d42fadd54aa025641 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -85,7 +85,7 @@ for cam: [optional]\n> > - libsdl2-dev: Enables the SDL sink\n> > \n> > for qcam: [optional]\n> > - libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > + libtiff-dev qt6-base-dev\n> > \n> > for tracing with lttng: [optional]\n> > liblttng-ust-dev python3-jinja2 lttng-tools\n> > \n> > ---\n> > base-commit: 39419ce431dbd4f34d8772bd31bb7f44a3534f86\n> > change-id: 20250311-qttools-unneeded-468370441a64\n> > \n> > Best regards,\n> > --\n> > Quentin Schulz \n> > \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C689C32F5\n\tfor ;\n\tMon, 17 Mar 2025 12:21:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5749768947;\n\tMon, 17 Mar 2025 13:21:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4581A617F8\n\tfor ;\n\tMon, 17 Mar 2025 13:21:48 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C4CFA965;\n\tMon, 17 Mar 2025 13:20:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wLt+mm0L\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742214005;\n\tbh=S6ulE3+2ikVGJyEiNHajfuIoYM0yGGuol/PYfeQEPI0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=wLt+mm0LXiTZ6rvzc6ezr3QIl7xLziG7oofVXgEv9oCe0DzK+QQPb592htiNFxabk\n\tyux9JPJqw6Obs5d65rchFWy1QjzhGljdjIs46JDy8vpEWWI+G/O+d0mYBTPqYsAbSr\n\tYeC8zNraSCYMWxORctGvU17sM0AtDyEBCPlYXglg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<4071a4ed-f765-4712-95b2-d36bad261f2a@cherry.de>","References":"<20250311-qttools-unneeded-v1-1-834c30be7e7a@cherry.de>\n\t<4071a4ed-f765-4712-95b2-d36bad261f2a@cherry.de>","Subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","From":"Kieran Bingham ","Cc":"Ricardo Ribalda ","To":"Quentin Schulz ,\n\tQuentin Schulz ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 17 Mar 2025 12:21:44 +0000","Message-ID":"<174221410402.1463678.10391570271713109059@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33600,"web_url":"https://patchwork.libcamera.org/comment/33600/","msgid":"<26c25a91-6e99-4f8e-a7a4-beec33d1a8c5@cherry.de>","date":"2025-03-17T12:30:48","subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","submitter":{"id":202,"url":"https://patchwork.libcamera.org/api/people/202/","name":"Quentin Schulz","email":"quentin.schulz@cherry.de"},"content":"Hi Kieran,\n\nOn 3/17/25 1:21 PM, Kieran Bingham wrote:\n> Quoting Quentin Schulz (2025-03-11 13:06:25)\n>> +Cc Ricardo, the original commit author, in case I'm missing something\n>>\n>> On 3/11/25 2:01 PM, Quentin Schulz wrote:\n>>> [foss+libcamera@0leil.net appears similar to someone who previously sent you email, but may not be that person. Learn why this could be a risk at https://aka.ms/LearnAboutSenderIdentification ]\n>>>\n>>> From: Quentin Schulz \n>>>\n>>> The introducing commit (dff416a84b78 (\"README: Add missing package for\n>>> Qt5 tools\"); for Qt 5 originally) stated that without the dependency we\n>>> would get the following messages:\n>>>\n>>> Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n>>> Program lrelease-qt5 found: NO\n>>> Program lrelease found: NO found but need: '== 5.14.2'\n>>>\n>>> That is still the case but this actually is neither breaking the build\n>>> nor is it doing anything to the outcome of the build as qcam is bit to\n>>> bit identical with and without that package.\n>>>\n>>> Therefore, let's not mislead users to install an unnecessary package.\n>>>\n>>> Signed-off-by: Quentin Schulz \n>>> ---\n>>> This was tested within a debian:bookworm container with and without the\n>>> package, checked out both at master and introducing commit. qcam is bit\n>>> to bit identical in both cases.\n> \n> That's the evidence I would look for in this, so\n> \n> Reviewed-by: Kieran Bingham \n> \n> Is this still the case on Qt6? I assume/infer that the reason you want\n> to remove this dependency is because something has changed in qt6 ?\n> \n> If so - adding that to the commit message would help clarify things, as\n> you are removing a qt6 package, but only discussing qt5 in the commit.\n> \n\nThis was tested for both qt5 and qt6, results are both bit to bit identical.\n\nI stated that in the Buildroot patch: \nhttps://lore.kernel.org/buildroot/20250311-libcamera-qt6-v1-1-4897aadc6fe3@cherry.de/ \nbut forgot to add it here before submitting the patch.\n\nI can reword the commit log to something like:\n\n\"\"\"\nThe introducing commit (dff416a84b78 (\"README: Add missing package for\nQt5 tools\"); for Qt 5 originally) stated that without the dependency we\nwould get the following messages:\n\n Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n Program lrelease-qt5 found: NO\n Program lrelease found: NO found but need: '== 5.14.2'\n\nThat was the case for qt5 and is still true for qt6 but this actually\nis neither breaking the build nor is it doing anything to the outcome\nof the build (for both qt5 and qt6) as qcam is bit to bit identical\nwith and without that package.\n\nTherefore, let's not mislead users to install an unnecessary package.\n\"\"\"\n\nWould that work for you? Do you want me to send a v2 for that?\n\nCheers,\nQuentin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6490C32FA\n\tfor ;\n\tMon, 17 Mar 2025 12:30:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA56E68947;\n\tMon, 17 Mar 2025 13:30:53 +0100 (CET)","from AS8PR03CU001.outbound.protection.outlook.com\n\t(mail-westeuropeazlp170120005.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c201::5])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 968CF617F8\n\tfor ;\n\tMon, 17 Mar 2025 13:30:51 +0100 (CET)","from AS8PR04MB8897.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:42c::20)\n\tby PA4PR04MB8031.eurprd04.prod.outlook.com (2603:10a6:102:bb::14)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.33;\n\tMon, 17 Mar 2025 12:30:48 +0000","from AS8PR04MB8897.eurprd04.prod.outlook.com\n\t([fe80::35f6:bc7d:633:369a]) by\n\tAS8PR04MB8897.eurprd04.prod.outlook.com\n\t([fe80::35f6:bc7d:633:369a%6]) with mapi id 15.20.8534.031;\n\tMon, 17 Mar 2025 12:30:48 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=cherry.de header.i=@cherry.de\n\theader.b=\"RtCxGj8T\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=cherry.de;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=qDa1orRuy51IURSCTp0AfJXN/6BWYmLXHRtOrNXnFznFbWlEZBAq64DbEzDNUOsobQ6ULUGMC+8JZeVbVeiRgwJi8Nfwc+ZAE5vM7See5rBjoEvRLDZbDHgv/Gz4xpPfvJmnFFC1EU0ovRhr7L8fU7XVh5vSETjeG/aq5qoPPPIU7sQQnjxOJ2gmZu9WSUguPlfNxLsFgEZzsO7h9f/MMcyzhOKfxMuw1+m3hkObVwxXP1wJZqMpW0WlOQl/GsRSKMtavb8UO3drWLryh5HqvbVvkvO50L+yVfDLzoPrKZPMczDX13GzuSE9Cs/iMBoFQ3rRA64pT+9k9fKL7KHSvw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=sEfZ/Lxv7YBwjHNg3ss2PADy9IwIe6CzqFv3s88rdE0=;\n\tb=D7M+Bc0CFVZ7WamkP0c9239+DcX4MvEL6zcriHlkTCKHMmirTwFccccu0+YLNIa5t2+KAN6MKLr1LUEQ1ZNMdYtruxwYpSQ43Qt8uSraUIiLegtVN1HMeik6ZNEPBrxjgrJv9qnfnTdPcmd8ZG8F4DesmDeUt04YsB9Vhv+fq8TjEz55vsTg6LC/dKuirhFau98imC4SkM5QP3fHTbJvxXk9hJkfvPkVYmn9pFZEOCHSg+nweoRQNNS6qzGLvEl84yB4OM5OtHwuhtVmF/PYbXiotFGn2rdqN7ONiZBR9xsd8IMAn/ayP+lzyvN1PamUVFIV6o6rlS5+JxuBA88k7g==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=cherry.de; dmarc=pass action=none header.from=cherry.de;\n\tdkim=pass header.d=cherry.de; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=cherry.de;\n\ts=selector1; \n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=sEfZ/Lxv7YBwjHNg3ss2PADy9IwIe6CzqFv3s88rdE0=;\n\tb=RtCxGj8T2Dc6VJSrWlW6QM7a9ORYOpQ6iYj0LLDnsBwX0f3JOd+pVMVvGpV8+iEP/QUQ4zmxtHOkawADVzMspGmCgl7Gm3F5A9CLAfwFfdlrp/SrGcqpXZwnLGEEmCjxcSc5KpqQTM1ReXejMj53Y6Q1W77yBrtwUwn5ktjdAB8=","Message-ID":"<26c25a91-6e99-4f8e-a7a4-beec33d1a8c5@cherry.de>","Date":"Mon, 17 Mar 2025 13:30:48 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","To":"Kieran Bingham ,\n\tQuentin Schulz ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Ricardo Ribalda ","References":"<20250311-qttools-unneeded-v1-1-834c30be7e7a@cherry.de>\n\t<4071a4ed-f765-4712-95b2-d36bad261f2a@cherry.de>\n\t<174221410402.1463678.10391570271713109059@ping.linuxembedded.co.uk>","Content-Language":"en-US","From":"Quentin Schulz ","In-Reply-To":"<174221410402.1463678.10391570271713109059@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"FR4P281CA0237.DEUP281.PROD.OUTLOOK.COM\n\t(2603:10a6:d10:e9::12) To AS8PR04MB8897.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:42c::20)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS8PR04MB8897:EE_|PA4PR04MB8031:EE_","X-MS-Office365-Filtering-Correlation-Id":"1efe1991-0c89-45be-5242-08dd654f8c3a","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0; ARA:13230040|1800799024|366016|376014|7053199007;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?0ZRRK2WpUDbNWUtJnb4+kKAW6lpi?=\n\t=?utf-8?q?yG0mUpPbGEHDytTAMo3UUlKO+eTtafbz7syA0j9aDmesBDfOBBeZ0ioo?=\n\t=?utf-8?q?ganQHfMF0NIkC2NhG0FEYrnBPWXhsVPibWLzS/ruQrkbpvKRVEtrFgeF?=\n\t=?utf-8?q?c/Zot8vJ26z3RKGVJUxykzM3DTBszPIp3Gbi1V/L+Mae7cIixSd8bTbY?=\n\t=?utf-8?q?7/paKCDBgZkwSfLEK/cEk2Tk9u1ocunhISouFYBhX41ynd7UitivR0xe?=\n\t=?utf-8?q?RRaunwMMnd/bKTYLESZ0ZK1pRqg7PvD2N0N3qsaBhCBbU4/Ax1wXR3j+?=\n\t=?utf-8?q?qnYDGDKN6vnMyEE8A4Vu+VNpPVC6IvwRciQbrL8hOL7knuryFBmD155j?=\n\t=?utf-8?q?xM4IOCNgcRY6ya4gb+qtSV5jwtNc4IgkX+dsuu97CvN1JforUPBHdLdf?=\n\t=?utf-8?q?7cmVnwvB9Hhbpcz/BYQ2wOPvyp1sKGrXf0Mx43/7QC7xrHCqHDyQkCAE?=\n\t=?utf-8?q?PCO29hlwJIDTXCWe0EM5d9i7Hz79gkLlPYuE46MCGuuzJhA072RPv8LS?=\n\t=?utf-8?q?EyFGMokg9DDELxl1jqlfIjvnDGHSSlU63jPlgwVAFR0lCqOSuZrU8xLG?=\n\t=?utf-8?q?upE7yFe+f5SEfij88TfuXhSz6AFPDZ2A8NJNQCCSgc/XLectuHwMo2BX?=\n\t=?utf-8?q?H+8KxvKLAl6jBb42y5RH8+gug6mW+jSBRNsy7tB38HA82qD86H8WlrZt?=\n\t=?utf-8?q?/ZH0qfnewU/RkkS81yjrylSmA3ZHGwOFPlCY29AKaYDn3c2F2UYYfPft?=\n\t=?utf-8?q?Wf4HpCZYNDogOL5rxx2Od3YRNs82qlZ9/bFDTYBsNnEcStjNFROLKhzi?=\n\t=?utf-8?q?VpSliTOANzWTzR96CAQtAn3oHP+dfl6xObKQygltVA1zMfDUlKFWxxJz?=\n\t=?utf-8?q?iXHJAG9BerXhVRbaAXErGD3xOlfXG5IMdud3qsPfn1yBWzt49rhdvpkj?=\n\t=?utf-8?q?X1Woo+sdF4Q/Nkzpd/aXqY1b9yp/4CnpzNqlOAYwxEf+U8ZsIzxn7IYo?=\n\t=?utf-8?q?NgeBjukzsu48Zejo8w37Amv08z5Z93Ap2fBbSncm3J+UiihNTKUkCk/C?=\n\t=?utf-8?q?5/0Q781v0TEaxSPSlM23+wDRJjVLUsYkJto5RgZ/V8D70cGqmRB7Mo8N?=\n\t=?utf-8?q?5FZc6iqS4y4NPX0O4urJmKgdswCViWDNb90HL/+qvFbRq0TJhQ/Zth/I?=\n\t=?utf-8?q?eni26O6+CeOXAkkUMlzejsy/94HQoufXFC15Xuz2k3xPBGXcZF2YsRPd?=\n\t=?utf-8?q?39uLyveaWST436Jors11CZvP4kquEfnl1A2uEjuM/g7UT4ROVfs789j1?=\n\t=?utf-8?q?6MJa1pIPdfnkRPiJ9CPJH+UI0e2folMaGpKemkn6A6umBxpjGx+8jv2K?=\n\t=?utf-8?q?Q3d86pqXZBKtbT5OM0PMmhWkilmqF1yVvX9iWqgzi8vlW9g5jCrLvA7t?=\n\t=?utf-8?q?W0ta2py33OsIkJflGD92wftgFHJqrpwJcTem?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:AS8PR04MB8897.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(1800799024)(366016)(376014)(7053199007); DIR:OUT;\n\tSFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?R7AF98AGsZyso/vxeQ1NwhRTE?=\n\t=?utf-8?q?uIWuA3W9N5iS61c5zx0UDKL2o40Yz9a8MGusm97dvecoI2O0HJYX3eMg?=\n\t=?utf-8?q?cak2zwUlp98hjgtKG1AaFv01aCf832tIMF3/j1e5kQgv+JN5XkSl+Mfh?=\n\t=?utf-8?q?cK6KVY04dwzlHYtikAF2DXK10DcOA2H7GUcewXoXrWRhRi10be78GMDy?=\n\t=?utf-8?q?33Ue561+L6mgNfI0SVQ6QzArBYohjy2F5pXXX51XRAggaD7C0YWIMnld?=\n\t=?utf-8?q?bKSwvMBmlODt7NNSf42206dbi21CK7ok6c03ekRa/ch0cCQ8h7xDigyR?=\n\t=?utf-8?q?bvbm87owMLpqcjfIqcOh/H/1UdEtm0rm6Fmy9YH33sUbz3r1D44rnhtR?=\n\t=?utf-8?q?2jvu09W/Fuoq1IxOfsAOX6h2TcOcMC2/GqzA8v0di1w3wMb+OuQZ899v?=\n\t=?utf-8?q?7Iu+XmxxgmBYnG9ZD7TrZ6vNClmdddfODhPW3NRW2SVhsdZDCWrdq8ZR?=\n\t=?utf-8?q?zREqkPJu8gazSJ1T285F/Jt8YZdjzNhX4HqueJkSu2EVDKJjSC36du4h?=\n\t=?utf-8?q?Pk+uxAAXE5H9KzPXHiwUmAwRxmWxBZlnjokscYtO7d7rXqQEBohpH10P?=\n\t=?utf-8?q?yO30BAguZ4tKKx4dW8+HPTlLXFgXTY2Ds/Tsomj8Rq6vEGoJhoudYv9C?=\n\t=?utf-8?q?ZT+qIQKkE1v7GKcwWsi2UJGsurXGfPXTcyz2a+fx7appH4mqhn9WJSHh?=\n\t=?utf-8?q?nWJAC2IKbCIY4qUibh1/boVi3IOtM8wkNveH7hwhwmhjQw2O4R8TymV4?=\n\t=?utf-8?q?oVlzlBHrJ/Qg1irknFt2bDIshubpWK0nkdGh69wSPAxwv4j2ua4mxZpi?=\n\t=?utf-8?q?uzOEQSDpeb4Iab/k7ZPxXdPds+fja+H+mhq4jvAPTOykYU9rtPVhw0pn?=\n\t=?utf-8?q?R9T5Kh2KJAix2H5et+7oyYzXQ7PhVVeeCmiS/VH8DsxSqV3Idr4rkf7x?=\n\t=?utf-8?q?c4JBI2IlzQ2qnuY+MS6dN0D6TeatNXSqKT8QI7J+ywH851CQgXbQvfdl?=\n\t=?utf-8?q?u0UXUKz3sOl1ElBhVmpoxMy3mIxqDSKMBsqeLUDGBkhT6w7IqWHRVhO7?=\n\t=?utf-8?q?N4YUWi9NFkYrL2kMIl/9XaZ+0QsgB+nQIzRvJuXz5Bzk2jbx/J2GjyEa?=\n\t=?utf-8?q?tGCbJcslaLp4hjc+NRRH2h4LSpABYipMTyvKb02jcw25F/qwJ3XqXI6l?=\n\t=?utf-8?q?7WscDxCTHx7TJ76/LJH62ipEPYsgIfXtsdYvTnKvHITEXmtpkPthtA+E?=\n\t=?utf-8?q?qnGTiUjRscsIMICSWl3x088CBlQkk9Mch5yh78eaw3T4VePFxksZpGoj?=\n\t=?utf-8?q?Fml5s5C+bz22KUDp1u0x3YKIYXO2+V7hSWefG7tCLcKIjN3fyzqr/Sra?=\n\t=?utf-8?q?FGHf0RBlYCDyeoNGg4vJpy+QT9mXoLlC49DabMSsH9vKLT6YI37k6Zzx?=\n\t=?utf-8?q?HCJdbBJG7u7t2NFQNZndsN93XccvqJkmvtrBjiLfrCZh28w2vEkEXRmG?=\n\t=?utf-8?q?8x3h1cftAWYCSMTmEBbJ4zr1msDjATNjy22LFxulrM+TIWZzPZOZa9kS?=\n\t=?utf-8?q?JGMfURVdeEcUOQ+LEI+/hhgWQOX+n4wZ4kNfBBoCUEmLQ1RMojbnQhPI?=\n\t=?utf-8?q?NbQCxKHBQFQ2EKVmaBzYS02k57gQtsg/IqXrw39cDTvEcjD+0g3Z0V4k?=\n\t=?utf-8?q?C4q+3rSlcoa6GqGbaZcWINJZC+WQQ=3D=3D?=","X-OriginatorOrg":"cherry.de","X-MS-Exchange-CrossTenant-Network-Message-Id":"1efe1991-0c89-45be-5242-08dd654f8c3a","X-MS-Exchange-CrossTenant-AuthSource":"AS8PR04MB8897.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"17 Mar 2025 12:30:48.7155\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"5e0e1b52-21b5-4e7b-83bb-514ec460677e","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"mSQqBx25cywfbsNJT4sZyPib/ey7j8/BUPak15wvA6Bc56i7/cSQ+A3RDsCev+vrehhZVoKSm1un+3XWi75X9VjQ+VCrnV4sn46LmQzsSlw=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PA4PR04MB8031","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33602,"web_url":"https://patchwork.libcamera.org/comment/33602/","msgid":"<174221704065.1463678.12290222536465941618@ping.linuxembedded.co.uk>","date":"2025-03-17T13:10:40","subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Quentin Schulz (2025-03-17 12:30:48)\n> Hi Kieran,\n> \n> On 3/17/25 1:21 PM, Kieran Bingham wrote:\n> > Quoting Quentin Schulz (2025-03-11 13:06:25)\n> >> +Cc Ricardo, the original commit author, in case I'm missing something\n> >>\n> >> On 3/11/25 2:01 PM, Quentin Schulz wrote:\n> >>> [foss+libcamera@0leil.net appears similar to someone who previously sent you email, but may not be that person. Learn why this could be a risk at https://aka.ms/LearnAboutSenderIdentification ]\n> >>>\n> >>> From: Quentin Schulz \n> >>>\n> >>> The introducing commit (dff416a84b78 (\"README: Add missing package for\n> >>> Qt5 tools\"); for Qt 5 originally) stated that without the dependency we\n> >>> would get the following messages:\n> >>>\n> >>> Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n> >>> Program lrelease-qt5 found: NO\n> >>> Program lrelease found: NO found but need: '== 5.14.2'\n> >>>\n> >>> That is still the case but this actually is neither breaking the build\n> >>> nor is it doing anything to the outcome of the build as qcam is bit to\n> >>> bit identical with and without that package.\n> >>>\n> >>> Therefore, let's not mislead users to install an unnecessary package.\n> >>>\n> >>> Signed-off-by: Quentin Schulz \n> >>> ---\n> >>> This was tested within a debian:bookworm container with and without the\n> >>> package, checked out both at master and introducing commit. qcam is bit\n> >>> to bit identical in both cases.\n> > \n> > That's the evidence I would look for in this, so\n> > \n> > Reviewed-by: Kieran Bingham \n> > \n> > Is this still the case on Qt6? I assume/infer that the reason you want\n> > to remove this dependency is because something has changed in qt6 ?\n> > \n> > If so - adding that to the commit message would help clarify things, as\n> > you are removing a qt6 package, but only discussing qt5 in the commit.\n> > \n> \n> This was tested for both qt5 and qt6, results are both bit to bit identical.\n> \n> I stated that in the Buildroot patch: \n> https://lore.kernel.org/buildroot/20250311-libcamera-qt6-v1-1-4897aadc6fe3@cherry.de/ \n> but forgot to add it here before submitting the patch.\n> \n> I can reword the commit log to something like:\n> \n> \"\"\"\n> The introducing commit (dff416a84b78 (\"README: Add missing package for\n> Qt5 tools\"); for Qt 5 originally) stated that without the dependency we\n> would get the following messages:\n> \n> Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n> Program lrelease-qt5 found: NO\n> Program lrelease found: NO found but need: '== 5.14.2'\n> \n> That was the case for qt5 and is still true for qt6 but this actually\n> is neither breaking the build nor is it doing anything to the outcome\n> of the build (for both qt5 and qt6) as qcam is bit to bit identical\n> with and without that package.\n> \n> Therefore, let's not mislead users to install an unnecessary package.\n> \"\"\"\n> \n> Would that work for you? Do you want me to send a v2 for that?\n\nNo need for a v2 at the moment ... we can easily fix up the commit, it's\njust the justification I want to get right. Stating that this is still\nthe case for Qt6 fixes my concern ;-)\n\nEspecially as this will now cause users to have a warning reintroduced\nin their setup logs! Why is that now acceptable when it wasn't before?\n\nIs there anything we can do to stop meson from looking for lrelease-qt5?\nWho's looking for that in the build?\n\n--\nKieran\n\n\n> \n> Cheers,\n> Quentin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCDA3C32FA\n\tfor ;\n\tMon, 17 Mar 2025 13:10:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8161E68947;\n\tMon, 17 Mar 2025 14:10:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B416617F8\n\tfor ;\n\tMon, 17 Mar 2025 14:10:44 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 70397352;\n\tMon, 17 Mar 2025 14:09:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ekh76Us7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742216942;\n\tbh=pWaY54k5AoHOeiFS9QqFTwoDF+nboAHOQBWpA8EZcVk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ekh76Us73791jEgkazgyBi9fEcyxhgsAkZ5yfCkYA+mtdZeEKy3wnYamzCrKYtkFr\n\tioNK5A+2vTzumYlXcW5l+WCIb9K6AekXUl7LC/XmdtJVqvoSjhX96oRXkXI92978jn\n\tsZGBNK14iV6KVhRe9LxReSQIRr/xXixSPLt/hd0Y=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<26c25a91-6e99-4f8e-a7a4-beec33d1a8c5@cherry.de>","References":"<20250311-qttools-unneeded-v1-1-834c30be7e7a@cherry.de>\n\t<4071a4ed-f765-4712-95b2-d36bad261f2a@cherry.de>\n\t<174221410402.1463678.10391570271713109059@ping.linuxembedded.co.uk>\n\t<26c25a91-6e99-4f8e-a7a4-beec33d1a8c5@cherry.de>","Subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","From":"Kieran Bingham ","Cc":"Ricardo Ribalda ","To":"Quentin Schulz ,\n\tQuentin Schulz ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 17 Mar 2025 13:10:40 +0000","Message-ID":"<174221704065.1463678.12290222536465941618@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33603,"web_url":"https://patchwork.libcamera.org/comment/33603/","msgid":"<89611012-5f0a-4338-a0ef-831022b718c0@cherry.de>","date":"2025-03-17T14:51:29","subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","submitter":{"id":202,"url":"https://patchwork.libcamera.org/api/people/202/","name":"Quentin Schulz","email":"quentin.schulz@cherry.de"},"content":"Hi Kieran,\n\nOn 3/17/25 2:10 PM, Kieran Bingham wrote:\n> Quoting Quentin Schulz (2025-03-17 12:30:48)\n>> Hi Kieran,\n>>\n>> On 3/17/25 1:21 PM, Kieran Bingham wrote:\n>>> Quoting Quentin Schulz (2025-03-11 13:06:25)\n>>>> +Cc Ricardo, the original commit author, in case I'm missing something\n>>>>\n>>>> On 3/11/25 2:01 PM, Quentin Schulz wrote:\n>>>>> [foss+libcamera@0leil.net appears similar to someone who previously sent you email, but may not be that person. Learn why this could be a risk at https://aka.ms/LearnAboutSenderIdentification ]\n>>>>>\n>>>>> From: Quentin Schulz \n>>>>>\n>>>>> The introducing commit (dff416a84b78 (\"README: Add missing package for\n>>>>> Qt5 tools\"); for Qt 5 originally) stated that without the dependency we\n>>>>> would get the following messages:\n>>>>>\n>>>>> Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n>>>>> Program lrelease-qt5 found: NO\n>>>>> Program lrelease found: NO found but need: '== 5.14.2'\n>>>>>\n>>>>> That is still the case but this actually is neither breaking the build\n>>>>> nor is it doing anything to the outcome of the build as qcam is bit to\n>>>>> bit identical with and without that package.\n>>>>>\n>>>>> Therefore, let's not mislead users to install an unnecessary package.\n>>>>>\n>>>>> Signed-off-by: Quentin Schulz \n>>>>> ---\n>>>>> This was tested within a debian:bookworm container with and without the\n>>>>> package, checked out both at master and introducing commit. qcam is bit\n>>>>> to bit identical in both cases.\n>>>\n>>> That's the evidence I would look for in this, so\n>>>\n>>> Reviewed-by: Kieran Bingham \n>>>\n>>> Is this still the case on Qt6? I assume/infer that the reason you want\n>>> to remove this dependency is because something has changed in qt6 ?\n>>>\n>>> If so - adding that to the commit message would help clarify things, as\n>>> you are removing a qt6 package, but only discussing qt5 in the commit.\n>>>\n>>\n>> This was tested for both qt5 and qt6, results are both bit to bit identical.\n>>\n>> I stated that in the Buildroot patch:\n>> https://lore.kernel.org/buildroot/20250311-libcamera-qt6-v1-1-4897aadc6fe3@cherry.de/\n>> but forgot to add it here before submitting the patch.\n>>\n>> I can reword the commit log to something like:\n>>\n>> \"\"\"\n>> The introducing commit (dff416a84b78 (\"README: Add missing package for\n>> Qt5 tools\"); for Qt 5 originally) stated that without the dependency we\n>> would get the following messages:\n>>\n>> Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n>> Program lrelease-qt5 found: NO\n>> Program lrelease found: NO found but need: '== 5.14.2'\n>>\n>> That was the case for qt5 and is still true for qt6 but this actually\n>> is neither breaking the build nor is it doing anything to the outcome\n>> of the build (for both qt5 and qt6) as qcam is bit to bit identical\n>> with and without that package.\n>>\n>> Therefore, let's not mislead users to install an unnecessary package.\n>> \"\"\"\n>>\n>> Would that work for you? Do you want me to send a v2 for that?\n> \n> No need for a v2 at the moment ... we can easily fix up the commit, it's\n> just the justification I want to get right. Stating that this is still\n> the case for Qt6 fixes my concern ;-)\n> \n> Especially as this will now cause users to have a warning reintroduced\n> in their setup logs! Why is that now acceptable when it wasn't before?\n> \n\n\"\"\"\nmeson setup build\nThe Meson build system\nVersion: 1.0.1\nSource dir: /home/qschulz/work/upstream/libcamera\nBuild dir: /home/qschulz/work/upstream/libcamera/build\nBuild type: native build\nProject name: libcamera\nProject version: 0.3.0\nC compiler for the host machine: cc (gcc 12.2.0 \"cc (Debian 12.2.0-14) \n12.2.0\")\nC linker for the host machine: cc ld.bfd 2.40\nC++ compiler for the host machine: c++ (gcc 12.2.0 \"c++ (Debian \n12.2.0-14) 12.2.0\")\nC++ linker for the host machine: c++ ld.bfd 2.40\nHost machine cpu family: x86_64\nHost machine cpu: x86_64\nHeader \"fcntl.h\" has symbol \"F_ADD_SEALS\" : YES\nHeader \"unistd.h\" has symbol \"issetugid\" : NO\nHeader \"locale.h\" has symbol \"locale_t\" : YES\nHeader \"sys/mman.h\" has symbol \"memfd_create\" : YES\nHeader \"stdlib.h\" has symbol \"secure_getenv\" : YES\nCompiler for C supports arguments -Wno-c99-designator: NO\nFound pkg-config: /usr/bin/pkg-config (1.8.1)\nDid not find CMake 'cmake'\nFound CMake: NO\nRun-time dependency lttng-ust found: NO (tried pkgconfig and cmake)\nProgram ./parser.py found: YES \n(/home/qschulz/work/upstream/libcamera/utils/ipc/./parser.py)\nProgram ./generate.py found: YES \n(/home/qschulz/work/upstream/libcamera/utils/ipc/./generate.py)\nProgram ./extract-docs.py found: YES \n(/home/qschulz/work/upstream/libcamera/utils/ipc/./extract-docs.py)\nProgram ./gen-tp-header.py found: YES \n(/home/qschulz/work/upstream/libcamera/utils/tracepoints/./gen-tp-header.py)\nConfiguring version.h using configuration\nProgram openssl found: YES (/usr/bin/openssl)\nLibrary atomic found: YES\nRun-time dependency threads found: YES\nRun-time dependency libdw found: NO (tried pkgconfig and cmake)\nRun-time dependency libunwind found: NO (tried pkgconfig and cmake)\nHeader \"execinfo.h\" has symbol \"backtrace\" : YES\nChecking for function \"dlopen\" : YES\nRun-time dependency libudev found: NO (tried pkgconfig and cmake)\nRun-time dependency yaml-0.1 found: YES 0.2.5\nRun-time dependency gnutls found: YES 3.7.9\nDependency libexif skipped: feature android disabled\nDependency libjpeg skipped: feature android disabled\nRun-time dependency libevent_pthreads found: NO (tried pkgconfig and cmake)\nRun-time dependency libevent_pthreads found: NO (tried pkgconfig and cmake)\nRun-time dependency libtiff-4 found: YES 4.5.0\nRun-time dependency GTest found: NO (tried pkgconfig and system)\nLooking for a fallback subproject for the dependency gtest\n\nExecuting subproject gtest\n\ngtest| Project name: gtest\ngtest| Project version: 1.11.0\ngtest| C++ compiler for the host machine: c++ (gcc 12.2.0 \"c++ (Debian \n12.2.0-14) 12.2.0\")\ngtest| C++ linker for the host machine: c++ ld.bfd 2.40\ngtest| Dependency threads found: YES unknown (cached)\ngtest| Dependency threads found: YES unknown (cached)\ngtest| Dependency threads found: YES unknown (cached)\ngtest| Dependency threads found: YES unknown (cached)\ngtest| Build targets in project: 35\ngtest| Subproject gtest finished.\n\nDependency gtest from subproject subprojects/googletest-release-1.11.0 \nfound: YES 1.11.0\nRun-time dependency qt5 (modules: Core, Gui, Widgets) found: YES 5.15.8 \n(pkg-config)\nHeader \"QOpenGLWidget\" has symbol \"QOpenGLWidget\" with dependencies \nQt5Core, Qt5Core, Qt5Gui, Qt5Widgets: YES\nDetecting Qt5 tools\nRun-time dependency qt5 (modules: Core) found: YES 5.15.8 (pkg-config)\nProgram /usr/lib/x86_64-linux-gnu/qt5/bin/moc found: YES 5.15.8 \n(/usr/lib/x86_64-linux-gnu/qt5/bin/moc)\nProgram /usr/lib/x86_64-linux-gnu/qt5/bin/uic found: YES 5.15.8 \n(/usr/lib/x86_64-linux-gnu/qt5/bin/uic)\nProgram /usr/lib/x86_64-linux-gnu/qt5/bin/rcc found: YES 5.15.8 \n(/usr/lib/x86_64-linux-gnu/qt5/bin/rcc)\nProgram /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\nProgram lrelease5 found: NO\nProgram lrelease-qt5 found: NO\nProgram lrelease found: NO found but need: '== 5.15.8' (/usr/bin/lrelease)\nRun-time dependency glib-2.0 found: NO (tried pkgconfig and cmake)\nRun-time dependency gstreamer-video-1.0 found: NO (tried pkgconfig and \ncmake)\nRun-time dependency gstreamer-allocators-1.0 found: NO (tried pkgconfig \nand cmake)\nRun-time dependency python3 found: NO (tried pkgconfig and sysconfig)\nProgram doxygen found: NO\nProgram dot found: NO\nProgram sphinx-build-3 found: NO\nProgram sphinx-build found: NO\nConfiguring config.h using configuration\nProgram python3 (jinja2, ply, jinja2, yaml) found: YES \n(/usr/bin/python3) modules: jinja2, ply, jinja2, yaml\nBuild targets in project: 39\n\nlibcamera 0.3.0\n\n Versions\n Sources : 0.3.0\n\n Paths\n LIBCAMERA_DATA_DIR : \"/usr/local/share/libcamera\"\n LIBCAMERA_SYSCONF_DIR : \"/usr/local/etc/libcamera\"\n IPA_PROXY_DIR : \"/usr/local/libexec/libcamera\"\n IPA_CONFIG_DIR : \n\"/usr/local/etc/libcamera/ipa:/usr/local/share/libcamera/ipa\"\n IPA_MODULE_DIR : \"/usr/local/lib/x86_64-linux-gnu/libcamera\"\n\n Configuration\n SoftISP support : False\n IPA modules signed with : gnutls\n Enabled pipelines : ipu3\n uvcvideo\n Enabled IPA modules : ipu3\n Controls files : control_ids_draft.yaml\n control_ids_core.yaml\n Properties files : property_ids_draft.yaml\n property_ids_core.yaml\n Hotplug support : NO\n Tracing support : NO\n Android support : NO\n GStreamer support : NO\n Python bindings : NO\n V4L2 emulation support : NO\n cam application : NO\n qcam application : YES\n lc-compliance application: NO\n Unit tests : NO\n\n Subprojects\n gtest : YES\n\"\"\"\n\nThere are plenty other \"NO\" printed during the setup detection. Does it \nreally matter if one gets a few other \"NO\" especially since they don't \nimpact anything?\n\n> Is there anything we can do to stop meson from looking for lrelease-qt5?\n\nDoesn't seem like it no.\n\nI'm not familiar with meson nor qt build systems but it seems like \nQtBaseModule in mesonbuild/modules/qt.py has a hardcoded list of tools \nto check. In Debian Bookworm, meson 1.0.1 is used. QtBaseModule has \nself.tools set to moc, uic, rcc and lrelease. The compilers_detect \nmethod checks for all binaries listed in that list (c.f. \nfind_program()). That method is called when _detect_tools() method is \ncalled. That method seems to be called whenever _compile_moc_impl(), \n_compile_resources_impl, or _compile_ui_impl() is called. Those are \ncalled when compile_resources(), compile_ui(), compile_moc() or \npreprocess() is called. Which is what we do in \nsrc/apps/qcam/meson.build, c.f.\n\n\"\"\"\nresources = qt5.preprocess(moc_headers : qcam_moc_headers,\n qresources : qcam_resources,\n dependencies : qt5_dep)\n\nqcam = executable('qcam', qcam_sources, resources,\n\"\"\"\n\nNote that it seems meson v1.7.0 will also check for qmlcachegen and \nqmltyperegistrar on the host, c.f. commit \n4508622a34932d23e336392a8a3c71ed79af4e3f.\n\nhas_tools now allows to pass a list of tools to check, c.f. commit \n6797f9bc1502609783a8fc465e2960819ab4f38f but that doesn't seem to change \nthe list of tools that are always checked, just a way to provide a way \nto conditionally do things in meson, based on the return value of \nhas_tools for specific tools, my understanding is that all hardcoded \ntools are still checked once.\n\n> Who's looking for that in the build?\n> \n\nmeson, based on the preprocess() call in the qt module. We need that \napparently for moc (header files with Q_OBJECT in there? c.f. \nhttps://doc.qt.io/qt-6/moc.html) and rcc (handling .qrc files, c.f. \nhttps://doc.qt.io/qt-6/rcc.html).\n\nWe may want to use qt.has_tools() with moc and rcc to manually check \nthose before we call preprocess() and fail otherwise? So people are \naware which qt tools are actually required? But that still wouldn't \nremove the \"NO\" for lrelease, and other unneeded binaries. Note that moc \nand rcc (and uic, another Qt tool that is required) are part of \nqtbase5-dev-tools package on Debian (not to be confused with \nqttools5-dev-tools which is bringing in lrelease (and lupdate, lconvert, \n...)).\n\nCheers,\nQuentin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 934F1C32F5\n\tfor ;\n\tMon, 17 Mar 2025 14:51:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B51568947;\n\tMon, 17 Mar 2025 15:51:33 +0100 (CET)","from EUR02-DB5-obe.outbound.protection.outlook.com\n\t(mail-db5eur02on20601.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:2608::601])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E11A1617F8\n\tfor ;\n\tMon, 17 Mar 2025 15:51:32 +0100 (CET)","from AS8PR04MB8897.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:42c::20)\n\tby DB8PR04MB7066.eurprd04.prod.outlook.com (2603:10a6:10:12e::14)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.33;\n\tMon, 17 Mar 2025 14:51:30 +0000","from AS8PR04MB8897.eurprd04.prod.outlook.com\n\t([fe80::35f6:bc7d:633:369a]) by\n\tAS8PR04MB8897.eurprd04.prod.outlook.com\n\t([fe80::35f6:bc7d:633:369a%6]) with mapi id 15.20.8534.031;\n\tMon, 17 Mar 2025 14:51:30 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=cherry.de header.i=@cherry.de\n\theader.b=\"gaPNsDp6\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=cherry.de;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=VONfPfFp5Y++ZbDqsyWFHT9iui4UrjrK2vG0KXm+NgJi7bwcHm5e+v8Z9c/WuiL6oa+jlcx78ck3o6/v8Qq+1gI0km2VIN9azAf8bn8KjmdncnMO0mFq+bjqRP1D9toAnHk/lYBKGIzBupOB3+i+EzuGEb05CzW5DlJHNck9QFyCYQXhr5M3ir0HZIgDOmLWWFIm1tu0hTrk/Er+xI2glcgke8L+jt6he/3kq54oVayrPngj5BJ3K+FeIq6/2ydVI3s5z0XXmKrYa3aJyNPz8hE7L6fmp6CzvbGobaPMcYIHYQpCUux06NzfRant0ilS+smapzBrs5DDN09NIkKmgA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=OBzgSgXrkdBEu1N1jbppFruaYtoo39u5c4T9puCPp3w=;\n\tb=lXNseCGkzDpPjrcT/s/zLwZpu3C0v0n3zYt5eQYN4J8fmiZAOGNvxSzCiSphDMsDOSfofgNvhxQN4ha3TYPa1aXjVDjj5CO5pI/92EVpRFJACj28nk0eojrMq0FRttET8QQ+YcRZ/r1mt5JMV8iEYIDCUPgmWZMb2MeY9NA/beWXONuXp26WYL2qUVMY4X/7arw0KbCbJLQhiINI0pDX5jzyrX4ltMtDZLBQavyTfUYcj+fMPCFe++cO6kNb614Ezivz01Xx7HFOX1SYvO5PTg2qIBLYB/gVOgOxT+QjvfL0Ic9DUPwLof8ALriCveNrA1+t+JUSw1hcIciq6ZiKCA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=cherry.de; dmarc=pass action=none header.from=cherry.de;\n\tdkim=pass header.d=cherry.de; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=cherry.de;\n\ts=selector1; \n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=OBzgSgXrkdBEu1N1jbppFruaYtoo39u5c4T9puCPp3w=;\n\tb=gaPNsDp61de81xhcxsT1kqIZhs3R24iomJBEQqt+WUxbrX45HhxpCZ3fx8ayw+GzApDV7CBT66PN++2Qkw52/IcEEjFCyyHPgo+NpCTLBgZrLQZ9N6uiW/73+IEuDP2sveiDBc6QpOgd7Na++3MWHJq763gVUxhic1Ge2g9vX1s=","Message-ID":"<89611012-5f0a-4338-a0ef-831022b718c0@cherry.de>","Date":"Mon, 17 Mar 2025 15:51:29 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","To":"Kieran Bingham ,\n\tQuentin Schulz ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Ricardo Ribalda ","References":"<20250311-qttools-unneeded-v1-1-834c30be7e7a@cherry.de>\n\t<4071a4ed-f765-4712-95b2-d36bad261f2a@cherry.de>\n\t<174221410402.1463678.10391570271713109059@ping.linuxembedded.co.uk>\n\t<26c25a91-6e99-4f8e-a7a4-beec33d1a8c5@cherry.de>\n\t<174221704065.1463678.12290222536465941618@ping.linuxembedded.co.uk>","Content-Language":"en-US","From":"Quentin Schulz ","In-Reply-To":"<174221704065.1463678.12290222536465941618@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","X-ClientProxiedBy":"FR4P281CA0192.DEUP281.PROD.OUTLOOK.COM\n\t(2603:10a6:d10:ca::10) To AS8PR04MB8897.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:42c::20)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS8PR04MB8897:EE_|DB8PR04MB7066:EE_","X-MS-Office365-Filtering-Correlation-Id":"c733ee69-5a72-4885-3fea-08dd656333b9","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0; ARA:13230040|1800799024|376014|366016|7053199007;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?7YakmSxKKCIs4KMMRqx6N2DXOyMB?=\n\t=?utf-8?q?GVRny24fXvR9yuu03/vlg4EPKo7BAzR4vF/xYxoDcmF1r+Ezpw2R7l6d?=\n\t=?utf-8?q?ZIEEZduf6ZexoK5qskSJuTy2/k6zzXZGk9IhJJe7T45A6M7ZmKqI4Q1h?=\n\t=?utf-8?q?5l8p0fWrXzFK+agbgrCcfg+KHtc+fKFqF5FNm7FH7oaqO5GzgWpeL3M7?=\n\t=?utf-8?q?HPtWiXAtvBlOx9cTUmC+Je/lKhuyiEjh0Y119LGJ9jKc1mqc6QufuldF?=\n\t=?utf-8?q?DNz6bHyyc3YiFjySeLxcPwpQh2B+wKi9X67+1KCaWngr+Wc+ZVZlHTgv?=\n\t=?utf-8?q?fdK5nda/bJLIjpMUed6DStc5otFLXWYedZFTTzKFMpYCNPl1496Kbfhk?=\n\t=?utf-8?q?/9XSXZwHQQy9wZc0QGRe52AOe21vFAKts6VzXaZVj4o/UoeGYwBZ0Pj7?=\n\t=?utf-8?q?Ikm4katFEsocJDosw3x6NUYZ9yNwWk5vE7Wdi2gOMUGmk8izuw9bb2HT?=\n\t=?utf-8?q?vZ6SG9YWymeRqpOMK7AXnpkSJQGzpgajVMFeaBNeO4WB5O6ymr09VMC3?=\n\t=?utf-8?q?eZgKTSSSjHcxgnHFU8XUuKEidcYS8jgFP3AxZVCphMl6wmV1Y2YQQWf0?=\n\t=?utf-8?q?S62vOOyOYSx3f/9jtqQFTK+xx1Vtz40CfBO0VrjpQLoT4kwpLpSjuZdL?=\n\t=?utf-8?q?bN4Csu3wGtdjlN6ylzek++kC3iYnuVr+wR7kXB6L5gzb32YHObELEde+?=\n\t=?utf-8?q?Da2wQOiVLtwQBaNE3vA2GzW+7Xx5Ir1B3P9u5sSn9rMH1D43UP/XPkoI?=\n\t=?utf-8?q?JlepeeZJ+knLb38vpTIYiJFfvKDaR9evFBPnPO2ds82BHeDDPbhKbyUv?=\n\t=?utf-8?q?2sqD9oRH3+RKvqWnKp2Ylrq+UnMgruMu/gJVrtYSAd7AWka5MxR7/T7P?=\n\t=?utf-8?q?Hvs2s8KWxoQDOltKpwp1kKk+6HgPdqh+LKRd3AJxRDTYwmVJ/IXYOZjw?=\n\t=?utf-8?q?23qZScStlTp2T1FxBu/sGTaBTHQ/HgGF/VaskSGGYrfGyzAWL8zA6WJ7?=\n\t=?utf-8?q?1jCI59gXGGjRfPfy5jpANxyQOPE+0boG1XAykqRnwz69i89RX+IJ02P5?=\n\t=?utf-8?q?vJozSWS53Bq4JmeRucCvlH/rDD+NWSEBqEOVFXRTyXZ/UKtoxeNAJHeG?=\n\t=?utf-8?q?q6/Sd4jBaG6W3U6tGMNHrszETjyaVZywgjcoDr/L5yZ52M9sJ5/QFI97?=\n\t=?utf-8?q?ISAfd3zlVNZ6CwW402jen76MnE59XkyQbRxykwnYP9v826tWCzqUk9n4?=\n\t=?utf-8?q?aO6ke2nj4r8EPag6DJ2j4pGo94EVkOg25UJ3c8+4NApUvytnDAJXDFYy?=\n\t=?utf-8?q?Z6FAFIOllfoIEs0KZo29B0fPbFqG774G41L3IWSS2ZLgdq+AKYZt7pNs?=\n\t=?utf-8?q?e2O0RbvUgtKezx1FjkcBiXsLciFq3T5CoT1K02YH4lSY8sXxsg=3D=3D?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:AS8PR04MB8897.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(1800799024)(376014)(366016)(7053199007); DIR:OUT;\n\tSFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?NYeyhRt6wqHvesgLzD4C0ppc2?=\n\t=?utf-8?q?r5DGMUl6INNyLUpNoK/syqrAk74nfJIZ6vYTCsxvos/DMH1qN96HEH3w?=\n\t=?utf-8?q?4Jb6xowsNY0VLB2TT6AaL8h9zYOq72Mtn9AdWu5zGqbdzo/iP2TONIHr?=\n\t=?utf-8?q?Qi2YKVXY+5uQP9dTT30xm+7vBFWFe6ss9IklfUBeXJmS4OsC3axYyk8k?=\n\t=?utf-8?q?GiqBAq7MtYNqzP9jKREPNiAbfH6al2AiR++K2kj7GAzRtna5a3snSsMK?=\n\t=?utf-8?q?bZRH6trDqRlxpbgSBiBQc0Ge2tEwuHKXoTU8+RrvkP2rfnA/c2mFWOGu?=\n\t=?utf-8?q?YVSx/lwgVQfhQ5zAwz5rljIHKXX6z9LMgkCoUqABAlN2TeS8/lK5BFq4?=\n\t=?utf-8?q?59bH8KnuQRRPZKli/azqbhl4dZCXistn15yYRo02EpjDpBoDqxgxwgRX?=\n\t=?utf-8?q?m9xbtwQpoH7Epl6N2KuSdMvJvdtSZQLVR/AvVLr5yIZyfowZuVFKUVMJ?=\n\t=?utf-8?q?q/Dt9VWgAGBuC/FWb8JFypiYXrwPsPulqoORUrmT3Ah4sz0POe9lDNiG?=\n\t=?utf-8?q?H4PdLkA3QI917l6VdPfBjZHwFXTLtOd63IERy5suRM2EmO7AFDZvhWPl?=\n\t=?utf-8?q?bTKpQ/Cal+FdOj4Z+iG9nueFJ0Z+5dneyjyfsx+puYKoicplvGJ+nTuU?=\n\t=?utf-8?q?GJWNAZ1REKdSfOyhggNscEwc6JzXxuaRph6sJttmc+qu8bSagDPnYN4p?=\n\t=?utf-8?q?swXK097vUkTtBKcvP4iOiCwf0wGnr/2237fPtlzlOqWeG5LsPhDQFbHZ?=\n\t=?utf-8?q?y3WLoXQAkM75dNyIbi5DP2GVwiM4oFhR5p2YOXW2OoXnMciYdyHFtL4E?=\n\t=?utf-8?q?2dBURDnrl/wfkmHvWmFlCO6TX2YDq/LJfcRnh7s7QPGP9JHo8BcKZ5Oa?=\n\t=?utf-8?q?u+50HPtixTzh0MJVPROj5LX2cb+rMFmnuDtvQHeT8sz1DK4hWmwHBwYN?=\n\t=?utf-8?q?fIeFghe1S2SHSmsX04hVy6xxFBzUPxhZkwRhJl7KxOop3LLDQQrW2411?=\n\t=?utf-8?q?FAEIzn3F+2AmjEOwdVr8C3BFbvaFJ/ycprHVGVJkZEeF1hmLE8GiE2/r?=\n\t=?utf-8?q?2JPFwXf59VuZLeSr1ZzOPKW/sRPhgRvjAManiIMbqAA8Y1WDLKBwgtD1?=\n\t=?utf-8?q?MK8JJ5LLjEcq24gu9j2snBzCN2FwOkojOl/tBTWkfYVgws7npLATSMgU?=\n\t=?utf-8?q?na1uQ1/MUAPAL1fblLNVuyp+wDxdzTrp4GpWDiH2J3pWRV5/6Ek2U1yP?=\n\t=?utf-8?q?faQYipDuDa+N5FC4V2oVIPv0Su7LhCEXBV0x9oBn1l13kze1PBhc1CzP?=\n\t=?utf-8?q?1QOFnbedDPUHNVvFagd4EZ30nHO1HekPJN1ZiaHckwCKY+MtYo8DdaXt?=\n\t=?utf-8?q?PpOXsnTFmwsA+xFIqUJD4aVcQOYwOHPgZ9j5zwAXxEX67nAIiy9EOeRt?=\n\t=?utf-8?q?2Vrp6QjHyqSOcdjTIGuCxqiWVbWtq3jnRr2WlG/Zw4Yjh+a3f9/7urP3?=\n\t=?utf-8?q?YQFtbHlb3xIuO+YyyFGQ2jjTPxsS2QADop7pR5Mbv0QaIKZcawHMVBgT?=\n\t=?utf-8?q?64mmEwfwoBaG/GoolHtXn86rfoOjnG6aMpTRnpgVUpLlDeYlsnJMkVY/?=\n\t=?utf-8?q?g/u+jSMOyfZFbdIpsaz/8513XEDQVGpLPMlzahTehFOIq2MpWYOwy1Qz?=\n\t=?utf-8?q?Rgx+mIo3K0hrlIuRlntTPUq3LI2gg=3D=3D?=","X-OriginatorOrg":"cherry.de","X-MS-Exchange-CrossTenant-Network-Message-Id":"c733ee69-5a72-4885-3fea-08dd656333b9","X-MS-Exchange-CrossTenant-AuthSource":"AS8PR04MB8897.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"17 Mar 2025 14:51:30.2262\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"5e0e1b52-21b5-4e7b-83bb-514ec460677e","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"MRsVpvFwkEwuoPfAsp9amWyKgy3RZ9gqV9lgQD5LukcesY/jUMgAne6c7XtK5VNdjw+oQTJiaZ0Xzs43dXlBIcx1/PpPzGgHjGCRNY1xUO4=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB8PR04MB7066","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33980,"web_url":"https://patchwork.libcamera.org/comment/33980/","msgid":"<44c7d9c7-0054-44d8-b79b-ef09270cda3d@cherry.de>","date":"2025-04-22T09:21:44","subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","submitter":{"id":202,"url":"https://patchwork.libcamera.org/api/people/202/","name":"Quentin Schulz","email":"quentin.schulz@cherry.de"},"content":"Hi Kieran,\n\nOn 3/17/25 3:51 PM, Quentin Schulz wrote:\n> Hi Kieran,\n> \n> On 3/17/25 2:10 PM, Kieran Bingham wrote:\n>> Quoting Quentin Schulz (2025-03-17 12:30:48)\n>>> Hi Kieran,\n>>>\n>>> On 3/17/25 1:21 PM, Kieran Bingham wrote:\n>>>> Quoting Quentin Schulz (2025-03-11 13:06:25)\n>>>>> +Cc Ricardo, the original commit author, in case I'm missing something\n>>>>>\n>>>>> On 3/11/25 2:01 PM, Quentin Schulz wrote:\n>>>>>> [foss+libcamera@0leil.net appears similar to someone who \n>>>>>> previously sent you email, but may not be that person. Learn why \n>>>>>> this could be a risk at https://aka.ms/ \n>>>>>> LearnAboutSenderIdentification ]\n>>>>>>\n>>>>>> From: Quentin Schulz \n>>>>>>\n>>>>>> The introducing commit (dff416a84b78 (\"README: Add missing package \n>>>>>> for\n>>>>>> Qt5 tools\"); for Qt 5 originally) stated that without the \n>>>>>> dependency we\n>>>>>> would get the following messages:\n>>>>>>\n>>>>>>        Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n>>>>>>        Program lrelease-qt5 found: NO\n>>>>>>        Program lrelease found: NO found  but need: '== 5.14.2'\n>>>>>>\n>>>>>> That is still the case but this actually is neither breaking the \n>>>>>> build\n>>>>>> nor is it doing anything to the outcome of the build as qcam is \n>>>>>> bit to\n>>>>>> bit identical with and without that package.\n>>>>>>\n>>>>>> Therefore, let's not mislead users to install an unnecessary package.\n>>>>>>\n>>>>>> Signed-off-by: Quentin Schulz \n>>>>>> ---\n>>>>>> This was tested within a debian:bookworm container with and \n>>>>>> without the\n>>>>>> package, checked out both at master and introducing commit. qcam \n>>>>>> is bit\n>>>>>> to bit identical in both cases.\n>>>>\n>>>> That's the evidence I would look for in this, so\n>>>>\n>>>> Reviewed-by: Kieran Bingham \n>>>>\n>>>> Is this still the case on Qt6? I assume/infer that the reason you want\n>>>> to remove this dependency is because something has changed in qt6 ?\n>>>>\n>>>> If so - adding that to the commit message would help clarify things, as\n>>>> you are removing a qt6 package, but only discussing qt5 in the commit.\n>>>>\n>>>\n>>> This was tested for both qt5 and qt6, results are both bit to bit \n>>> identical.\n>>>\n>>> I stated that in the Buildroot patch:\n>>> https://eur02.safelinks.protection.outlook.com/? \n>>> url=https%3A%2F%2Flore.kernel.org%2Fbuildroot%2F20250311-libcamera- \n>>> qt6- \n>>> v1-1-4897aadc6fe3%40cherry.de%2F&data=05%7C02%7Cquentin.schulz%40cherry.de%7C2f082d52936f4a81ed5808dd65552053%7C5e0e1b5221b54e7b83bb514ec460677e%7C0%7C0%7C638778138464717991%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=b3bBcP2OYapWwhMwAoAMgIKTLcg8rurpdOnKqW6XzwQ%3D&reserved=0\n>>> but forgot to add it here before submitting the patch.\n>>>\n>>> I can reword the commit log to something like:\n>>>\n>>> \"\"\"\n>>> The introducing commit (dff416a84b78 (\"README: Add missing package for\n>>> Qt5 tools\"); for Qt 5 originally) stated that without the dependency we\n>>> would get the following messages:\n>>>\n>>>         Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n>>>         Program lrelease-qt5 found: NO\n>>>         Program lrelease found: NO found  but need: '== 5.14.2'\n>>>\n>>> That was the case for qt5 and is still true for qt6 but this actually\n>>> is neither breaking the build nor is it doing anything to the outcome\n>>> of the build (for both qt5 and qt6) as qcam is bit to bit identical\n>>> with and without that package.\n>>>\n>>> Therefore, let's not mislead users to install an unnecessary package.\n>>> \"\"\"\n>>>\n>>> Would that work for you? Do you want me to send a v2 for that?\n>>\n>> No need for a v2 at the moment ... we can easily fix up the commit, it's\n>> just the justification I want to get right. Stating that this is still\n>> the case for Qt6 fixes my concern ;-)\n>>\n>> Especially as this will now cause users to have a warning reintroduced\n>> in their setup logs! Why is that now acceptable when it wasn't before?\n>>\n> \n> \"\"\"\n> meson setup build\n> The Meson build system\n> Version: 1.0.1\n> Source dir: /home/qschulz/work/upstream/libcamera\n> Build dir: /home/qschulz/work/upstream/libcamera/build\n> Build type: native build\n> Project name: libcamera\n> Project version: 0.3.0\n> C compiler for the host machine: cc (gcc 12.2.0 \"cc (Debian 12.2.0-14) \n> 12.2.0\")\n> C linker for the host machine: cc ld.bfd 2.40\n> C++ compiler for the host machine: c++ (gcc 12.2.0 \"c++ (Debian \n> 12.2.0-14) 12.2.0\")\n> C++ linker for the host machine: c++ ld.bfd 2.40\n> Host machine cpu family: x86_64\n> Host machine cpu: x86_64\n> Header \"fcntl.h\" has symbol \"F_ADD_SEALS\" : YES\n> Header \"unistd.h\" has symbol \"issetugid\" : NO\n> Header \"locale.h\" has symbol \"locale_t\" : YES\n> Header \"sys/mman.h\" has symbol \"memfd_create\" : YES\n> Header \"stdlib.h\" has symbol \"secure_getenv\" : YES\n> Compiler for C supports arguments -Wno-c99-designator: NO\n> Found pkg-config: /usr/bin/pkg-config (1.8.1)\n> Did not find CMake 'cmake'\n> Found CMake: NO\n> Run-time dependency lttng-ust found: NO (tried pkgconfig and cmake)\n> Program ./parser.py found: YES (/home/qschulz/work/upstream/libcamera/ \n> utils/ipc/./parser.py)\n> Program ./generate.py found: YES (/home/qschulz/work/upstream/libcamera/ \n> utils/ipc/./generate.py)\n> Program ./extract-docs.py found: YES (/home/qschulz/work/upstream/ \n> libcamera/utils/ipc/./extract-docs.py)\n> Program ./gen-tp-header.py found: YES (/home/qschulz/work/upstream/ \n> libcamera/utils/tracepoints/./gen-tp-header.py)\n> Configuring version.h using configuration\n> Program openssl found: YES (/usr/bin/openssl)\n> Library atomic found: YES\n> Run-time dependency threads found: YES\n> Run-time dependency libdw found: NO (tried pkgconfig and cmake)\n> Run-time dependency libunwind found: NO (tried pkgconfig and cmake)\n> Header \"execinfo.h\" has symbol \"backtrace\" : YES\n> Checking for function \"dlopen\" : YES\n> Run-time dependency libudev found: NO (tried pkgconfig and cmake)\n> Run-time dependency yaml-0.1 found: YES 0.2.5\n> Run-time dependency gnutls found: YES 3.7.9\n> Dependency libexif skipped: feature android disabled\n> Dependency libjpeg skipped: feature android disabled\n> Run-time dependency libevent_pthreads found: NO (tried pkgconfig and cmake)\n> Run-time dependency libevent_pthreads found: NO (tried pkgconfig and cmake)\n> Run-time dependency libtiff-4 found: YES 4.5.0\n> Run-time dependency GTest found: NO (tried pkgconfig and system)\n> Looking for a fallback subproject for the dependency gtest\n> \n> Executing subproject gtest\n> \n> gtest| Project name: gtest\n> gtest| Project version: 1.11.0\n> gtest| C++ compiler for the host machine: c++ (gcc 12.2.0 \"c++ (Debian \n> 12.2.0-14) 12.2.0\")\n> gtest| C++ linker for the host machine: c++ ld.bfd 2.40\n> gtest| Dependency threads found: YES unknown (cached)\n> gtest| Dependency threads found: YES unknown (cached)\n> gtest| Dependency threads found: YES unknown (cached)\n> gtest| Dependency threads found: YES unknown (cached)\n> gtest| Build targets in project: 35\n> gtest| Subproject gtest finished.\n> \n> Dependency gtest from subproject subprojects/googletest-release-1.11.0 \n> found: YES 1.11.0\n> Run-time dependency qt5 (modules: Core, Gui, Widgets) found: YES 5.15.8 \n> (pkg-config)\n> Header \"QOpenGLWidget\" has symbol \"QOpenGLWidget\" with dependencies \n> Qt5Core, Qt5Core, Qt5Gui, Qt5Widgets: YES\n> Detecting Qt5 tools\n> Run-time dependency qt5 (modules: Core) found: YES 5.15.8 (pkg-config)\n> Program /usr/lib/x86_64-linux-gnu/qt5/bin/moc found: YES 5.15.8 (/usr/ \n> lib/x86_64-linux-gnu/qt5/bin/moc)\n> Program /usr/lib/x86_64-linux-gnu/qt5/bin/uic found: YES 5.15.8 (/usr/ \n> lib/x86_64-linux-gnu/qt5/bin/uic)\n> Program /usr/lib/x86_64-linux-gnu/qt5/bin/rcc found: YES 5.15.8 (/usr/ \n> lib/x86_64-linux-gnu/qt5/bin/rcc)\n> Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n> Program lrelease5 found: NO\n> Program lrelease-qt5 found: NO\n> Program lrelease found: NO found  but need: '== 5.15.8' (/usr/bin/lrelease)\n> Run-time dependency glib-2.0 found: NO (tried pkgconfig and cmake)\n> Run-time dependency gstreamer-video-1.0 found: NO (tried pkgconfig and \n> cmake)\n> Run-time dependency gstreamer-allocators-1.0 found: NO (tried pkgconfig \n> and cmake)\n> Run-time dependency python3 found: NO (tried pkgconfig and sysconfig)\n> Program doxygen found: NO\n> Program dot found: NO\n> Program sphinx-build-3 found: NO\n> Program sphinx-build found: NO\n> Configuring config.h using configuration\n> Program python3 (jinja2, ply, jinja2, yaml) found: YES (/usr/bin/ \n> python3) modules: jinja2, ply, jinja2, yaml\n> Build targets in project: 39\n> \n> libcamera 0.3.0\n> \n>   Versions\n>     Sources                  : 0.3.0\n> \n>   Paths\n>     LIBCAMERA_DATA_DIR       : \"/usr/local/share/libcamera\"\n>     LIBCAMERA_SYSCONF_DIR    : \"/usr/local/etc/libcamera\"\n>     IPA_PROXY_DIR            : \"/usr/local/libexec/libcamera\"\n>     IPA_CONFIG_DIR           : \"/usr/local/etc/libcamera/ipa:/usr/ \n> local/share/libcamera/ipa\"\n>     IPA_MODULE_DIR           : \"/usr/local/lib/x86_64-linux-gnu/libcamera\"\n> \n>   Configuration\n>     SoftISP support          : False\n>     IPA modules signed with  : gnutls\n>     Enabled pipelines        : ipu3\n>                                uvcvideo\n>     Enabled IPA modules      : ipu3\n>     Controls files           : control_ids_draft.yaml\n>                                control_ids_core.yaml\n>     Properties files         : property_ids_draft.yaml\n>                                property_ids_core.yaml\n>     Hotplug support          : NO\n>     Tracing support          : NO\n>     Android support          : NO\n>     GStreamer support        : NO\n>     Python bindings          : NO\n>     V4L2 emulation support   : NO\n>     cam application          : NO\n>     qcam application         : YES\n>     lc-compliance application: NO\n>     Unit tests               : NO\n> \n>   Subprojects\n>     gtest                    : YES\n> \"\"\"\n> \n> There are plenty other \"NO\" printed during the setup detection. Does it \n> really matter if one gets a few other \"NO\" especially since they don't \n> impact anything?\n> \n>> Is there anything we can do to stop meson from looking for lrelease-qt5?\n> \n> Doesn't seem like it no.\n> \n> I'm not familiar with meson nor qt build systems but it seems like \n> QtBaseModule in mesonbuild/modules/qt.py has a hardcoded list of tools \n> to check. In Debian Bookworm, meson 1.0.1 is used. QtBaseModule has \n> self.tools set to moc, uic, rcc and lrelease. The compilers_detect \n> method checks for all binaries listed in that list (c.f. \n> find_program()). That method is called when _detect_tools() method is \n> called. That method seems to be called whenever _compile_moc_impl(), \n> _compile_resources_impl, or _compile_ui_impl() is called. Those are \n> called when compile_resources(), compile_ui(), compile_moc() or \n> preprocess() is called. Which is what we do in src/apps/qcam/ \n> meson.build, c.f.\n> \n> \"\"\"\n> resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n>                            qresources : qcam_resources,\n>                            dependencies : qt5_dep)\n> \n> qcam  = executable('qcam', qcam_sources, resources,\n> \"\"\"\n> \n> Note that it seems meson v1.7.0 will also check for qmlcachegen and \n> qmltyperegistrar on the host, c.f. commit \n> 4508622a34932d23e336392a8a3c71ed79af4e3f.\n> \n> has_tools now allows to pass a list of tools to check, c.f. commit \n> 6797f9bc1502609783a8fc465e2960819ab4f38f but that doesn't seem to change \n> the list of tools that are always checked, just a way to provide a way \n> to conditionally do things in meson, based on the return value of \n> has_tools for specific tools, my understanding is that all hardcoded \n> tools are still checked once.\n> \n>> Who's looking for that in the build?\n>>\n> \n> meson, based on the preprocess() call in the qt module. We need that \n> apparently for moc (header files with Q_OBJECT in there? c.f. https:// \n> doc.qt.io/qt-6/moc.html) and rcc (handling .qrc files, c.f. https:// \n> doc.qt.io/qt-6/rcc.html).\n> \n> We may want to use qt.has_tools() with moc and rcc to manually check \n> those before we call preprocess() and fail otherwise? So people are \n> aware which qt tools are actually required? But that still wouldn't \n> remove the \"NO\" for lrelease, and other unneeded binaries. Note that moc \n> and rcc (and uic, another Qt tool that is required) are part of qtbase5- \n> dev-tools package on Debian (not to be confused with qttools5-dev-tools \n> which is bringing in lrelease (and lupdate, lconvert, ...)).\n> \n\nAnything I can help with to get this merged? Or do we abandon it? Just \nto know what to do with this patch that I am occasionally still \nmonitoring :)\n\nCheers,\nQuentin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4483BC327D\n\tfor ;\n\tTue, 22 Apr 2025 09:21:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBE3E68AC7;\n\tTue, 22 Apr 2025 11:21:51 +0200 (CEST)","from EUR05-DB8-obe.outbound.protection.outlook.com\n\t(mail-db8eur05on2061a.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:2614::61a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95953617E6\n\tfor ;\n\tTue, 22 Apr 2025 11:21:49 +0200 (CEST)","from AS8PR04MB8897.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:42c::20)\n\tby PA4PR04MB9461.eurprd04.prod.outlook.com (2603:10a6:102:2a9::18)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.34;\n\tTue, 22 Apr 2025 09:21:45 +0000","from AS8PR04MB8897.eurprd04.prod.outlook.com\n\t([fe80::35f6:bc7d:633:369a]) by\n\tAS8PR04MB8897.eurprd04.prod.outlook.com\n\t([fe80::35f6:bc7d:633:369a%7]) with mapi id 15.20.8655.033;\n\tTue, 22 Apr 2025 09:21:45 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=cherry.de header.i=@cherry.de\n\theader.b=\"I7Z78U1V\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=cherry.de;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=wLxHlVcmBlTMVCYVFHd8izagwodQHJ3gQ7gsbo8mGko4JfGprZMmrDBA9Axo1pMPXp7eyATiKWOBhwWB90aqWfIyQp2ZYHcSOAK/J/o+Mgjjr4QG+Hm7dZOG2CZAJG2fUk+1bzXmLCtWOp/F/ZcfHsq5uN24UMbuH+ILItuJNVaHMdlMb4RAVfWTwpMiMSPhUac10vn51v3qMhzIw6QH/v/ZqKejS8kQLmowu44amTq7wod2U0FONl5xxoj2Xqb3u6wcP6nB0lpVzjZnUr0KhMPBsSvsf08/y4YGwwNGwWyE/DGB/HHP+x5Fi9Dk/5ZQ4f0Cm6H3zw34WFXuo8aPzQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=zJmsL5LLmSD9wlavIRMmYFIK5a4SXz+im2UYfMgLaq0=;\n\tb=tIlJ1wPRoUvPWQiudq3p6Gfyby/w7QamT3LeO2ZUBKiNlGASeecLIzVzUUAT0g25n11DplJPO6ERzUZHO6s8fYsWLEtR/MAM19+9Jc/IshkFJWenYZaDMKLnGymYFJihZrrQ3y5ZeUKv9o7j339jA5sfeivgtcEGBH1BlTf9ZdQXOKaQvS/6b5TioJBGMvwLFqjdPfX5FvllbcCReoliADmxzXPcK6O+lgrjjcr/d3f3pd/FQajaPz2q1GH8ceIibsRUzpz/pcUYdzwgAuajGJq7rbO6SX6poouDmU9Wt/KaR19BTnyw3W2XCzK2XadfXGGgciT1MXt/103wdf9Glw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=cherry.de; dmarc=pass action=none header.from=cherry.de;\n\tdkim=pass header.d=cherry.de; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=cherry.de;\n\ts=selector1; \n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=zJmsL5LLmSD9wlavIRMmYFIK5a4SXz+im2UYfMgLaq0=;\n\tb=I7Z78U1Vipjyx4McGQBG68Qe6AnBHJZdyaBQvurScTjWzwOBfJeggXdJvysTSE2qkCfepto25N0tGShU/kQ9JsK3UGwmlEnZJyiI5Et2O3GZGr5v1ZkRonkQs6W6kDTielvOrS05+bQtCaWSsXCwsRYJfjHrUTYC+COYpOqzxNs=","Message-ID":"<44c7d9c7-0054-44d8-b79b-ef09270cda3d@cherry.de>","Date":"Tue, 22 Apr 2025 11:21:44 +0200","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","From":"Quentin Schulz ","To":"Kieran Bingham ,\n\tQuentin Schulz ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Ricardo Ribalda ","References":"<20250311-qttools-unneeded-v1-1-834c30be7e7a@cherry.de>\n\t<4071a4ed-f765-4712-95b2-d36bad261f2a@cherry.de>\n\t<174221410402.1463678.10391570271713109059@ping.linuxembedded.co.uk>\n\t<26c25a91-6e99-4f8e-a7a4-beec33d1a8c5@cherry.de>\n\t<174221704065.1463678.12290222536465941618@ping.linuxembedded.co.uk>\n\t<89611012-5f0a-4338-a0ef-831022b718c0@cherry.de>","Content-Language":"en-US","In-Reply-To":"<89611012-5f0a-4338-a0ef-831022b718c0@cherry.de>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"FR4P281CA0035.DEUP281.PROD.OUTLOOK.COM\n\t(2603:10a6:d10:c7::19) To AS8PR04MB8897.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:42c::20)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS8PR04MB8897:EE_|PA4PR04MB9461:EE_","X-MS-Office365-Filtering-Correlation-Id":"c114bcfb-ed7b-431b-93ec-08dd817f19fa","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n\tARA:13230040|366016|10070799003|1800799024|376014|7053199007; ","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?2DZYO6DzTQ0fUJYYSsfKGJ0OtQJR?=\n\t=?utf-8?q?Xn8H9xI3w3pib95SSi3g1XJid4j4LUPVtieOPJiBpwYtrQCrQ8R5GkAx?=\n\t=?utf-8?q?96wbJTUl2PPfHh/DysOYD1iOSQvyu9SpswP/Tc9xFJfuTCMcmuZSC/Zb?=\n\t=?utf-8?q?WgUmautBjq0g+KcmEJtHDZmhPbbbup9IU6Vodm4DJ+2f70oLOalJr6RM?=\n\t=?utf-8?q?iU+bQabuyQzoFlZ9fwO0dha2YF3+cvqOb3qlFjJrjru2zPPB+ZBEzAWc?=\n\t=?utf-8?q?yA7VHFbTBzXvwG0OHQZ4zcdGBF8A2H0LvqyG2pvaPYvFMlm1xVJK53rL?=\n\t=?utf-8?q?njABZ2TYNljSX9prsPjXbdFPnSTJpLt3YoTel707IBrHWgIUA3o+B69F?=\n\t=?utf-8?q?qNosWuR5FyXZkwSlIx5PM3I84sPlYdVEQLPkVAv5oPhiXn/OZNj0KnkW?=\n\t=?utf-8?q?V72QTEh6BRE2/iUoPP8eTiVik4omqUwFdf9YHBbh9Ix2lDB82B2W18Vf?=\n\t=?utf-8?q?hwzVhYzP45c3oZKPVPhmGNKU6QzYFPTbA9MZjw8ISwRvsPTdQvSIsW/C?=\n\t=?utf-8?q?IgRml0MDNRNYiUEe0Jq/PnfzuTHXH4qQQKGUmLHY35NTAT6+tnRRbNL2?=\n\t=?utf-8?q?SZx222DQY55Q0dTN2U4R6fp16NSJfKIxbp+fNbG9FZpiSRwLWjUDy9k+?=\n\t=?utf-8?q?o0OEdeu82giJ0Gj8zeIsN/7zSukuRlkCRhHXM09UTYFINjsNvIy4GthD?=\n\t=?utf-8?q?ohFx8e97G6LZhtRwGQavQkTMBe3yHtFKHOm/eA+JjcpAzgkciUql4niJ?=\n\t=?utf-8?q?S5iUrFDQnUYSQ0HYJhYcuJXukV0l3CFiMWJ7nA6c5oLJrunjGaSZtzf2?=\n\t=?utf-8?q?SElVI2BMYvB7x7yZBMipDCfbJM89wg2GMfbBkWZ6IqiMepfFVaDElH6X?=\n\t=?utf-8?q?66xwpEiejfV3Pw7aYdvdLR0hkVHwhmA91RYsU9QYoErvnX25XK5bWk7V?=\n\t=?utf-8?q?f7Q9nPdLZJztGUCKlns2/tQAoKoF/pJFS2F9gqu/muXqevyXNQG2sXum?=\n\t=?utf-8?q?woiUH0x+q+mXZTAzzVsf5ezRhBkomea6wb9+pVUGB7G+myKhINdzCv8Z?=\n\t=?utf-8?q?S79E0T7DO0tbfEAx3A3FHJxJOueC7wPc+8TLfxnKRcu6nSBGoL8yB5jI?=\n\t=?utf-8?q?CRmxIS68V3f6kp+Rv2nKowfaD/aZsOFx31+K9Njiqc7kABUGxT6griJG?=\n\t=?utf-8?q?SoCHDJuA7Pne7zpxgxrdy4bxGKa+YRMWeblfwqN/FP1oSSQ7Of8vyamL?=\n\t=?utf-8?q?+myivnPmqz5wzyyFlQ8BIjJPLHS3Qe5dJCMScNtB5G3O3Y8+eRTuwSyX?=\n\t=?utf-8?q?EUA1z+CPCsyvEcpxoJ0uIAOToBykPWxgZcAJ/6StaSF06jMuwwYS6+QU?=\n\t=?utf-8?q?+dLYpX9R6me9UkinQdEjXRBu+4wmO60nvHQ0Y6xNIifjOQnLdXb97hhQ?=\n\t=?utf-8?q?5lRBxdPCcFgvXZU=3D?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:AS8PR04MB8897.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(366016)(10070799003)(1800799024)(376014)(7053199007);\n\tDIR:OUT; SFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?P3aq304yqVIGlyE9nRiL4JnOy?=\n\t=?utf-8?q?uzo6yXfSBY4u1sOuiX0qJA1xOBzm61C+4JuqA2rBUtfbnrkOWOY8l7nA?=\n\t=?utf-8?q?Ln18aUIgrVfedHgw4hshnZZ+vkYjveeh/4y5Oxv0FrMwkCmj+/tsR+Er?=\n\t=?utf-8?q?jzBwmt0fp6A6f4F8orYqYW1qnYYurnSKedmU3f9sj1k0tASfZ0EPvRhu?=\n\t=?utf-8?q?wHdhmgCDd09hZVAaDP/elvJAWULpjPXD8KA3X1IpBAdIXJBlb3QhRHag?=\n\t=?utf-8?q?6JyMAyR/ECdW89SmlJnjfWdxus1qjdSYl16PZxceom323drkWtW4bj+j?=\n\t=?utf-8?q?zBreqwOIyFYe2BUDR6NqETVOjKTwr4Nv/6erIk3gVREWfegZyDWH4VWS?=\n\t=?utf-8?q?1ujoKmmyrq9Ruo6HDna7MKfmsr2PQoAG3M9M0nE0MHO4KRIxurlMQeJt?=\n\t=?utf-8?q?u59L2zf/Y7cBZ2NZFItKO9sS+qc9jk/9PbQw987S0WQy92FxxMr2H38q?=\n\t=?utf-8?q?4XCW+8hgcbazVdTw7mJGXODkknu7zDz2cDj7O/EhvweDE0LsMs7cGSiw?=\n\t=?utf-8?q?nkLEEufu4zIkUMSo8YxI8I/FFGZSITGRjqBsMTxrE3rdEwxPDEZEeYJB?=\n\t=?utf-8?q?66hNCnr4oH155mYvfy9BZh50ZAc9Rx1nDByT7EZH+5Olz9tH+OIF6zif?=\n\t=?utf-8?q?YWi3NanlYITR34QCQ3uObacvOWp1hl2ZEhcaFvDhYVP+n3NJYgx8OQVf?=\n\t=?utf-8?q?3f/rEbLGBGQwrMRljfq97axUizdOio4Sb4xpb8UuU4qeCZm3NCsU+on8?=\n\t=?utf-8?q?oNQ+fnIPkN9Ew5DJCPr2K9xO9yEXXmst4hys9bQ03Jwz+aFsNLgl4IH0?=\n\t=?utf-8?q?dneDuSmRIwf5+0i4pANdlxZI8Jt9wNJZfChK7O+4JTYkWMtzHQF1H/6A?=\n\t=?utf-8?q?RzH7avPwfYpVNBVa5dIR+lGGEg5HR3sKWReNWYAlQrfHnTjDbCxEasF+?=\n\t=?utf-8?q?Ud2ROwf9SOHtLJ7n/V2Oq0Q6qPtK431y6IhwcFIS42mEexg4oxAZn63B?=\n\t=?utf-8?q?Ir0UYhd4gV36XoN4G0DaFYBknO/j84ALz3voejclxSYSScL6n3bYLaaM?=\n\t=?utf-8?q?dETngKNgDE77wM+zf4YFG3JR0rhgenDyVYcJGfkhhSQq6cp38NN55lUE?=\n\t=?utf-8?q?LuaCB8ZdEvF5H9jOrvmZd9Fu1wOmIqe9fn1MJG4/xX5VAQezSbE577hr?=\n\t=?utf-8?q?bmG1GmuOqlXuuIWUJNhCU3Jpf8csgwYtinLj6KBvbFeB0Y5LJiyqgkAO?=\n\t=?utf-8?q?rSqH8H2qL5ugBEzJzDzNY4gfWLy5y3ysBp6KDdI/afYcsAoV40IpsG4r?=\n\t=?utf-8?q?ouHN4/+c8zvz+kREdTOuD/XT/EAkgbZh0cZpulINVjB7tvabT7DmVUq6?=\n\t=?utf-8?q?y2oC5Fh5z2yAVw+FYUtz7sS0iS+KdlI6a2KnAwTod5+D5OVwqtduUr2e?=\n\t=?utf-8?q?horXKaGA6yjRdZ6bqDIhmkvEcFSug1rKnYpFBPn/isIKCHgStVUR2w0n?=\n\t=?utf-8?q?d0KrIVuex9H8bl8tw0KFoSnIdbEFS5oyZrC0x/sfuYmVnrynxiumb/k0?=\n\t=?utf-8?q?+4fvqHY32yD1o3shOg+Cpm81RGhYW3CkFTTBc+EGXwP3++B63HK9mqhR?=\n\t=?utf-8?q?gpJSRjY+R8qae1ytMjJ0scnXyqrqPDLtUhnolhvA/TcHwDUlexM7Ksoo?=\n\t=?utf-8?q?CVTDDiShKy1qQYt/D3lLbw0DCeLdS87y2cGysvoFtvvkQ9ykK0Nog9+0?=\n\t=?utf-8?q?w8tGjSe5hNYR8BFrGGDYTWw/Tk4XokfXcLajg=3D=3D?=","X-OriginatorOrg":"cherry.de","X-MS-Exchange-CrossTenant-Network-Message-Id":"c114bcfb-ed7b-431b-93ec-08dd817f19fa","X-MS-Exchange-CrossTenant-AuthSource":"AS8PR04MB8897.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"22 Apr 2025 09:21:45.4834\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"5e0e1b52-21b5-4e7b-83bb-514ec460677e","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"SwA5TAYzAz3zU2887Txrx4uSydLgWd6072PzYWhg1bkWus8l1W5gGRDznb6mK03pu0eUOKtTi5mFyRQmL51H6dW7I5Jwb5z9UbG5VSpkzyA=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PA4PR04MB9461","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34125,"web_url":"https://patchwork.libcamera.org/comment/34125/","msgid":"<20250502211440.GC24278@pendragon.ideasonboard.com>","date":"2025-05-02T21:14:40","subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Apr 22, 2025 at 11:21:44AM +0200, Quentin Schulz wrote:\n> On 3/17/25 3:51 PM, Quentin Schulz wrote:\n> > On 3/17/25 2:10 PM, Kieran Bingham wrote:\n> >> Quoting Quentin Schulz (2025-03-17 12:30:48)\n> >>> On 3/17/25 1:21 PM, Kieran Bingham wrote:\n> >>>> Quoting Quentin Schulz (2025-03-11 13:06:25)\n> >>>>> +Cc Ricardo, the original commit author, in case I'm missing something\n> >>>>>\n> >>>>> On 3/11/25 2:01 PM, Quentin Schulz wrote:\n> >>>>>> [foss+libcamera@0leil.net appears similar to someone who \n> >>>>>> previously sent you email, but may not be that person. Learn why \n> >>>>>> this could be a risk at https://aka.ms/ \n> >>>>>> LearnAboutSenderIdentification ]\n> >>>>>>\n> >>>>>> From: Quentin Schulz \n> >>>>>>\n> >>>>>> The introducing commit (dff416a84b78 (\"README: Add missing package \n> >>>>>> for\n> >>>>>> Qt5 tools\"); for Qt 5 originally) stated that without the \n> >>>>>> dependency we\n> >>>>>> would get the following messages:\n> >>>>>>\n> >>>>>>        Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n> >>>>>>        Program lrelease-qt5 found: NO\n> >>>>>>        Program lrelease found: NO found  but need: '== 5.14.2'\n> >>>>>>\n> >>>>>> That is still the case but this actually is neither breaking the \n> >>>>>> build\n> >>>>>> nor is it doing anything to the outcome of the build as qcam is \n> >>>>>> bit to\n> >>>>>> bit identical with and without that package.\n> >>>>>>\n> >>>>>> Therefore, let's not mislead users to install an unnecessary package.\n> >>>>>>\n> >>>>>> Signed-off-by: Quentin Schulz \n> >>>>>> ---\n> >>>>>> This was tested within a debian:bookworm container with and \n> >>>>>> without the\n> >>>>>> package, checked out both at master and introducing commit. qcam \n> >>>>>> is bit\n> >>>>>> to bit identical in both cases.\n> >>>>\n> >>>> That's the evidence I would look for in this, so\n> >>>>\n> >>>> Reviewed-by: Kieran Bingham \n> >>>>\n> >>>> Is this still the case on Qt6? I assume/infer that the reason you want\n> >>>> to remove this dependency is because something has changed in qt6 ?\n> >>>>\n> >>>> If so - adding that to the commit message would help clarify things, as\n> >>>> you are removing a qt6 package, but only discussing qt5 in the commit.\n> >>>>\n> >>>\n> >>> This was tested for both qt5 and qt6, results are both bit to bit \n> >>> identical.\n> >>>\n> >>> I stated that in the Buildroot patch:\n> >>> https://eur02.safelinks.protection.outlook.com/? \n> >>> url=https%3A%2F%2Flore.kernel.org%2Fbuildroot%2F20250311-libcamera- \n> >>> qt6- \n> >>> v1-1-4897aadc6fe3%40cherry.de%2F&data=05%7C02%7Cquentin.schulz%40cherry.de%7C2f082d52936f4a81ed5808dd65552053%7C5e0e1b5221b54e7b83bb514ec460677e%7C0%7C0%7C638778138464717991%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=b3bBcP2OYapWwhMwAoAMgIKTLcg8rurpdOnKqW6XzwQ%3D&reserved=0\n> >>> but forgot to add it here before submitting the patch.\n> >>>\n> >>> I can reword the commit log to something like:\n> >>>\n> >>> \"\"\"\n> >>> The introducing commit (dff416a84b78 (\"README: Add missing package for\n> >>> Qt5 tools\"); for Qt 5 originally) stated that without the dependency we\n> >>> would get the following messages:\n> >>>\n> >>>         Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n> >>>         Program lrelease-qt5 found: NO\n> >>>         Program lrelease found: NO found  but need: '== 5.14.2'\n> >>>\n> >>> That was the case for qt5 and is still true for qt6 but this actually\n> >>> is neither breaking the build nor is it doing anything to the outcome\n> >>> of the build (for both qt5 and qt6) as qcam is bit to bit identical\n> >>> with and without that package.\n> >>>\n> >>> Therefore, let's not mislead users to install an unnecessary package.\n> >>> \"\"\"\n> >>>\n> >>> Would that work for you? Do you want me to send a v2 for that?\n> >>\n> >> No need for a v2 at the moment ... we can easily fix up the commit, it's\n> >> just the justification I want to get right. Stating that this is still\n> >> the case for Qt6 fixes my concern ;-)\n> >>\n> >> Especially as this will now cause users to have a warning reintroduced\n> >> in their setup logs! Why is that now acceptable when it wasn't before?\n> >>\n> > \n> > \"\"\"\n> > meson setup build\n> > The Meson build system\n> > Version: 1.0.1\n> > Source dir: /home/qschulz/work/upstream/libcamera\n> > Build dir: /home/qschulz/work/upstream/libcamera/build\n> > Build type: native build\n> > Project name: libcamera\n> > Project version: 0.3.0\n> > C compiler for the host machine: cc (gcc 12.2.0 \"cc (Debian 12.2.0-14) \n> > 12.2.0\")\n> > C linker for the host machine: cc ld.bfd 2.40\n> > C++ compiler for the host machine: c++ (gcc 12.2.0 \"c++ (Debian \n> > 12.2.0-14) 12.2.0\")\n> > C++ linker for the host machine: c++ ld.bfd 2.40\n> > Host machine cpu family: x86_64\n> > Host machine cpu: x86_64\n> > Header \"fcntl.h\" has symbol \"F_ADD_SEALS\" : YES\n> > Header \"unistd.h\" has symbol \"issetugid\" : NO\n> > Header \"locale.h\" has symbol \"locale_t\" : YES\n> > Header \"sys/mman.h\" has symbol \"memfd_create\" : YES\n> > Header \"stdlib.h\" has symbol \"secure_getenv\" : YES\n> > Compiler for C supports arguments -Wno-c99-designator: NO\n> > Found pkg-config: /usr/bin/pkg-config (1.8.1)\n> > Did not find CMake 'cmake'\n> > Found CMake: NO\n> > Run-time dependency lttng-ust found: NO (tried pkgconfig and cmake)\n> > Program ./parser.py found: YES (/home/qschulz/work/upstream/libcamera/ \n> > utils/ipc/./parser.py)\n> > Program ./generate.py found: YES (/home/qschulz/work/upstream/libcamera/ \n> > utils/ipc/./generate.py)\n> > Program ./extract-docs.py found: YES (/home/qschulz/work/upstream/ \n> > libcamera/utils/ipc/./extract-docs.py)\n> > Program ./gen-tp-header.py found: YES (/home/qschulz/work/upstream/ \n> > libcamera/utils/tracepoints/./gen-tp-header.py)\n> > Configuring version.h using configuration\n> > Program openssl found: YES (/usr/bin/openssl)\n> > Library atomic found: YES\n> > Run-time dependency threads found: YES\n> > Run-time dependency libdw found: NO (tried pkgconfig and cmake)\n> > Run-time dependency libunwind found: NO (tried pkgconfig and cmake)\n> > Header \"execinfo.h\" has symbol \"backtrace\" : YES\n> > Checking for function \"dlopen\" : YES\n> > Run-time dependency libudev found: NO (tried pkgconfig and cmake)\n> > Run-time dependency yaml-0.1 found: YES 0.2.5\n> > Run-time dependency gnutls found: YES 3.7.9\n> > Dependency libexif skipped: feature android disabled\n> > Dependency libjpeg skipped: feature android disabled\n> > Run-time dependency libevent_pthreads found: NO (tried pkgconfig and cmake)\n> > Run-time dependency libevent_pthreads found: NO (tried pkgconfig and cmake)\n> > Run-time dependency libtiff-4 found: YES 4.5.0\n> > Run-time dependency GTest found: NO (tried pkgconfig and system)\n> > Looking for a fallback subproject for the dependency gtest\n> > \n> > Executing subproject gtest\n> > \n> > gtest| Project name: gtest\n> > gtest| Project version: 1.11.0\n> > gtest| C++ compiler for the host machine: c++ (gcc 12.2.0 \"c++ (Debian \n> > 12.2.0-14) 12.2.0\")\n> > gtest| C++ linker for the host machine: c++ ld.bfd 2.40\n> > gtest| Dependency threads found: YES unknown (cached)\n> > gtest| Dependency threads found: YES unknown (cached)\n> > gtest| Dependency threads found: YES unknown (cached)\n> > gtest| Dependency threads found: YES unknown (cached)\n> > gtest| Build targets in project: 35\n> > gtest| Subproject gtest finished.\n> > \n> > Dependency gtest from subproject subprojects/googletest-release-1.11.0 \n> > found: YES 1.11.0\n> > Run-time dependency qt5 (modules: Core, Gui, Widgets) found: YES 5.15.8 \n> > (pkg-config)\n> > Header \"QOpenGLWidget\" has symbol \"QOpenGLWidget\" with dependencies \n> > Qt5Core, Qt5Core, Qt5Gui, Qt5Widgets: YES\n> > Detecting Qt5 tools\n> > Run-time dependency qt5 (modules: Core) found: YES 5.15.8 (pkg-config)\n> > Program /usr/lib/x86_64-linux-gnu/qt5/bin/moc found: YES 5.15.8 (/usr/ \n> > lib/x86_64-linux-gnu/qt5/bin/moc)\n> > Program /usr/lib/x86_64-linux-gnu/qt5/bin/uic found: YES 5.15.8 (/usr/ \n> > lib/x86_64-linux-gnu/qt5/bin/uic)\n> > Program /usr/lib/x86_64-linux-gnu/qt5/bin/rcc found: YES 5.15.8 (/usr/ \n> > lib/x86_64-linux-gnu/qt5/bin/rcc)\n> > Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n> > Program lrelease5 found: NO\n> > Program lrelease-qt5 found: NO\n> > Program lrelease found: NO found  but need: '== 5.15.8' (/usr/bin/lrelease)\n> > Run-time dependency glib-2.0 found: NO (tried pkgconfig and cmake)\n> > Run-time dependency gstreamer-video-1.0 found: NO (tried pkgconfig and \n> > cmake)\n> > Run-time dependency gstreamer-allocators-1.0 found: NO (tried pkgconfig \n> > and cmake)\n> > Run-time dependency python3 found: NO (tried pkgconfig and sysconfig)\n> > Program doxygen found: NO\n> > Program dot found: NO\n> > Program sphinx-build-3 found: NO\n> > Program sphinx-build found: NO\n> > Configuring config.h using configuration\n> > Program python3 (jinja2, ply, jinja2, yaml) found: YES (/usr/bin/ \n> > python3) modules: jinja2, ply, jinja2, yaml\n> > Build targets in project: 39\n> > \n> > libcamera 0.3.0\n> > \n> >   Versions\n> >     Sources                  : 0.3.0\n> > \n> >   Paths\n> >     LIBCAMERA_DATA_DIR       : \"/usr/local/share/libcamera\"\n> >     LIBCAMERA_SYSCONF_DIR    : \"/usr/local/etc/libcamera\"\n> >     IPA_PROXY_DIR            : \"/usr/local/libexec/libcamera\"\n> >     IPA_CONFIG_DIR           : \"/usr/local/etc/libcamera/ipa:/usr/ \n> > local/share/libcamera/ipa\"\n> >     IPA_MODULE_DIR           : \"/usr/local/lib/x86_64-linux-gnu/libcamera\"\n> > \n> >   Configuration\n> >     SoftISP support          : False\n> >     IPA modules signed with  : gnutls\n> >     Enabled pipelines        : ipu3\n> >                                uvcvideo\n> >     Enabled IPA modules      : ipu3\n> >     Controls files           : control_ids_draft.yaml\n> >                                control_ids_core.yaml\n> >     Properties files         : property_ids_draft.yaml\n> >                                property_ids_core.yaml\n> >     Hotplug support          : NO\n> >     Tracing support          : NO\n> >     Android support          : NO\n> >     GStreamer support        : NO\n> >     Python bindings          : NO\n> >     V4L2 emulation support   : NO\n> >     cam application          : NO\n> >     qcam application         : YES\n> >     lc-compliance application: NO\n> >     Unit tests               : NO\n> > \n> >   Subprojects\n> >     gtest                    : YES\n> > \"\"\"\n> > \n> > There are plenty other \"NO\" printed during the setup detection. Does it \n> > really matter if one gets a few other \"NO\" especially since they don't \n> > impact anything?\n> > \n> >> Is there anything we can do to stop meson from looking for lrelease-qt5?\n> > \n> > Doesn't seem like it no.\n> > \n> > I'm not familiar with meson nor qt build systems but it seems like \n> > QtBaseModule in mesonbuild/modules/qt.py has a hardcoded list of tools \n> > to check. In Debian Bookworm, meson 1.0.1 is used. QtBaseModule has \n> > self.tools set to moc, uic, rcc and lrelease. The compilers_detect \n> > method checks for all binaries listed in that list (c.f. \n> > find_program()). That method is called when _detect_tools() method is \n> > called. That method seems to be called whenever _compile_moc_impl(), \n> > _compile_resources_impl, or _compile_ui_impl() is called. Those are \n> > called when compile_resources(), compile_ui(), compile_moc() or \n> > preprocess() is called. Which is what we do in src/apps/qcam/ \n> > meson.build, c.f.\n> > \n> > \"\"\"\n> > resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> >                            qresources : qcam_resources,\n> >                            dependencies : qt5_dep)\n> > \n> > qcam  = executable('qcam', qcam_sources, resources,\n> > \"\"\"\n> > \n> > Note that it seems meson v1.7.0 will also check for qmlcachegen and \n> > qmltyperegistrar on the host, c.f. commit \n> > 4508622a34932d23e336392a8a3c71ed79af4e3f.\n> > \n> > has_tools now allows to pass a list of tools to check, c.f. commit \n> > 6797f9bc1502609783a8fc465e2960819ab4f38f but that doesn't seem to change \n> > the list of tools that are always checked, just a way to provide a way \n> > to conditionally do things in meson, based on the return value of \n> > has_tools for specific tools, my understanding is that all hardcoded \n> > tools are still checked once.\n> > \n> >> Who's looking for that in the build?\n> >>\n> > \n> > meson, based on the preprocess() call in the qt module. We need that \n> > apparently for moc (header files with Q_OBJECT in there? c.f. https:// \n> > doc.qt.io/qt-6/moc.html) and rcc (handling .qrc files, c.f. https:// \n> > doc.qt.io/qt-6/rcc.html).\n> > \n> > We may want to use qt.has_tools() with moc and rcc to manually check \n> > those before we call preprocess() and fail otherwise? So people are \n> > aware which qt tools are actually required? But that still wouldn't \n> > remove the \"NO\" for lrelease, and other unneeded binaries. Note that moc \n> > and rcc (and uic, another Qt tool that is required) are part of qtbase5- \n> > dev-tools package on Debian (not to be confused with qttools5-dev-tools \n> > which is bringing in lrelease (and lupdate, lconvert, ...)).\n> \n> Anything I can help with to get this merged? Or do we abandon it? Just \n> to know what to do with this patch that I am occasionally still \n> monitoring :)\n\nSorry for the delay. The patch has now been merged.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77751C327D\n\tfor ;\n\tFri, 2 May 2025 21:14:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8DE9B68B2C;\n\tFri, 2 May 2025 23:14:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F27268ACC\n\tfor ;\n\tFri, 2 May 2025 23:14:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18DF622F;\n\tFri, 2 May 2025 23:14:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Is5+LwQI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746220481;\n\tbh=LFrc7lCk345GDJ+AKDBK0SEX7m/Rjnr1HnEFincIKl8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Is5+LwQIbJWv9UYsa1lBXrxph97b9SO33aLOh8vN1mr93CGmraJzQsC+T0oM/eC2S\n\tHTz+pwuhdN3LAxxUshkyeypYmCJ71K4rRFc/euh8UrkHeutS8Z4ARWYpDbOo13/gN+\n\tLxjUKkI/hLeCYgNqiQQP0xGef+exqrB4LZg/DR7A=","Date":"Sat, 3 May 2025 00:14:40 +0300","From":"Laurent Pinchart ","To":"Quentin Schulz ","Cc":"Kieran Bingham ,\n\tQuentin Schulz ,\n\tlibcamera-devel@lists.libcamera.org,\n\tRicardo Ribalda ","Subject":"Re: [PATCH] README.rst: remove unnecessary dependency for qcam","Message-ID":"<20250502211440.GC24278@pendragon.ideasonboard.com>","References":"<20250311-qttools-unneeded-v1-1-834c30be7e7a@cherry.de>\n\t<4071a4ed-f765-4712-95b2-d36bad261f2a@cherry.de>\n\t<174221410402.1463678.10391570271713109059@ping.linuxembedded.co.uk>\n\t<26c25a91-6e99-4f8e-a7a4-beec33d1a8c5@cherry.de>\n\t<174221704065.1463678.12290222536465941618@ping.linuxembedded.co.uk>\n\t<89611012-5f0a-4338-a0ef-831022b718c0@cherry.de>\n\t<44c7d9c7-0054-44d8-b79b-ef09270cda3d@cherry.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<44c7d9c7-0054-44d8-b79b-ef09270cda3d@cherry.de>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]