[{"id":3010,"web_url":"https://patchwork.libcamera.org/comment/3010/","msgid":"<20191114074727.GB7353@bigcity.dyn.berto.se>","date":"2019-11-14T07:47:27","subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix compilation with\n\tuClibc and uClibc-ng","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-11-08 21:47:39 +0200, Laurent Pinchart wrote:\n> Neither uClibc nor uClibc-ng support O_TMPFILE. Define it in utils.h if\n> not defined.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/utils.h | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> Is utils.h a good location, or should we create a compat.h (maybe even\n> one that is automatically included) for this purpose ?\n> \n> diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\n> index 3efb11c119c2..a80f7d096bf7 100644\n> --- a/src/libcamera/include/utils.h\n> +++ b/src/libcamera/include/utils.h\n> @@ -16,6 +16,15 @@\n> \n> #define ARRAY_SIZE(a)\t(sizeof(a) / sizeof(a[0]))\n> \n> +#ifndef __DOXYGEN__\n> +\n> +/* uClibc and uClibc-ng don't provide O_TMPFILE */\n> +#ifndef O_TMPFILE\n> +#define O_TMPFILE\t(020000000 | O_DIRECTORY)\n> +#endif\n> +\n> +#endif\n> +\n> namespace libcamera {\n> \n> namespace utils {\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17D8360C33\n\tfor ;\n\tThu, 14 Nov 2019 08:47:30 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id j14so4198709lfb.8\n\tfor ;\n\tWed, 13 Nov 2019 23:47:30 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tp193sm2837968lfa.18.2019.11.13.23.47.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Nov 2019 23:47:28 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=gbLZkxvlKaVeES0HRIPcC2qIScYIk3p7iHjIGAxZVgQ=;\n\tb=DoNY7yKavlHADwID4WNojxmtxe/YMZkQly2QbP8W2JbB57/5ZXzBCS14JzDNbn+h5n\n\tN4rqqqeTiOwl2tajRA+bHf3enSv3uBL2z+wdYUU6UTN8LqQM84BHL6wWfXMzK1+6Q1hD\n\tanGWsYAXYZFeN77BWuVPYm2VmFbCT3KWRBBpKTFyT7sf95dfkA9TQ7iGMRNgZbmrTDTG\n\tntnyU3EbffbtrNb23wV4sK9vNbDMUB7dfLMZqm3Ogilcmhwee6FocE/t+FVhfWOy2TB+\n\thI3QsZR7rE3XagzycXK+9kjwiGrcJ80zoIgfOSyBtMbUZIC4GCcTcDgqJatx25NOiEvZ\n\tM8bQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=gbLZkxvlKaVeES0HRIPcC2qIScYIk3p7iHjIGAxZVgQ=;\n\tb=hZP9Mp+9dRp/zJkl7LaQqIlIPGkb7DHUciAxXf1x+Cb9pWLEc/L8xaXUKsGfZ56/4R\n\tD3/Bqsn1FTaH0I8ovsRhtoOitP8xBx5HraH3F6puW3jK1P67ySDMS9Bcvvq0PZWcmGsP\n\t+V+CPvYIn3bM0RrDyyKAg0Ip3mMaEDKkSH/dQtErS9NSoMLQC0HS9mWzQr/vgLSp92ZW\n\tes+DFMzDahoZrdQx3L6fOCVYpgaNSQMlc34w/DFG0PF1RnyhGF/FE5xQzqn6f1xlYcsQ\n\tCIcedqDzexqd/HOYqa0pcsNGNG6RZ3MH4Ry2FwyivSaD67utr4jB8/Dh57QS/Ev1H5ep\n\t0V9w==","X-Gm-Message-State":"APjAAAUejANSnTnvMzAzE2spg5ZWHMtVoJ+vYGCT+HaATuITeJ2O99iP\n\tnierakS0i0BOJnxSJiN9ihgq8POet9U=","X-Google-Smtp-Source":"APXvYqzpV6doIiUToOu4GpYux7DwnKIm/BtGHG4YZGX9xbrwNAHu0T+Nvu0JVuPu4w0pwLf/vvTS9g==","X-Received":"by 2002:a19:ee1a:: with SMTP id g26mr5789289lfb.0.1573717649122; \n\tWed, 13 Nov 2019 23:47:29 -0800 (PST)","Date":"Thu, 14 Nov 2019 08:47:27 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191114074727.GB7353@bigcity.dyn.berto.se>","References":"<20191108194739.1632-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191108194739.1632-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix compilation with\n\tuClibc and uClibc-ng","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 14 Nov 2019 07:47:30 -0000"}}]