[{"id":33610,"web_url":"https://patchwork.libcamera.org/comment/33610/","msgid":"<4tpoqg7dcxlyrzun64stugangqh5ljxthjzfs3qdgn55mvnqyf@5rsydi5owoav>","date":"2025-03-17T17:58:55","subject":"Re: [PATCH v1] test: thread: Use `pthread_testcancel()`","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"On Mon, Mar 10, 2025 at 06:03:18PM +0100, Barnabás Pőcze wrote:\n> `pthread_testcancel()` is a guaranteed cancellation point,\n> specifically for testing if cancellation has been requested,\n> so use it.\n>\n> Signed-off-by: Barnabás Pőcze \n\nNice\n\nReviewed-by: Jacopo Mondi \n\n> ---\n> test/threads.cpp | 8 +-------\n> 1 file changed, 1 insertion(+), 7 deletions(-)\n>\n> diff --git a/test/threads.cpp b/test/threads.cpp\n> index 8d6ee1510..c00d95a41 100644\n> --- a/test/threads.cpp\n> +++ b/test/threads.cpp\n> @@ -52,14 +52,8 @@ protected:\n> \t{\n> \t\tcancelled_ = true;\n>\n> -\t\t/*\n> -\t\t * Cancel the thread and call a guaranteed cancellation point\n> -\t\t * (nanosleep).\n> -\t\t */\n> \t\tpthread_cancel(pthread_self());\n> -\n> -\t\tstruct timespec req{ 0, 100*000*000 };\n> -\t\tnanosleep(&req, nullptr);\n> +\t\tpthread_testcancel();\n>\n> \t\tcancelled_ = false;\n> \t}\n> --\n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8356CC32FA\n\tfor ;\n\tMon, 17 Mar 2025 17:59:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E82266894C;\n\tMon, 17 Mar 2025 18:58:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3EAF168826\n\tfor ;\n\tMon, 17 Mar 2025 18:58:59 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 888428DB;\n\tMon, 17 Mar 2025 18:57:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PfQASSls\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742234237;\n\tbh=vIUZ+GCGh0Ao9F7wRd9ovYBdxrMiW58bXHsYhtpMjfo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PfQASSlse3SdtIE9SiXA5JKXmKQKkzvm4GbBA7gQyv2uNi+mmafoXPBISazRQz46P\n\tXXjJtmVgxTrNH9XgiJ7pQ7LIOdKre4gUwk3UpdLoUSxLja1vsq1uHlMny4zbAOvUoH\n\tQYwfv4H3HQuXU8Xk2HPLniHf85pTJ38sQgcFcVIQ=","Date":"Mon, 17 Mar 2025 18:58:55 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] test: thread: Use `pthread_testcancel()`","Message-ID":"<4tpoqg7dcxlyrzun64stugangqh5ljxthjzfs3qdgn55mvnqyf@5rsydi5owoav>","References":"<20250310170318.185249-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250310170318.185249-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33624,"web_url":"https://patchwork.libcamera.org/comment/33624/","msgid":"<174224854261.1463678.16505687082884640755@ping.linuxembedded.co.uk>","date":"2025-03-17T21:55:42","subject":"Re: [PATCH v1] test: thread: Use `pthread_testcancel()`","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2025-03-17 17:58:55)\n> \n> On Mon, Mar 10, 2025 at 06:03:18PM +0100, Barnabás Pőcze wrote:\n> > `pthread_testcancel()` is a guaranteed cancellation point,\n> > specifically for testing if cancellation has been requested,\n> > so use it.\n> >\n> > Signed-off-by: Barnabás Pőcze \n> \n> Nice\n> \n> Reviewed-by: Jacopo Mondi \n> \n> > ---\n> > test/threads.cpp | 8 +-------\n> > 1 file changed, 1 insertion(+), 7 deletions(-)\n> >\n> > diff --git a/test/threads.cpp b/test/threads.cpp\n> > index 8d6ee1510..c00d95a41 100644\n> > --- a/test/threads.cpp\n> > +++ b/test/threads.cpp\n> > @@ -52,14 +52,8 @@ protected:\n> > {\n> > cancelled_ = true;\n> >\n> > - /*\n> > - * Cancel the thread and call a guaranteed cancellation point\n> > - * (nanosleep).\n> > - */\n> > pthread_cancel(pthread_self());\n> > -\n> > - struct timespec req{ 0, 100*000*000 };\n> > - nanosleep(&req, nullptr);\n\nI guess this delay was uncessary ...\n\npthread_testcancel() sounds like the right thing from the man page\nthough!\n\nReviewed-by: Kieran Bingham \n\n> > + pthread_testcancel();\n> >\n> > cancelled_ = false;\n> > }\n> > --\n> > 2.48.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22660C32FA\n\tfor ;\n\tMon, 17 Mar 2025 21:55:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9272268947;\n\tMon, 17 Mar 2025 22:55:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2A6C68826\n\tfor ;\n\tMon, 17 Mar 2025 22:55:45 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ABFF6965;\n\tMon, 17 Mar 2025 22:54:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tXtOJ0y7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742248443;\n\tbh=lOHa9+9DFcU10XW2AJOQg18+omxjn5IS4iJvtFMmcfc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tXtOJ0y7Vl4kYtxXzImNkIhcoJ/9ZH/c/OjMkplke2kE3E1aC78YLmmlyI3DT3W0z\n\t9CNQmuDboYjEWFxOzHsHspiXiXNX+qQTdgCWh2FZ6rX47sRX5nbScQmbMZxZgLRqWv\n\tKP6soxzfz83bt/oIxuf02OPUvMRq0xbsBfItiQLY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<4tpoqg7dcxlyrzun64stugangqh5ljxthjzfs3qdgn55mvnqyf@5rsydi5owoav>","References":"<20250310170318.185249-1-barnabas.pocze@ideasonboard.com>\n\t<4tpoqg7dcxlyrzun64stugangqh5ljxthjzfs3qdgn55mvnqyf@5rsydi5owoav>","Subject":"Re: [PATCH v1] test: thread: Use `pthread_testcancel()`","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tJacopo Mondi ","Date":"Mon, 17 Mar 2025 21:55:42 +0000","Message-ID":"<174224854261.1463678.16505687082884640755@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]