[{"id":33685,"web_url":"https://patchwork.libcamera.org/comment/33685/","msgid":"<174257284452.783128.1005770466736152551@ping.linuxembedded.co.uk>","date":"2025-03-21T16:00:44","subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Expose `Gamma` control","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-03-10 17:03:13)\n> Commit 294ead848c3fa2 (\"libcamera: Add gamma control id\")\n> introduced the \"Gamma\" control, so expose it for UVC\n> cameras as well using the `V4L2_CID_GAMMA` control.\n> \n> Signed-off-by: Barnabás Pőcze \n\nI've just tested this on a UVC camera with camshark, and the controls\nseem to work as I expect:\n\n\nTested-by: Kieran Bingham \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 18 ++++++++++++++++++\n> 1 file changed, 18 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 7470b5627..8a845233d 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -304,6 +304,8 @@ int PipelineHandlerUVC::processControl(ControlList *controls, unsigned int id,\n> cid = V4L2_CID_EXPOSURE_ABSOLUTE;\n> else if (id == controls::AnalogueGain)\n> cid = V4L2_CID_GAIN;\n> + else if (id == controls::Gamma)\n> + cid = V4L2_CID_GAMMA;\n> else\n> return -EINVAL;\n> \n> @@ -358,6 +360,10 @@ int PipelineHandlerUVC::processControl(ControlList *controls, unsigned int id,\n> break;\n> }\n> \n> + case V4L2_CID_GAMMA:\n> + controls->set(cid, static_cast(std::lround(value.get() * 100)));\n> + break;\n> +\n> default: {\n> int32_t ivalue = value.get();\n> controls->set(cid, ivalue);\n> @@ -655,6 +661,9 @@ void UVCCameraData::addControl(uint32_t cid, const ControlInfo &v4l2Info,\n> case V4L2_CID_GAIN:\n> id = &controls::AnalogueGain;\n> break;\n> + case V4L2_CID_GAMMA:\n> + id = &controls::Gamma;\n> + break;\n> default:\n> return;\n> }\n> @@ -782,6 +791,15 @@ void UVCCameraData::addControl(uint32_t cid, const ControlInfo &v4l2Info,\n> break;\n> }\n> \n> + case V4L2_CID_GAMMA:\n> + /* UVC gamma is in units of 1/100 gamma. */\n> + info = ControlInfo{\n> + { min / 100.0f },\n> + { max / 100.0f },\n> + { def / 100.0f }\n> + };\n> + break;\n> +\n> default:\n> info = v4l2Info;\n> break;\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 365E4C3272\n\tfor ;\n\tFri, 21 Mar 2025 16:00:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF06768951;\n\tFri, 21 Mar 2025 17:00:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1501968947\n\tfor ;\n\tFri, 21 Mar 2025 17:00:47 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7021A9FF;\n\tFri, 21 Mar 2025 16:59:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"INqlQJKG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742572742;\n\tbh=TT2WxQPhI5KYvOlByPgjUOr0NPcBnsqSSxh9EOoMmEQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=INqlQJKGBwhsPG2sW102ToWdwEPcQM/U7WJbZr2L5/IAnO5hW2I4wQEXvZhwRDioc\n\t8A32PzDWNUgbUL6OZoX/1t/c4whwM8+Awt+eTdvw+G6qCuQ+JKxpZ9QkjxkRzEVKLk\n\t/tPc4IwCmbi2cT4bFS0NahZKbCy9J2GmufMMEuSY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250310170313.185227-1-barnabas.pocze@ideasonboard.com>","References":"<20250310170313.185227-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Expose `Gamma` control","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 21 Mar 2025 16:00:44 +0000","Message-ID":"<174257284452.783128.1005770466736152551@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]