[{"id":33609,"web_url":"https://patchwork.libcamera.org/comment/33609/","msgid":"","date":"2025-03-17T17:57:05","subject":"Re: [PATCH v1] ipa: simple: lut: Fix include path","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Mon, Mar 10, 2025 at 06:03:03PM +0100, Barnabás Pőcze wrote:\n> Use the proper path to include `libcamera/control_ids.h`.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/simple/algorithms/lut.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\n> index 0ba2391f8..18f3a550b 100644\n> --- a/src/ipa/simple/algorithms/lut.cpp\n> +++ b/src/ipa/simple/algorithms/lut.cpp\n> @@ -14,9 +14,9 @@\n>\n> #include \n>\n> -#include \"simple/ipa_context.h\"\n> +#include \n>\n> -#include \"control_ids.h\"\n> +#include \"simple/ipa_context.h\"\n>\n> namespace libcamera {\n>\n> --\n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34032C32F5\n\tfor ;\n\tMon, 17 Mar 2025 17:57:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DFCC968950;\n\tMon, 17 Mar 2025 18:57:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B18B68928\n\tfor ;\n\tMon, 17 Mar 2025 18:57:08 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E02608DB;\n\tMon, 17 Mar 2025 18:55:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ihgwwmtV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742234127;\n\tbh=GmCwFieb98hvhCF99nfrOtsPuRynTDi0Tjmj5eAcRk0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ihgwwmtVp0bh9ZYU10t+wfqt+2YpEQqyxn7OoCWqWcQfVaOE7gosViVKtWkglVHux\n\tQWqfxdV9WmZ5fy/a5OGhA9vjdeiYs8STTf93wN7fFXvTs6nuUtB11HPO43AIh38hDl\n\tPrDCUb5hLrBcoTbjZWvKLDIDDlqobdXM3CVDRQWU=","Date":"Mon, 17 Mar 2025 18:57:05 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] ipa: simple: lut: Fix include path","Message-ID":"","References":"<20250310170303.185199-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250310170303.185199-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33611,"web_url":"https://patchwork.libcamera.org/comment/33611/","msgid":"<174223433957.3394313.1372722438861623675@ping.linuxembedded.co.uk>","date":"2025-03-17T17:58:59","subject":"Re: [PATCH v1] ipa: simple: lut: Fix include path","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-03-10 17:03:03)\n> Use the proper path to include `libcamera/control_ids.h`.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/ipa/simple/algorithms/lut.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\n> index 0ba2391f8..18f3a550b 100644\n> --- a/src/ipa/simple/algorithms/lut.cpp\n> +++ b/src/ipa/simple/algorithms/lut.cpp\n> @@ -14,9 +14,9 @@\n> \n> #include \n> \n> -#include \"simple/ipa_context.h\"\n> +#include \n> \n> -#include \"control_ids.h\"\n\nEeek - does this already find control_ids.h? That makes me think we\nhave incorrectly added libcamera/ to the default include path somewhere\n... I wouldn't expect it to be allowed to compile like that...\n\nBut that means I believe the patch is correct by itself !\n\nReviewed-by: Kieran Bingham \n\n> +#include \"simple/ipa_context.h\"\n> \n> namespace libcamera {\n> \n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CDEC0C32FA\n\tfor ;\n\tMon, 17 Mar 2025 17:59:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88E2068942;\n\tMon, 17 Mar 2025 18:59:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 153B568826\n\tfor ;\n\tMon, 17 Mar 2025 18:59:02 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A0E2965;\n\tMon, 17 Mar 2025 18:57:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EVi6R4Ra\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742234240;\n\tbh=sL6M6ZaIs+61Eu/PtKH2XGBoTU2KoSj2UUeDpeaquME=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=EVi6R4RaNmcMBRRmAIdQGWKgbmP5QJubzu3HjtXtle0ogtKc4YoSQbhaoSFrFtGJ0\n\tIoEapaujUFSdKOWSRDD917UnvovxtQX1VvXyoxAEOLGyJC+TnkcxsruFfzGtqBrqto\n\t6w5l17sHSUKMz6wMizOLYB4s3fSgKeq6GPltKrts=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250310170303.185199-1-barnabas.pocze@ideasonboard.com>","References":"<20250310170303.185199-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] ipa: simple: lut: Fix include path","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 17 Mar 2025 17:58:59 +0000","Message-ID":"<174223433957.3394313.1372722438861623675@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]