[{"id":33774,"web_url":"https://patchwork.libcamera.org/comment/33774/","msgid":"","date":"2025-03-31T15:56:59","subject":"Re: [PATCH v6 5/5] pipeline: simple: Reset delayedCtrls at start.","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Stanislaw,\n\nThank you for the patch. \n\nOn Wed, Mar 05, 2025 at 02:52:56PM +0100, Stanislaw Gruszka wrote:\n> Similar like in other pipelines (IPU3, rpi) avoid using stale\n> values of DelayedControls class when the same camera is started\n> second time.\n> \n> Co-developed-by: Hans de Goede \n> Signed-off-by: Hans de Goede \n> Signed-off-by: Stanislaw Gruszka \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 58aa3dba..659b1123 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -1376,6 +1376,7 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL\n> \n> \tvideo->bufferReady.connect(data, &SimpleCameraData::imageBufferReady);\n> \n> +\tdata->delayedCtrls_->reset();\n> \tif (frameStartEmitter) {\n> \t\tret = frameStartEmitter->setFrameStartEnabled(true);\n> \t\tif (ret) {\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B295C3213\n\tfor ;\n\tMon, 31 Mar 2025 15:57:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6920B68985;\n\tMon, 31 Mar 2025 17:57:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61EA168967\n\tfor ;\n\tMon, 31 Mar 2025 17:57:03 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:823a:c275:e8b5:b937])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A3AAC703;\n\tMon, 31 Mar 2025 17:55:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rl8Xk9vH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743436511;\n\tbh=3XwZmF0WUnfs10iDIrNQ9a7tCAMO8PzPN/eCS0uJWM0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rl8Xk9vHw1F/gxD0rbeQSra7LriwTb8fm7taWqub5q0IDfMfnW8fogfpUbz8sAYAA\n\tAPTemo8eH4LbTCNUX0q41q8930L/fyHPX6V12GjsyN/qiiOJhLkZA7vs3NquU7CcHt\n\t7lqOhXGaymZg0+DWNjbqUI0fsy7GyWTGjmm6r7qw=","Date":"Mon, 31 Mar 2025 17:56:59 +0200","From":"Stefan Klug ","To":"Stanislaw Gruszka ","Cc":"libcamera-devel@lists.libcamera.org, Milan Zamazal ,\n\tLaurent Pinchart , \n\tKieran Bingham ,\n\tNaushir Patuck , \n\tSakari Ailus ,\n\tHans de Goede ","Subject":"Re: [PATCH v6 5/5] pipeline: simple: Reset delayedCtrls at start.","Message-ID":"","References":"<20250305135256.801351-1-stanislaw.gruszka@linux.intel.com>\n\t<20250305135256.801351-6-stanislaw.gruszka@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250305135256.801351-6-stanislaw.gruszka@linux.intel.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33788,"web_url":"https://patchwork.libcamera.org/comment/33788/","msgid":"<174344002091.3394313.18103659601325696905@ping.linuxembedded.co.uk>","date":"2025-03-31T16:53:40","subject":"Re: [PATCH v6 5/5] pipeline: simple: Reset delayedCtrls at start.","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stanislaw Gruszka (2025-03-05 13:52:56)\n> Similar like in other pipelines (IPU3, rpi) avoid using stale\n> values of DelayedControls class when the same camera is started\n> second time.\n> \n> Co-developed-by: Hans de Goede \n> Signed-off-by: Hans de Goede \n> Signed-off-by: Stanislaw Gruszka \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 58aa3dba..659b1123 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -1376,6 +1376,7 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL\n> \n> video->bufferReady.connect(data, &SimpleCameraData::imageBufferReady);\n> \n> + data->delayedCtrls_->reset();\n> if (frameStartEmitter) {\n> ret = frameStartEmitter->setFrameStartEnabled(true);\n> if (ret) {\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB010C3213\n\tfor ;\n\tMon, 31 Mar 2025 16:53:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59FF268988;\n\tMon, 31 Mar 2025 18:53:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6125968981\n\tfor ;\n\tMon, 31 Mar 2025 18:53:44 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DDDC3725;\n\tMon, 31 Mar 2025 18:51:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wdsHvksg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743439913;\n\tbh=QgcRodHcmwMlqqnR3t0836rhyUNz24Q9RVua9BXb0eQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=wdsHvksg3pQ949pWMhLMDb1QI+mI9sRl9exhQPvrYjbrawyUASdSC/YUvf8/+wuZn\n\tAkfkvn09s2UC69DxGUcgr8E+CdMttQv0w54P/m0IKvG8I0QOSnGJF71+HCu1MV1ogK\n\tizooE3Xqv03x+DQ8DJourmUrIkcqJFU8LGSdDbIg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250305135256.801351-6-stanislaw.gruszka@linux.intel.com>","References":"<20250305135256.801351-1-stanislaw.gruszka@linux.intel.com>\n\t<20250305135256.801351-6-stanislaw.gruszka@linux.intel.com>","Subject":"Re: [PATCH v6 5/5] pipeline: simple: Reset delayedCtrls at start.","From":"Kieran Bingham ","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ,\n\tNaushir Patuck ,\n\tSakari Ailus ,\n\tHans de Goede ","To":"Stanislaw Gruszka ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 31 Mar 2025 17:53:40 +0100","Message-ID":"<174344002091.3394313.18103659601325696905@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]