[{"id":3013,"web_url":"https://patchwork.libcamera.org/comment/3013/","msgid":"<20191114075510.GE7353@bigcity.dyn.berto.se>","date":"2019-11-14T07:55:10","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Remove space between\n\tempty curly brackets","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-11-04 19:08:05 +0200, Laurent Pinchart wrote:\n> Remove spaces between empty curly brackets (replacing { } with {}) to\n> comply with the coding style. Fix one other coding style violation on\n> the lines touched by those fixes.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/media_object.h | 10 ++++++----\n> src/libcamera/media_device.cpp | 4 ++--\n> src/libcamera/message.cpp | 2 +-\n> test/libtest/test.h | 2 +-\n> test/media_device/media_device_print_test.cpp | 8 ++++----\n> 5 files changed, 14 insertions(+), 12 deletions(-)\n> \n> diff --git a/src/libcamera/include/media_object.h b/src/libcamera/include/media_object.h\n> index 2a3ffc06c876..748eafdc880b 100644\n> --- a/src/libcamera/include/media_object.h\n> +++ b/src/libcamera/include/media_object.h\n> @@ -27,9 +27,11 @@ public:\n> protected:\n> \tfriend class MediaDevice;\n> \n> -\tMediaObject(MediaDevice *dev, unsigned int id) :\n> -\t\tdev_(dev), id_(id) { }\n> -\tvirtual ~MediaObject() { }\n> +\tMediaObject(MediaDevice *dev, unsigned int id)\n> +\t\t: dev_(dev), id_(id)\n> +\t{\n> +\t}\n> +\tvirtual ~MediaObject() {}\n> \n> \tMediaDevice *dev_;\n> \tunsigned int id_;\n> @@ -49,7 +51,7 @@ private:\n> \tMediaLink(const struct media_v2_link *link,\n> \t\t MediaPad *source, MediaPad *sink);\n> \tMediaLink(const MediaLink &) = delete;\n> -\t~MediaLink() { }\n> +\t~MediaLink() {}\n> \n> \tMediaPad *source_;\n> \tMediaPad *sink_;\n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index 0d6630fbd1f4..e1ae34f88455 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -199,7 +199,7 @@ void MediaDevice::unlock()\n> */\n> int MediaDevice::populate()\n> {\n> -\tstruct media_v2_topology topology = { };\n> +\tstruct media_v2_topology topology = {};\n> \tstruct media_v2_entity *ents = nullptr;\n> \tstruct media_v2_interface *interfaces = nullptr;\n> \tstruct media_v2_link *links = nullptr;\n> @@ -767,7 +767,7 @@ void MediaDevice::fixupEntityFlags(struct media_v2_entity *entity)\n> */\n> int MediaDevice::setupLink(const MediaLink *link, unsigned int flags)\n> {\n> -\tstruct media_link_desc linkDesc = { };\n> +\tstruct media_link_desc linkDesc = {};\n> \tMediaPad *source = link->source();\n> \tMediaPad *sink = link->sink();\n> \n> diff --git a/src/libcamera/message.cpp b/src/libcamera/message.cpp\n> index c547895362f3..c35bb33dfeda 100644\n> --- a/src/libcamera/message.cpp\n> +++ b/src/libcamera/message.cpp\n> @@ -93,7 +93,7 @@ Message::~Message()\n> * class MyCustomMessage : public Message\n> * {\n> * public:\n> - *\tMyCustomMessage() : Message(type()) { }\n> + *\tMyCustomMessage() : Message(type()) {}\n> *\n> *\tstatic Message::Type type()\n> *\t{\n> diff --git a/test/libtest/test.h b/test/libtest/test.h\n> index ec08bf97c03d..26d4b94bc12d 100644\n> --- a/test/libtest/test.h\n> +++ b/test/libtest/test.h\n> @@ -26,7 +26,7 @@ public:\n> protected:\n> \tvirtual int init() { return 0; }\n> \tvirtual int run() = 0;\n> -\tvirtual void cleanup() { }\n> +\tvirtual void cleanup() {}\n> };\n> \n> #define TEST_REGISTER(klass)\t\t\t\t\t\t\\\n> diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp\n> index 8dd8a151266d..5018906c75e7 100644\n> --- a/test/media_device/media_device_print_test.cpp\n> +++ b/test/media_device/media_device_print_test.cpp\n> @@ -26,13 +26,13 @@ using namespace std;\n> class MediaDevicePrintTest : public Test\n> {\n> public:\n> -\tMediaDevicePrintTest() { }\n> -\t~MediaDevicePrintTest() { }\n> +\tMediaDevicePrintTest() {}\n> +\t~MediaDevicePrintTest() {}\n> \n> protected:\n> \tint init() { return 0; }\n> \tint run();\n> -\tvoid cleanup() { }\n> +\tvoid cleanup() {}\n> \n> private:\n> \tint testMediaDevice(string deviceNode);\n> @@ -137,7 +137,7 @@ int MediaDevicePrintTest::run()\n> \t */\n> \tfor (i = 0; i < MAX_MEDIA_DEV; i++) {\n> \t\tstring mediadev = deviceNode + to_string(i);\n> -\t\tstruct stat pstat = { };\n> +\t\tstruct stat pstat = {};\n> \n> \t\tif (stat(mediadev.c_str(), &pstat))\n> \t\t\tcontinue;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30A5D60C33\n\tfor ;\n\tThu, 14 Nov 2019 08:55:12 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id x22so85939lfa.3\n\tfor ;\n\tWed, 13 Nov 2019 23:55:12 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tg23sm2298190ljn.63.2019.11.13.23.55.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Nov 2019 23:55:10 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=k2pXh47ZpDAPHYYyw7NUYIkmxOv5OtS0d/cQEwtsY8A=;\n\tb=uH+6uTlLnVw2C9bsaZGReu29tYYFBy03JS1YSHONkzEtafGrjZ2KBNi/QvhTPxBCXQ\n\tH1NoHyPfra/ph/qxbTGxq86AeLT5stURL5UbPa3GHiafCvOTrTOHQ2Zin3AoFG1pRYam\n\tDeRHdL7OdMVrHXvl5EP9pC5vLjfAge07vHvlHQsIThp74yO/DGNsAKGqS7zVtDJTFBLK\n\tEj++tak7iiF4O/LCdOhPoZawgbwSCzlf4HLkTSe05TyepCjf2nZvffFaNfmcvp/cuhfL\n\tRJ6QPb+hoI9bXFzZM1q3ohjs6v23Rocbx0xe6okjuNjsPpgWTDblmVAZEgkg1ZTAqgYj\n\tsn8w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=k2pXh47ZpDAPHYYyw7NUYIkmxOv5OtS0d/cQEwtsY8A=;\n\tb=eFj6OT/go07dSPZ2ZU4wrh/3K3zNsF3AFQU8TCpRwpGSW8UNAMKSgEnEES9uNeuib1\n\tbVV86dTJHPp8pMVpl7WD0PwQnmr+da+1J+aKce+J5AmfCZB1I8azKQ8FwuurSfhtAb+C\n\tpLkx5mmIOFckqLSdqrf41Qk/wTFxIbmtSRJ/NquQ0Lr+mz/qrbLNkaZKThqFO8ysmS7i\n\t+4BLaRxxofpm9RoBE+UiZpL/lPwokhEK61ZKkrLmA8U22XJR8x8E0jAOPyslF0tuXS3W\n\tUU1706D6/ldSJT0rvfM54gD3AWOdC1zSSdbAsLCDochEdCWXbHPCzJaPJeqIZM8yIxgc\n\t0J0w==","X-Gm-Message-State":"APjAAAXES4od8FFEU2gQpv5Cdd8sD62iTVxPI2qAKAclsiaCWGxvRM0c\n\tutMlRUsLFbDFj5njqzto6PkpV1rYdJU=","X-Google-Smtp-Source":"APXvYqw1bmuCKYwP72xaScFB/zQhBGirsXOaVegMSf6Puj75G5lQr9EoEhCplXOgFOGv/tRQlo7v+Q==","X-Received":"by 2002:ac2:5090:: with SMTP id\n\tf16mr5844546lfm.115.1573718111629; \n\tWed, 13 Nov 2019 23:55:11 -0800 (PST)","Date":"Thu, 14 Nov 2019 08:55:10 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191114075510.GE7353@bigcity.dyn.berto.se>","References":"<20191104170805.20647-1-laurent.pinchart@ideasonboard.com>\n\t<20191104170805.20647-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191104170805.20647-2-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Remove space between\n\tempty curly brackets","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 14 Nov 2019 07:55:12 -0000"}}]