[{"id":33773,"web_url":"https://patchwork.libcamera.org/comment/33773/","msgid":"","date":"2025-03-31T15:54:49","subject":"Re: [PATCH v6 4/5] pipeline: simple: Create DelayedControls instance\n\tonce only","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Stanislaw,\n\nThank you for the patch.\n\nOn Wed, Mar 05, 2025 at 02:52:55PM +0100, Stanislaw Gruszka wrote:\n> From: Laurent Pinchart \n> \n> The DelayedControls instance for the camera sensor is created in\n> SimplePipelineHandler::configure(). Constant deletion and reconstruction\n> of a new object is unnecessary, as the control delays are an intrinsic\n> property of the sensor and are known at initialization time. Move the\n> DelayedControls creation to the SimpleCameraData class constructor.\n> \n> Signed-off-by: Laurent Pinchart \n> Signed-off-by: Stanislaw Gruszka \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 16 +++++++---------\n> 1 file changed, 7 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 7be49017..58aa3dba 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -489,6 +489,13 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n> \tif (!sensor_)\n> \t\treturn;\n> \n> +\tconst CameraSensorProperties::SensorDelays &delays = sensor_->sensorDelays();\n> +\tstd::unordered_map params = {\n> +\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n> +\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n> +\t};\n> +\tdelayedCtrls_ = std::make_unique(sensor_->device(), params);\n> +\n> \tLOG(SimplePipeline, Debug)\n> \t\t<< \"Found pipeline: \"\n> \t\t<< utils::join(entities_, \" -> \",\n> @@ -1302,15 +1309,6 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \tif (outputCfgs.empty())\n> \t\treturn 0;\n> \n> -\tconst CameraSensorProperties::SensorDelays &delays = data->sensor_->sensorDelays();\n> -\tstd::unordered_map params = {\n> -\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n> -\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n> -\t};\n> -\tdata->delayedCtrls_ =\n> -\t\tstd::make_unique(data->sensor_->device(),\n> -\t\t\t\t\t\t params);\n> -\n> \tStreamConfiguration inputCfg;\n> \tinputCfg.pixelFormat = pipeConfig->captureFormat;\n> \tinputCfg.size = pipeConfig->captureSize;\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA03FC3213\n\tfor ;\n\tMon, 31 Mar 2025 15:54:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DDF2768985;\n\tMon, 31 Mar 2025 17:54:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DD9768967\n\tfor ;\n\tMon, 31 Mar 2025 17:54:53 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:823a:c275:e8b5:b937])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B4D3703;\n\tMon, 31 Mar 2025 17:53:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SJkTd1pG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743436381;\n\tbh=X0l/RdqbrI6fJIdIl2LRjtacbRpua1+B+1T6mqehVGs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SJkTd1pGrigb1uEOef3QFEgXkcgAVnwn7Fa1cuNm6P4KpiyIngifVFNA51Bfxlq36\n\tFDtd+RxTW34M4wQh/OYw69wOVZhB6ihZZ3qFiH5v+te+1sOzA4goja2lfa/qCm5G1R\n\tdgVxMvcSUG2SPRclw3bsV1SCWBDI4BivRTgXGOPM=","Date":"Mon, 31 Mar 2025 17:54:49 +0200","From":"Stefan Klug ","To":"Stanislaw Gruszka ","Cc":"libcamera-devel@lists.libcamera.org, Milan Zamazal ,\n\tLaurent Pinchart , \n\tKieran Bingham ,\n\tNaushir Patuck , \n\tSakari Ailus ,\n\tHans de Goede ","Subject":"Re: [PATCH v6 4/5] pipeline: simple: Create DelayedControls instance\n\tonce only","Message-ID":"","References":"<20250305135256.801351-1-stanislaw.gruszka@linux.intel.com>\n\t<20250305135256.801351-5-stanislaw.gruszka@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250305135256.801351-5-stanislaw.gruszka@linux.intel.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]