[{"id":33770,"web_url":"https://patchwork.libcamera.org/comment/33770/","msgid":"","date":"2025-03-31T15:16:04","subject":"Re: [PATCH v6 2/5] pipeline: simple: Connect/disconnect frameStart\n\tsignal at start/stop time","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Stanislaw,\n\nThank you for the patch. \n\nOn Wed, Mar 05, 2025 at 02:52:53PM +0100, Stanislaw Gruszka wrote:\n> The frameStart signal from the frame start emitter is connected in the\n> configure() function, and is never disconnected. This means that each\n> time the camera is configured a new connection is made, causing the\n> DelayedControls::applyControls() to be called multiple times. Fix it by\n> connecting and disconnecting the signal when starting and stopping the\n> camera.\n> \n> Co-developed-by: Hans de Goede \n> Signed-off-by: Hans de Goede \n> Co-developed-by: Laurent Pinchart \n> Signed-off-by: Laurent Pinchart \n> Signed-off-by: Stanislaw Gruszka \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 8 ++++++--\n> 1 file changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 6e039bf3..8345a771 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -1285,8 +1285,6 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \tdata->delayedCtrls_ =\n> \t\tstd::make_unique(data->sensor_->device(),\n> \t\t\t\t\t\t params);\n> -\tdata->video_->frameStart.connect(data->delayedCtrls_.get(),\n> -\t\t\t\t\t &DelayedControls::applyControls);\n> \n> \tStreamConfiguration inputCfg;\n> \tinputCfg.pixelFormat = pipeConfig->captureFormat;\n> @@ -1354,6 +1352,9 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL\n> \n> \tvideo->bufferReady.connect(data, &SimpleCameraData::imageBufferReady);\n> \n> +\tdata->video_->frameStart.connect(data->delayedCtrls_.get(),\n> +\t\t\t\t\t &DelayedControls::applyControls);\n> +\n> \tret = video->streamOn();\n> \tif (ret < 0) {\n> \t\tstop(camera);\n> @@ -1386,6 +1387,9 @@ void SimplePipelineHandler::stopDevice(Camera *camera)\n> \tSimpleCameraData *data = cameraData(camera);\n> \tV4L2VideoDevice *video = data->video_;\n> \n> +\tdata->video_->frameStart.disconnect(data->delayedCtrls_.get(),\n> +\t\t\t\t\t &DelayedControls::applyControls);\n> +\n> \tif (data->useConversion_) {\n> \t\tif (data->converter_)\n> \t\t\tdata->converter_->stop();\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E612AC323E\n\tfor ;\n\tMon, 31 Mar 2025 15:16:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C6D168985;\n\tMon, 31 Mar 2025 17:16:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 371BC68967\n\tfor ;\n\tMon, 31 Mar 2025 17:16:08 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:823a:c275:e8b5:b937])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CE7082A;\n\tMon, 31 Mar 2025 17:14:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qxCJWD7K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743434056;\n\tbh=mkwtqVpZ3JiHPgls9vFlUmumtZtF1rBuA3mE9iKkclQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qxCJWD7Krc/f6Av9uLcS66gcq8BkPD7TlCBCobHD6lIV/OLEy3hCRDSiLFTVNQIqS\n\tvfWIZjrEHgcHeuX2+2zGDqal3zvm312hkucG9k6ea06vf/1F4Ub3UIOOT3yaPzzKME\n\twqKFMXZP0coecZSdaAYMI/cQkynrMoO5anRurQ0k=","Date":"Mon, 31 Mar 2025 17:16:04 +0200","From":"Stefan Klug ","To":"Stanislaw Gruszka ","Cc":"libcamera-devel@lists.libcamera.org, Milan Zamazal ,\n\tLaurent Pinchart , \n\tKieran Bingham ,\n\tNaushir Patuck , \n\tSakari Ailus ,\n\tHans de Goede ","Subject":"Re: [PATCH v6 2/5] pipeline: simple: Connect/disconnect frameStart\n\tsignal at start/stop time","Message-ID":"","References":"<20250305135256.801351-1-stanislaw.gruszka@linux.intel.com>\n\t<20250305135256.801351-3-stanislaw.gruszka@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250305135256.801351-3-stanislaw.gruszka@linux.intel.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]