{"id":22927,"url":"https://patchwork.libcamera.org/api/patches/22927/?format=json","web_url":"https://patchwork.libcamera.org/patch/22927/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250305135256.801351-3-stanislaw.gruszka@linux.intel.com>","date":"2025-03-05T13:52:53","name":"[v6,2/5] pipeline: simple: Connect/disconnect frameStart signal at start/stop time","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ffaa2b42a2d48da21ffdd3b1b964b18610010ef9","submitter":{"id":211,"url":"https://patchwork.libcamera.org/api/people/211/?format=json","name":"Stanislaw Gruszka","email":"stanislaw.gruszka@linux.intel.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22927/mbox/","series":[{"id":5046,"url":"https://patchwork.libcamera.org/api/series/5046/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5046","date":"2025-03-05T13:52:51","name":"libcamera: start frame events changes","version":6,"mbox":"https://patchwork.libcamera.org/series/5046/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22927/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22927/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26C9EC3257\n\tfor ;\n\tWed, 5 Mar 2025 13:53:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA4CF68826;\n\tWed, 5 Mar 2025 14:53:13 +0100 (CET)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D42C68823\n\tfor ;\n\tWed, 5 Mar 2025 14:53:11 +0100 (CET)","from orviesa004.jf.intel.com ([10.64.159.144])\n\tby orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t05 Mar 2025 05:53:12 -0800","from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.245.112.97]) by orviesa004-auth.jf.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 05:53:09 -0800"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"WQEXXZfS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1741182793; x=1772718793;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=RL+FnaRLMxhqroKIeL15KGsCJK4hX7iIspRBBAocApQ=;\n\tb=WQEXXZfS8H0JbNQd8FO36GI2TZv8/h/GtWRsMPdUKAvQbb7/s7aXG8wa\n\tzVceeI0t+MfUT6+zLyJCJozyHq/j6EyGorZdlZ+WlTIo/H2Q6q6keDLOO\n\t07HvwqNhdzWP8yNNz3BTWv7sCwlMQ6OdMb+EbFFSaUkksYKnF5geDOS1B\n\tuQmx5qOmSEeOY0x6yrqs82jC6YIOGFNyn3Cwg8E9LGN2eAn6mjJxT2L+2\n\tEPff64fQGPVm+t1ICnk5quwEKVKGroelvkSqcTH6yZFDta1EA62kYSY3H\n\ttq3QoRp/SeQSmQndsGRTnhPrkZllV2xknbWarAsFDuyvQTAFYMSHVEEr1 Q==;","X-CSE-ConnectionGUID":["Sly69FHqQzCpcHgVrzh88w==","KInF+gRkTcivMbZqi+OXfQ=="],"X-CSE-MsgGUID":["JowmiEMsR66zUPUgQxdbZA==","xULXDFEeTAOeeJ71//WIzg=="],"X-IronPort-AV":["E=McAfee;i=\"6700,10204,11363\"; a=\"53134769\"","E=Sophos;i=\"6.14,223,1736841600\"; d=\"scan'208\";a=\"53134769\"","E=Sophos;i=\"6.14,223,1736841600\"; d=\"scan'208\";a=\"123735779\""],"X-ExtLoop1":"1","From":"Stanislaw Gruszka ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ,\n\tKieran Bingham ,\n\tNaushir Patuck ,\n\tSakari Ailus ,\n\tHans de Goede ","Subject":"[PATCH v6 2/5] pipeline: simple: Connect/disconnect frameStart\n\tsignal at start/stop time","Date":"Wed, 5 Mar 2025 14:52:53 +0100","Message-Id":"<20250305135256.801351-3-stanislaw.gruszka@linux.intel.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20250305135256.801351-1-stanislaw.gruszka@linux.intel.com>","References":"<20250305135256.801351-1-stanislaw.gruszka@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The frameStart signal from the frame start emitter is connected in the\nconfigure() function, and is never disconnected. This means that each\ntime the camera is configured a new connection is made, causing the\nDelayedControls::applyControls() to be called multiple times. Fix it by\nconnecting and disconnecting the signal when starting and stopping the\ncamera.\n\nCo-developed-by: Hans de Goede \nSigned-off-by: Hans de Goede \nCo-developed-by: Laurent Pinchart \nSigned-off-by: Laurent Pinchart \nSigned-off-by: Stanislaw Gruszka \n---\n src/libcamera/pipeline/simple/simple.cpp | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 6e039bf3..8345a771 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1285,8 +1285,6 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tdata->delayedCtrls_ =\n \t\tstd::make_unique(data->sensor_->device(),\n \t\t\t\t\t\t params);\n-\tdata->video_->frameStart.connect(data->delayedCtrls_.get(),\n-\t\t\t\t\t &DelayedControls::applyControls);\n \n \tStreamConfiguration inputCfg;\n \tinputCfg.pixelFormat = pipeConfig->captureFormat;\n@@ -1354,6 +1352,9 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL\n \n \tvideo->bufferReady.connect(data, &SimpleCameraData::imageBufferReady);\n \n+\tdata->video_->frameStart.connect(data->delayedCtrls_.get(),\n+\t\t\t\t\t &DelayedControls::applyControls);\n+\n \tret = video->streamOn();\n \tif (ret < 0) {\n \t\tstop(camera);\n@@ -1386,6 +1387,9 @@ void SimplePipelineHandler::stopDevice(Camera *camera)\n \tSimpleCameraData *data = cameraData(camera);\n \tV4L2VideoDevice *video = data->video_;\n \n+\tdata->video_->frameStart.disconnect(data->delayedCtrls_.get(),\n+\t\t\t\t\t &DelayedControls::applyControls);\n+\n \tif (data->useConversion_) {\n \t\tif (data->converter_)\n \t\t\tdata->converter_->stop();\n","prefixes":["v6","2/5"]}