[{"id":2994,"web_url":"https://patchwork.libcamera.org/comment/2994/","msgid":"<63faad21-7217-c4b5-c6bd-c8d5c475f3fe@ideasonboard.com>","date":"2019-11-05T10:06:58","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Remove unneeded\n\tsemicolons","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 04/11/2019 17:08, Laurent Pinchart wrote:\n> Comply with the coding style by removing lots of unneeded semicolons.\n> Fix a few other coding style violations on the lines touched by those\n> fixes.\n\nThese all look fine to me.\n\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  include/ipa/ipa_module_info.h                   | 4 ++--\n>  include/ipa/ipa_vimc.h                          | 2 +-\n>  include/libcamera/bound_method.h                | 2 +-\n>  include/libcamera/object.h                      | 2 +-\n>  src/cam/event_loop.h                            | 2 +-\n>  src/cam/options.cpp                             | 2 +-\n>  src/ipa/ipa_vimc.cpp                            | 4 ++--\n>  src/ipa/rkisp1/rkisp1.cpp                       | 4 ++--\n>  src/libcamera/include/ipa_proxy.h               | 2 +-\n>  src/libcamera/include/pipeline_handler.h        | 2 +-\n>  src/libcamera/message.cpp                       | 2 +-\n>  src/libcamera/object.cpp                        | 2 +-\n>  src/libcamera/pipeline_handler.cpp              | 2 +-\n>  src/libcamera/proxy/ipa_proxy_linux.cpp         | 2 +-\n>  src/libcamera/thread.cpp                        | 2 +-\n>  test/camera/camera_test.cpp                     | 2 +-\n>  test/v4l2_subdevice/v4l2_subdevice_test.h       | 4 +++-\n>  test/v4l2_videodevice/v4l2_videodevice_test.cpp | 2 +-\n>  18 files changed, 23 insertions(+), 21 deletions(-)\n> \n> diff --git a/include/ipa/ipa_module_info.h b/include/ipa/ipa_module_info.h\n> index d9e33c1db1e4..7ecd149566be 100644\n> --- a/include/ipa/ipa_module_info.h\n> +++ b/include/ipa/ipa_module_info.h\n> @@ -23,8 +23,8 @@ struct IPAModuleInfo {\n>  \n>  extern \"C\" {\n>  extern const struct IPAModuleInfo ipaModuleInfo;\n> -};\n> +}\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n>  \n>  #endif /* __LIBCAMERA_IPA_MODULE_INFO_H__ */\n> diff --git a/include/ipa/ipa_vimc.h b/include/ipa/ipa_vimc.h\n> index 05b561d80047..9add122cf598 100644\n> --- a/include/ipa/ipa_vimc.h\n> +++ b/include/ipa/ipa_vimc.h\n> @@ -17,6 +17,6 @@ enum IPAOperationCode {\n>  \tIPAOperationInit,\n>  };\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n>  \n>  #endif /* __LIBCAMERA_IPA_VIMC_H__ */\n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index bdeb5469cda3..b841a2aed147 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -142,6 +142,6 @@ private:\n>  \tvoid (*func_)(Args...);\n>  };\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n>  \n>  #endif /* __LIBCAMERA_BOUND_METHOD_H__ */\n> diff --git a/include/libcamera/object.h b/include/libcamera/object.h\n> index 91b56596c9db..86e0f7265865 100644\n> --- a/include/libcamera/object.h\n> +++ b/include/libcamera/object.h\n> @@ -67,6 +67,6 @@ private:\n>  \tunsigned int pendingMessages_;\n>  };\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n>  \n>  #endif /* __LIBCAMERA_OBJECT_H__ */\n> diff --git a/src/cam/event_loop.h b/src/cam/event_loop.h\n> index aaca5838f979..581c7cba2fc4 100644\n> --- a/src/cam/event_loop.h\n> +++ b/src/cam/event_loop.h\n> @@ -13,7 +13,7 @@\n>  \n>  namespace libcamera {\n>  class EventDispatcher;\n> -};\n> +}\n>  \n>  class EventLoop\n>  {\n> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> index 1f0631eccfba..7e2dfa636ccf 100644\n> --- a/src/cam/options.cpp\n> +++ b/src/cam/options.cpp\n> @@ -490,7 +490,7 @@ void OptionsParser::usage()\n>  \t\t\telse\n>  \t\t\t\targument += \"  \";\n>  \t\t\targument += std::string(\"--\") + option.name;\n> -\t\t};\n> +\t\t}\n>  \n>  \t\tif (option.argument != ArgumentNone) {\n>  \t\t\tif (option.argument == ArgumentOptional)\n> diff --git a/src/ipa/ipa_vimc.cpp b/src/ipa/ipa_vimc.cpp\n> index 63d578b4e2aa..9fd5212b0381 100644\n> --- a/src/ipa/ipa_vimc.cpp\n> +++ b/src/ipa/ipa_vimc.cpp\n> @@ -112,6 +112,6 @@ IPAInterface *ipaCreate()\n>  {\n>  \treturn new IPAVimc();\n>  }\n> -};\n> +}\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 9a13f5c7df17..d741d5677d0e 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -251,6 +251,6 @@ IPAInterface *ipaCreate()\n>  {\n>  \treturn new IPARkISP1();\n>  }\n> -};\n> +}\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/include/ipa_proxy.h b/src/libcamera/include/ipa_proxy.h\n> index 72216662e373..add40b4b3368 100644\n> --- a/src/libcamera/include/ipa_proxy.h\n> +++ b/src/libcamera/include/ipa_proxy.h\n> @@ -36,7 +36,7 @@ class IPAProxyFactory\n>  {\n>  public:\n>  \tIPAProxyFactory(const char *name);\n> -\tvirtual ~IPAProxyFactory(){};\n> +\tvirtual ~IPAProxyFactory() {}\n>  \n>  \tvirtual std::unique_ptr<IPAProxy> create(IPAModule *ipam) = 0;\n>  \n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index 42b90a4bf1a6..241af58beec0 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -111,7 +111,7 @@ class PipelineHandlerFactory\n>  {\n>  public:\n>  \tPipelineHandlerFactory(const char *name);\n> -\tvirtual ~PipelineHandlerFactory() { };\n> +\tvirtual ~PipelineHandlerFactory() {}\n>  \n>  \tstd::shared_ptr<PipelineHandler> create(CameraManager *manager);\n>  \n> diff --git a/src/libcamera/message.cpp b/src/libcamera/message.cpp\n> index daf653221077..c547895362f3 100644\n> --- a/src/libcamera/message.cpp\n> +++ b/src/libcamera/message.cpp\n> @@ -161,4 +161,4 @@ void InvokeMessage::invoke()\n>   * \\brief The packed method invocation arguments\n>   */\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/object.cpp b/src/libcamera/object.cpp\n> index db2c6f68fbc8..1f787271f782 100644\n> --- a/src/libcamera/object.cpp\n> +++ b/src/libcamera/object.cpp\n> @@ -223,4 +223,4 @@ void Object::disconnect(SignalBase *signal)\n>  \t}\n>  }\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index bf8c86d35c4f..884feaa6ecbd 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -135,7 +135,7 @@ PipelineHandler::~PipelineHandler()\n>  {\n>  \tfor (std::shared_ptr<MediaDevice> media : mediaDevices_)\n>  \t\tmedia->release();\n> -};\n> +}\n>  \n>  /**\n>   * \\fn PipelineHandler::match(DeviceEnumerator *enumerator)\n> diff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> index 4e6fa6899e07..27b6639d6312 100644\n> --- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n> +++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> @@ -92,4 +92,4 @@ void IPAProxyLinux::readyRead(IPCUnixSocket *ipc)\n>  \n>  REGISTER_IPA_PROXY(IPAProxyLinux)\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> index 872ad1bd9d69..e152af14631e 100644\n> --- a/src/libcamera/thread.cpp\n> +++ b/src/libcamera/thread.cpp\n> @@ -495,4 +495,4 @@ void Thread::moveObject(Object *object, ThreadData *currentData,\n>  \t\tmoveObject(child, currentData, targetData);\n>  }\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> diff --git a/test/camera/camera_test.cpp b/test/camera/camera_test.cpp\n> index 0e105414bf46..101e31fbce79 100644\n> --- a/test/camera/camera_test.cpp\n> +++ b/test/camera/camera_test.cpp\n> @@ -45,4 +45,4 @@ void CameraTest::cleanup()\n>  \n>  \tcm_->stop();\n>  \tdelete cm_;\n> -};\n> +}\n> diff --git a/test/v4l2_subdevice/v4l2_subdevice_test.h b/test/v4l2_subdevice/v4l2_subdevice_test.h\n> index 96646a155536..3bce6691f8ef 100644\n> --- a/test/v4l2_subdevice/v4l2_subdevice_test.h\n> +++ b/test/v4l2_subdevice/v4l2_subdevice_test.h\n> @@ -21,7 +21,9 @@ class V4L2SubdeviceTest : public Test\n>  {\n>  public:\n>  \tV4L2SubdeviceTest()\n> -\t\t: scaler_(nullptr){};\n> +\t\t: scaler_(nullptr)\n> +\t{\n> +\t}\n>  \n>  protected:\n>  \tint init() override;\n> diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.cpp b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> index 096f9649bfc9..577da4cb601c 100644\n> --- a/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> +++ b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> @@ -99,4 +99,4 @@ void V4L2VideoDeviceTest::cleanup()\n>  \tdelete debayer_;\n>  \tdelete sensor_;\n>  \tdelete capture_;\n> -};\n> +}\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1D5760BF3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  5 Nov 2019 11:07:03 +0100 (CET)","from [192.168.43.26] (unknown [80.2.22.69])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD08952C;\n\tTue,  5 Nov 2019 11:07:02 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1572948423;\n\tbh=acSyTwriUrFGUP2EAyuzu4QooDKuF3+M0F7kzeAs3ag=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=L3QGVclzQVO1bNi+FK19+FfHYyDBmHkktHLdIJlzuD6g4NLxMmVRatHoZwOcoBsul\n\tnbd2NsaefvgCQZpQvSEjqwgihZzFounXFEIIUoyjCTE/0twl4N/pimZ+nkaWogg3pQ\n\tvyBBF4rUwzdRsUdrwSMCerRXvmF3zVAXrmo8dkUU=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20191104170805.20647-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<63faad21-7217-c4b5-c6bd-c8d5c475f3fe@ideasonboard.com>","Date":"Tue, 5 Nov 2019 10:06:58 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.8.0","MIME-Version":"1.0","In-Reply-To":"<20191104170805.20647-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Remove unneeded\n\tsemicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 05 Nov 2019 10:07:04 -0000"}},{"id":3006,"web_url":"https://patchwork.libcamera.org/comment/3006/","msgid":"<20191109103412.bsy374jmsvdkv22v@uno.localdomain>","date":"2019-11-09T10:34:12","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Remove unneeded\n\tsemicolons","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n   thanks for the patch\n\nOn Tue, Nov 05, 2019 at 10:06:58AM +0000, Kieran Bingham wrote:\n> Hi Laurent,\n>\n> On 04/11/2019 17:08, Laurent Pinchart wrote:\n> > Comply with the coding style by removing lots of unneeded semicolons.\n> > Fix a few other coding style violations on the lines touched by those\n> > fixes.\n>\n> These all look fine to me.\n>\n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>\n> > ---\n> >  include/ipa/ipa_module_info.h                   | 4 ++--\n> >  include/ipa/ipa_vimc.h                          | 2 +-\n> >  include/libcamera/bound_method.h                | 2 +-\n> >  include/libcamera/object.h                      | 2 +-\n> >  src/cam/event_loop.h                            | 2 +-\n> >  src/cam/options.cpp                             | 2 +-\n> >  src/ipa/ipa_vimc.cpp                            | 4 ++--\n> >  src/ipa/rkisp1/rkisp1.cpp                       | 4 ++--\n> >  src/libcamera/include/ipa_proxy.h               | 2 +-\n> >  src/libcamera/include/pipeline_handler.h        | 2 +-\n> >  src/libcamera/message.cpp                       | 2 +-\n> >  src/libcamera/object.cpp                        | 2 +-\n> >  src/libcamera/pipeline_handler.cpp              | 2 +-\n> >  src/libcamera/proxy/ipa_proxy_linux.cpp         | 2 +-\n> >  src/libcamera/thread.cpp                        | 2 +-\n> >  test/camera/camera_test.cpp                     | 2 +-\n> >  test/v4l2_subdevice/v4l2_subdevice_test.h       | 4 +++-\n> >  test/v4l2_videodevice/v4l2_videodevice_test.cpp | 2 +-\n> >  18 files changed, 23 insertions(+), 21 deletions(-)\n> >\n> > diff --git a/include/ipa/ipa_module_info.h b/include/ipa/ipa_module_info.h\n> > index d9e33c1db1e4..7ecd149566be 100644\n> > --- a/include/ipa/ipa_module_info.h\n> > +++ b/include/ipa/ipa_module_info.h\n> > @@ -23,8 +23,8 @@ struct IPAModuleInfo {\n> >\n> >  extern \"C\" {\n> >  extern const struct IPAModuleInfo ipaModuleInfo;\n> > -};\n> > +}\n> >\n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> >\n> >  #endif /* __LIBCAMERA_IPA_MODULE_INFO_H__ */\n> > diff --git a/include/ipa/ipa_vimc.h b/include/ipa/ipa_vimc.h\n> > index 05b561d80047..9add122cf598 100644\n> > --- a/include/ipa/ipa_vimc.h\n> > +++ b/include/ipa/ipa_vimc.h\n> > @@ -17,6 +17,6 @@ enum IPAOperationCode {\n> >  \tIPAOperationInit,\n> >  };\n> >\n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> >\n> >  #endif /* __LIBCAMERA_IPA_VIMC_H__ */\n> > diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> > index bdeb5469cda3..b841a2aed147 100644\n> > --- a/include/libcamera/bound_method.h\n> > +++ b/include/libcamera/bound_method.h\n> > @@ -142,6 +142,6 @@ private:\n> >  \tvoid (*func_)(Args...);\n> >  };\n> >\n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> >\n> >  #endif /* __LIBCAMERA_BOUND_METHOD_H__ */\n> > diff --git a/include/libcamera/object.h b/include/libcamera/object.h\n> > index 91b56596c9db..86e0f7265865 100644\n> > --- a/include/libcamera/object.h\n> > +++ b/include/libcamera/object.h\n> > @@ -67,6 +67,6 @@ private:\n> >  \tunsigned int pendingMessages_;\n> >  };\n> >\n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> >\n> >  #endif /* __LIBCAMERA_OBJECT_H__ */\n> > diff --git a/src/cam/event_loop.h b/src/cam/event_loop.h\n> > index aaca5838f979..581c7cba2fc4 100644\n> > --- a/src/cam/event_loop.h\n> > +++ b/src/cam/event_loop.h\n> > @@ -13,7 +13,7 @@\n> >\n> >  namespace libcamera {\n> >  class EventDispatcher;\n> > -};\n> > +}\n\nShould you /* namespace libcamera */ here ?\n\nOtherwise\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n   j\n\n> >\n> >  class EventLoop\n> >  {\n> > diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> > index 1f0631eccfba..7e2dfa636ccf 100644\n> > --- a/src/cam/options.cpp\n> > +++ b/src/cam/options.cpp\n> > @@ -490,7 +490,7 @@ void OptionsParser::usage()\n> >  \t\t\telse\n> >  \t\t\t\targument += \"  \";\n> >  \t\t\targument += std::string(\"--\") + option.name;\n> > -\t\t};\n> > +\t\t}\n> >\n> >  \t\tif (option.argument != ArgumentNone) {\n> >  \t\t\tif (option.argument == ArgumentOptional)\n> > diff --git a/src/ipa/ipa_vimc.cpp b/src/ipa/ipa_vimc.cpp\n> > index 63d578b4e2aa..9fd5212b0381 100644\n> > --- a/src/ipa/ipa_vimc.cpp\n> > +++ b/src/ipa/ipa_vimc.cpp\n> > @@ -112,6 +112,6 @@ IPAInterface *ipaCreate()\n> >  {\n> >  \treturn new IPAVimc();\n> >  }\n> > -};\n> > +}\n> >\n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > index 9a13f5c7df17..d741d5677d0e 100644\n> > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > @@ -251,6 +251,6 @@ IPAInterface *ipaCreate()\n> >  {\n> >  \treturn new IPARkISP1();\n> >  }\n> > -};\n> > +}\n> >\n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> > diff --git a/src/libcamera/include/ipa_proxy.h b/src/libcamera/include/ipa_proxy.h\n> > index 72216662e373..add40b4b3368 100644\n> > --- a/src/libcamera/include/ipa_proxy.h\n> > +++ b/src/libcamera/include/ipa_proxy.h\n> > @@ -36,7 +36,7 @@ class IPAProxyFactory\n> >  {\n> >  public:\n> >  \tIPAProxyFactory(const char *name);\n> > -\tvirtual ~IPAProxyFactory(){};\n> > +\tvirtual ~IPAProxyFactory() {}\n> >\n> >  \tvirtual std::unique_ptr<IPAProxy> create(IPAModule *ipam) = 0;\n> >\n> > diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> > index 42b90a4bf1a6..241af58beec0 100644\n> > --- a/src/libcamera/include/pipeline_handler.h\n> > +++ b/src/libcamera/include/pipeline_handler.h\n> > @@ -111,7 +111,7 @@ class PipelineHandlerFactory\n> >  {\n> >  public:\n> >  \tPipelineHandlerFactory(const char *name);\n> > -\tvirtual ~PipelineHandlerFactory() { };\n> > +\tvirtual ~PipelineHandlerFactory() {}\n> >\n> >  \tstd::shared_ptr<PipelineHandler> create(CameraManager *manager);\n> >\n> > diff --git a/src/libcamera/message.cpp b/src/libcamera/message.cpp\n> > index daf653221077..c547895362f3 100644\n> > --- a/src/libcamera/message.cpp\n> > +++ b/src/libcamera/message.cpp\n> > @@ -161,4 +161,4 @@ void InvokeMessage::invoke()\n> >   * \\brief The packed method invocation arguments\n> >   */\n> >\n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> > diff --git a/src/libcamera/object.cpp b/src/libcamera/object.cpp\n> > index db2c6f68fbc8..1f787271f782 100644\n> > --- a/src/libcamera/object.cpp\n> > +++ b/src/libcamera/object.cpp\n> > @@ -223,4 +223,4 @@ void Object::disconnect(SignalBase *signal)\n> >  \t}\n> >  }\n> >\n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > index bf8c86d35c4f..884feaa6ecbd 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -135,7 +135,7 @@ PipelineHandler::~PipelineHandler()\n> >  {\n> >  \tfor (std::shared_ptr<MediaDevice> media : mediaDevices_)\n> >  \t\tmedia->release();\n> > -};\n> > +}\n> >\n> >  /**\n> >   * \\fn PipelineHandler::match(DeviceEnumerator *enumerator)\n> > diff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> > index 4e6fa6899e07..27b6639d6312 100644\n> > --- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n> > +++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> > @@ -92,4 +92,4 @@ void IPAProxyLinux::readyRead(IPCUnixSocket *ipc)\n> >\n> >  REGISTER_IPA_PROXY(IPAProxyLinux)\n> >\n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> > diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> > index 872ad1bd9d69..e152af14631e 100644\n> > --- a/src/libcamera/thread.cpp\n> > +++ b/src/libcamera/thread.cpp\n> > @@ -495,4 +495,4 @@ void Thread::moveObject(Object *object, ThreadData *currentData,\n> >  \t\tmoveObject(child, currentData, targetData);\n> >  }\n> >\n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> > diff --git a/test/camera/camera_test.cpp b/test/camera/camera_test.cpp\n> > index 0e105414bf46..101e31fbce79 100644\n> > --- a/test/camera/camera_test.cpp\n> > +++ b/test/camera/camera_test.cpp\n> > @@ -45,4 +45,4 @@ void CameraTest::cleanup()\n> >\n> >  \tcm_->stop();\n> >  \tdelete cm_;\n> > -};\n> > +}\n> > diff --git a/test/v4l2_subdevice/v4l2_subdevice_test.h b/test/v4l2_subdevice/v4l2_subdevice_test.h\n> > index 96646a155536..3bce6691f8ef 100644\n> > --- a/test/v4l2_subdevice/v4l2_subdevice_test.h\n> > +++ b/test/v4l2_subdevice/v4l2_subdevice_test.h\n> > @@ -21,7 +21,9 @@ class V4L2SubdeviceTest : public Test\n> >  {\n> >  public:\n> >  \tV4L2SubdeviceTest()\n> > -\t\t: scaler_(nullptr){};\n> > +\t\t: scaler_(nullptr)\n> > +\t{\n> > +\t}\n> >\n> >  protected:\n> >  \tint init() override;\n> > diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.cpp b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> > index 096f9649bfc9..577da4cb601c 100644\n> > --- a/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> > +++ b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> > @@ -99,4 +99,4 @@ void V4L2VideoDeviceTest::cleanup()\n> >  \tdelete debayer_;\n> >  \tdelete sensor_;\n> >  \tdelete capture_;\n> > -};\n> > +}\n> >\n>\n> --\n> Regards\n> --\n> Kieran\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CBE5161508\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat,  9 Nov 2019 11:32:15 +0100 (CET)","from uno.localdomain (unknown [54.36.30.212])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id B866D60003;\n\tSat,  9 Nov 2019 10:32:14 +0000 (UTC)"],"X-Originating-IP":"54.36.30.212","Date":"Sat, 9 Nov 2019 11:34:12 +0100","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20191109103412.bsy374jmsvdkv22v@uno.localdomain>","References":"<20191104170805.20647-1-laurent.pinchart@ideasonboard.com>\n\t<63faad21-7217-c4b5-c6bd-c8d5c475f3fe@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"7gbh3i3x27bwwpfl\"","Content-Disposition":"inline","In-Reply-To":"<63faad21-7217-c4b5-c6bd-c8d5c475f3fe@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Remove unneeded\n\tsemicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 09 Nov 2019 10:32:16 -0000"}},{"id":3011,"web_url":"https://patchwork.libcamera.org/comment/3011/","msgid":"<20191114075234.GC7353@bigcity.dyn.berto.se>","date":"2019-11-14T07:52:34","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Remove unneeded\n\tsemicolons","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-11-04 19:08:04 +0200, Laurent Pinchart wrote:\n> Comply with the coding style by removing lots of unneeded semicolons.\n> Fix a few other coding style violations on the lines touched by those\n> fixes.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nFor ~PipelineHandlerFactory() and V4L2SubdeviceTest() you also fix the \ncurly brackets which you otherwise fix in 2/2 ;-P\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  include/ipa/ipa_module_info.h                   | 4 ++--\n>  include/ipa/ipa_vimc.h                          | 2 +-\n>  include/libcamera/bound_method.h                | 2 +-\n>  include/libcamera/object.h                      | 2 +-\n>  src/cam/event_loop.h                            | 2 +-\n>  src/cam/options.cpp                             | 2 +-\n>  src/ipa/ipa_vimc.cpp                            | 4 ++--\n>  src/ipa/rkisp1/rkisp1.cpp                       | 4 ++--\n>  src/libcamera/include/ipa_proxy.h               | 2 +-\n>  src/libcamera/include/pipeline_handler.h        | 2 +-\n>  src/libcamera/message.cpp                       | 2 +-\n>  src/libcamera/object.cpp                        | 2 +-\n>  src/libcamera/pipeline_handler.cpp              | 2 +-\n>  src/libcamera/proxy/ipa_proxy_linux.cpp         | 2 +-\n>  src/libcamera/thread.cpp                        | 2 +-\n>  test/camera/camera_test.cpp                     | 2 +-\n>  test/v4l2_subdevice/v4l2_subdevice_test.h       | 4 +++-\n>  test/v4l2_videodevice/v4l2_videodevice_test.cpp | 2 +-\n>  18 files changed, 23 insertions(+), 21 deletions(-)\n> \n> diff --git a/include/ipa/ipa_module_info.h b/include/ipa/ipa_module_info.h\n> index d9e33c1db1e4..7ecd149566be 100644\n> --- a/include/ipa/ipa_module_info.h\n> +++ b/include/ipa/ipa_module_info.h\n> @@ -23,8 +23,8 @@ struct IPAModuleInfo {\n>  \n>  extern \"C\" {\n>  extern const struct IPAModuleInfo ipaModuleInfo;\n> -};\n> +}\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n>  \n>  #endif /* __LIBCAMERA_IPA_MODULE_INFO_H__ */\n> diff --git a/include/ipa/ipa_vimc.h b/include/ipa/ipa_vimc.h\n> index 05b561d80047..9add122cf598 100644\n> --- a/include/ipa/ipa_vimc.h\n> +++ b/include/ipa/ipa_vimc.h\n> @@ -17,6 +17,6 @@ enum IPAOperationCode {\n>  \tIPAOperationInit,\n>  };\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n>  \n>  #endif /* __LIBCAMERA_IPA_VIMC_H__ */\n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index bdeb5469cda3..b841a2aed147 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -142,6 +142,6 @@ private:\n>  \tvoid (*func_)(Args...);\n>  };\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n>  \n>  #endif /* __LIBCAMERA_BOUND_METHOD_H__ */\n> diff --git a/include/libcamera/object.h b/include/libcamera/object.h\n> index 91b56596c9db..86e0f7265865 100644\n> --- a/include/libcamera/object.h\n> +++ b/include/libcamera/object.h\n> @@ -67,6 +67,6 @@ private:\n>  \tunsigned int pendingMessages_;\n>  };\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n>  \n>  #endif /* __LIBCAMERA_OBJECT_H__ */\n> diff --git a/src/cam/event_loop.h b/src/cam/event_loop.h\n> index aaca5838f979..581c7cba2fc4 100644\n> --- a/src/cam/event_loop.h\n> +++ b/src/cam/event_loop.h\n> @@ -13,7 +13,7 @@\n>  \n>  namespace libcamera {\n>  class EventDispatcher;\n> -};\n> +}\n>  \n>  class EventLoop\n>  {\n> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> index 1f0631eccfba..7e2dfa636ccf 100644\n> --- a/src/cam/options.cpp\n> +++ b/src/cam/options.cpp\n> @@ -490,7 +490,7 @@ void OptionsParser::usage()\n>  \t\t\telse\n>  \t\t\t\targument += \"  \";\n>  \t\t\targument += std::string(\"--\") + option.name;\n> -\t\t};\n> +\t\t}\n>  \n>  \t\tif (option.argument != ArgumentNone) {\n>  \t\t\tif (option.argument == ArgumentOptional)\n> diff --git a/src/ipa/ipa_vimc.cpp b/src/ipa/ipa_vimc.cpp\n> index 63d578b4e2aa..9fd5212b0381 100644\n> --- a/src/ipa/ipa_vimc.cpp\n> +++ b/src/ipa/ipa_vimc.cpp\n> @@ -112,6 +112,6 @@ IPAInterface *ipaCreate()\n>  {\n>  \treturn new IPAVimc();\n>  }\n> -};\n> +}\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 9a13f5c7df17..d741d5677d0e 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -251,6 +251,6 @@ IPAInterface *ipaCreate()\n>  {\n>  \treturn new IPARkISP1();\n>  }\n> -};\n> +}\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/include/ipa_proxy.h b/src/libcamera/include/ipa_proxy.h\n> index 72216662e373..add40b4b3368 100644\n> --- a/src/libcamera/include/ipa_proxy.h\n> +++ b/src/libcamera/include/ipa_proxy.h\n> @@ -36,7 +36,7 @@ class IPAProxyFactory\n>  {\n>  public:\n>  \tIPAProxyFactory(const char *name);\n> -\tvirtual ~IPAProxyFactory(){};\n> +\tvirtual ~IPAProxyFactory() {}\n>  \n>  \tvirtual std::unique_ptr<IPAProxy> create(IPAModule *ipam) = 0;\n>  \n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index 42b90a4bf1a6..241af58beec0 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -111,7 +111,7 @@ class PipelineHandlerFactory\n>  {\n>  public:\n>  \tPipelineHandlerFactory(const char *name);\n> -\tvirtual ~PipelineHandlerFactory() { };\n> +\tvirtual ~PipelineHandlerFactory() {}\n>  \n>  \tstd::shared_ptr<PipelineHandler> create(CameraManager *manager);\n>  \n> diff --git a/src/libcamera/message.cpp b/src/libcamera/message.cpp\n> index daf653221077..c547895362f3 100644\n> --- a/src/libcamera/message.cpp\n> +++ b/src/libcamera/message.cpp\n> @@ -161,4 +161,4 @@ void InvokeMessage::invoke()\n>   * \\brief The packed method invocation arguments\n>   */\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/object.cpp b/src/libcamera/object.cpp\n> index db2c6f68fbc8..1f787271f782 100644\n> --- a/src/libcamera/object.cpp\n> +++ b/src/libcamera/object.cpp\n> @@ -223,4 +223,4 @@ void Object::disconnect(SignalBase *signal)\n>  \t}\n>  }\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index bf8c86d35c4f..884feaa6ecbd 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -135,7 +135,7 @@ PipelineHandler::~PipelineHandler()\n>  {\n>  \tfor (std::shared_ptr<MediaDevice> media : mediaDevices_)\n>  \t\tmedia->release();\n> -};\n> +}\n>  \n>  /**\n>   * \\fn PipelineHandler::match(DeviceEnumerator *enumerator)\n> diff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> index 4e6fa6899e07..27b6639d6312 100644\n> --- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n> +++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> @@ -92,4 +92,4 @@ void IPAProxyLinux::readyRead(IPCUnixSocket *ipc)\n>  \n>  REGISTER_IPA_PROXY(IPAProxyLinux)\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> index 872ad1bd9d69..e152af14631e 100644\n> --- a/src/libcamera/thread.cpp\n> +++ b/src/libcamera/thread.cpp\n> @@ -495,4 +495,4 @@ void Thread::moveObject(Object *object, ThreadData *currentData,\n>  \t\tmoveObject(child, currentData, targetData);\n>  }\n>  \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> diff --git a/test/camera/camera_test.cpp b/test/camera/camera_test.cpp\n> index 0e105414bf46..101e31fbce79 100644\n> --- a/test/camera/camera_test.cpp\n> +++ b/test/camera/camera_test.cpp\n> @@ -45,4 +45,4 @@ void CameraTest::cleanup()\n>  \n>  \tcm_->stop();\n>  \tdelete cm_;\n> -};\n> +}\n> diff --git a/test/v4l2_subdevice/v4l2_subdevice_test.h b/test/v4l2_subdevice/v4l2_subdevice_test.h\n> index 96646a155536..3bce6691f8ef 100644\n> --- a/test/v4l2_subdevice/v4l2_subdevice_test.h\n> +++ b/test/v4l2_subdevice/v4l2_subdevice_test.h\n> @@ -21,7 +21,9 @@ class V4L2SubdeviceTest : public Test\n>  {\n>  public:\n>  \tV4L2SubdeviceTest()\n> -\t\t: scaler_(nullptr){};\n> +\t\t: scaler_(nullptr)\n> +\t{\n> +\t}\n>  \n>  protected:\n>  \tint init() override;\n> diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.cpp b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> index 096f9649bfc9..577da4cb601c 100644\n> --- a/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> +++ b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> @@ -99,4 +99,4 @@ void V4L2VideoDeviceTest::cleanup()\n>  \tdelete debayer_;\n>  \tdelete sensor_;\n>  \tdelete capture_;\n> -};\n> +}\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2BB560C33\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 14 Nov 2019 08:52:35 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id j14so4210081lfb.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Nov 2019 23:52:35 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tf14sm1783865ljn.105.2019.11.13.23.52.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Nov 2019 23:52:34 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=EUfTBUM/gsenoA6gres0ph2FaPFq4zdf8SD9YZNXxVk=;\n\tb=sy6/l17FDcE6kwms3ijgRAneBlumqOnypApE9H1j71AEre7o+Tp7qORNzltkTHNE+q\n\t1wdOMmJyBi7tzvNwwhhIhA85p8dsMKEF8H7rEsMEXr9eYFvpLrrv9M6xYRnO3nhWpFjI\n\tnbRe2IoiSp/cfLZ6UO2lGUpNpmJf6kuyb3dLW6dqUrTnd7okegU4PtMx64uWWBDxULD/\n\tsytckqVamlkz0InTHfXC9p58ok9ZWAEGarVRrRjPC/hP3Hb6m0CGSAvOP3t3QdGfrumq\n\tUDOCO+Cnh3VvOq63YoRyVqF0yYp39GcyijWO3OlYupW03RSgtVqGVGRuzaj2XatZa25A\n\tiYlg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=EUfTBUM/gsenoA6gres0ph2FaPFq4zdf8SD9YZNXxVk=;\n\tb=GNX4OIDZ1INvtPoxBSpHisvwy1uviedsyijC1WzsIyxAIrVrXHpdz1VnPJIJ9kTN/b\n\tH4iG4IFPoF5m6zgIpyzdBWzp3XFKWA/fE47F9ZqjzbOga9CSUwpeBtoBdQ8qL1As4TXT\n\tntD87xoP+scsFyZ4JSwrk0bvRnYAdiaHZCClG4Q9mYPjpzCiyu2eTQek53x2SbKBcKsb\n\tYscbK4JWv+UKtdUiN743mYp+B7F+QYPhL7XQKF3BW7a53bLmlCtRmEFUg66603NAaXR9\n\t+wUv+cdkzr2g96dwh6oUjphNrUSDB92p2GfpcFMSEpkpMa7CVRH6msndl+oP+d+iIk0d\n\tapbA==","X-Gm-Message-State":"APjAAAU0FPiX7SrnZ3slGAcZ5UYynjFEDZKaleHaTUamSKE4raghULi7\n\tGoosNrSwGG6QO3nBQrSwX+wzzg==","X-Google-Smtp-Source":"APXvYqy1lTb0116RrOvIh0gIvzvWoc/CsbrXglaN1GakjdLghlQ4jboRN/D7AaeIzAecxQJhR+BgJA==","X-Received":"by 2002:ac2:5637:: with SMTP id b23mr5701109lff.73.1573717955219;\n\tWed, 13 Nov 2019 23:52:35 -0800 (PST)","Date":"Thu, 14 Nov 2019 08:52:34 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191114075234.GC7353@bigcity.dyn.berto.se>","References":"<20191104170805.20647-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191104170805.20647-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Remove unneeded\n\tsemicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 14 Nov 2019 07:52:36 -0000"}},{"id":3012,"web_url":"https://patchwork.libcamera.org/comment/3012/","msgid":"<20191114075405.GD7353@bigcity.dyn.berto.se>","date":"2019-11-14T07:54:05","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Remove unneeded\n\tsemicolons","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"On 2019-11-14 08:52:35 +0100, Niklas Söderlund wrote:\n> Hi Laurent,\n> \n> Thanks for your patch.\n> \n> On 2019-11-04 19:08:04 +0200, Laurent Pinchart wrote:\n> > Comply with the coding style by removing lots of unneeded semicolons.\n> > Fix a few other coding style violations on the lines touched by those\n> > fixes.\n> > \n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> For ~PipelineHandlerFactory() and V4L2SubdeviceTest() you also fix the \n> curly brackets which you otherwise fix in 2/2 ;-P\n\nWhich I now see you already mention in the cover letter, my bad.\n\n> \n> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> \n> > ---\n> >  include/ipa/ipa_module_info.h                   | 4 ++--\n> >  include/ipa/ipa_vimc.h                          | 2 +-\n> >  include/libcamera/bound_method.h                | 2 +-\n> >  include/libcamera/object.h                      | 2 +-\n> >  src/cam/event_loop.h                            | 2 +-\n> >  src/cam/options.cpp                             | 2 +-\n> >  src/ipa/ipa_vimc.cpp                            | 4 ++--\n> >  src/ipa/rkisp1/rkisp1.cpp                       | 4 ++--\n> >  src/libcamera/include/ipa_proxy.h               | 2 +-\n> >  src/libcamera/include/pipeline_handler.h        | 2 +-\n> >  src/libcamera/message.cpp                       | 2 +-\n> >  src/libcamera/object.cpp                        | 2 +-\n> >  src/libcamera/pipeline_handler.cpp              | 2 +-\n> >  src/libcamera/proxy/ipa_proxy_linux.cpp         | 2 +-\n> >  src/libcamera/thread.cpp                        | 2 +-\n> >  test/camera/camera_test.cpp                     | 2 +-\n> >  test/v4l2_subdevice/v4l2_subdevice_test.h       | 4 +++-\n> >  test/v4l2_videodevice/v4l2_videodevice_test.cpp | 2 +-\n> >  18 files changed, 23 insertions(+), 21 deletions(-)\n> > \n> > diff --git a/include/ipa/ipa_module_info.h b/include/ipa/ipa_module_info.h\n> > index d9e33c1db1e4..7ecd149566be 100644\n> > --- a/include/ipa/ipa_module_info.h\n> > +++ b/include/ipa/ipa_module_info.h\n> > @@ -23,8 +23,8 @@ struct IPAModuleInfo {\n> >  \n> >  extern \"C\" {\n> >  extern const struct IPAModuleInfo ipaModuleInfo;\n> > -};\n> > +}\n> >  \n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> >  \n> >  #endif /* __LIBCAMERA_IPA_MODULE_INFO_H__ */\n> > diff --git a/include/ipa/ipa_vimc.h b/include/ipa/ipa_vimc.h\n> > index 05b561d80047..9add122cf598 100644\n> > --- a/include/ipa/ipa_vimc.h\n> > +++ b/include/ipa/ipa_vimc.h\n> > @@ -17,6 +17,6 @@ enum IPAOperationCode {\n> >  \tIPAOperationInit,\n> >  };\n> >  \n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> >  \n> >  #endif /* __LIBCAMERA_IPA_VIMC_H__ */\n> > diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> > index bdeb5469cda3..b841a2aed147 100644\n> > --- a/include/libcamera/bound_method.h\n> > +++ b/include/libcamera/bound_method.h\n> > @@ -142,6 +142,6 @@ private:\n> >  \tvoid (*func_)(Args...);\n> >  };\n> >  \n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> >  \n> >  #endif /* __LIBCAMERA_BOUND_METHOD_H__ */\n> > diff --git a/include/libcamera/object.h b/include/libcamera/object.h\n> > index 91b56596c9db..86e0f7265865 100644\n> > --- a/include/libcamera/object.h\n> > +++ b/include/libcamera/object.h\n> > @@ -67,6 +67,6 @@ private:\n> >  \tunsigned int pendingMessages_;\n> >  };\n> >  \n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> >  \n> >  #endif /* __LIBCAMERA_OBJECT_H__ */\n> > diff --git a/src/cam/event_loop.h b/src/cam/event_loop.h\n> > index aaca5838f979..581c7cba2fc4 100644\n> > --- a/src/cam/event_loop.h\n> > +++ b/src/cam/event_loop.h\n> > @@ -13,7 +13,7 @@\n> >  \n> >  namespace libcamera {\n> >  class EventDispatcher;\n> > -};\n> > +}\n> >  \n> >  class EventLoop\n> >  {\n> > diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> > index 1f0631eccfba..7e2dfa636ccf 100644\n> > --- a/src/cam/options.cpp\n> > +++ b/src/cam/options.cpp\n> > @@ -490,7 +490,7 @@ void OptionsParser::usage()\n> >  \t\t\telse\n> >  \t\t\t\targument += \"  \";\n> >  \t\t\targument += std::string(\"--\") + option.name;\n> > -\t\t};\n> > +\t\t}\n> >  \n> >  \t\tif (option.argument != ArgumentNone) {\n> >  \t\t\tif (option.argument == ArgumentOptional)\n> > diff --git a/src/ipa/ipa_vimc.cpp b/src/ipa/ipa_vimc.cpp\n> > index 63d578b4e2aa..9fd5212b0381 100644\n> > --- a/src/ipa/ipa_vimc.cpp\n> > +++ b/src/ipa/ipa_vimc.cpp\n> > @@ -112,6 +112,6 @@ IPAInterface *ipaCreate()\n> >  {\n> >  \treturn new IPAVimc();\n> >  }\n> > -};\n> > +}\n> >  \n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > index 9a13f5c7df17..d741d5677d0e 100644\n> > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > @@ -251,6 +251,6 @@ IPAInterface *ipaCreate()\n> >  {\n> >  \treturn new IPARkISP1();\n> >  }\n> > -};\n> > +}\n> >  \n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> > diff --git a/src/libcamera/include/ipa_proxy.h b/src/libcamera/include/ipa_proxy.h\n> > index 72216662e373..add40b4b3368 100644\n> > --- a/src/libcamera/include/ipa_proxy.h\n> > +++ b/src/libcamera/include/ipa_proxy.h\n> > @@ -36,7 +36,7 @@ class IPAProxyFactory\n> >  {\n> >  public:\n> >  \tIPAProxyFactory(const char *name);\n> > -\tvirtual ~IPAProxyFactory(){};\n> > +\tvirtual ~IPAProxyFactory() {}\n> >  \n> >  \tvirtual std::unique_ptr<IPAProxy> create(IPAModule *ipam) = 0;\n> >  \n> > diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> > index 42b90a4bf1a6..241af58beec0 100644\n> > --- a/src/libcamera/include/pipeline_handler.h\n> > +++ b/src/libcamera/include/pipeline_handler.h\n> > @@ -111,7 +111,7 @@ class PipelineHandlerFactory\n> >  {\n> >  public:\n> >  \tPipelineHandlerFactory(const char *name);\n> > -\tvirtual ~PipelineHandlerFactory() { };\n> > +\tvirtual ~PipelineHandlerFactory() {}\n> >  \n> >  \tstd::shared_ptr<PipelineHandler> create(CameraManager *manager);\n> >  \n> > diff --git a/src/libcamera/message.cpp b/src/libcamera/message.cpp\n> > index daf653221077..c547895362f3 100644\n> > --- a/src/libcamera/message.cpp\n> > +++ b/src/libcamera/message.cpp\n> > @@ -161,4 +161,4 @@ void InvokeMessage::invoke()\n> >   * \\brief The packed method invocation arguments\n> >   */\n> >  \n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> > diff --git a/src/libcamera/object.cpp b/src/libcamera/object.cpp\n> > index db2c6f68fbc8..1f787271f782 100644\n> > --- a/src/libcamera/object.cpp\n> > +++ b/src/libcamera/object.cpp\n> > @@ -223,4 +223,4 @@ void Object::disconnect(SignalBase *signal)\n> >  \t}\n> >  }\n> >  \n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > index bf8c86d35c4f..884feaa6ecbd 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -135,7 +135,7 @@ PipelineHandler::~PipelineHandler()\n> >  {\n> >  \tfor (std::shared_ptr<MediaDevice> media : mediaDevices_)\n> >  \t\tmedia->release();\n> > -};\n> > +}\n> >  \n> >  /**\n> >   * \\fn PipelineHandler::match(DeviceEnumerator *enumerator)\n> > diff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> > index 4e6fa6899e07..27b6639d6312 100644\n> > --- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n> > +++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> > @@ -92,4 +92,4 @@ void IPAProxyLinux::readyRead(IPCUnixSocket *ipc)\n> >  \n> >  REGISTER_IPA_PROXY(IPAProxyLinux)\n> >  \n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> > diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> > index 872ad1bd9d69..e152af14631e 100644\n> > --- a/src/libcamera/thread.cpp\n> > +++ b/src/libcamera/thread.cpp\n> > @@ -495,4 +495,4 @@ void Thread::moveObject(Object *object, ThreadData *currentData,\n> >  \t\tmoveObject(child, currentData, targetData);\n> >  }\n> >  \n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> > diff --git a/test/camera/camera_test.cpp b/test/camera/camera_test.cpp\n> > index 0e105414bf46..101e31fbce79 100644\n> > --- a/test/camera/camera_test.cpp\n> > +++ b/test/camera/camera_test.cpp\n> > @@ -45,4 +45,4 @@ void CameraTest::cleanup()\n> >  \n> >  \tcm_->stop();\n> >  \tdelete cm_;\n> > -};\n> > +}\n> > diff --git a/test/v4l2_subdevice/v4l2_subdevice_test.h b/test/v4l2_subdevice/v4l2_subdevice_test.h\n> > index 96646a155536..3bce6691f8ef 100644\n> > --- a/test/v4l2_subdevice/v4l2_subdevice_test.h\n> > +++ b/test/v4l2_subdevice/v4l2_subdevice_test.h\n> > @@ -21,7 +21,9 @@ class V4L2SubdeviceTest : public Test\n> >  {\n> >  public:\n> >  \tV4L2SubdeviceTest()\n> > -\t\t: scaler_(nullptr){};\n> > +\t\t: scaler_(nullptr)\n> > +\t{\n> > +\t}\n> >  \n> >  protected:\n> >  \tint init() override;\n> > diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.cpp b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> > index 096f9649bfc9..577da4cb601c 100644\n> > --- a/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> > +++ b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> > @@ -99,4 +99,4 @@ void V4L2VideoDeviceTest::cleanup()\n> >  \tdelete debayer_;\n> >  \tdelete sensor_;\n> >  \tdelete capture_;\n> > -};\n> > +}\n> > -- \n> > Regards,\n> > \n> > Laurent Pinchart\n> > \n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n> \n> -- \n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5BF0360C33\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 14 Nov 2019 08:54:07 +0100 (CET)","by mail-lj1-x244.google.com with SMTP id d5so5580524ljl.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Nov 2019 23:54:07 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tv22sm2675634lfg.63.2019.11.13.23.54.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Nov 2019 23:54:06 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=woX99zZXyTM2355qmKGovD/wE5tVP3I28ipFundFOI4=;\n\tb=mcL2rUvxC9VwDDbC2Hfl2cy50Fc72EN3hKOU5PMMg9ySasjqtsaUpMqbMkknliux1D\n\tknO51gcd6Sw3zR3LvL6m75deJi4DA/C1D2PmplMqN/jxHPbOmu5bnHU2e0TjtpPhb0hV\n\thR5PJq354zenca+RW/VBYFdGVoV2zDHhJ96tMoljgjKE6KCSa1OerDRZfaqYPxegSwuP\n\tskLqH2CjXhXuMJOIBORFSLC4NdvdTnQ9LmDRCVLNPSgL2W4ayhhn0BqIgaODFFtR/b4v\n\t2BXwl+f1dULN07SnX2AST7kI1gr6mbvwATArC1Y28zg4XDuLCzPN2T/hIr4yqbVevWiO\n\t+0uQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=woX99zZXyTM2355qmKGovD/wE5tVP3I28ipFundFOI4=;\n\tb=hFGTxkPB+uxdJs2coZunpEnvPFOrU8pXyMQYCRi9jWJ2PzizpDIEyYh/W1uY6FR2QS\n\txk1ZUw59M5GifSacidjdQjnvOHb6PaqbEpsFQcKHDoj2o4CK65ABtcbqPFhLPnyEtJI0\n\tN8VjPOEKXd7JjPO6NyQUtdO04RWDlleoWCNzIypttbkq3lWGlHX2Qj7AIV20R8sslxdS\n\tNMFh1eS5syYIeDxS3Z39oB7fljOALytvURxS9hXvukvNo3nAGaq/i6Ac53B6f7rA5riS\n\t8XScueR5baL4RehW2bpZp/n+QTujCnw8VInGYbNXM7U0Sd1YVJiHLwNpj2XxBNcF0tif\n\tSGAw==","X-Gm-Message-State":"APjAAAUpFldtwYkuHnXoACBA04JVzKyVayEMjmMAFWHbnkL0ET8ZiHHA\n\te7ScgS2gmKJsNQROAUhH28GnNw==","X-Google-Smtp-Source":"APXvYqz4xNInQdyk/LDQO6xCy2vocR+7GrVbBfADCU7ibres+a7t0BFlwpyORt34J6gEMtjlkOSgrw==","X-Received":"by 2002:a2e:8151:: with SMTP id t17mr5509078ljg.95.1573718046746;\n\tWed, 13 Nov 2019 23:54:06 -0800 (PST)","Date":"Thu, 14 Nov 2019 08:54:05 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191114075405.GD7353@bigcity.dyn.berto.se>","References":"<20191104170805.20647-1-laurent.pinchart@ideasonboard.com>\n\t<20191114075234.GC7353@bigcity.dyn.berto.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191114075234.GC7353@bigcity.dyn.berto.se>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Remove unneeded\n\tsemicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 14 Nov 2019 07:54:07 -0000"}}]