[{"id":33576,"web_url":"https://patchwork.libcamera.org/comment/33576/","msgid":"<174109911623.2914008.182676048480019032@ping.linuxembedded.co.uk>","date":"2025-03-04T14:38:36","subject":"Re: [PATCH] README.rst: Remove duplicate Python entry","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2025-03-04 11:02:36)\n> Commit 36753f5cbbcd (\"README.rst: Report py dependencies\")\n> dropped the requirement for libpython3-dev but did that by introducing\n> a duplicated entry for the Python bindings in the dependencies\n> description.\n> \n> Fix that by removing the outdated entry.\n> \n> Fixes: 36753f5cbbcd (\"README.rst: Report py dependencies\")\n> Signed-off-by: Jacopo Mondi \n> ---\n> README.rst | 3 ---\n> 1 file changed, 3 deletions(-)\n> \n> diff --git a/README.rst b/README.rst\n> index 4068c6cc83ca..d8b6ec2208fb 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -72,9 +72,6 @@ for documentation: [optional]\n> for gstreamer: [optional]\n> libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> \n> -for Python bindings: [optional]\n> - libpython3-dev pybind11-dev\n\nI believe both of these are required. It looks like my patch\n36753f5cbbcd7c9e00fa3657d918cbe298f48c9c was just plain wrong and\nperhaps should just be reverted!\n\nI would very much like to keep libpython3-dev as a dependency as it's\ncertainly required! ( I discovered that when cross compiling in a\ncontainer for RPi - it fails to build the python bindings if you don't\nhave libpython3-dev! )\n\n--\nKieran\n\n> -\n> for cam: [optional]\n> libevent-dev is required to support cam, however the following\n> optional dependencies bring more functionality to the cam test\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CBDD2C3257\n\tfor ;\n\tTue, 4 Mar 2025 14:38:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DC4D68779;\n\tTue, 4 Mar 2025 15:38:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BC4E68755\n\tfor ;\n\tTue, 4 Mar 2025 15:38:39 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA8B7E8A;\n\tTue, 4 Mar 2025 15:37:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SrnXNVsi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741099027;\n\tbh=LsDV/pl4wBVtnQS7DNC8WH9s/ojNR/mXmsBo5ulSmHk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=SrnXNVsi7DJLw7/0NxSeqqEf2JoHFxKCC+QtyV/Whgb66/rfpbQwv+yK++3ppeGp9\n\tVbu3fJg2LuG2lT3WuFynN2/1i/kQeXDskMuIciWw6mthLk+nlFW2KiNTp0SzonJPd/\n\troRj/FZzHV41HiqVI/igglZ03cNtZmY2S7ktEE7c=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250304110239.51729-1-jacopo.mondi@ideasonboard.com>","References":"<20250304110239.51729-1-jacopo.mondi@ideasonboard.com>","Subject":"Re: [PATCH] README.rst: Remove duplicate Python entry","From":"Kieran Bingham ","Cc":"Jacopo Mondi ","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 04 Mar 2025 14:38:36 +0000","Message-ID":"<174109911623.2914008.182676048480019032@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33577,"web_url":"https://patchwork.libcamera.org/comment/33577/","msgid":"","date":"2025-03-04T16:38:36","subject":"Re: [PATCH] README.rst: Remove duplicate Python entry","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Tue, Mar 04, 2025 at 02:38:36PM +0000, Kieran Bingham wrote:\n> Quoting Jacopo Mondi (2025-03-04 11:02:36)\n> > Commit 36753f5cbbcd (\"README.rst: Report py dependencies\")\n> > dropped the requirement for libpython3-dev but did that by introducing\n> > a duplicated entry for the Python bindings in the dependencies\n> > description.\n> >\n> > Fix that by removing the outdated entry.\n> >\n> > Fixes: 36753f5cbbcd (\"README.rst: Report py dependencies\")\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > README.rst | 3 ---\n> > 1 file changed, 3 deletions(-)\n> >\n> > diff --git a/README.rst b/README.rst\n> > index 4068c6cc83ca..d8b6ec2208fb 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -72,9 +72,6 @@ for documentation: [optional]\n> > for gstreamer: [optional]\n> > libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> >\n> > -for Python bindings: [optional]\n> > - libpython3-dev pybind11-dev\n>\n> I believe both of these are required. It looks like my patch\n> 36753f5cbbcd7c9e00fa3657d918cbe298f48c9c was just plain wrong and\n> perhaps should just be reverted!\n>\n> I would very much like to keep libpython3-dev as a dependency as it's\n> certainly required! ( I discovered that when cross compiling in a\n> container for RPi - it fails to build the python bindings if you don't\n> have libpython3-dev! )\n\nI litterally just hit that.\n\nI'll send a patch to remote the entry added by\n36753f5cbbcd7c9e00fa3657d918cbe298f48c9c\n>\n> --\n> Kieran\n>\n> > -\n> > for cam: [optional]\n> > libevent-dev is required to support cam, however the following\n> > optional dependencies bring more functionality to the cam test\n> > --\n> > 2.48.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 687D1C32DC\n\tfor ;\n\tTue, 4 Mar 2025 16:38:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 671BE68777;\n\tTue, 4 Mar 2025 17:38:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B67E68755\n\tfor ;\n\tTue, 4 Mar 2025 17:38:40 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DAD2E7E6;\n\tTue, 4 Mar 2025 17:37:07 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qP458pqK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741106228;\n\tbh=l0eMd85iYQWwtykdMK4vFPy88EirfHkBTAN5kz0hSoY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qP458pqKiBcgrFvw89WpDyiWSrvDq4LVLaH+pehNTXbwxr7MyxnsFJOMQyom7wDT/\n\tMcUzgd3yLc3J9FEMRP+1wiYxi4UC5VwDO+Fk1x/X/Zk9lj5jDV9YCwn5Plvp7BUhal\n\tto5AkIW/T12VvpVHyJHOIn00HcCHlBcornzivab4=","Date":"Tue, 4 Mar 2025 17:38:36 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Cc":"Jacopo Mondi , \n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] README.rst: Remove duplicate Python entry","Message-ID":"","References":"<20250304110239.51729-1-jacopo.mondi@ideasonboard.com>\n\t<174109911623.2914008.182676048480019032@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<174109911623.2914008.182676048480019032@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]