[{"id":33550,"web_url":"https://patchwork.libcamera.org/comment/33550/","msgid":"<20250303205816.GC23684@pendragon.ideasonboard.com>","date":"2025-03-03T20:58:16","subject":"Re: [PATCH v1] apps: cam: file_sink: Add missing include","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Mon, Mar 03, 2025 at 08:33:45PM +0100, Barnabás Pőcze wrote:\n> The `ControlList` is needed for the member function declarations,\n> but it is not included, so include it. This has not bee noticed\n\ns/bee/been/\n\n> because `file_sink.cpp` does not include `file_sink.hpp` first,\n\ns/hpp/h/\n\n> so change that as well.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/apps/cam/file_sink.cpp | 4 ++--\n> src/apps/cam/file_sink.h | 1 +\n> 2 files changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/apps/cam/file_sink.cpp b/src/apps/cam/file_sink.cpp\n> index 76e21db9b..65794a2f9 100644\n> --- a/src/apps/cam/file_sink.cpp\n> +++ b/src/apps/cam/file_sink.cpp\n> @@ -5,6 +5,8 @@\n> * File Sink\n> */\n> \n> +#include \"file_sink.h\"\n> +\n> #include \n> #include \n> #include \n> @@ -21,8 +23,6 @@\n> #include \"../common/image.h\"\n> #include \"../common/ppm_writer.h\"\n> \n> -#include \"file_sink.h\"\n> -\n> using namespace libcamera;\n> \n> FileSink::FileSink([[maybe_unused]] const libcamera::Camera *camera,\n> diff --git a/src/apps/cam/file_sink.h b/src/apps/cam/file_sink.h\n> index 71b7fe0fe..26cd61b36 100644\n> --- a/src/apps/cam/file_sink.h\n> +++ b/src/apps/cam/file_sink.h\n> @@ -11,6 +11,7 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> \n> #include \"frame_sink.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E989ABD808\n\tfor ;\n\tMon, 3 Mar 2025 20:58:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1379868777;\n\tMon, 3 Mar 2025 21:58:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2B0E68772\n\tfor ;\n\tMon, 3 Mar 2025 21:58:37 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8F7A8DB;\n\tMon, 3 Mar 2025 21:57:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QjUZN/CN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741035425;\n\tbh=PeHnSWNYItIKdcY+iIXF75lY+JXAY4TSQ+g/HIun7/s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QjUZN/CNGk502Zowb4DUvwxjj2J9GGDniFBNdvXjTmGD9BI5houcpcRFExa27PU9b\n\tN8P0XHMXdcriYPw406bM3MxRC8p9GXah6IfbHR1CzZxGLTnqGA7XS8nYYkSW8HWVha\n\tWOTPCM8t9E/zmCL/hb0NzBN9TC3c8chLxZl/L/q8=","Date":"Mon, 3 Mar 2025 22:58:16 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] apps: cam: file_sink: Add missing include","Message-ID":"<20250303205816.GC23684@pendragon.ideasonboard.com>","References":"<20250303193345.785661-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250303193345.785661-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33565,"web_url":"https://patchwork.libcamera.org/comment/33565/","msgid":"<174108279015.2914008.7493478937854699888@ping.linuxembedded.co.uk>","date":"2025-03-04T10:06:30","subject":"Re: [PATCH v1] apps: cam: file_sink: Add missing include","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-03-03 20:58:16)\n> Hi Barnabás,\n> \n> Thank you for the patch.\n> \n> On Mon, Mar 03, 2025 at 08:33:45PM +0100, Barnabás Pőcze wrote:\n> > The `ControlList` is needed for the member function declarations,\n> > but it is not included, so include it. This has not bee noticed\n> \n> s/bee/been/\n> \n> > because `file_sink.cpp` does not include `file_sink.hpp` first,\n> \n> s/hpp/h/\n> \n> > so change that as well.\n> > \n> > Signed-off-by: Barnabás Pőcze \n> \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> \n> > ---\n> > src/apps/cam/file_sink.cpp | 4 ++--\n> > src/apps/cam/file_sink.h | 1 +\n> > 2 files changed, 3 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/apps/cam/file_sink.cpp b/src/apps/cam/file_sink.cpp\n> > index 76e21db9b..65794a2f9 100644\n> > --- a/src/apps/cam/file_sink.cpp\n> > +++ b/src/apps/cam/file_sink.cpp\n> > @@ -5,6 +5,8 @@\n> > * File Sink\n> > */\n> > \n> > +#include \"file_sink.h\"\n> > +\n> > #include \n> > #include \n> > #include \n> > @@ -21,8 +23,6 @@\n> > #include \"../common/image.h\"\n> > #include \"../common/ppm_writer.h\"\n> > \n> > -#include \"file_sink.h\"\n> > -\n> > using namespace libcamera;\n> > \n> > FileSink::FileSink([[maybe_unused]] const libcamera::Camera *camera,\n> > diff --git a/src/apps/cam/file_sink.h b/src/apps/cam/file_sink.h\n> > index 71b7fe0fe..26cd61b36 100644\n> > --- a/src/apps/cam/file_sink.h\n> > +++ b/src/apps/cam/file_sink.h\n> > @@ -11,6 +11,7 @@\n> > #include \n> > #include \n> > \n> > +#include \n> > #include \n> > \n> > #include \"frame_sink.h\"\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EAEEC3257\n\tfor ;\n\tTue, 4 Mar 2025 10:06:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F205B68779;\n\tTue, 4 Mar 2025 11:06:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D715068754\n\tfor ;\n\tTue, 4 Mar 2025 11:06:32 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0B971083;\n\tTue, 4 Mar 2025 11:05:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pHupx0T6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741082701;\n\tbh=8+NCE2yik4YEf2QRwH/HdgdG8TE8QfC6mdnnfOz0IqY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=pHupx0T6OJywXJZiFe9nc8QPKaT2u3T2qvRnCkTTLQ0eQyDTky5SToh3/OOmArgHC\n\tSjPx9fwzcGfec41D4edz06xSOP8XjWUNjFNE/LVyaBKw/m9ROb3Ilc85VixnLnh2Df\n\tCmy7aCbJeBfvTHh77ghRD5d+ZX2jZmqnFZjPucs0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250303205816.GC23684@pendragon.ideasonboard.com>","References":"<20250303193345.785661-1-barnabas.pocze@ideasonboard.com>\n\t<20250303205816.GC23684@pendragon.ideasonboard.com>","Subject":"Re: [PATCH v1] apps: cam: file_sink: Add missing include","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tLaurent Pinchart ","Date":"Tue, 04 Mar 2025 10:06:30 +0000","Message-ID":"<174108279015.2914008.7493478937854699888@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]