{"id":22916,"url":"https://patchwork.libcamera.org/api/patches/22916/?format=json","web_url":"https://patchwork.libcamera.org/patch/22916/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250303193345.785661-1-barnabas.pocze@ideasonboard.com>","date":"2025-03-03T19:33:45","name":"[v1] apps: cam: file_sink: Add missing include","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"48fab211ccbce135010d90513d8355a1ebb34ec8","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22916/mbox/","series":[{"id":5041,"url":"https://patchwork.libcamera.org/api/series/5041/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5041","date":"2025-03-03T19:33:45","name":"[v1] apps: cam: file_sink: Add missing include","version":1,"mbox":"https://patchwork.libcamera.org/series/5041/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22916/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22916/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8FE4EBD808\n\tfor ;\n\tMon, 3 Mar 2025 19:33:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4940B68889;\n\tMon, 3 Mar 2025 20:33:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E6F76884F\n\tfor ;\n\tMon, 3 Mar 2025 20:33:48 +0100 (CET)","from pb-laptop.local (185.221.143.4.nat.pool.zt.hu [185.221.143.4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 19AF4346\n\tfor ;\n\tMon, 3 Mar 2025 20:32:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JeQ/AWJ1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741030337;\n\tbh=74JbFO6LWPwdoJinllqW1KD3vNd29wI/dkm9SHv96Wc=;\n\th=From:To:Subject:Date:From;\n\tb=JeQ/AWJ1roDO6XOVJc7UKmWmMf3gACmIycQJHoItde7XLy/THQsHLut5d25vThYkJ\n\t1nfdBkAJX1VFj+XSgbQC0DWdXA6be+6HfZNgQSNSmb82Egjr8CwOQa1tYBa7Lu1hDb\n\t1/x1y7odlCO+1AzoF1msXFHIivG5C0zOJhxd5n7c=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] apps: cam: file_sink: Add missing include","Date":"Mon, 3 Mar 2025 20:33:45 +0100","Message-ID":"<20250303193345.785661-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The `ControlList` is needed for the member function declarations,\nbut it is not included, so include it. This has not bee noticed\nbecause `file_sink.cpp` does not include `file_sink.hpp` first,\nso change that as well.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/apps/cam/file_sink.cpp | 4 ++--\n src/apps/cam/file_sink.h | 1 +\n 2 files changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/src/apps/cam/file_sink.cpp b/src/apps/cam/file_sink.cpp\nindex 76e21db9b..65794a2f9 100644\n--- a/src/apps/cam/file_sink.cpp\n+++ b/src/apps/cam/file_sink.cpp\n@@ -5,6 +5,8 @@\n * File Sink\n */\n \n+#include \"file_sink.h\"\n+\n #include \n #include \n #include \n@@ -21,8 +23,6 @@\n #include \"../common/image.h\"\n #include \"../common/ppm_writer.h\"\n \n-#include \"file_sink.h\"\n-\n using namespace libcamera;\n \n FileSink::FileSink([[maybe_unused]] const libcamera::Camera *camera,\ndiff --git a/src/apps/cam/file_sink.h b/src/apps/cam/file_sink.h\nindex 71b7fe0fe..26cd61b36 100644\n--- a/src/apps/cam/file_sink.h\n+++ b/src/apps/cam/file_sink.h\n@@ -11,6 +11,7 @@\n #include \n #include \n \n+#include \n #include \n \n #include \"frame_sink.h\"\n","prefixes":["v1"]}