[{"id":33552,"web_url":"https://patchwork.libcamera.org/comment/33552/","msgid":"<20250303205956.GE23684@pendragon.ideasonboard.com>","date":"2025-03-03T20:59:56","subject":"Re: [PATCH v1] libcamera: base: mutex: Remove unnecessary\n\tconstructors","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Mon, Mar 03, 2025 at 08:33:30PM +0100, Barnabás Pőcze wrote:\n> The compiler defined default constructor works perfectly fine.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/base/mutex.h | 8 --------\n> 1 file changed, 8 deletions(-)\n> \n> diff --git a/include/libcamera/base/mutex.h b/include/libcamera/base/mutex.h\n> index fa9a8d0dc..20ebe6fee 100644\n> --- a/include/libcamera/base/mutex.h\n> +++ b/include/libcamera/base/mutex.h\n> @@ -23,10 +23,6 @@ namespace libcamera {\n> class LIBCAMERA_TSA_CAPABILITY(\"mutex\") Mutex final\n> {\n> public:\n> -\tconstexpr Mutex()\n> -\t{\n> -\t}\n> -\n> \tvoid lock() LIBCAMERA_TSA_ACQUIRE()\n> \t{\n> \t\tmutex_.lock();\n> @@ -84,10 +80,6 @@ private:\n> class ConditionVariable final\n> {\n> public:\n> -\tConditionVariable()\n> -\t{\n> -\t}\n> -\n> \tvoid notify_one() noexcept\n> \t{\n> \t\tcv_.notify_one();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6B81BD808\n\tfor ;\n\tMon, 3 Mar 2025 21:00:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8133F68779;\n\tMon, 3 Mar 2025 22:00:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9541468772\n\tfor ;\n\tMon, 3 Mar 2025 22:00:17 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7CAE8DB;\n\tMon, 3 Mar 2025 21:58:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jeOVCmI3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741035526;\n\tbh=0iesvgB9J5VC1oQ3JVZbZVqTeDWBnT/wPmILdfEfNgU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jeOVCmI3/KPhuV+OdLKAYn4efpMovojn3QNsMY9kcDkCuCtr0QHdilrQfuZo2n/Eb\n\txuor+UXrPNRmofAB09iTSkowdzc7a/SyqWbXu5p3QfGNN0dAuoZ1GmQfJJ52/KamOl\n\t+IjXm8F9xe5lXdl8TyEh8kTKo+3WulkUh8GfEPqg=","Date":"Mon, 3 Mar 2025 22:59:56 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: base: mutex: Remove unnecessary\n\tconstructors","Message-ID":"<20250303205956.GE23684@pendragon.ideasonboard.com>","References":"<20250303193330.785575-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250303193330.785575-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33563,"web_url":"https://patchwork.libcamera.org/comment/33563/","msgid":"<174108267512.2914008.8966111647313104348@ping.linuxembedded.co.uk>","date":"2025-03-04T10:04:35","subject":"Re: [PATCH v1] libcamera: base: mutex: Remove unnecessary\n\tconstructors","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-03-03 19:33:30)\n> The compiler defined default constructor works perfectly fine.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/base/mutex.h | 8 --------\n> 1 file changed, 8 deletions(-)\n> \n> diff --git a/include/libcamera/base/mutex.h b/include/libcamera/base/mutex.h\n> index fa9a8d0dc..20ebe6fee 100644\n> --- a/include/libcamera/base/mutex.h\n> +++ b/include/libcamera/base/mutex.h\n> @@ -23,10 +23,6 @@ namespace libcamera {\n> class LIBCAMERA_TSA_CAPABILITY(\"mutex\") Mutex final\n> {\n> public:\n> - constexpr Mutex()\n> - {\n> - }\n> -\n> void lock() LIBCAMERA_TSA_ACQUIRE()\n> {\n> mutex_.lock();\n> @@ -84,10 +80,6 @@ private:\n> class ConditionVariable final\n> {\n> public:\n> - ConditionVariable()\n> - {\n> - }\n> -\n> void notify_one() noexcept\n> {\n> cv_.notify_one();\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6F9FC3257\n\tfor ;\n\tTue, 4 Mar 2025 10:04:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 526AB68822;\n\tTue, 4 Mar 2025 11:04:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 536A568754\n\tfor ;\n\tTue, 4 Mar 2025 11:04:37 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 627AE1083;\n\tTue, 4 Mar 2025 11:03:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RvAUVjoF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741082585;\n\tbh=dbfUlidWGv6WulN3tQTQxHUisJIyeIM87LQQQbHlha8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=RvAUVjoFLWBQC12xAKywhVFCbNPGP6b2kiyxz+9OA51hKEnxADFu1NSF0KpFICHh2\n\tfSFddkdfBdr2GMTeN19LHqeIhbFHGjQxSBJiVYWP7Snekpug/7q0KepQTtF8zCHJ0p\n\tEQ7HS/T93deK0tc/lvlJKOxMDVsr8f6LsehJr3R4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250303193330.785575-1-barnabas.pocze@ideasonboard.com>","References":"<20250303193330.785575-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] libcamera: base: mutex: Remove unnecessary\n\tconstructors","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 04 Mar 2025 10:04:35 +0000","Message-ID":"<174108267512.2914008.8966111647313104348@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]