{"id":22908,"url":"https://patchwork.libcamera.org/api/patches/22908/?format=json","web_url":"https://patchwork.libcamera.org/patch/22908/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250303152616.739193-1-barnabas.pocze@ideasonboard.com>","date":"2025-03-03T15:26:16","name":"[v1] libcamera: media_object: Fix unnecessary copy","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a1b0292c9b65795db602361ec2fa2fa569c3bd97","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22908/mbox/","series":[{"id":5036,"url":"https://patchwork.libcamera.org/api/series/5036/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5036","date":"2025-03-03T15:26:16","name":"[v1] libcamera: media_object: Fix unnecessary copy","version":1,"mbox":"https://patchwork.libcamera.org/series/5036/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22908/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22908/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3F2EBD808\n\tfor ;\n\tMon, 3 Mar 2025 15:26:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E20868777;\n\tMon, 3 Mar 2025 16:26:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4976D68772\n\tfor ;\n\tMon, 3 Mar 2025 16:26:20 +0100 (CET)","from pb-laptop.local (185.221.143.4.nat.pool.zt.hu [185.221.143.4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CBEA92D5\n\tfor ;\n\tMon, 3 Mar 2025 16:24:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"b2OzN8Kk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741015488;\n\tbh=Gj7vqcaWys7bGVQK26vq/PpS+wa6hByjYVNNRHoYlHo=;\n\th=From:To:Subject:Date:From;\n\tb=b2OzN8KkCpKcqHjAlcDCr9eFZM1/t2AqdesRhIPbbv/3BsAEnaHufLyuj58x8ibTq\n\tWpYmk8iBh14vmbi4wQ76Lk7yAWln1AxLYcEb1YgKZWSqrslkWqjLqO2cEDYBqOks/L\n\tzgpIjEJhAhhvv/rRNZw2Pg/7Mk8fLCE5mx8Rpbgw=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: media_object: Fix unnecessary copy","Date":"Mon, 3 Mar 2025 16:26:16 +0100","Message-ID":"<20250303152616.739193-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`MediaEntity::ancillaryEntities()` can just return a const lvalue\nreference to the underlying array, a copy need not be made. That\nwas likely the original intention.\n\nFixes: 9490c664b57a6c (\"libcamera: Add members to MediaEntity to support ancillary entities\")\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/internal/media_object.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\nindex 9356d204d..54e2e5cef 100644\n--- a/include/libcamera/internal/media_object.h\n+++ b/include/libcamera/internal/media_object.h\n@@ -112,7 +112,7 @@ public:\n \tunsigned int deviceMinor() const { return minor_; }\n \n \tconst std::vector &pads() const { return pads_; }\n-\tconst std::vector ancillaryEntities() const { return ancillaryEntities_; }\n+\tconst std::vector &ancillaryEntities() const { return ancillaryEntities_; }\n \n \tconst MediaPad *getPadByIndex(unsigned int index) const;\n \tconst MediaPad *getPadById(unsigned int id) const;\n","prefixes":["v1"]}