[{"id":33534,"web_url":"https://patchwork.libcamera.org/comment/33534/","msgid":"","date":"2025-03-03T10:41:58","subject":"Re: [PATCH] libcamera: base: log: Fix uninitialized variable warning","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n\n2025. március 2., vasárnap 3:09 keltezéssel, Laurent Pinchart írta:\n\n> gcc 13.3.0, cross-compiling from amd64 to arm64, warns about a possibly\n> uninitialized variable in Logger::parseLogLevel():\n\nYet it has no problems with it when not cross compiling:\nhttps://gitlab.freedesktop.org/camera/libcamera/-/jobs/71959259 ...\n\n> \n> src/libcamera/base/log.cpp: In static member function ‘static libcamera::LogSeverity libcamera::Logger::parseLogLevel(std::string_view)’:\n> ../../src/libcamera/base/log.cpp:694:55: error: ‘severity’ may be used uninitialized [-Werror=maybe-uninitialized]\n> 694 | if (ec != std::errc() || *end != '\\0' || severity > LogFatal)\n> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~\n> src/libcamera/base/log.cpp:690:22: note: ‘severity’ was declared here\n> 690 | unsigned int severity;\n> | ^~~~~~~~\n> \n> This appears to be a false positive, as the std::from_chars() function\n> should set severity value when it returns without an error. Still, the\n> warning is easy to solve, so fix it by initializing the severity\n> variable.\n\nI am pretty sure it is false positive, barring any bugs in from_chars(), unfortunate...\n\n\nRegards,\nBarnabás Pőcze\n\n\n> \n> Fixes: 8fa119e0b50f (\"libcamera: base: log: Use `std::from_chars()`\")\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/base/log.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> index 6a040b59290a..8bf3e1daa9c6 100644\n> --- a/src/libcamera/base/log.cpp\n> +++ b/src/libcamera/base/log.cpp\n> @@ -687,14 +687,13 @@ LogSeverity Logger::parseLogLevel(std::string_view level)\n> \t\t\"FATAL\",\n> \t};\n> \n> -\tunsigned int severity;\n> +\tunsigned int severity = LogInvalid;\n> \n> \tif (std::isdigit(level[0])) {\n> \t\tauto [end, ec] = std::from_chars(level.data(), level.data() + level.size(), severity);\n> \t\tif (ec != std::errc() || *end != '\\0' || severity > LogFatal)\n> \t\t\tseverity = LogInvalid;\n> \t} else {\n> -\t\tseverity = LogInvalid;\n> \t\tfor (unsigned int i = 0; i < std::size(names); ++i) {\n> \t\t\tif (names[i] == level) {\n> \t\t\t\tseverity = i;\n> \n> base-commit: c0a58b97989f7d529f1469b2c2f8705ff55d3af4\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B357FC3263\n\tfor ;\n\tMon, 3 Mar 2025 10:42:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8760768778;\n\tMon, 3 Mar 2025 11:42:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0322068772\n\tfor ;\n\tMon, 3 Mar 2025 11:42:01 +0100 (CET)","from [192.168.33.24] (185.182.215.238.nat.pool.zt.hu\n\t[185.182.215.238])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 727F9346;\n\tMon, 3 Mar 2025 11:40:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uN6wVpvC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740998430;\n\tbh=nZtAzAaJzSJQ9kkNlGVrtBJLGyLdwaufVGqbuklhhhQ=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=uN6wVpvCea24karqUR7cU4tiYktdku+yvCMGzuzq8CYZvWKo0JEZwn3GlZGIbcDqP\n\trVZVn+jxDhvMakFdHUa9Wnhbk4fE0JK6W7EmHPlUwTpGKD0R70AveU2DPaqs2SvD+X\n\t/fF/rk2LSvQORIo3ZEJZ+Y2eTDb0BWPYwpoap4Eg=","Message-ID":"","Date":"Mon, 3 Mar 2025 11:41:58 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: base: log: Fix uninitialized variable warning","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250302020903.24077-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US, hu-HU","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","In-Reply-To":"<20250302020903.24077-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33535,"web_url":"https://patchwork.libcamera.org/comment/33535/","msgid":"<20250303104829.GQ18557@pendragon.ideasonboard.com>","date":"2025-03-03T10:48:29","subject":"Re: [PATCH] libcamera: base: log: Fix uninitialized variable warning","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Mar 03, 2025 at 11:41:58AM +0100, Barnabás Pőcze wrote:\n> 2025. március 2., vasárnap 3:09 keltezéssel, Laurent Pinchart írta:\n> \n> > gcc 13.3.0, cross-compiling from amd64 to arm64, warns about a possibly\n> > uninitialized variable in Logger::parseLogLevel():\n> \n> Yet it has no problems with it when not cross compiling:\n> https://gitlab.freedesktop.org/camera/libcamera/-/jobs/71959259 ...\n> \n> > \n> > src/libcamera/base/log.cpp: In static member function ‘static libcamera::LogSeverity libcamera::Logger::parseLogLevel(std::string_view)’:\n> > ../../src/libcamera/base/log.cpp:694:55: error: ‘severity’ may be used uninitialized [-Werror=maybe-uninitialized]\n> > 694 | if (ec != std::errc() || *end != '\\0' || severity > LogFatal)\n> > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~\n> > src/libcamera/base/log.cpp:690:22: note: ‘severity’ was declared here\n> > 690 | unsigned int severity;\n> > | ^~~~~~~~\n> > \n> > This appears to be a false positive, as the std::from_chars() function\n> > should set severity value when it returns without an error. Still, the\n> > warning is easy to solve, so fix it by initializing the severity\n> > variable.\n> \n> I am pretty sure it is false positive, barring any bugs in from_chars(), unfortunate...\n\nI'm pretty sure as well, but I don't really see an alternative to this\npatch for the time being.\n\n> > Fixes: 8fa119e0b50f (\"libcamera: base: log: Use `std::from_chars()`\")\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/base/log.cpp | 3 +--\n> > 1 file changed, 1 insertion(+), 2 deletions(-)\n> > \n> > diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> > index 6a040b59290a..8bf3e1daa9c6 100644\n> > --- a/src/libcamera/base/log.cpp\n> > +++ b/src/libcamera/base/log.cpp\n> > @@ -687,14 +687,13 @@ LogSeverity Logger::parseLogLevel(std::string_view level)\n> > \t\t\"FATAL\",\n> > \t};\n> > \n> > -\tunsigned int severity;\n> > +\tunsigned int severity = LogInvalid;\n> > \n> > \tif (std::isdigit(level[0])) {\n> > \t\tauto [end, ec] = std::from_chars(level.data(), level.data() + level.size(), severity);\n> > \t\tif (ec != std::errc() || *end != '\\0' || severity > LogFatal)\n> > \t\t\tseverity = LogInvalid;\n> > \t} else {\n> > -\t\tseverity = LogInvalid;\n> > \t\tfor (unsigned int i = 0; i < std::size(names); ++i) {\n> > \t\t\tif (names[i] == level) {\n> > \t\t\t\tseverity = i;\n> > \n> > base-commit: c0a58b97989f7d529f1469b2c2f8705ff55d3af4","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EEB87BD808\n\tfor ;\n\tMon, 3 Mar 2025 10:48:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2318B68778;\n\tMon, 3 Mar 2025 11:48:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E1B968772\n\tfor ;\n\tMon, 3 Mar 2025 11:48:50 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1192D346;\n\tMon, 3 Mar 2025 11:47:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r2H9Ho8o\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740998839;\n\tbh=EMdIocSOX5+/2w5CW1ao3QxAMZ45plaQxmFVB4umGF0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=r2H9Ho8obJepXjE1LSORkREqbww+UtjXaZe35bruPQWZpVmmagqjLDjga0mk+FoA3\n\tETYUuvtV77moVzpTV46ttTaT62aXwu6sCICMoOVC5vYVJAaRIlkfn2KyLSs0ho+M2Q\n\tDkhzyNtbBid0to/KUZotT0gloEKB7UHgxjgU9onk=","Date":"Mon, 3 Mar 2025 12:48:29 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: base: log: Fix uninitialized variable warning","Message-ID":"<20250303104829.GQ18557@pendragon.ideasonboard.com>","References":"<20250302020903.24077-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33538,"web_url":"https://patchwork.libcamera.org/comment/33538/","msgid":"<174100604020.2914008.4620858382489161032@ping.linuxembedded.co.uk>","date":"2025-03-03T12:47:20","subject":"Re: [PATCH] libcamera: base: log: Fix uninitialized variable warning","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-03-03 10:48:29)\n> On Mon, Mar 03, 2025 at 11:41:58AM +0100, Barnabás Pőcze wrote:\n> > 2025. március 2., vasárnap 3:09 keltezéssel, Laurent Pinchart írta:\n> > \n> > > gcc 13.3.0, cross-compiling from amd64 to arm64, warns about a possibly\n> > > uninitialized variable in Logger::parseLogLevel():\n> > \n> > Yet it has no problems with it when not cross compiling:\n> > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/71959259 ...\n> > \n> > > \n> > > src/libcamera/base/log.cpp: In static member function ‘static libcamera::LogSeverity libcamera::Logger::parseLogLevel(std::string_view)’:\n> > > ../../src/libcamera/base/log.cpp:694:55: error: ‘severity’ may be used uninitialized [-Werror=maybe-uninitialized]\n> > > 694 | if (ec != std::errc() || *end != '\\0' || severity > LogFatal)\n> > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~\n> > > src/libcamera/base/log.cpp:690:22: note: ‘severity’ was declared here\n> > > 690 | unsigned int severity;\n> > > | ^~~~~~~~\n> > > \n> > > This appears to be a false positive, as the std::from_chars() function\n> > > should set severity value when it returns without an error. Still, the\n> > > warning is easy to solve, so fix it by initializing the severity\n> > > variable.\n> > \n> > I am pretty sure it is false positive, barring any bugs in from_chars(), unfortunate...\n> \n> I'm pretty sure as well, but I don't really see an alternative to this\n> patch for the time being.\n> \n> > > Fixes: 8fa119e0b50f (\"libcamera: base: log: Use `std::from_chars()`\")\n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > src/libcamera/base/log.cpp | 3 +--\n> > > 1 file changed, 1 insertion(+), 2 deletions(-)\n> > > \n> > > diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> > > index 6a040b59290a..8bf3e1daa9c6 100644\n> > > --- a/src/libcamera/base/log.cpp\n> > > +++ b/src/libcamera/base/log.cpp\n> > > @@ -687,14 +687,13 @@ LogSeverity Logger::parseLogLevel(std::string_view level)\n> > > \"FATAL\",\n> > > };\n> > > \n> > > - unsigned int severity;\n> > > + unsigned int severity = LogInvalid;\n\nFalse positive or not, it's not /incorrect/ to initialise the variable -\nso if it's a solution it's fine with me.\n\n\nAcked-by: Kieran Bingham \n\n> > > \n> > > if (std::isdigit(level[0])) {\n> > > auto [end, ec] = std::from_chars(level.data(), level.data() + level.size(), severity);\n> > > if (ec != std::errc() || *end != '\\0' || severity > LogFatal)\n> > > severity = LogInvalid;\n> > > } else {\n> > > - severity = LogInvalid;\n> > > for (unsigned int i = 0; i < std::size(names); ++i) {\n> > > if (names[i] == level) {\n> > > severity = i;\n> > > \n> > > base-commit: c0a58b97989f7d529f1469b2c2f8705ff55d3af4\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCC32C3257\n\tfor ;\n\tMon, 3 Mar 2025 12:47:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8AF6B68777;\n\tMon, 3 Mar 2025 13:47:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24ED768772\n\tfor ;\n\tMon, 3 Mar 2025 13:47:23 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1E6F346;\n\tMon, 3 Mar 2025 13:45:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RXnCkBMa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741005951;\n\tbh=c0YV2hHZCVkriGns6D13boSNWfSqa1t/6Ek5IxZG230=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=RXnCkBMaOMSh48z5UawX5S4jOdoXZiqV+as1HB8P1559dtGz+27UCccPPk+SVV7X8\n\txnGcLd6piGH6qD1jUA5KOxKT4p8xp32BkTt1fF0qXwiGkYmUHAmHYm+vz8jrH7wSQ1\n\teub658+YBA4PsgjoqARrtWFtu0yii8Hi493KcMpI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250303104829.GQ18557@pendragon.ideasonboard.com>","References":"<20250302020903.24077-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<20250303104829.GQ18557@pendragon.ideasonboard.com>","Subject":"Re: [PATCH] libcamera: base: log: Fix uninitialized variable warning","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tLaurent Pinchart ","Date":"Mon, 03 Mar 2025 12:47:20 +0000","Message-ID":"<174100604020.2914008.4620858382489161032@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]