{"id":22900,"url":"https://patchwork.libcamera.org/api/patches/22900/?format=json","web_url":"https://patchwork.libcamera.org/patch/22900/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250302020903.24077-1-laurent.pinchart@ideasonboard.com>","date":"2025-03-02T02:09:03","name":"libcamera: base: log: Fix uninitialized variable warning","commit_ref":"bb1d216113bc9080167469f08c0a8329073991d9","pull_url":null,"state":"accepted","archived":false,"hash":"6fc5a6dde176d3c8b3092412b1236a5f1f83f8bb","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22900/mbox/","series":[{"id":5030,"url":"https://patchwork.libcamera.org/api/series/5030/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5030","date":"2025-03-02T02:09:03","name":"libcamera: base: log: Fix uninitialized variable warning","version":1,"mbox":"https://patchwork.libcamera.org/series/5030/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22900/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22900/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3BC6C3263\n\tfor ;\n\tSun, 2 Mar 2025 02:09:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99D1B6871A;\n\tSun, 2 Mar 2025 03:09:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C977861833\n\tfor ;\n\tSun, 2 Mar 2025 03:09:21 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 37E5F670;\n\tSun, 2 Mar 2025 03:07:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ly736yeI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740881271;\n\tbh=Bd4sYTFf0HltRgeOnggFK85C78uxmjFfSBapEZesn1M=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ly736yeIjXd85VomBNQUKJyhcAKJS2XhDhqzZSoWUUJIfAXxdt+YEAUBRxKqaQiFE\n\tVCad4vuGvcK5z0N2DMsLlq+73vKX5+QkxTqV5adj7x1n8B+L6q+nKtpsNr9tPO6wfm\n\t0SxzY+UpiMbY/rV1fwp3H7zrmXgtwlrQX+3rF3IY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH] libcamera: base: log: Fix uninitialized variable warning","Date":"Sun, 2 Mar 2025 04:09:03 +0200","Message-ID":"<20250302020903.24077-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.3","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"gcc 13.3.0, cross-compiling from amd64 to arm64, warns about a possibly\nuninitialized variable in Logger::parseLogLevel():\n\nsrc/libcamera/base/log.cpp: In static member function ‘static libcamera::LogSeverity libcamera::Logger::parseLogLevel(std::string_view)’:\n../../src/libcamera/base/log.cpp:694:55: error: ‘severity’ may be used uninitialized [-Werror=maybe-uninitialized]\n 694 | if (ec != std::errc() || *end != '\\0' || severity > LogFatal)\n | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~\nsrc/libcamera/base/log.cpp:690:22: note: ‘severity’ was declared here\n 690 | unsigned int severity;\n | ^~~~~~~~\n\nThis appears to be a false positive, as the std::from_chars() function\nshould set severity value when it returns without an error. Still, the\nwarning is easy to solve, so fix it by initializing the severity\nvariable.\n\nFixes: 8fa119e0b50f (\"libcamera: base: log: Use `std::from_chars()`\")\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/base/log.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\n\nbase-commit: c0a58b97989f7d529f1469b2c2f8705ff55d3af4","diff":"diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex 6a040b59290a..8bf3e1daa9c6 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -687,14 +687,13 @@ LogSeverity Logger::parseLogLevel(std::string_view level)\n \t\t\"FATAL\",\n \t};\n \n-\tunsigned int severity;\n+\tunsigned int severity = LogInvalid;\n \n \tif (std::isdigit(level[0])) {\n \t\tauto [end, ec] = std::from_chars(level.data(), level.data() + level.size(), severity);\n \t\tif (ec != std::errc() || *end != '\\0' || severity > LogFatal)\n \t\t\tseverity = LogInvalid;\n \t} else {\n-\t\tseverity = LogInvalid;\n \t\tfor (unsigned int i = 0; i < std::size(names); ++i) {\n \t\t\tif (names[i] == level) {\n \t\t\t\tseverity = i;\n","prefixes":[]}