[{"id":320,"web_url":"https://patchwork.libcamera.org/comment/320/","msgid":"","date":"2019-01-15T14:57:54","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: Make Camera destructor\n\tpublic","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 15/01/2019 14:07, Jacopo Mondi wrote:\n> The Camera class destructor is defined as private, but it needs to be\n> accessed by classes that create Camera instances, such as pipeline\n> handlers.\n> \n\nThis seems reasonable to me\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/camera.h | 2 +-\n> src/libcamera/pipeline/vimc.cpp | 2 ++\n> 2 files changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> index 9a7579d..d751d2d 100644\n> --- a/include/libcamera/camera.h\n> +++ b/include/libcamera/camera.h\n> @@ -15,13 +15,13 @@ class Camera\n> {\n> public:\n> \tCamera(const std::string &name);\n> +\tvirtual ~Camera() { };\n> \n> \tconst std::string &name() const;\n> \tvoid get();\n> \tvoid put();\n> \n> private:\n> -\tvirtual ~Camera() { };\n> \tint ref_;\n> \tstd::string name_;\n> };\n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index 720d9c2..00c544c 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -41,6 +41,8 @@ PipeHandlerVimc::~PipeHandlerVimc()\n> \n> \tif (dev_)\n> \t\tdev_->release();\n> +\n> +\tdelete camera_;\n> }\n> \n> unsigned int PipeHandlerVimc::count()\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B990D60C78\n\tfor ;\n\tTue, 15 Jan 2019 15:57:58 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A43794F8;\n\tTue, 15 Jan 2019 15:57:56 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547564276;\n\tbh=xCMiZ4aYqgA8qQudnFHyB68F37ON5qWNtU/QRGeTmXM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=pjEH+j0pg91lkzKemAidVTtZuEpwnRYH6P+ODGq4nNokUlaeDv2mI9YQ7DJBEIUBr\n\tse2xqkaPkdZ7TMzr5z5y+SNUHWPcQA4v8XJ7BgoUSKKbB1ftiQcsB612Lv1AOhaAAD\n\tOM7vh6eYxO44DjXWvoqqRDbk0Ljg5a1wgFbWVK3k=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20190115140749.8297-1-jacopo@jmondi.org>\n\t<20190115140749.8297-3-jacopo@jmondi.org>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 15 Jan 2019 14:57:54 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20190115140749.8297-3-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: Make Camera destructor\n\tpublic","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 15 Jan 2019 14:57:58 -0000"}},{"id":323,"web_url":"https://patchwork.libcamera.org/comment/323/","msgid":"<1981838.FLNtBfLD7u@avalon>","date":"2019-01-15T15:43:08","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: Make Camera destructor\n\tpublic","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tuesday, 15 January 2019 16:57:54 EET Kieran Bingham wrote:\n> Hi Jacopo,\n> \n> On 15/01/2019 14:07, Jacopo Mondi wrote:\n> > The Camera class destructor is defined as private, but it needs to be\n> > accessed by classes that create Camera instances, such as pipeline\n> > handlers.\n> \n> This seems reasonable to me\n\nNot to me. Do you guys read the documentation ? :-) This isn't how cameras are \ndestroyed.\n\n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > \n> > include/libcamera/camera.h | 2 +-\n> > src/libcamera/pipeline/vimc.cpp | 2 ++\n> > 2 files changed, 3 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> > index 9a7579d..d751d2d 100644\n> > --- a/include/libcamera/camera.h\n> > +++ b/include/libcamera/camera.h\n> > @@ -15,13 +15,13 @@ class Camera\n> > {\n> > public:\n> > \tCamera(const std::string &name);\n> > +\tvirtual ~Camera() { };\n> > \n> > \tconst std::string &name() const;\n> > \tvoid get();\n> > \tvoid put();\n> > \n> > private:\n> > -\tvirtual ~Camera() { };\n> > \tint ref_;\n> > \tstd::string name_;\n> > };\n> > diff --git a/src/libcamera/pipeline/vimc.cpp\n> > b/src/libcamera/pipeline/vimc.cpp index 720d9c2..00c544c 100644\n> > --- a/src/libcamera/pipeline/vimc.cpp\n> > +++ b/src/libcamera/pipeline/vimc.cpp\n> > @@ -41,6 +41,8 @@ PipeHandlerVimc::~PipeHandlerVimc()\n> > \n> > \tif (dev_)\n> > \t\tdev_->release();\n> > +\n> > +\tdelete camera_;\n> > }\n> > \n> > unsigned int PipeHandlerVimc::count()","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E87E60B0C\n\tfor ;\n\tTue, 15 Jan 2019 16:41:53 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 348B44F8;\n\tTue, 15 Jan 2019 16:41:52 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547566912;\n\tbh=WRk5OIEk7/KngHnjautcrFGuN9h3kYOrgTF7hzhCMck=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kE8aKd0pfsOHPZDVRvtIDN46FqBhAxjSMtrfzOKUkQIZ17zzonFc6mfrJZNxMxs0V\n\ta4M1FZTC6WUw88bebLy7qGNmiYdcsGw/KssUpzjUudUks45mPDLyAhavIx4Mo8VDwv\n\t+g4nyPXBLn0WJ4gInSdK123iuVVSdw1BuKRoPnCI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org, kieran.bingham@ideasonboard.com","Date":"Tue, 15 Jan 2019 17:43:08 +0200","Message-ID":"<1981838.FLNtBfLD7u@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"","References":"<20190115140749.8297-1-jacopo@jmondi.org>\n\t<20190115140749.8297-3-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: Make Camera destructor\n\tpublic","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 15 Jan 2019 15:41:53 -0000"}},{"id":325,"web_url":"https://patchwork.libcamera.org/comment/325/","msgid":"<20190115155728.nyrffrnfwbaqrupb@uno.localdomain>","date":"2019-01-15T15:57:28","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: Make Camera destructor\n\tpublic","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Tue, Jan 15, 2019 at 05:43:08PM +0200, Laurent Pinchart wrote:\n> On Tuesday, 15 January 2019 16:57:54 EET Kieran Bingham wrote:\n> > Hi Jacopo,\n> >\n> > On 15/01/2019 14:07, Jacopo Mondi wrote:\n> > > The Camera class destructor is defined as private, but it needs to be\n> > > accessed by classes that create Camera instances, such as pipeline\n> > > handlers.\n> >\n> > This seems reasonable to me\n>\n> Not to me. Do you guys read the documentation ? :-) This isn't how cameras are\n> destroyed.\n\nAh, ups\n\nvoid Camera::put()\n{\n\tif (--ref_ == 0)\n\t\tdelete this;\n}\n\nYes, this calls for shared_ptr<>\n\n>\n> > Reviewed-by: Kieran Bingham \n> >\n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > >\n> > > include/libcamera/camera.h | 2 +-\n> > > src/libcamera/pipeline/vimc.cpp | 2 ++\n> > > 2 files changed, 3 insertions(+), 1 deletion(-)\n> > >\n> > > diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> > > index 9a7579d..d751d2d 100644\n> > > --- a/include/libcamera/camera.h\n> > > +++ b/include/libcamera/camera.h\n> > > @@ -15,13 +15,13 @@ class Camera\n> > > {\n> > > public:\n> > > \tCamera(const std::string &name);\n> > > +\tvirtual ~Camera() { };\n> > >\n> > > \tconst std::string &name() const;\n> > > \tvoid get();\n> > > \tvoid put();\n> > >\n> > > private:\n> > > -\tvirtual ~Camera() { };\n> > > \tint ref_;\n> > > \tstd::string name_;\n> > > };\n> > > diff --git a/src/libcamera/pipeline/vimc.cpp\n> > > b/src/libcamera/pipeline/vimc.cpp index 720d9c2..00c544c 100644\n> > > --- a/src/libcamera/pipeline/vimc.cpp\n> > > +++ b/src/libcamera/pipeline/vimc.cpp\n> > > @@ -41,6 +41,8 @@ PipeHandlerVimc::~PipeHandlerVimc()\n> > >\n> > > \tif (dev_)\n> > > \t\tdev_->release();\n> > > +\n> > > +\tdelete camera_;\n> > > }\n> > >\n> > > unsigned int PipeHandlerVimc::count()\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>\n>","headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30B2C60B0C\n\tfor ;\n\tTue, 15 Jan 2019 16:57:20 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 81F2C10000A;\n\tTue, 15 Jan 2019 15:57:19 +0000 (UTC)"],"Date":"Tue, 15 Jan 2019 16:57:28 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, kieran.bingham@ideasonboard.com","Message-ID":"<20190115155728.nyrffrnfwbaqrupb@uno.localdomain>","References":"<20190115140749.8297-1-jacopo@jmondi.org>\n\t<20190115140749.8297-3-jacopo@jmondi.org>\n\t\n\t<1981838.FLNtBfLD7u@avalon>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"tcaphplxxqlo2ncs\"","Content-Disposition":"inline","In-Reply-To":"<1981838.FLNtBfLD7u@avalon>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: Make Camera destructor\n\tpublic","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 15 Jan 2019 15:57:20 -0000"}}]