{"id":229,"url":"https://patchwork.libcamera.org/api/patches/229/?format=json","web_url":"https://patchwork.libcamera.org/patch/229/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190115140749.8297-3-jacopo@jmondi.org>","date":"2019-01-15T14:07:47","name":"[libcamera-devel,2/4] libcamera: Make Camera destructor public","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"8a9d8d783140214254ced2c22e5add7f865aef62","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/229/mbox/","series":[{"id":80,"url":"https://patchwork.libcamera.org/api/series/80/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=80","date":"2019-01-15T14:07:45","name":"libcamera: IPU3: Add pipeline handler","version":1,"mbox":"https://patchwork.libcamera.org/series/80/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/229/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/229/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D8D260C78\n\tfor ;\n\tTue, 15 Jan 2019 15:07:48 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id AA13920001C;\n\tTue, 15 Jan 2019 14:07:47 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 15 Jan 2019 15:07:47 +0100","Message-Id":"<20190115140749.8297-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190115140749.8297-1-jacopo@jmondi.org>","References":"<20190115140749.8297-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/4] libcamera: Make Camera destructor\n\tpublic","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 15 Jan 2019 14:07:48 -0000"},"content":"The Camera class destructor is defined as private, but it needs to be\naccessed by classes that create Camera instances, such as pipeline\nhandlers.\n\nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/camera.h | 2 +-\n src/libcamera/pipeline/vimc.cpp | 2 ++\n 2 files changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex 9a7579d..d751d2d 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -15,13 +15,13 @@ class Camera\n {\n public:\n \tCamera(const std::string &name);\n+\tvirtual ~Camera() { };\n \n \tconst std::string &name() const;\n \tvoid get();\n \tvoid put();\n \n private:\n-\tvirtual ~Camera() { };\n \tint ref_;\n \tstd::string name_;\n };\ndiff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex 720d9c2..00c544c 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -41,6 +41,8 @@ PipeHandlerVimc::~PipeHandlerVimc()\n \n \tif (dev_)\n \t\tdev_->release();\n+\n+\tdelete camera_;\n }\n \n unsigned int PipeHandlerVimc::count()\n","prefixes":["libcamera-devel","2/4"]}