[{"id":33581,"web_url":"https://patchwork.libcamera.org/comment/33581/","msgid":"<174112332208.2914008.14904712693068283270@ping.linuxembedded.co.uk>","date":"2025-03-04T21:22:02","subject":"Re: [PATCH 3/3] ipa: rksip1: Remove setControls(0) to reduce startup\n\toscillations","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-02-28 12:55:55)\n> The call to setControls(0) is counter productive. At start() time, no\n> requests were queued and no stats were received. So setControls(0)\n> accesses a zeroed frame context and in turn sends 0 as gain, exposure\n> and vblank to the pipeline handler and DelayedControls. This leads to\n> strong oscillations on every start of the camera.\n> \n> A proper fix for handling the startup controls still needs to be done\n> and was already started in [1] and [2].\n> \n> From a DelayedControls point of view the call to setControls(0) is also\n> unnecessary as DelayedControls treat frame 0 as already being queued in\n> after initialization.\n> \n> So it is save to just remove it and the removal fixes the zero\n\ns/save/safe/\n\n> effectiveExposureValue discussed in the previous patch for rkisp1.\n> \n> [1]: https://patchwork.libcamera.org/patch/21708/\n> [2]: https://patchwork.libcamera.org/patch/22445/\n> \n> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> ---\n>  src/ipa/rkisp1/rkisp1.cpp | 2 --\n>  1 file changed, 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 5f1583e8219b..b09dd6efdf08 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -211,8 +211,6 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n>  \n>  int IPARkISP1::start()\n>  {\n> -       setControls(0);\n> -\n\nAha, I thought I had recollection of this being added here more recently\nbut this dates all the way back to 2021\n(1456efe7d51a3a0c6b57db4310f75b2a08ab1756) ... so I don't think it\ntramples on any active development of AGC.\n\n\nThe above makes enough sense to me so:\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\nThough - now I check through patchwork - I see:\n\nhttps://patchwork.libcamera.org/patch/21708/\n\nfrom https://patchwork.libcamera.org/project/libcamera/list/?series=4728\nalso touches code here. Have you reviewed that series? Does anything\nthere need to be also considered or reviewed ?\n\n--\nKieran\n\n\n>         return 0;\n>  }\n>  \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09660C32DC\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  4 Mar 2025 21:22:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D9E268822;\n\tTue,  4 Mar 2025 22:22:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C84C168755\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  4 Mar 2025 22:22:04 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AAAC352;\n\tTue,  4 Mar 2025 22:20:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ag9U3cep\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741123232;\n\tbh=lpHb8TDbAe5du9kQeVkrqD9N8qgI9g5cFBHjFX5az24=;\n\th=In-Reply-To:References:Subject:From:To:Cc:Date:From;\n\tb=Ag9U3cepecuv+CjWB8G2JN+2EFzu+T2ZKrbiKDkmDUUnhUmvcnRTB8YUfBM/MYJLz\n\tjfVm8UKS4mSpWA7xWK+MpVTNVLz+kYM+Rlgf1GDcj+zVMbyoa7SKbRdyrcwmffQoAK\n\tahTcB6KT0ShhdWwz4fixbeUJhKWrm8B0O8v/W0jU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250228125600.3241397-4-stefan.klug@ideasonboard.com>","References":"<20250228125600.3241397-1-stefan.klug@ideasonboard.com>\n\t<20250228125600.3241397-4-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 3/3] ipa: rksip1: Remove setControls(0) to reduce startup\n\toscillations","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Stefan Klug <stefan.klug@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Stefan Klug <stefan.klug@ideasonboard.com>,\n\tMikhail Rudenko <mike.rudenko@gmail.com>, ","Date":"Tue, 04 Mar 2025 21:22:02 +0000","Message-ID":"<174112332208.2914008.14904712693068283270@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":33584,"web_url":"https://patchwork.libcamera.org/comment/33584/","msgid":"<ryiazctjehrqdppme37f4iqnb3c5uhwza25bmgnfiezqlerrkx@gxuuf2dpe3dm>","date":"2025-03-05T09:51:15","subject":"Re: [PATCH 3/3] ipa: rksip1: Remove setControls(0) to reduce startup\n\toscillations","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Kieran\n\nThank you for the review.\n\nOn Tue, Mar 04, 2025 at 09:22:02PM +0000, Kieran Bingham wrote:\n> Quoting Stefan Klug (2025-02-28 12:55:55)\n> > The call to setControls(0) is counter productive. At start() time, no\n> > requests were queued and no stats were received. So setControls(0)\n> > accesses a zeroed frame context and in turn sends 0 as gain, exposure\n> > and vblank to the pipeline handler and DelayedControls. This leads to\n> > strong oscillations on every start of the camera.\n> > \n> > A proper fix for handling the startup controls still needs to be done\n> > and was already started in [1] and [2].\n> > \n> > From a DelayedControls point of view the call to setControls(0) is also\n> > unnecessary as DelayedControls treat frame 0 as already being queued in\n> > after initialization.\n> > \n> > So it is save to just remove it and the removal fixes the zero\n> \n> s/save/safe/\n> \n> > effectiveExposureValue discussed in the previous patch for rkisp1.\n> > \n> > [1]: https://patchwork.libcamera.org/patch/21708/\n> > [2]: https://patchwork.libcamera.org/patch/22445/\n> > \n> > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> > ---\n> >  src/ipa/rkisp1/rkisp1.cpp | 2 --\n> >  1 file changed, 2 deletions(-)\n> > \n> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > index 5f1583e8219b..b09dd6efdf08 100644\n> > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > @@ -211,8 +211,6 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n> >  \n> >  int IPARkISP1::start()\n> >  {\n> > -       setControls(0);\n> > -\n> \n> Aha, I thought I had recollection of this being added here more recently\n> but this dates all the way back to 2021\n> (1456efe7d51a3a0c6b57db4310f75b2a08ab1756) ... so I don't think it\n> tramples on any active development of AGC.\n> \n> \n> The above makes enough sense to me so:\n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> \n> Though - now I check through patchwork - I see:\n> \n> https://patchwork.libcamera.org/patch/21708/\n> \n> from https://patchwork.libcamera.org/project/libcamera/list/?series=4728\n> also touches code here. Have you reviewed that series? Does anything\n> there need to be also considered or reviewed ?\n> \n\nYes, I'm aware of that series (that's why I mentioned it in the commit\nmessage above). Time wise those changes overlapped with similar changes\nI did to improve regulation in rkisp1. I'll continue to push on that and\nwill pull in changes from Mikhail as fit.\n\nThis series is just a tiny step in that direction and makes upcoming\nchanges easier.\n\nBest regards,\nStefan\n\n> --\n> Kieran\n> \n> \n> >         return 0;\n> >  }\n> >  \n> > -- \n> > 2.43.0\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC7E3C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  5 Mar 2025 09:51:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B46D687F0;\n\tWed,  5 Mar 2025 10:51:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5A5668771\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  5 Mar 2025 10:51:17 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:e13d:9941:bf88:d66d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC30063F;\n\tWed,  5 Mar 2025 10:49:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pt7gd37q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741168185;\n\tbh=30IdZEUDPUaNv4Z/5iyIanRSTFIHD6eG6t1pggDCZWA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pt7gd37qZIQK/hJXlJuRGRTHNKXxghm9j4CftHBgHqZQVa1pj4CtmffRwyIuRGWUb\n\tt6vhpZ55eFiRnkgZMLLfGyYTeeWIqzYeZCUhCtXkB8w/WHfrsoUzjsHfBMcvcsuISz\n\tzXjIi0d4Av/jII3FVI2RtHjQZ1UuQ6MiK8ej6Czc=","Date":"Wed, 5 Mar 2025 10:51:15 +0100","From":"Stefan Klug <stefan.klug@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, \n\tMikhail Rudenko <mike.rudenko@gmail.com>","Subject":"Re: [PATCH 3/3] ipa: rksip1: Remove setControls(0) to reduce startup\n\toscillations","Message-ID":"<ryiazctjehrqdppme37f4iqnb3c5uhwza25bmgnfiezqlerrkx@gxuuf2dpe3dm>","References":"<20250228125600.3241397-1-stefan.klug@ideasonboard.com>\n\t<20250228125600.3241397-4-stefan.klug@ideasonboard.com>\n\t<174112332208.2914008.14904712693068283270@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<174112332208.2914008.14904712693068283270@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":33586,"web_url":"https://patchwork.libcamera.org/comment/33586/","msgid":"<174117071434.2914008.12853380481639591179@ping.linuxembedded.co.uk>","date":"2025-03-05T10:31:54","subject":"Re: [PATCH 3/3] ipa: rksip1: Remove setControls(0) to reduce startup\n\toscillations","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-03-05 09:51:15)\n> Hi Kieran\n> \n> Thank you for the review.\n> \n> On Tue, Mar 04, 2025 at 09:22:02PM +0000, Kieran Bingham wrote:\n> > Quoting Stefan Klug (2025-02-28 12:55:55)\n> > > The call to setControls(0) is counter productive. At start() time, no\n> > > requests were queued and no stats were received. So setControls(0)\n> > > accesses a zeroed frame context and in turn sends 0 as gain, exposure\n> > > and vblank to the pipeline handler and DelayedControls. This leads to\n> > > strong oscillations on every start of the camera.\n> > > \n> > > A proper fix for handling the startup controls still needs to be done\n> > > and was already started in [1] and [2].\n> > > \n> > > From a DelayedControls point of view the call to setControls(0) is also\n> > > unnecessary as DelayedControls treat frame 0 as already being queued in\n> > > after initialization.\n> > > \n> > > So it is save to just remove it and the removal fixes the zero\n> > \n> > s/save/safe/\n> > \n> > > effectiveExposureValue discussed in the previous patch for rkisp1.\n> > > \n> > > [1]: https://patchwork.libcamera.org/patch/21708/\n> > > [2]: https://patchwork.libcamera.org/patch/22445/\n> > > \n> > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> > > ---\n> > >  src/ipa/rkisp1/rkisp1.cpp | 2 --\n> > >  1 file changed, 2 deletions(-)\n> > > \n> > > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > > index 5f1583e8219b..b09dd6efdf08 100644\n> > > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > > @@ -211,8 +211,6 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n> > >  \n> > >  int IPARkISP1::start()\n> > >  {\n> > > -       setControls(0);\n> > > -\n> > \n> > Aha, I thought I had recollection of this being added here more recently\n> > but this dates all the way back to 2021\n> > (1456efe7d51a3a0c6b57db4310f75b2a08ab1756) ... so I don't think it\n> > tramples on any active development of AGC.\n> > \n> > \n> > The above makes enough sense to me so:\n> > \n> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > \n> > \n> > Though - now I check through patchwork - I see:\n> > \n> > https://patchwork.libcamera.org/patch/21708/\n> > \n> > from https://patchwork.libcamera.org/project/libcamera/list/?series=4728\n> > also touches code here. Have you reviewed that series? Does anything\n> > there need to be also considered or reviewed ?\n> > \n> \n> Yes, I'm aware of that series (that's why I mentioned it in the commit\n> message above). Time wise those changes overlapped with similar changes\n\nOopps, Sorry - I missed that !\n\n> I did to improve regulation in rkisp1. I'll continue to push on that and\n> will pull in changes from Mikhail as fit.\n> \n> This series is just a tiny step in that direction and makes upcoming\n> changes easier.\n> \n\nGreat, Looking forward to this series progressing!\n--\nKieran\n\n> Best regards,\n> Stefan\n> \n> > --\n> > Kieran\n> > \n> > \n> > >         return 0;\n> > >  }\n> > >  \n> > > -- \n> > > 2.43.0\n> > >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4ADE1C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  5 Mar 2025 10:32:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12C0B687F0;\n\tWed,  5 Mar 2025 11:31:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0E2868771\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  5 Mar 2025 11:31:57 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C74AA605;\n\tWed,  5 Mar 2025 11:30:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hoQR8x/5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741170624;\n\tbh=pKXNdvIFwJwVLCGVzKK+00w3yBf+PqKOJPqnjCBZw5E=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=hoQR8x/5Tq41KQYBNyWuLtfQ//WT9Y7ssUjta+E/zDPw5ESrMtcpMprIsyudaH1bk\n\tSN1hO3bIVgjOR8AgReWq027EtkLbAJodIFwTrdcWXNFnEAwy9DDegAZi9i6GOdcFze\n\tqr5sfa0ZFeIA2BjZoYVMlZIuyEMAgHO0DpDVnUPU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<ryiazctjehrqdppme37f4iqnb3c5uhwza25bmgnfiezqlerrkx@gxuuf2dpe3dm>","References":"<20250228125600.3241397-1-stefan.klug@ideasonboard.com>\n\t<20250228125600.3241397-4-stefan.klug@ideasonboard.com>\n\t<174112332208.2914008.14904712693068283270@ping.linuxembedded.co.uk>\n\t<ryiazctjehrqdppme37f4iqnb3c5uhwza25bmgnfiezqlerrkx@gxuuf2dpe3dm>","Subject":"Re: [PATCH 3/3] ipa: rksip1: Remove setControls(0) to reduce startup\n\toscillations","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tMikhail Rudenko <mike.rudenko@gmail.com>","To":"Stefan Klug <stefan.klug@ideasonboard.com>","Date":"Wed, 05 Mar 2025 10:31:54 +0000","Message-ID":"<174117071434.2914008.12853380481639591179@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":33716,"web_url":"https://patchwork.libcamera.org/comment/33716/","msgid":"<20250326122935.GD29473@pendragon.ideasonboard.com>","date":"2025-03-26T12:29:35","subject":"Re: [PATCH 3/3] ipa: rksip1: Remove setControls(0) to reduce startup\n\toscillations","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Feb 28, 2025 at 01:55:55PM +0100, Stefan Klug wrote:\n> The call to setControls(0) is counter productive. At start() time, no\n> requests were queued and no stats were received. So setControls(0)\n> accesses a zeroed frame context and in turn sends 0 as gain, exposure\n> and vblank to the pipeline handler and DelayedControls. This leads to\n> strong oscillations on every start of the camera.\n> \n> A proper fix for handling the startup controls still needs to be done\n> and was already started in [1] and [2].\n> \n> From a DelayedControls point of view the call to setControls(0) is also\n> unnecessary as DelayedControls treat frame 0 as already being queued in\n> after initialization.\n> \n> So it is save to just remove it and the removal fixes the zero\n> effectiveExposureValue discussed in the previous patch for rkisp1.\n> \n> [1]: https://patchwork.libcamera.org/patch/21708/\n> [2]: https://patchwork.libcamera.org/patch/22445/\n> \n> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> ---\n>  src/ipa/rkisp1/rkisp1.cpp | 2 --\n>  1 file changed, 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 5f1583e8219b..b09dd6efdf08 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -211,8 +211,6 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n>  \n>  int IPARkISP1::start()\n>  {\n> -\tsetControls(0);\n> -\n\nCould you add a \\todo comment ? With that,\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n>  \treturn 0;\n>  }\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8D44C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 Mar 2025 12:30:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 864B368969;\n\tWed, 26 Mar 2025 13:29:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 58FB568950\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Mar 2025 13:29:58 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C76E3A4;\n\tWed, 26 Mar 2025 13:28:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n+OrlCEl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742992090;\n\tbh=2e2oGP3uxMBhJJAJbd4RkJSwPgCp424PBlu+s+ZZ+zs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=n+OrlCEl12enLn9kn7ugiV8lXAdDRzcUGFgIaFhHD6N793LbuPi5sLlXUSgUAxiJ2\n\tlVOybETPKllE2fB8Uqz3+UQftyKBhjaHWiDjP8TJ4ul+HvU25oYjfduzeprgXIeGhi\n\tdO6xZ2F9pQ+m3RQLul8rDj9BDLxwaD8SgJsv/5Us=","Date":"Wed, 26 Mar 2025 14:29:35 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Stefan Klug <stefan.klug@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 3/3] ipa: rksip1: Remove setControls(0) to reduce startup\n\toscillations","Message-ID":"<20250326122935.GD29473@pendragon.ideasonboard.com>","References":"<20250228125600.3241397-1-stefan.klug@ideasonboard.com>\n\t<20250228125600.3241397-4-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250228125600.3241397-4-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]