[{"id":33580,"web_url":"https://patchwork.libcamera.org/comment/33580/","msgid":"<174112278916.2914008.4628101997310146267@ping.linuxembedded.co.uk>","date":"2025-03-04T21:13:09","subject":"Re: [PATCH 1/3] ipa: rkisp1: Add debug log for the sensor controls\n\tbeing set","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-02-28 12:55:53)\n> In the algorithms a lot of information get's logged in debug log level,\n> but there is no place where the values sent to the sensor get logged.\n> Add such a log message.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 7547d2f274f4..5f1583e8219b 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -455,6 +455,11 @@ void IPARkISP1::setControls(unsigned int frame)\n> uint32_t gain = context_.camHelper->gainCode(frameContext.agc.gain);\n> uint32_t vblank = frameContext.agc.vblank;\n> \n> + LOG(IPARkISP1, Debug) << \"Set controls frame \" << frame\n> + << \": exposure \" << exposure\n> + << \", gain \" << frameContext.agc.gain\n> + << \", vblank \" << vblank;\n> +\n> ControlList ctrls(sensorControls_);\n> ctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure));\n> ctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain));\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD9F2C3257\n\tfor ;\n\tTue, 4 Mar 2025 21:13:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7F54687F0;\n\tTue, 4 Mar 2025 22:13:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1A0A68755\n\tfor ;\n\tTue, 4 Mar 2025 22:13:12 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 664BF352;\n\tTue, 4 Mar 2025 22:11:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cjv6dzsd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741122700;\n\tbh=J3uUEyZuLnOPO4EC8F/z8zCrWrgWmhYsW6k7jfxYWJU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Cjv6dzsdF7GUXBTACO7ch8WmkrMblL6/gHVL53WNNS7TOpyjZwsOohQgk35nVXlAo\n\txu/0TkCI5ybm26m8NsR8k/Ux9fonVM7zRzeLeHslzM2mx6+cv0IHwH9uHwlrNmmjCj\n\tsG+95Vbla1rQfkvq7BByEAZK58O+k98fS1wH3OLs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250228125600.3241397-2-stefan.klug@ideasonboard.com>","References":"<20250228125600.3241397-1-stefan.klug@ideasonboard.com>\n\t<20250228125600.3241397-2-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 1/3] ipa: rkisp1: Add debug log for the sensor controls\n\tbeing set","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 04 Mar 2025 21:13:09 +0000","Message-ID":"<174112278916.2914008.4628101997310146267@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33714,"web_url":"https://patchwork.libcamera.org/comment/33714/","msgid":"<20250326120008.GA29473@pendragon.ideasonboard.com>","date":"2025-03-26T12:00:08","subject":"Re: [PATCH 1/3] ipa: rkisp1: Add debug log for the sensor controls\n\tbeing set","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Feb 28, 2025 at 01:55:53PM +0100, Stefan Klug wrote:\n> In the algorithms a lot of information get's logged in debug log level,\n> but there is no place where the values sent to the sensor get logged.\n> Add such a log message.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 7547d2f274f4..5f1583e8219b 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -455,6 +455,11 @@ void IPARkISP1::setControls(unsigned int frame)\n> \tuint32_t gain = context_.camHelper->gainCode(frameContext.agc.gain);\n> \tuint32_t vblank = frameContext.agc.vblank;\n> \n> +\tLOG(IPARkISP1, Debug) << \"Set controls frame \" << frame\n\nMaybe s/frame/for frame/\n\n> +\t\t\t << \": exposure \" << exposure\n> +\t\t\t << \", gain \" << frameContext.agc.gain\n> +\t\t\t << \", vblank \" << vblank;\n\nOur usual coding style would be\n\n\tLOG(IPARkISP1, Debug)\n\t\t<< \"Set controls for frame \" << frame << \": exposure \" << exposure\n\t\t<< \", gain \" << frameContext.agc.gain << \", vblank \" << vblank;\n\nReviewed-by: Laurent Pinchart \n\n> +\n> \tControlList ctrls(sensorControls_);\n> \tctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure));\n> \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain));","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0605FC323E\n\tfor ;\n\tWed, 26 Mar 2025 12:00:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0CE6368969;\n\tWed, 26 Mar 2025 13:00:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F0C968950\n\tfor ;\n\tWed, 26 Mar 2025 13:00:31 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D63F3A4;\n\tWed, 26 Mar 2025 12:58:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ID46NRtm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742990323;\n\tbh=2EqktO7SanHcSJ2ZhBuPilGDizwa7wjezQJi4R8vhok=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ID46NRtmODR58WQKWkG5TVe6p5RI/fQna7umyUL7SKsMVAly4a4wfrRBsRGLhAMZc\n\tiwgZ2q9F81GgdvWh5l7ba3rGS7FM2NqdGiR9lzJjGfmRVSvY1Zcf9XyapyN9X04yvG\n\tGeBOi+hslk1sjr6XO7a38ncbu3ShwiTpGOngi5d4=","Date":"Wed, 26 Mar 2025 14:00:08 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/3] ipa: rkisp1: Add debug log for the sensor controls\n\tbeing set","Message-ID":"<20250326120008.GA29473@pendragon.ideasonboard.com>","References":"<20250228125600.3241397-1-stefan.klug@ideasonboard.com>\n\t<20250228125600.3241397-2-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250228125600.3241397-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33717,"web_url":"https://patchwork.libcamera.org/comment/33717/","msgid":"<7wplbtulbvywc5b7ar22gu7nzscbybm3zrz5esgj4zpigyorsl@sxpsezlxmmmd>","date":"2025-03-26T12:44:04","subject":"Re: [PATCH 1/3] ipa: rkisp1: Add debug log for the sensor controls\n\tbeing set","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the review. \n\nOn Wed, Mar 26, 2025 at 02:00:08PM +0200, Laurent Pinchart wrote:\n> Hi Stefan,\n> \n> Thank you for the patch.\n> \n> On Fri, Feb 28, 2025 at 01:55:53PM +0100, Stefan Klug wrote:\n> > In the algorithms a lot of information get's logged in debug log level,\n> > but there is no place where the values sent to the sensor get logged.\n> > Add such a log message.\n> > \n> > Signed-off-by: Stefan Klug \n> > ---\n> > src/ipa/rkisp1/rkisp1.cpp | 5 +++++\n> > 1 file changed, 5 insertions(+)\n> > \n> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > index 7547d2f274f4..5f1583e8219b 100644\n> > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > @@ -455,6 +455,11 @@ void IPARkISP1::setControls(unsigned int frame)\n> > \tuint32_t gain = context_.camHelper->gainCode(frameContext.agc.gain);\n> > \tuint32_t vblank = frameContext.agc.vblank;\n> > \n> > +\tLOG(IPARkISP1, Debug) << \"Set controls frame \" << frame\n> \n> Maybe s/frame/for frame/\n> \n> > +\t\t\t << \": exposure \" << exposure\n> > +\t\t\t << \", gain \" << frameContext.agc.gain\n> > +\t\t\t << \", vblank \" << vblank;\n> \n> Our usual coding style would be\n> \n> \tLOG(IPARkISP1, Debug)\n> \t\t<< \"Set controls for frame \" << frame << \": exposure \" << exposure\n> \t\t<< \", gain \" << frameContext.agc.gain << \", vblank \" << vblank;\n\nOh I wasn't aware of that. I'll apply the fixes when merging.\n\nCheers,\nStefan\n\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > +\n> > \tControlList ctrls(sensorControls_);\n> > \tctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure));\n> > \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain));\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1890CC323E\n\tfor ;\n\tWed, 26 Mar 2025 12:44:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B9C56896A;\n\tWed, 26 Mar 2025 13:44:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F4A168964\n\tfor ;\n\tWed, 26 Mar 2025 13:44:07 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b21a:42f4:9f3:1df6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A29833A4;\n\tWed, 26 Mar 2025 13:42:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RQZzHUet\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742992939;\n\tbh=cWgJGKb4gkBPO1VOwbcSDuqy3vDc90iGMcSTVtBl5lA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RQZzHUetZbg4kXpLqvJpPn2inD64frUlmk/9+Jub8nu+/5mPWo2/HASqZ+sQ9j+OI\n\txyiJmtPXJVfo0BACpCYU0ObJB50q1lhNS6ulawbm+n4AwgbPnke+LKsuNyBIkgETey\n\tv5vm9Wncj8fdiFedjn21XEeASoXsjUf1ETgsoBN8=","Date":"Wed, 26 Mar 2025 13:44:04 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/3] ipa: rkisp1: Add debug log for the sensor controls\n\tbeing set","Message-ID":"<7wplbtulbvywc5b7ar22gu7nzscbybm3zrz5esgj4zpigyorsl@sxpsezlxmmmd>","References":"<20250228125600.3241397-1-stefan.klug@ideasonboard.com>\n\t<20250228125600.3241397-2-stefan.klug@ideasonboard.com>\n\t<20250326120008.GA29473@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250326120008.GA29473@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]