{"id":22882,"url":"https://patchwork.libcamera.org/api/patches/22882/?format=json","web_url":"https://patchwork.libcamera.org/patch/22882/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250226192413.2903243-1-stefan.klug@ideasonboard.com>","date":"2025-02-26T19:23:53","name":"media: rkisp1: Apply full quantization when color space JPEG is requested","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"9f5d74629faf0ada9ae92749b06d29467f4dd527","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22882/mbox/","series":[{"id":5026,"url":"https://patchwork.libcamera.org/api/series/5026/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5026","date":"2025-02-26T19:23:53","name":"media: rkisp1: Apply full quantization when color space JPEG is requested","version":1,"mbox":"https://patchwork.libcamera.org/series/5026/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22882/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22882/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C88BC324C\n\tfor ;\n\tWed, 26 Feb 2025 19:27:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 630CA6874C;\n\tWed, 26 Feb 2025 20:27:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A7FF61853\n\tfor ;\n\tWed, 26 Feb 2025 20:27:37 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:2b29:76dc:a5a9:647c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92A9C49E;\n\tWed, 26 Feb 2025 20:26:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NW8lxxvD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740597968;\n\tbh=TR7F1RtqVngJgjrbPnHgmwGaX8T2VMKYSMSpMKAAPlE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=NW8lxxvDmzfPYMXpgDSCd6IHHfUuXIIuesoKkEjM/CbPFSewuNBLXD2Ac6G4j/+ew\n\tHg/pFr74tx67Rjt5r7WVNu3NLh/jjThLjdQ/lqtCRYThnm5hfSExf/UFMyKHXBAHNY\n\tRlF/Q/CmwML/jQGYJLlZPFuU7l/PlcwhAfIYdI9Q=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ,\n\tMauro Carvalho Chehab ,\n\tPaul Elder ,\n\tDafna Hirschfeld , linux-media@vger.kernel.org,\n\tlinux-rockchip@lists.infradead.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Cc":"Stefan Klug ,\n\tHeiko Stuebner ","Subject":"[PATCH] media: rkisp1: Apply full quantization when color space JPEG\n\tis requested","Date":"Wed, 26 Feb 2025 20:23:53 +0100","Message-ID":"<20250226192413.2903243-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When color space V4L2_COLORSPACE_JPEG is requested the ISP incorrectly\nsets the output quantization to V4L2_QUANTIZATION_LIM_RANGE. Fix that by\napplying the default quantization for the requested color space.\n\nFixes: c1ec5efba080 (\"media: rkisp1: Allow setting all color space fields on ISP source pad\")\nSigned-off-by: Stefan Klug \n---\n drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c\nindex d94917211828..98635d875ac4 100644\n--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c\n+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c\n@@ -646,7 +646,7 @@ static void rkisp1_isp_set_src_fmt(struct rkisp1_isp *isp,\n \n \t/*\n \t * Copy the color space for the sink pad. When converting from Bayer to\n-\t * YUV, default to a limited quantization range.\n+\t * YUV, default to the default quantization range of the color space.\n \t */\n \tsrc_fmt->colorspace = sink_fmt->colorspace;\n \tsrc_fmt->xfer_func = sink_fmt->xfer_func;\n@@ -654,7 +654,8 @@ static void rkisp1_isp_set_src_fmt(struct rkisp1_isp *isp,\n \n \tif (sink_info->pixel_enc == V4L2_PIXEL_ENC_BAYER &&\n \t src_info->pixel_enc == V4L2_PIXEL_ENC_YUV)\n-\t\tsrc_fmt->quantization = V4L2_QUANTIZATION_LIM_RANGE;\n+\t\tsrc_fmt->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(\n+\t\t\tfalse, sink_fmt->colorspace, sink_fmt->ycbcr_enc);\n \telse\n \t\tsrc_fmt->quantization = sink_fmt->quantization;\n \n","prefixes":[]}