[{"id":33489,"web_url":"https://patchwork.libcamera.org/comment/33489/","msgid":"","date":"2025-02-26T06:04:50","subject":"Re: [PATCH] libcamera: camera: Log info message to report camera\n\tcreation","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Feb 26, 2025 at 02:55:47AM +0200, Laurent Pinchart wrote:\n> Camera creation is one of the most important events generated by\n> libcamera, but we are completely silent about it. The lack of a log\n> message makes it more difficult to identify problems and provide\n> support. Fix it by adding an Info message that reports the camera id and\n> its pipeline handler when the camera is created.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/camera.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 56c5851993c9..35097bfdafa2 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -862,6 +862,10 @@ std::shared_ptr Camera::create(std::unique_ptr d,\n> \t\t}\n> \t};\n> \n> +\tLOG(Camera, Info)\n> +\t\t<< \"Creating camera '\" << id << \"' for pipeline handler \"\n> +\t\t<< d->pipe_->name();\n> +\n> \tCamera *camera = new Camera(std::move(d), id, streams);\n> \n> \treturn std::shared_ptr(camera, Deleter());\n> \n> base-commit: 33ce463a46c44f874fdbc3e484bee730e7b251a3\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A078C324C\n\tfor ;\n\tWed, 26 Feb 2025 06:05:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 653616873D;\n\tWed, 26 Feb 2025 07:04:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B17A61852\n\tfor ;\n\tWed, 26 Feb 2025 07:04:58 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:c539:d123:6770:2110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8102E6DF;\n\tWed, 26 Feb 2025 07:03:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y68nX7Dg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740549810;\n\tbh=8HYJYwQiUHgx430eCzW4fauKCCvwLqtngK1RjlRANb0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Y68nX7Dgk9D/JZUdttEB6X4kMfW1v4FCGefxTWR6vLv/uPNykaJAtdhM3Zz7X1nRb\n\t/aqUMwJXAubf37dELLPcgh69Xpu1VA+eJ2wkjFBXB0AKxpy8QDYCnoSuSEA1s4XaLT\n\t2kOncczPSkFXCt6OgUy925ejE8VKvguJ2OCMbre8=","Date":"Wed, 26 Feb 2025 15:04:50 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: camera: Log info message to report camera\n\tcreation","Message-ID":"","References":"<20250226005547.30237-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250226005547.30237-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33531,"web_url":"https://patchwork.libcamera.org/comment/33531/","msgid":"<2829371.vuYhMxLoTh@adam-laptop-hp>","date":"2025-03-02T20:35:18","subject":"Re: [PATCH] libcamera: camera: Log info message to report camera\n\tcreation","submitter":{"id":220,"url":"https://patchwork.libcamera.org/api/people/220/","name":null,"email":"adam@piggz.co.uk"},"content":"I have tested this with the uvcvideo handler and it worked as expected.\n\nTested-by: Adam Pigg \n\n\nOn Wednesday, 26 February 2025 00:55:47 Greenwich Mean Time Laurent Pinchart \nwrote:\n> Camera creation is one of the most important events generated by\n> libcamera, but we are completely silent about it. The lack of a log\n> message makes it more difficult to identify problems and provide\n> support. Fix it by adding an Info message that reports the camera id and\n> its pipeline handler when the camera is created.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Paul Elder \n> ---\n> src/libcamera/camera.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> \n> base-commit: 33ce463a46c44f874fdbc3e484bee730e7b251a3\n> --\n> Regards,\n> \n> Laurent Pinchart\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 56c5851993c9..35097bfdafa2 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -862,6 +862,10 @@ std::shared_ptr\n> Camera::create(std::unique_ptr d, }\n> \t};\n> \n> +\tLOG(Camera, Info)\n> +\t\t<< \"Creating camera '\" << id << \"' for pipeline handler \n\"\n> +\t\t<< d->pipe_->name();\n> +\n> \tCamera *camera = new Camera(std::move(d), id, streams);\n> \n> \treturn std::shared_ptr(camera, Deleter());","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DD8DBD808\n\tfor ;\n\tSun, 2 Mar 2025 20:54:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7D916871A;\n\tSun, 2 Mar 2025 21:54:28 +0100 (CET)","from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5963B61846\n\tfor ;\n\tSun, 2 Mar 2025 21:35:24 +0100 (CET)","by mail-wm1-x32d.google.com with SMTP id\n\t5b1f17b1804b1-43998deed24so35653355e9.2\n\tfor ;\n\tSun, 02 Mar 2025 12:35:24 -0800 (PST)","from adam-laptop-hp.localnet\n\t([2a0a:ef40:c4c:a101:4aab:ea92:29a5:2c59])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-390e4844a38sm12389487f8f.75.2025.03.02.12.35.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 02 Mar 2025 12:35:21 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Z84SP4ze\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1740947723; x=1741552523;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=PM2BAZIs/kE2BCvMhvmg1D7fSZ/zQ65L7cTuuqAIK14=;\n\tb=Z84SP4ze2izdguFoGUQS7MMPRwFnjfzCRVFIUAlv9bqTV6/CXCrbOLpz0NBJxSAKBi\n\t/tVajdk6y47brj3tuwRZecLXx5w6vrGgNW6kken8I3uyT+JFbHhDr9PRjSX5j8evX37K\n\tXrDNWIsxPw8cG8irNeJrE7RD6DfC4u8bJoqCyRVpuADeZjejtqYcps9mNPEXgQEJeKoF\n\t+i+3T6xBbk8+dfHdzra5pKMqRdx4YrCkh1ihXRscQH6sXzSqw9cGinGMadkVc2RkztvI\n\tpBFoMX5Jmw81FAW4CR+zkhHX6oKXiVl1lXg/R2z5EJEifAkCbuYB8qoeT2J3Wek11w3X\n\txSeA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1740947723; x=1741552523;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:sender:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=PM2BAZIs/kE2BCvMhvmg1D7fSZ/zQ65L7cTuuqAIK14=;\n\tb=HBdn6OWUiGNfJRBQmjT7FhnLTjgdJQnUZDv+C9PxsPDhqqS/g7gSZUXK9arew7Kr0R\n\tG7Kui/JtJ8RLlKT21KCMXT0VdA1f3HHRVD4GWp6MWPjO69LsTCQU1xIByM3Asde6lFck\n\t4Eypu4h7HHedbFv47puUFYGJAVKIvERS0UH4Ab6gP/DL6FGLHdFBCAeZkFPtyt+LvAh0\n\t2tWCU2JGSWAdjJDZSVNEpHb9mZ63RhflN2yjC1dQdyoHq2QpVtOuVoJk1c+Q6uVvcDlc\n\tgoAKJv3UMoYtbgLb5k+E27ZhtSdltV72UnZ5A4Yd14BU4vfI4kFhoWoVPQ5HzMd9kZX5\n\terWA==","X-Gm-Message-State":"AOJu0YznO6Yurng8HPujZr0GS3afLHxmB4CQOGOXjWhVtLGd8PWDm529\n\tb9zKZQuv9WevIuu1yS3PviCBEdirkTrP3aI6p1ji0c61Zb+rifO05hLWAg==","X-Gm-Gg":"ASbGncvkrqmWPuIVTlgc8iHr7OkOFBu2fPg+OQ7jKJxmelCcSPR0f+qKFREALbOHhtV\n\tTgmVJJBT8AsPvIVs1o+tdJdakCyI3N1w4KLFgVNp/P7E8LbK5wgCret8tjcrUOPD86uCQc/Cjzu\n\tnr+rbyLstzClLaI4j6Te0+OHo22PBHBnFeR709/FIONittE7Re0xUImoCybKtz7t6IpuKlSEMu+\n\tWYhXtxrXN1sk9DFla+yS+QtMmvEg/OkPWItLtluINAGfwAuZtVlhW1EOk/W8qkGnl6yDJ0rOuwf\n\t50zF6S1mF1pNIU/VEB+dEkcl0Ex00G0jDavA08tWGoM7dBMC3VyYGlUu8w==","X-Google-Smtp-Source":"AGHT+IHtuOWUhMG6wnAgwvCayvwpvxLOYLVkXL5HjsZii81RvOh3DUul442uvHhxvVyJrkos3rMTcw==","X-Received":"by 2002:a05:600c:1c8c:b0:439:9ba1:5f7e with SMTP id\n\t5b1f17b1804b1-43ba675a843mr77508285e9.21.1740947722660; \n\tSun, 02 Mar 2025 12:35:22 -0800 (PST)","From":"adam@piggz.co.uk","To":"libcamera-devel@lists.libcamera.org","Cc":"Laurent Pinchart ","Subject":"Re: [PATCH] libcamera: camera: Log info message to report camera\n\tcreation","Date":"Sun, 02 Mar 2025 20:35:18 +0000","Message-ID":"<2829371.vuYhMxLoTh@adam-laptop-hp>","In-Reply-To":"<20250226005547.30237-1-laurent.pinchart@ideasonboard.com>","References":"<20250226005547.30237-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"utf-8\"","X-Mailman-Approved-At":"Sun, 02 Mar 2025 21:54:27 +0100","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33540,"web_url":"https://patchwork.libcamera.org/comment/33540/","msgid":"<174100691990.2914008.17818852095585473469@ping.linuxembedded.co.uk>","date":"2025-03-03T13:01:59","subject":"Re: [PATCH] libcamera: camera: Log info message to report camera\n\tcreation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-02-26 00:55:47)\n> Camera creation is one of the most important events generated by\n> libcamera, but we are completely silent about it. The lack of a log\n> message makes it more difficult to identify problems and provide\n> support. Fix it by adding an Info message that reports the camera id and\n> its pipeline handler when the camera is created.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/camera.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 56c5851993c9..35097bfdafa2 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -862,6 +862,10 @@ std::shared_ptr Camera::create(std::unique_ptr d,\n> }\n> };\n> \n> + LOG(Camera, Info)\n> + << \"Creating camera '\" << id << \"' for pipeline handler \"\n> + << d->pipe_->name();\n> +\n\nI'm fine with this indeed.\n\nLater on I might send the patch I have that puts the pipeline handler\ninto the CameraID too ;-)\n\n\nReviewed-by: Kieran Bingham \n\n> Camera *camera = new Camera(std::move(d), id, streams);\n> \n> return std::shared_ptr(camera, Deleter());\n> \n> base-commit: 33ce463a46c44f874fdbc3e484bee730e7b251a3\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDDBBC3257\n\tfor ;\n\tMon, 3 Mar 2025 13:02:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3A6C68772;\n\tMon, 3 Mar 2025 14:02:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACD2A68772\n\tfor ;\n\tMon, 3 Mar 2025 14:02:02 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22C8D346;\n\tMon, 3 Mar 2025 14:00:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iSR+1faq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741006831;\n\tbh=r/FfrSY5FfO3KtLm8cycMICAdDpYn4s0ug+exgYmkmY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=iSR+1faquXRe9NuXiAnyGBr7ocNkaumXojyD2t3JTGub2o/aM8KpLZ+ZK63CD/E1k\n\tY7aNkzIVUYuqz2DYsDV2zB/Mj3lJr3ivqgG8u3kLsh6HlNojHN41OtgphcRBgd9XOm\n\tq7TitAEUO0061iJNnjamtiGhNdp0U5++o/C8n7i0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250226005547.30237-1-laurent.pinchart@ideasonboard.com>","References":"<20250226005547.30237-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] libcamera: camera: Log info message to report camera\n\tcreation","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 03 Mar 2025 13:01:59 +0000","Message-ID":"<174100691990.2914008.17818852095585473469@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33541,"web_url":"https://patchwork.libcamera.org/comment/33541/","msgid":"<3bc1190e-dc6e-44a2-8a63-6ef90b15133c@ideasonboard.com>","date":"2025-03-03T13:10:38","subject":"Re: [PATCH] libcamera: camera: Log info message to report camera\n\tcreation","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n\n2025. 02. 26. 1:55 keltezéssel, Laurent Pinchart írta:\n> Camera creation is one of the most important events generated by\n> libcamera, but we are completely silent about it. The lack of a log\n> message makes it more difficult to identify problems and provide\n> support. Fix it by adding an Info message that reports the camera id and\n> its pipeline handler when the camera is created.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/camera.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 56c5851993c9..35097bfdafa2 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -862,6 +862,10 @@ std::shared_ptr Camera::create(std::unique_ptr d,\n> \t\t}\n> \t};\n> \n> +\tLOG(Camera, Info)\n> +\t\t<< \"Creating camera '\" << id << \"' for pipeline handler \"\n> +\t\t<< d->pipe_->name();\n> +\n\nI have a similar change locally but it adds log messages to `CameraManager::{add,remove}Camera()`,\nnot sure which is the better place, but I think the removal also deserves at\nleast a \"Debug\" message. I am also wondering if the \"Info\" level is not too high?\n\n\nRegards,\nBarnabás Pőcze\n\n\n> \tCamera *camera = new Camera(std::move(d), id, streams);\n> \n> \treturn std::shared_ptr(camera, Deleter());\n> \n> base-commit: 33ce463a46c44f874fdbc3e484bee730e7b251a3\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 386D8BD808\n\tfor ;\n\tMon, 3 Mar 2025 13:10:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E7EF7687EB;\n\tMon, 3 Mar 2025 14:10:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68E7568772\n\tfor ;\n\tMon, 3 Mar 2025 14:10:42 +0100 (CET)","from [192.168.33.24] (185.221.143.4.nat.pool.zt.hu [185.221.143.4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC40B2D5;\n\tMon, 3 Mar 2025 14:09:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lonLY9T3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741007350;\n\tbh=7GMKkQD56ZOxCXykmxMk7uGxN/YFeJgM0o4twQwEDiY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=lonLY9T3LJ4W4KCpiAsVOGkbja7A8W3i3n7bv9wEm9ljmXctZwzJvaGDwwQJoDQnq\n\tkxFHUSVVXaZ4+HvfhVwVxY8oJnA611MZ4kqfaA+e/AjTaT/X2spogUXL0S3Dl6r9Tw\n\tn7oEn/dHZzCzgLfija97TThwQ23MuOYF11MNIN6Y=","Message-ID":"<3bc1190e-dc6e-44a2-8a63-6ef90b15133c@ideasonboard.com>","Date":"Mon, 3 Mar 2025 14:10:38 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: camera: Log info message to report camera\n\tcreation","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250226005547.30237-1-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250226005547.30237-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33542,"web_url":"https://patchwork.libcamera.org/comment/33542/","msgid":"<04f9d7e8-1a21-4b7a-8e08-0825b85b46c4@ideasonboard.com>","date":"2025-03-03T13:18:20","subject":"Re: [PATCH] libcamera: camera: Log info message to report camera\n\tcreation","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 03. 03. 14:10 keltezéssel, Barnabás Pőcze írta:\n> Hi\n> \n> \n> 2025. 02. 26. 1:55 keltezéssel, Laurent Pinchart írta:\n>> Camera creation is one of the most important events generated by\n>> libcamera, but we are completely silent about it. The lack of a log\n>> message makes it more difficult to identify problems and provide\n>> support. Fix it by adding an Info message that reports the camera id and\n>> its pipeline handler when the camera is created.\n>>\n>> Signed-off-by: Laurent Pinchart \n>> ---\n>>   src/libcamera/camera.cpp | 4 ++++\n>>   1 file changed, 4 insertions(+)\n>>\n>> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n>> index 56c5851993c9..35097bfdafa2 100644\n>> --- a/src/libcamera/camera.cpp\n>> +++ b/src/libcamera/camera.cpp\n>> @@ -862,6 +862,10 @@ std::shared_ptr Camera::create(std::unique_ptr d,\n>>           }\n>>       };\n>>\n>> +    LOG(Camera, Info)\n>> +        << \"Creating camera '\" << id << \"' for pipeline handler \"\n>> +        << d->pipe_->name();\n>> +\n> \n> I have a similar change locally but it adds log messages to `CameraManager::{add,remove}Camera()`,\n> not sure which is the better place, but I think the removal also deserves at\n> least a \"Debug\" message. I am also wondering if the \"Info\" level is not too high?\n\nSorry, there is already a message in `removeCamera()`... I don't know what I was hallucinating...\n\n\n> \n> \n> Regards,\n> Barnabás Pőcze\n> \n> \n>>       Camera *camera = new Camera(std::move(d), id, streams);\n>>\n>>       return std::shared_ptr(camera, Deleter());\n>>\n>> base-commit: 33ce463a46c44f874fdbc3e484bee730e7b251a3\n>> -- \n>> Regards,\n>>\n>> Laurent Pinchart\n>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6CC4C3257\n\tfor ;\n\tMon, 3 Mar 2025 13:18:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC1B168779;\n\tMon, 3 Mar 2025 14:18:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A00BB68772\n\tfor ;\n\tMon, 3 Mar 2025 14:18:24 +0100 (CET)","from [192.168.33.24] (185.221.143.4.nat.pool.zt.hu [185.221.143.4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D74452D5;\n\tMon, 3 Mar 2025 14:16:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pTdPtaYK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741007813;\n\tbh=OlwFcF7zhfe+4X0qRITGurQvqOglZcRWPsrPnpMIMMI=;\n\th=Date:Subject:From:To:References:In-Reply-To:From;\n\tb=pTdPtaYKb81U166fQ6jrMMLGbcC9pbaOs+BqlNIiBBsiaAqFwiUPDjhcI1P9Xp0Sg\n\tsmR1Ola9MuJjcXIuNuJFsj23CmNdjk6JwAeklzlWwwXknVUxiRjDFxD+zQo8S7qaOg\n\tQYfqDlAdHLGuepbJkUUmK6k8Qh+jWDpEJYJmG7Zw=","Message-ID":"<04f9d7e8-1a21-4b7a-8e08-0825b85b46c4@ideasonboard.com>","Date":"Mon, 3 Mar 2025 14:18:20 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: camera: Log info message to report camera\n\tcreation","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250226005547.30237-1-laurent.pinchart@ideasonboard.com>\n\t<3bc1190e-dc6e-44a2-8a63-6ef90b15133c@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<3bc1190e-dc6e-44a2-8a63-6ef90b15133c@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33543,"web_url":"https://patchwork.libcamera.org/comment/33543/","msgid":"<20250303133434.GA32048@pendragon.ideasonboard.com>","date":"2025-03-03T13:34:34","subject":"Re: [PATCH] libcamera: camera: Log info message to report camera\n\tcreation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Mar 03, 2025 at 02:18:20PM +0100, Barnabás Pőcze wrote:\n> 2025. 03. 03. 14:10 keltezéssel, Barnabás Pőcze írta:\n> > 2025. 02. 26. 1:55 keltezéssel, Laurent Pinchart írta:\n> >> Camera creation is one of the most important events generated by\n> >> libcamera, but we are completely silent about it. The lack of a log\n> >> message makes it more difficult to identify problems and provide\n> >> support. Fix it by adding an Info message that reports the camera id and\n> >> its pipeline handler when the camera is created.\n> >>\n> >> Signed-off-by: Laurent Pinchart \n> >> ---\n> >>   src/libcamera/camera.cpp | 4 ++++\n> >>   1 file changed, 4 insertions(+)\n> >>\n> >> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> >> index 56c5851993c9..35097bfdafa2 100644\n> >> --- a/src/libcamera/camera.cpp\n> >> +++ b/src/libcamera/camera.cpp\n> >> @@ -862,6 +862,10 @@ std::shared_ptr Camera::create(std::unique_ptr d,\n> >>           }\n> >>       };\n> >>\n> >> +    LOG(Camera, Info)\n> >> +        << \"Creating camera '\" << id << \"' for pipeline handler \"\n> >> +        << d->pipe_->name();\n> >> +\n> > \n> > I have a similar change locally but it adds log messages to `CameraManager::{add,remove}Camera()`,\n> > not sure which is the better place, but I think the removal also deserves at\n> > least a \"Debug\" message. I am also wondering if the \"Info\" level is not too high?\n> \n> Sorry, there is already a message in `removeCamera()`... I don't know\n> what I was hallucinating...\n\nThe message could go to CameraManager::Private::addCamera() indeed, to\nmatch CameraManager::Private::removeCamera(). I've picked Info on\npurpose, I think this is an important event that deserves it.\n\nI'll send a v2 that moves the message to the CameraManager class.\n\n> >>       Camera *camera = new Camera(std::move(d), id, streams);\n> >>\n> >>       return std::shared_ptr(camera, Deleter());\n> >>\n> >> base-commit: 33ce463a46c44f874fdbc3e484bee730e7b251a3","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1EE30BD808\n\tfor ;\n\tMon, 3 Mar 2025 13:34:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6A7A68777;\n\tMon, 3 Mar 2025 14:34:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BAA6F68777\n\tfor ;\n\tMon, 3 Mar 2025 14:34:55 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F247D2D5;\n\tMon, 3 Mar 2025 14:33:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uf3GWrRJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741008804;\n\tbh=3FGiDZ92ePc3XHfEV7bXSUdBtucTivsdworoTBHyaa8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uf3GWrRJidudU3f2xSBVJA4WvaJnX20ziqDmIO3+4LR3vX4AFHi2aNMwA/6Zv3MpD\n\tbIMqkVftuLb6fMXOu60u4v7ZRKYmvM0kizqR9460CzORSkenp9Kpz++7naDypXYWJ9\n\tXBy8FeaMyNDq50LUXaZwaRlST4jeeHOuxF4FT2I0=","Date":"Mon, 3 Mar 2025 15:34:34 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: camera: Log info message to report camera\n\tcreation","Message-ID":"<20250303133434.GA32048@pendragon.ideasonboard.com>","References":"<20250226005547.30237-1-laurent.pinchart@ideasonboard.com>\n\t<3bc1190e-dc6e-44a2-8a63-6ef90b15133c@ideasonboard.com>\n\t<04f9d7e8-1a21-4b7a-8e08-0825b85b46c4@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<04f9d7e8-1a21-4b7a-8e08-0825b85b46c4@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]