[{"id":33488,"web_url":"https://patchwork.libcamera.org/comment/33488/","msgid":"","date":"2025-02-26T05:56:10","subject":"Re: [PATCH] libcamera: base: signal: Drop pre-C++17 support","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Feb 26, 2025 at 02:55:41AM +0200, Laurent Pinchart wrote:\n> The libcamera public API requires C++17, ddddrop support for older\n\nddddrop :)\n\n> standards.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/base/signal.h | 14 ++++----------\n> 1 file changed, 4 insertions(+), 10 deletions(-)\n> \n> diff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h\n> index bbff1495ac75..ed1d81ea5c98 100644\n> --- a/include/libcamera/base/signal.h\n> +++ b/include/libcamera/base/signal.h\n> @@ -63,11 +63,8 @@ public:\n> \n> #ifndef __DOXYGEN__\n> \ttemplate -\t\t std::enable_if_t::value\n> -#if __cplusplus >= 201703L\n> -\t\t\t\t && std::is_invocable_v\n> -#endif\n> -\t\t\t\t > * = nullptr>\n> +\t\t std::enable_if_t::value &&\n> +\t\t\t\t std::is_invocable_v> * = nullptr>\n> \tvoid connect(T *obj, Func func, ConnectionType type = ConnectionTypeAuto)\n> \t{\n> \t\tObject *object = static_cast(obj);\n> @@ -75,11 +72,8 @@ public:\n> \t}\n> \n> \ttemplate -\t\t std::enable_if_t::value\n> -#if __cplusplus >= 201703L\n> -\t\t\t\t && std::is_invocable_v\n> -#endif\n> -\t\t\t\t > * = nullptr>\n> +\t\t std::enable_if_t::value &&\n> +\t\t\t\t std::is_invocable_v> * = nullptr>\n> #else\n> \ttemplate\n> #endif\n> \n> base-commit: 33ce463a46c44f874fdbc3e484bee730e7b251a3\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B56E8BF415\n\tfor ;\n\tWed, 26 Feb 2025 05:56:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6DF66873D;\n\tWed, 26 Feb 2025 06:56:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC93661852\n\tfor ;\n\tWed, 26 Feb 2025 06:56:17 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:c539:d123:6770:2110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E2EF502;\n\tWed, 26 Feb 2025 06:54:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CuPaiPuT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740549290;\n\tbh=Hjvq6xI5CyYyY9hxlV9g7x4r/PZt1o/2VuGmYqrlSRo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CuPaiPuTvRvFC8zm6hsh3zD+24lvKbL/uXvUxrVeXZb5fs+V6nB+0zkEZMnqHibr2\n\tR9Ef13KcQvKy+NpA2GUTRCEFIF22UeWoLNpOoWF9kQ1pp5XJT9WJKwm8rBis7jVegN\n\tsTaIX0kjJfYOjubEnuUQGfL3UeiimP3427MXLpOE=","Date":"Wed, 26 Feb 2025 14:56:10 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: base: signal: Drop pre-C++17 support","Message-ID":"","References":"<20250226005541.30200-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250226005541.30200-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33537,"web_url":"https://patchwork.libcamera.org/comment/33537/","msgid":"<174100562474.2914008.12812870312128601597@ping.linuxembedded.co.uk>","date":"2025-03-03T12:40:24","subject":"Re: [PATCH] libcamera: base: signal: Drop pre-C++17 support","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2025-02-26 05:56:10)\n> On Wed, Feb 26, 2025 at 02:55:41AM +0200, Laurent Pinchart wrote:\n> > The libcamera public API requires C++17, ddddrop support for older\n> \n> ddddrop :)\n> \n> > standards.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Paul Elder \n\nReviewed-by: Kieran Bingham \n\n> \n> > ---\n> > include/libcamera/base/signal.h | 14 ++++----------\n> > 1 file changed, 4 insertions(+), 10 deletions(-)\n> > \n> > diff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h\n> > index bbff1495ac75..ed1d81ea5c98 100644\n> > --- a/include/libcamera/base/signal.h\n> > +++ b/include/libcamera/base/signal.h\n> > @@ -63,11 +63,8 @@ public:\n> > \n> > #ifndef __DOXYGEN__\n> > template > - std::enable_if_t::value\n> > -#if __cplusplus >= 201703L\n> > - && std::is_invocable_v\n> > -#endif\n> > - > * = nullptr>\n> > + std::enable_if_t::value &&\n> > + std::is_invocable_v> * = nullptr>\n> > void connect(T *obj, Func func, ConnectionType type = ConnectionTypeAuto)\n> > {\n> > Object *object = static_cast(obj);\n> > @@ -75,11 +72,8 @@ public:\n> > }\n> > \n> > template > - std::enable_if_t::value\n> > -#if __cplusplus >= 201703L\n> > - && std::is_invocable_v\n> > -#endif\n> > - > * = nullptr>\n> > + std::enable_if_t::value &&\n> > + std::is_invocable_v> * = nullptr>\n> > #else\n> > template\n> > #endif\n> > \n> > base-commit: 33ce463a46c44f874fdbc3e484bee730e7b251a3\n> > --\n> > Regards,\n> > \n> > Laurent Pinchart\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2CB5DBD808\n\tfor ;\n\tMon, 3 Mar 2025 12:40:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F76E68777;\n\tMon, 3 Mar 2025 13:40:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69CDD68772\n\tfor ;\n\tMon, 3 Mar 2025 13:40:27 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E61D6346;\n\tMon, 3 Mar 2025 13:38:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hAmWzNTS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741005536;\n\tbh=S/eDUllqvHVL3UAXfxm8q51K+WdGiXs+d6vqc9b1prI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=hAmWzNTSME2pQRU89fi6b/h2c6Oi5UiHkHH4exW08JBe7p6WBcyoatyWrjqOu31f3\n\t7EFOYVmjYU488JfXX2qg/9j/Fv7Crz+BE9B4JIkIoFXpV14wUcq05l3/sgRst46sMD\n\tLgP4sJtVVNULPpVFYidUzY9yYf9P+W89oBdX/MSw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250226005541.30200-1-laurent.pinchart@ideasonboard.com>\n\t","Subject":"Re: [PATCH] libcamera: base: signal: Drop pre-C++17 support","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart ,\n\tPaul Elder ","Date":"Mon, 03 Mar 2025 12:40:24 +0000","Message-ID":"<174100562474.2914008.12812870312128601597@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]