[{"id":33526,"web_url":"https://patchwork.libcamera.org/comment/33526/","msgid":"<174087246904.3864332.8934702061428144094@ping.linuxembedded.co.uk>","date":"2025-03-01T23:41:09","subject":"Re: [PATCH v5 5/5] pipeline: simple: Create DelayedControls instance\n\tonce only","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stanislaw Gruszka (2025-02-25 16:41:16)\n> From: Laurent Pinchart \n> \n> The DelayedControls instance for the camera sensor is created in\n> SimplePipelineHandler::configure(). Constant deletion and reconstruction\n> of a new object is unnecessary, as the control delays are an intrinsic\n> property of the sensor and are known at initialization time. Move the\n> DelayedControls creation to the SimpleCameraData class constructor.\n> \n> Signed-off-by: Laurent Pinchart \n> Signed-off-by: Stanislaw Gruszka \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 16 +++++++---------\n> 1 file changed, 7 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index b92b738b..73a4138e 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -489,6 +489,13 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n> if (!sensor_)\n> return;\n> \n> + const CameraSensorProperties::SensorDelays &delays = sensor_->sensorDelays();\n> + std::unordered_map params = {\n> + { V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n> + { V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n> + };\n> + delayedCtrls_ = std::make_unique(sensor_->device(), params);\n> +\n> LOG(SimplePipeline, Debug)\n> << \"Found pipeline: \"\n> << utils::join(entities_, \" -> \",\n> @@ -1294,15 +1301,6 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> if (outputCfgs.empty())\n> return 0;\n> \n> - const CameraSensorProperties::SensorDelays &delays = data->sensor_->sensorDelays();\n> - std::unordered_map params = {\n> - { V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n> - { V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n> - };\n> - data->delayedCtrls_ =\n> - std::make_unique(data->sensor_->device(),\n> - params);\n> -\n> StreamConfiguration inputCfg;\n> inputCfg.pixelFormat = pipeConfig->captureFormat;\n> inputCfg.size = pipeConfig->captureSize;\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66BB8C3263\n\tfor ;\n\tSat, 1 Mar 2025 23:41:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 220F468754;\n\tSun, 2 Mar 2025 00:41:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4033461853\n\tfor ;\n\tSun, 2 Mar 2025 00:41:11 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 09F53666;\n\tSun, 2 Mar 2025 00:39:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vnUzi0Nr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740872381;\n\tbh=M3IXDTn+Adr7hbrIYY9OhpfA7slbvnCBGUchPl/6y4M=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=vnUzi0NrTFZq+xALLw5mIPiUJmryzTTT/o20+21M2VDolq+8AjnYYKQFKiIsUhNQS\n\t7Yb/cjpW0tadieqThotOtUK5IrwnuwGE6NZGPW/EuwJleTJjNwTmDO0/3dTjJ3gZKs\n\t3yPXi8vG5YqjCk2QasjnpUIJx0PRVvhSceS/CRT8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250225164116.414301-6-stanislaw.gruszka@linux.intel.com>","References":"<20250225164116.414301-1-stanislaw.gruszka@linux.intel.com>\n\t<20250225164116.414301-6-stanislaw.gruszka@linux.intel.com>","Subject":"Re: [PATCH v5 5/5] pipeline: simple: Create DelayedControls instance\n\tonce only","From":"Kieran Bingham ","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ,\n\tNaushir Patuck ,\n\tSakari Ailus ,\n\tHans de Goede ","To":"Stanislaw Gruszka ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sat, 01 Mar 2025 23:41:09 +0000","Message-ID":"<174087246904.3864332.8934702061428144094@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]