{"id":22857,"url":"https://patchwork.libcamera.org/api/patches/22857/?format=json","web_url":"https://patchwork.libcamera.org/patch/22857/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250225150614.20195-2-mzamazal@redhat.com>","date":"2025-02-25T15:06:07","name":"[v3,1/6] libcamera: software_isp: Emit ispStatsReady only if IPA is running","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"19f30594282adcd071eceaef37d7a57aad04acce","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22857/mbox/","series":[{"id":5019,"url":"https://patchwork.libcamera.org/api/series/5019/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5019","date":"2025-02-25T15:06:06","name":"Fix occasional software ISP assertion error on stop","version":3,"mbox":"https://patchwork.libcamera.org/series/5019/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22857/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22857/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3EB50BDB1C\n\tfor ;\n\tTue, 25 Feb 2025 15:06:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 989C06871F;\n\tTue, 25 Feb 2025 16:06:32 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D73AD61855\n\tfor ;\n\tTue, 25 Feb 2025 16:06:29 +0100 (CET)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-652-OHhc8cz7MUqMsXUHmASi7A-1;\n\tTue, 25 Feb 2025 10:06:27 -0500","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 523D11975AFC; Tue, 25 Feb 2025 15:06:26 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.119])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 46386180035F; Tue, 25 Feb 2025 15:06:24 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"S3oHJSU/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1740495988;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=kOI2yAMnOqdn+NRq9PiaAmANGbd3NScM+hL3TL2cZh0=;\n\tb=S3oHJSU/cSLcqK/jRp7U13OEChFWwWQFbBOuRIpPZH+f6vS49kQV8/iJtFGMGSO+XSPsFI\n\t31ZSVOF9ekamz4vRlq6z9eySEG6zogh2KwNnJCYNnPpaFX64Rw1U2E0/oj445zcDu4PdqQ\n\tId0apfWSfCfLekIYWjzP4u58ijvTGeo=","X-MC-Unique":"OHhc8cz7MUqMsXUHmASi7A-1","X-Mimecast-MFC-AGG-ID":"OHhc8cz7MUqMsXUHmASi7A_1740495986","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tStanislaw Gruszka ,\n\tLaurent Pinchart ,\n\tKieran Bingham ","Subject":"[PATCH v3 1/6] libcamera: software_isp: Emit ispStatsReady only if\n\tIPA is running","Date":"Tue, 25 Feb 2025 16:06:07 +0100","Message-ID":"<20250225150614.20195-2-mzamazal@redhat.com>","In-Reply-To":"<20250225150614.20195-1-mzamazal@redhat.com>","References":"<20250225150614.20195-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"k_qcu-bEqTxzXDjxLp1LhzDqfvZb0D3cr53WKuLIekM_1740495986","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Software ISP runs debayering in a separate thread and debayering may\nemit statsReady when software ISP (including the IPA) is being stopped.\nThe signal waits in a queue and gets invoked later, resulting in an\nassertion error when attempting to invoke a method on the stopped IPA:\n\n FATAL default soft_ipa_proxy.cpp:456 assertion\n \"state_ == ProxyRunning\" failed in processStatsThread()\n\nLet's prevent this problem by forwarding the ISP stats signal from\nsoftware ISP only when the IPA is running. To track this,\nSoftwareISP::running_ variable is introduced.\n\nMaking processing of the other signals in SoftwareISP more robust is\naddressed in the followup patches.\n\nSigned-off-by: Milan Zamazal \nReported-by: Stanislaw Gruszka \nReviewed-by: Laurent Pinchart \n---\n include/libcamera/internal/software_isp/software_isp.h | 1 +\n src/libcamera/software_isp/software_isp.cpp | 5 ++++-\n 2 files changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex 440a296d..af0dcc24 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -100,6 +100,7 @@ private:\n \tDmaBufAllocator dmaHeap_;\n \n \tstd::unique_ptr ipa_;\n+\tbool running_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 44baf200..1a39f4d8 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -315,6 +315,7 @@ int SoftwareIsp::start()\n \tint ret = ipa_->start();\n \tif (ret)\n \t\treturn ret;\n+\trunning_ = true;\n \n \tispWorkerThread_.start();\n \treturn 0;\n@@ -328,6 +329,7 @@ void SoftwareIsp::stop()\n \tispWorkerThread_.exit();\n \tispWorkerThread_.wait();\n \n+\trunning_ = false;\n \tipa_->stop();\n }\n \n@@ -356,7 +358,8 @@ void SoftwareIsp::setSensorCtrls(const ControlList &sensorControls)\n \n void SoftwareIsp::statsReady(uint32_t frame, uint32_t bufferId)\n {\n-\tispStatsReady.emit(frame, bufferId);\n+\tif (running_)\n+\t\tispStatsReady.emit(frame, bufferId);\n }\n \n void SoftwareIsp::inputReady(FrameBuffer *input)\n","prefixes":["v3","1/6"]}