{"id":22854,"url":"https://patchwork.libcamera.org/api/patches/22854/?format=json","web_url":"https://patchwork.libcamera.org/patch/22854/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250224220438.21512-3-laurent.pinchart@ideasonboard.com>","date":"2025-02-24T22:04:38","name":"[2/2] meson: Enable the -Wnon-virtual-dtor compiler option","commit_ref":"4849a84a9bf3577435ba7e9bc39a8ff5d8960e6e","pull_url":null,"state":"accepted","archived":false,"hash":"198d27841daa5405d68e02a7aa1468a954611886","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22854/mbox/","series":[{"id":5017,"url":"https://patchwork.libcamera.org/api/series/5017/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5017","date":"2025-02-24T22:04:36","name":"libcamera: Fix -Wnon-virtual-dtor warning","version":1,"mbox":"https://patchwork.libcamera.org/series/5017/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22854/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22854/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4AEC7BF415\n\tfor ;\n\tMon, 24 Feb 2025 22:05:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF3AD68719;\n\tMon, 24 Feb 2025 23:05:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AFF16870E\n\tfor ;\n\tMon, 24 Feb 2025 23:05:02 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F9E482A;\n\tMon, 24 Feb 2025 23:03:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iw9fHluk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740434615;\n\tbh=tCrJlyp082j7WOX1a1l+duTfQIxi8EvqffXdAx0AoDY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=iw9fHluk4o1VVQ3lcd4tKJD79nLhOPBOWTOlenB4ET5KVrQf85ix7h0hFtGbrAvzj\n\t9tm5rHoLcsfAJCPP8BlTuD1Ca0H48Z3mJIiKEARzUtk2qaMrFq+6tVR+h5Bqm0RwQt\n\tkVwQfI89bECcJieXBMxasOMEProm5Wk/4CIcIhZ8=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tMilan Zamazal ","Subject":"[PATCH 2/2] meson: Enable the -Wnon-virtual-dtor compiler option","Date":"Tue, 25 Feb 2025 00:04:38 +0200","Message-ID":"<20250224220438.21512-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.3","In-Reply-To":"<20250224220438.21512-1-laurent.pinchart@ideasonboard.com>","References":"<20250224220438.21512-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A base class with virtual functions and a non-virtual public destructor\nis prone to undefined behaviourif deleted from a pointer to the base.\nEnable the -Wnon-virtual-dtor warning to report those issues.\n\nSigned-off-by: Laurent Pinchart \n---\n meson.build | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/meson.build b/meson.build\nindex 5270f626f2fb..f8d32dcf8d7a 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -110,7 +110,9 @@ common_arguments = [\n ]\n \n c_arguments = []\n-cpp_arguments = []\n+cpp_arguments = [\n+ '-Wnon-virtual-dtor',\n+]\n \n cxx_stdlib = 'libstdc++'\n \n","prefixes":["2/2"]}