[{"id":33458,"web_url":"https://patchwork.libcamera.org/comment/33458/","msgid":"<20250224195959.GJ6778@pendragon.ideasonboard.com>","date":"2025-02-24T19:59:59","subject":"Re: [PATCH v2 4/5] libcamera: base: Fix formatting in thread.cpp","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Feb 24, 2025 at 07:52:34PM +0100, Milan Zamazal wrote:\n> Let's make the autoformatter happy with thread.cpp formatting.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> src/libcamera/base/thread.cpp | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\n> index 319bfda9..02128f23 100644\n> --- a/src/libcamera/base/thread.cpp\n> +++ b/src/libcamera/base/thread.cpp\n> @@ -5,8 +5,6 @@\n> * Thread support\n> */\n> \n> -#include \n> -\n\nThis is done on purpose, see Documentation/coding-style.rst:\n\n For .cpp files, if the file implements an API declared in a header\n file, that header file shall be included first in order to ensure it\n is self-contained.\n\n> #include \n> #include \n> #include \n> @@ -20,6 +18,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> /**\n> * \\page thread Thread Support\n> @@ -657,7 +656,7 @@ void Thread::dispatchMessages(Message::Type type)\n> \t * the outer calls.\n> \t */\n> \tif (!--data_->messages_.recursion_) {\n> -\t\tfor (auto iter = messages.begin(); iter != messages.end(); ) {\n> +\t\tfor (auto iter = messages.begin(); iter != messages.end();) {\n\nHmmmm... I thought we standardized on the style with a space, but we\nhave 6 occurrences with a space, and 15 without. Among those 15, 10 are\nin the software ISP though :-)\n\nI find the space more readable, but if there's no way to make\nclang-format happy about it, I'm OK dropping it.\n\n> \t\t\tif (!*iter)\n> \t\t\t\titer = messages.erase(iter);\n> \t\t\telse","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A152FC324E\n\tfor ;\n\tMon, 24 Feb 2025 20:00:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A493C68701;\n\tMon, 24 Feb 2025 21:00:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8008F61856\n\tfor ;\n\tMon, 24 Feb 2025 21:00:17 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92BC0220;\n\tMon, 24 Feb 2025 20:58:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J2UHbbyu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740427130;\n\tbh=zPmjkIYtkPL8jvVve1jWNzrznc0mMnIZbV1zLbvOh0A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J2UHbbyuTJpUwpoc9R/6PrsF4wk80uTbKi4r9gTd3A76CSGPLiqWfYXum+m5yJu2d\n\tG4J5O+3+IlX1wElaoPhjlnrsfid4CKJCEUjJx30eeaDaGvRysBpJVD3v+0onyGepRR\n\txwXMAu/gHmXYGoz1VRFEThPxkDBm3RXyg0aZEQJ4=","Date":"Mon, 24 Feb 2025 21:59:59 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tStanislaw Gruszka ,\n\tKieran Bingham ","Subject":"Re: [PATCH v2 4/5] libcamera: base: Fix formatting in thread.cpp","Message-ID":"<20250224195959.GJ6778@pendragon.ideasonboard.com>","References":"<20250224185235.43381-1-mzamazal@redhat.com>\n\t<20250224185235.43381-5-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250224185235.43381-5-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33460,"web_url":"https://patchwork.libcamera.org/comment/33460/","msgid":"<85a5abm697.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-02-24T20:34:28","subject":"Re: [PATCH v2 4/5] libcamera: base: Fix formatting in thread.cpp","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Laurent,\n\nthank you for review.\n\nLaurent Pinchart writes:\n\n> Hi Milan,\n>\n> Thank you for the patch.\n>\n> On Mon, Feb 24, 2025 at 07:52:34PM +0100, Milan Zamazal wrote:\n>> Let's make the autoformatter happy with thread.cpp formatting.\n>> \n>> Signed-off-by: Milan Zamazal \n>> ---\n>> src/libcamera/base/thread.cpp | 5 ++---\n>> 1 file changed, 2 insertions(+), 3 deletions(-)\n>> \n>> diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\n>> index 319bfda9..02128f23 100644\n>> --- a/src/libcamera/base/thread.cpp\n>> +++ b/src/libcamera/base/thread.cpp\n>> @@ -5,8 +5,6 @@\n>> * Thread support\n>> */\n>> \n>> -#include \n>> -\n>\n> This is done on purpose, see Documentation/coding-style.rst:\n>\n> For .cpp files, if the file implements an API declared in a header\n> file, that header file shall be included first in order to ensure it\n> is self-contained.\n\nAh, right. It seems the autoformatter does the right thing for includes\nwith quotes but not for those with angle brackets. I can see in\n.clang-format\n\n IncludeCategories:\n # Headers matching the name of the component are matched automatically.\n # Priority 1\n\nso it doesn't look like we can do anything about it.\n\n>> #include \n>> #include \n>> #include \n>> @@ -20,6 +18,7 @@\n>> #include \n>> #include \n>> #include \n>> +#include \n>> \n>> /**\n>> * \\page thread Thread Support\n>> @@ -657,7 +656,7 @@ void Thread::dispatchMessages(Message::Type type)\n>> \t * the outer calls.\n>> \t */\n>> \tif (!--data_->messages_.recursion_) {\n>> -\t\tfor (auto iter = messages.begin(); iter != messages.end(); ) {\n>> +\t\tfor (auto iter = messages.begin(); iter != messages.end();) {\n>\n> Hmmmm... I thought we standardized on the style with a space, but we\n> have 6 occurrences with a space, and 15 without. Among those 15, 10 are\n> in the software ISP though :-)\n\nMaybe because of the autoformatter assistance?\n\n> I find the space more readable, but if there's no way to make\n> clang-format happy about it, I'm OK dropping it.\n\nI don't mind either way as long as I don't have to override changes made\nby the formatter all the time. :-)\n\n>> \t\t\tif (!*iter)\n>> \t\t\t\titer = messages.erase(iter);\n>> \t\t\telse","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16DD9C324E\n\tfor ;\n\tMon, 24 Feb 2025 20:34:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 528FA68702;\n\tMon, 24 Feb 2025 21:34:37 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EAF8B61856\n\tfor ;\n\tMon, 24 Feb 2025 21:34:34 +0100 (CET)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-663-PMxIaDjkMtOK06dBPfxiDQ-1; Mon, 24 Feb 2025 15:34:32 -0500","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-43942e82719so36164665e9.2\n\tfor ;\n\tMon, 24 Feb 2025 12:34:32 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-43ab155eb97sm2145175e9.26.2025.02.24.12.34.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 24 Feb 2025 12:34:29 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"IudZcppQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1740429273;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=qKdMXcUc+AThTJuSsR7d+szw7Eg9oyzQgUhDdQCVWJQ=;\n\tb=IudZcppQwTspPbksDvqXFnJhulBfC6526ix8DgBR5JGMiuh1lAOvkOLXJn64ocXgD9PKMD\n\t31klvNB3pTPzuPtgurNEYuJG9BofJrUaEhhddirbJP0nrls0bBqiLHFLM2wpL5XqqWii/E\n\tK9+LKgZLngK+ifgmHdyOIMsyC539OGc=","X-MC-Unique":"PMxIaDjkMtOK06dBPfxiDQ-1","X-Mimecast-MFC-AGG-ID":"PMxIaDjkMtOK06dBPfxiDQ_1740429271","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1740429271; x=1741034071;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=qKdMXcUc+AThTJuSsR7d+szw7Eg9oyzQgUhDdQCVWJQ=;\n\tb=kVGMEyWIC79pAjyjjt+UlV9ovJ95oguKlEIp6zxyeQiRrOs6MHKW3HgtXrwJi0tXyD\n\t96+yH2Pegtpc1/KFpmoZsYjtN1jKV076ZUw+d3qr5XJxYb0NXRw7dlYbIv5jOG4+VEWi\n\tV2GBzd+W80t2dTjf6kKQRxhAxmktBp+QVf9SOUBXbPTk3iIUU5NhKhZkJPmh08XpwF4E\n\t41cMl+JilAj5qijV41zG+hPWgUAgQt09S9XeZnL2ZIWK4aiBV9w6rwY4VKo/KtgJ2MlW\n\tkuK9uFN4/Hz937KjX9IodQZ+6yl/rAlFRtzzEUpYw/csaYC0vEsrtytUD7Qv4qqGQ2KK\n\tgfwg==","X-Gm-Message-State":"AOJu0YxvYhIdQxCDOXmTMKvpRXS28BerA6PblYyqDrlw4Hm0Q19dnIyh\n\twhbHyN4/woXiEEcjb8OqxQk4fGrufk76YelDYsUBsfX6B5hGcGtF00j5kNCcWLhHmVkIhCcP19Y\n\t0qIgn6Jd/Dju0C7pMs0YUrH5tRzBT7A7i1Fmh973Qr4G0A55dcMi2rnZn72lFDDGnU5N1RppN9i\n\ts8CAs=","X-Gm-Gg":"ASbGncsdMuTC6vuGKU7e0EAZNI9NW5AtVbL9JxoeRXXZXpYXyKBugwYcovnec6Ql1Tl\n\tmY8zd+hqx5WmQ6MSYPJEpEa9ICvYeK3di2bncsrKVH02LpNoJO5Dh2Y8EN80oR2gRS/XV1OEEsJ\n\tq3u2KAyY2UQ3DfK7ors6bvJCZvlJ7MZn8MNf8Q/9t+S1IRxU5qa5SrbfIMhjQ59vPXQOtXqqJXf\n\tYcMp1nIpp1g0spn89To7F+XE2MPbQU0JpXdvl/T7AbXEebkVvZLlvdnSA+ZLuiggY3m+9p0/DsL\n\tncNM6uIQuBTj4pLusL8Q5RBH9QVzh4tF8kkIyozD+djJSOJb0kq4LvbfmJZNKCmwvpD4","X-Received":["by 2002:a5d:6482:0:b0:38d:e6b6:508b with SMTP id\n\tffacd0b85a97d-38f6e755c4emr13258717f8f.9.1740429270845; \n\tMon, 24 Feb 2025 12:34:30 -0800 (PST)","by 2002:a5d:6482:0:b0:38d:e6b6:508b with SMTP id\n\tffacd0b85a97d-38f6e755c4emr13258703f8f.9.1740429270448; \n\tMon, 24 Feb 2025 12:34:30 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IEJlraCY1O7EuuITZOXM3r7I+aYflAhK8nNHt+FQLLtc6w7Q44uP8pe7rOZDIUNEXBvjH4sNA==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Stanislaw Gruszka\n\t, Kieran Bingham\n\t","Subject":"Re: [PATCH v2 4/5] libcamera: base: Fix formatting in thread.cpp","In-Reply-To":"<20250224195959.GJ6778@pendragon.ideasonboard.com> (Laurent\n\tPinchart's message of \"Mon, 24 Feb 2025 21:59:59 +0200\")","References":"<20250224185235.43381-1-mzamazal@redhat.com>\n\t<20250224185235.43381-5-mzamazal@redhat.com>\n\t<20250224195959.GJ6778@pendragon.ideasonboard.com>","Date":"Mon, 24 Feb 2025 21:34:28 +0100","Message-ID":"<85a5abm697.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"aAxGRHrJ7T73Ja2iWrz5WP3JMtWsGMEaX-jWx7NiwcE_1740429271","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33465,"web_url":"https://patchwork.libcamera.org/comment/33465/","msgid":"<20250224210342.GL6778@pendragon.ideasonboard.com>","date":"2025-02-24T21:03:42","subject":"Re: [PATCH v2 4/5] libcamera: base: Fix formatting in thread.cpp","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Feb 24, 2025 at 09:34:28PM +0100, Milan Zamazal wrote:\n> Laurent Pinchart writes:\n> > On Mon, Feb 24, 2025 at 07:52:34PM +0100, Milan Zamazal wrote:\n> >> Let's make the autoformatter happy with thread.cpp formatting.\n> >> \n> >> Signed-off-by: Milan Zamazal \n> >> ---\n> >> src/libcamera/base/thread.cpp | 5 ++---\n> >> 1 file changed, 2 insertions(+), 3 deletions(-)\n> >> \n> >> diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\n> >> index 319bfda9..02128f23 100644\n> >> --- a/src/libcamera/base/thread.cpp\n> >> +++ b/src/libcamera/base/thread.cpp\n> >> @@ -5,8 +5,6 @@\n> >> * Thread support\n> >> */\n> >> \n> >> -#include \n> >> -\n> >\n> > This is done on purpose, see Documentation/coding-style.rst:\n> >\n> > For .cpp files, if the file implements an API declared in a header\n> > file, that header file shall be included first in order to ensure it\n> > is self-contained.\n> \n> Ah, right. It seems the autoformatter does the right thing for includes\n> with quotes but not for those with angle brackets. I can see in\n> .clang-format\n> \n> IncludeCategories:\n> # Headers matching the name of the component are matched automatically.\n> # Priority 1\n> \n> so it doesn't look like we can do anything about it.\n> \n> >> #include \n> >> #include \n> >> #include \n> >> @@ -20,6 +18,7 @@\n> >> #include \n> >> #include \n> >> #include \n> >> +#include \n> >> \n> >> /**\n> >> * \\page thread Thread Support\n> >> @@ -657,7 +656,7 @@ void Thread::dispatchMessages(Message::Type type)\n> >> \t * the outer calls.\n> >> \t */\n> >> \tif (!--data_->messages_.recursion_) {\n> >> -\t\tfor (auto iter = messages.begin(); iter != messages.end(); ) {\n> >> +\t\tfor (auto iter = messages.begin(); iter != messages.end();) {\n> >\n> > Hmmmm... I thought we standardized on the style with a space, but we\n> > have 6 occurrences with a space, and 15 without. Among those 15, 10 are\n> > in the software ISP though :-)\n> \n> Maybe because of the autoformatter assistance?\n> \n> > I find the space more readable, but if there's no way to make\n> > clang-format happy about it, I'm OK dropping it.\n> \n> I don't mind either way as long as I don't have to override changes made\n> by the formatter all the time. :-)\n\nI didn't find a suitable clang-format option after a cursory look. If\nyou can't see one either, I'm fine changing this.\n\nAs the header change from this patch needs to be dropped, you could\nsubmit a v2 that drops the space after the semicolon in all locations (I\njust ran \"git grep '; )'\" to locate them). That can be sent as patch of\nits own, separate from this series.\n\n> >> \t\t\tif (!*iter)\n> >> \t\t\t\titer = messages.erase(iter);\n> >> \t\t\telse","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EC44C32A9\n\tfor ;\n\tMon, 24 Feb 2025 21:04:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 403686870E;\n\tMon, 24 Feb 2025 22:04:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CAFF686FF\n\tfor ;\n\tMon, 24 Feb 2025 22:04:01 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3681D220;\n\tMon, 24 Feb 2025 22:02:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KXP8+GBL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740430954;\n\tbh=pNn8RJvsPzENjdbP+97A9CWiBUGgJzh5quKnL2R6fX8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KXP8+GBLeLaEonQVq2EVm6i3Bjux+FGd4uTEq2JrC1JZaTU3/4x2rgEvXKJL//v8H\n\takUPJkVVX3aon0KSiJI3ATUyMZpaX/Ue6fT3B+vJYw4Hp/BpUiaGuERZVXCTCCGSQk\n\t4G6/aJVjwr0nMfIuKf/c3+gt9Vs8RQQuuBarkCQo=","Date":"Mon, 24 Feb 2025 23:03:42 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tStanislaw Gruszka ,\n\tKieran Bingham ","Subject":"Re: [PATCH v2 4/5] libcamera: base: Fix formatting in thread.cpp","Message-ID":"<20250224210342.GL6778@pendragon.ideasonboard.com>","References":"<20250224185235.43381-1-mzamazal@redhat.com>\n\t<20250224185235.43381-5-mzamazal@redhat.com>\n\t<20250224195959.GJ6778@pendragon.ideasonboard.com>\n\t<85a5abm697.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<85a5abm697.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]