{"id":22851,"url":"https://patchwork.libcamera.org/api/patches/22851/?format=json","web_url":"https://patchwork.libcamera.org/patch/22851/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250224185235.43381-5-mzamazal@redhat.com>","date":"2025-02-24T18:52:34","name":"[v2,4/5] libcamera: base: Fix formatting in thread.cpp","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"cba25da4c7503decad0c5ce3dd542a4f9a5a567c","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22851/mbox/","series":[{"id":5016,"url":"https://patchwork.libcamera.org/api/series/5016/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5016","date":"2025-02-24T18:52:30","name":"Fix occasional software ISP assertion error on stop","version":2,"mbox":"https://patchwork.libcamera.org/series/5016/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22851/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22851/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 151C3C32C2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Feb 2025 18:53:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89EE768707;\n\tMon, 24 Feb 2025 19:53:05 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EACC268705\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 19:53:01 +0100 (CET)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-359-bec1-ZqaO2qYk5eG9bALxQ-1;\n\tMon, 24 Feb 2025 13:52:55 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id BA1BB1800570; Mon, 24 Feb 2025 18:52:54 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.225.60])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id DB61F1800352; Mon, 24 Feb 2025 18:52:52 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"RbzPX6rO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1740423180;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=VhZSMnTkSMHOBoDCRJqhrex1EQoVkWDnJS7uGdChitc=;\n\tb=RbzPX6rO4epI6A0E5cyRbVqiLCB0QMgdaiHpN/T22gNH376BudWB0KkLlwfSjK4+Wy86WX\n\tfbj/iEOTTwDnlgy1FikacKjhxHiCQl86M59yJxu+d6GHdN/D504LvIp6ZeGgJHr2Yz0L2q\n\tQVx0xyept3P3S0H2H5WcLI+34riNbKg=","X-MC-Unique":"bec1-ZqaO2qYk5eG9bALxQ-1","X-Mimecast-MFC-AGG-ID":"bec1-ZqaO2qYk5eG9bALxQ_1740423174","From":"Milan Zamazal <mzamazal@redhat.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal <mzamazal@redhat.com>,\n\tStanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"[PATCH v2 4/5] libcamera: base: Fix formatting in thread.cpp","Date":"Mon, 24 Feb 2025 19:52:34 +0100","Message-ID":"<20250224185235.43381-5-mzamazal@redhat.com>","In-Reply-To":"<20250224185235.43381-1-mzamazal@redhat.com>","References":"<20250224185235.43381-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"mSPHW9As5TRsqmI_JFgx05Gfy1dbtINcZZMRM3sWxo0_1740423174","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Let's make the autoformatter happy with thread.cpp formatting.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/base/thread.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\nindex 319bfda9..02128f23 100644\n--- a/src/libcamera/base/thread.cpp\n+++ b/src/libcamera/base/thread.cpp\n@@ -5,8 +5,6 @@\n  * Thread support\n  */\n \n-#include <libcamera/base/thread.h>\n-\n #include <atomic>\n #include <list>\n #include <optional>\n@@ -20,6 +18,7 @@\n #include <libcamera/base/message.h>\n #include <libcamera/base/mutex.h>\n #include <libcamera/base/object.h>\n+#include <libcamera/base/thread.h>\n \n /**\n  * \\page thread Thread Support\n@@ -657,7 +656,7 @@ void Thread::dispatchMessages(Message::Type type)\n \t * the outer calls.\n \t */\n \tif (!--data_->messages_.recursion_) {\n-\t\tfor (auto iter = messages.begin(); iter != messages.end(); ) {\n+\t\tfor (auto iter = messages.begin(); iter != messages.end();) {\n \t\t\tif (!*iter)\n \t\t\t\titer = messages.erase(iter);\n \t\t\telse\n","prefixes":["v2","4/5"]}