{"id":22844,"url":"https://patchwork.libcamera.org/api/patches/22844/?format=json","web_url":"https://patchwork.libcamera.org/patch/22844/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250224120854.19747-5-mzamazal@redhat.com>","date":"2025-02-24T12:08:53","name":"[4/5] libcamera: base: Fix formatting in thread.cpp","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"cba25da4c7503decad0c5ce3dd542a4f9a5a567c","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22844/mbox/","series":[{"id":5015,"url":"https://patchwork.libcamera.org/api/series/5015/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5015","date":"2025-02-24T12:08:49","name":"Fix occasional software ISP assertion error on stop","version":1,"mbox":"https://patchwork.libcamera.org/series/5015/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22844/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22844/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF5AAC324E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Feb 2025 12:09:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72BA5686FA;\n\tMon, 24 Feb 2025 13:09:23 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63E18686F4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 13:09:21 +0100 (CET)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-91-0CX69NwiNCii2PGiCqwnFQ-1;\n\tMon, 24 Feb 2025 07:09:16 -0500","from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id E4E3319560BC; Mon, 24 Feb 2025 12:09:14 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.225.60])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id DC89219560AA; Mon, 24 Feb 2025 12:09:12 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"gWVmhpEp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1740398960;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=VhZSMnTkSMHOBoDCRJqhrex1EQoVkWDnJS7uGdChitc=;\n\tb=gWVmhpEpnE+m9yz94HczBtsR8uOH4Pffdyhh/rGNT2NHqz5REffyC3j/8R4jv5djCY1UKt\n\tDU5aUSqeJYYwp/HfrM6rLXIEgjRsrefMrjLyRO191clYXow6ky7+G4KHnb3TYASWmMvCn5\n\t6rP+7cmSgrkuJhubn25Uz/9D/Szuo2E=","X-MC-Unique":"0CX69NwiNCii2PGiCqwnFQ-1","X-Mimecast-MFC-AGG-ID":"0CX69NwiNCii2PGiCqwnFQ_1740398955","From":"Milan Zamazal <mzamazal@redhat.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal <mzamazal@redhat.com>,\n\tStanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"[PATCH 4/5] libcamera: base: Fix formatting in thread.cpp","Date":"Mon, 24 Feb 2025 13:08:53 +0100","Message-ID":"<20250224120854.19747-5-mzamazal@redhat.com>","In-Reply-To":"<20250224120854.19747-1-mzamazal@redhat.com>","References":"<20250224120854.19747-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.40","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"p0fCIdwvTjpElKQNDyITWGYFC_Al48BPi8p43LKt7rI_1740398955","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Let's make the autoformatter happy with thread.cpp formatting.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/base/thread.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\nindex 319bfda9..02128f23 100644\n--- a/src/libcamera/base/thread.cpp\n+++ b/src/libcamera/base/thread.cpp\n@@ -5,8 +5,6 @@\n  * Thread support\n  */\n \n-#include <libcamera/base/thread.h>\n-\n #include <atomic>\n #include <list>\n #include <optional>\n@@ -20,6 +18,7 @@\n #include <libcamera/base/message.h>\n #include <libcamera/base/mutex.h>\n #include <libcamera/base/object.h>\n+#include <libcamera/base/thread.h>\n \n /**\n  * \\page thread Thread Support\n@@ -657,7 +656,7 @@ void Thread::dispatchMessages(Message::Type type)\n \t * the outer calls.\n \t */\n \tif (!--data_->messages_.recursion_) {\n-\t\tfor (auto iter = messages.begin(); iter != messages.end(); ) {\n+\t\tfor (auto iter = messages.begin(); iter != messages.end();) {\n \t\t\tif (!*iter)\n \t\t\t\titer = messages.erase(iter);\n \t\t\telse\n","prefixes":["4/5"]}