[{"id":33442,"web_url":"https://patchwork.libcamera.org/comment/33442/","msgid":"","date":"2025-02-24T09:48:35","subject":"Re: [PATCH 15/15] libcamera: Drop spurious colon after doxygen \\todo\n\tdirective","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent\n\nThank you for the patch. \n\nOn Mon, Feb 24, 2025 at 01:04:03AM +0200, Laurent Pinchart wrote:\n> The doxygen \\todo directive doesn't need to be followed by a colon. Drop\n> it. While at it, turn one 'todo:' into '\\todo'.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/libipa/awb_bayes.cpp | 5 +++--\n> src/ipa/rkisp1/algorithms/awb.cpp | 2 +-\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +-\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n> src/libcamera/pipeline/virtual/config_parser.cpp | 2 +-\n> 5 files changed, 7 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/libipa/awb_bayes.cpp b/src/ipa/libipa/awb_bayes.cpp\n> index d2869610a25b..c3d05e7e3413 100644\n> --- a/src/ipa/libipa/awb_bayes.cpp\n> +++ b/src/ipa/libipa/awb_bayes.cpp\n> @@ -26,7 +26,8 @@\n> *\n> * This implementation is based on the initial implementation done by\n> * RaspberryPi.\n> - * \\todo: Documentation\n> + *\n> + * \\todo Documentation\n> *\n> * \\todo Not all the features implemented by RaspberryPi were ported over to\n> * this algorithm because they either rely on hardware features not generally\n> @@ -272,7 +273,7 @@ void AwbBayes::handleControls(const ControlList &controls)\n> RGB AwbBayes::gainsFromColourTemperature(double colourTemperature)\n> {\n> \t/*\n> -\t * \\todo: In the RaspberryPi code, the ct curve was interpolated in\n> +\t * \\todo In the RaspberryPi code, the ct curve was interpolated in\n> \t * the white point space (1/x) not in gains space. This feels counter\n> \t * intuitive, as the gains are in linear space. But I can't prove it.\n> \t */\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index 3c2864fd181c..52b57ab4e3b6 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -176,7 +176,7 @@ void Awb::queueRequest(IPAContext &context,\n> \t\tawb.gains.manual.r() = (*colourGains)[0];\n> \t\tawb.gains.manual.b() = (*colourGains)[1];\n> \t\t/*\n> -\t\t * \\todo: Colour temperature reported in metadata is now\n> +\t\t * \\todo Colour temperature reported in metadata is now\n> \t\t * incorrect, as we can't deduce the temperature from the gains.\n> \t\t * This will be fixed with the bayes AWB algorithm.\n> \t\t */\n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 566f18ced51c..ee05b798fded 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -738,7 +738,7 @@ int V4L2M2MConverter::queueBuffers(FrameBuffer *input,\n> }\n> \n> /*\n> - * \\todo: This should be extended to include Feature::Flag to denote\n> + * \\todo This should be extended to include Feature::Flag to denote\n> * what each converter supports feature-wise.\n> */\n> static std::initializer_list compatibles = {\n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 5abd6b200e83..a05e11fccf8d 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -1615,7 +1615,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)\n> \t\tisp_->frameStart.connect(data->delayedCtrls_.get(),\n> \t\t\t\t\t &DelayedControls::applyControls);\n> \n> -\t\t/* \\todo: Init properties. */\n> +\t\t/* \\todo Init properties. */\n\nOh, that's from a different patchset. Maybe we need an addition to\ncheckstyle :-).\n\nReviewed-by: Stefan Klug \n\n> \n> \t\tif (!registerMaliCamera(std::move(data), sensor->name()))\n> \t\t\treturn false;\n> diff --git a/src/libcamera/pipeline/virtual/config_parser.cpp b/src/libcamera/pipeline/virtual/config_parser.cpp\n> index 0cbfe39bf2f0..1e009946d53b 100644\n> --- a/src/libcamera/pipeline/virtual/config_parser.cpp\n> +++ b/src/libcamera/pipeline/virtual/config_parser.cpp\n> @@ -54,7 +54,7 @@ ConfigParser::parseConfigFile(File &file, PipelineHandler *pipe)\n> \n> \t\tdata->config_.id = cameraId;\n> \t\tControlInfoMap::Map controls;\n> -\t\t/* todo: Check which resolution's frame rate to be reported */\n> +\t\t/* \\todo Check which resolution's frame rate to be reported */\n> \t\tcontrols[&controls::FrameDurationLimits] =\n> \t\t\tControlInfo(1000000 / data->config_.resolutions[0].frameRates[1],\n> \t\t\t\t 1000000 / data->config_.resolutions[0].frameRates[0]);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AEE4BC32A9\n\tfor ;\n\tMon, 24 Feb 2025 09:48:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DDA62686DC;\n\tMon, 24 Feb 2025 10:48:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D918A686A6\n\tfor ;\n\tMon, 24 Feb 2025 10:48:37 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c02b:2ffa:8001:90d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EF9E220;\n\tMon, 24 Feb 2025 10:47:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aXg4CUeQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740390431;\n\tbh=GQ/cnsNAtCm7lgeSf8u9UWAtPs0nf96rg6lBb0YNiYs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aXg4CUeQjMEyJGT/6CE2zFkoOS9oTEyqVqkYm3gJccCW3xBUmCA4Jn0vUQg/ZiMOh\n\tOZPlLslE2zjEWFM7L1YhxHaOEjHWwylO+i4kO9ZwdKJz9I/qORfJSZCfWJEx5tf+XM\n\tcxmLIBTbSlXFiJDJYACudTQ0VErz/jrfqfZfY7+I=","Date":"Mon, 24 Feb 2025 10:48:35 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 15/15] libcamera: Drop spurious colon after doxygen \\todo\n\tdirective","Message-ID":"","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>\n\t<20250223230403.1226-16-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250223230403.1226-16-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]