[{"id":33441,"web_url":"https://patchwork.libcamera.org/comment/33441/","msgid":"<3xj44rp4rrf6moz2lsfoqpyqppwpyqhmwurray3k5pv3vy52qk@c7tgfe7xdzkt>","date":"2025-02-24T09:41:29","subject":"Re: [PATCH 14/15] ipa: rkisp1: awb: Capitalize AWB","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch. \n\nOn Mon, Feb 24, 2025 at 01:04:02AM +0200, Laurent Pinchart wrote:\n> AWB is an abbreviation, capitalize it in comments and log messages for\n> consistency.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index 7f333ef86518..3c2864fd181c 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -92,7 +92,7 @@ int Awb::init(IPAContext &context, const YamlObject &tuningData)\n> \t\t\t\t\t\t\t kDefaultColourTemperature);\n> \n> \tif (!tuningData.contains(\"algorithm\"))\n> -\t\tLOG(RkISP1Awb, Info) << \"No awb algorithm specified.\"\n> +\t\tLOG(RkISP1Awb, Info) << \"No AWB algorithm specified.\"\n> \t\t\t\t << \" Default to grey world\";\n> \n> \tauto mode = tuningData[\"algorithm\"].get(\"grey\");\n> @@ -101,14 +101,14 @@ int Awb::init(IPAContext &context, const YamlObject &tuningData)\n> \t} else if (mode == \"bayes\") {\n> \t\tawbAlgo_ = std::make_unique();\n> \t} else {\n> -\t\tLOG(RkISP1Awb, Error) << \"Unknown awb algorithm: \" << mode;\n> +\t\tLOG(RkISP1Awb, Error) << \"Unknown AWB algorithm: \" << mode;\n> \t\treturn -EINVAL;\n> \t}\n> -\tLOG(RkISP1Awb, Debug) << \"Using awb algorithm: \" << mode;\n> +\tLOG(RkISP1Awb, Debug) << \"Using AWB algorithm: \" << mode;\n> \n> \tint ret = awbAlgo_->init(tuningData);\n> \tif (ret) {\n> -\t\tLOG(RkISP1Awb, Error) << \"Failed to init awb algorithm\";\n> +\t\tLOG(RkISP1Awb, Error) << \"Failed to init AWB algorithm\";\n> \t\treturn ret;\n> \t}\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11E02C324E\n\tfor ;\n\tMon, 24 Feb 2025 09:41:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8AF7686DE;\n\tMon, 24 Feb 2025 10:41:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D9CE686A6\n\tfor ;\n\tMon, 24 Feb 2025 10:41:31 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c02b:2ffa:8001:90d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DDFFC220;\n\tMon, 24 Feb 2025 10:40:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pyRJUpl2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740390005;\n\tbh=/u4RYMXBrHnCrWepRcvAdGh2hMeXHRxgweDjKhuuLP4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pyRJUpl2VHtGgl8HFSZu4NN+zocdOdvVJPRrdcV4FtwbKqjmwYXDBcL0owvxcazCW\n\t5AOcSM8ApLo9Pbvlo8Z/6X7PHzNBUSKcDzBMqyT2lBYBC6hiD8GIAQWWA/fKjZM/IM\n\tqqgrhhpIY8c/tZ2XUAUn8GqK2+xWOzA8ai5f9dJE=","Date":"Mon, 24 Feb 2025 10:41:29 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 14/15] ipa: rkisp1: awb: Capitalize AWB","Message-ID":"<3xj44rp4rrf6moz2lsfoqpyqppwpyqhmwurray3k5pv3vy52qk@c7tgfe7xdzkt>","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>\n\t<20250223230403.1226-15-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250223230403.1226-15-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]