[{"id":33440,"web_url":"https://patchwork.libcamera.org/comment/33440/","msgid":"<7bhuojistw7geerqdxddavnyakzqlqrkpmxvmnhe3xbkpex7gf@chjgmgd5ymgn>","date":"2025-02-24T09:40:45","subject":"Re: [PATCH 13/15] ipa: rkisp1: awb: Don't calculate RGB means if\n\tstats are missing","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn Mon, Feb 24, 2025 at 01:04:01AM +0200, Laurent Pinchart wrote:\n> When statistics are missing we can't meaningfully calculate the RGB\n> means. Move their calculation after checking if stats are available.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index af34b81beb96..7f333ef86518 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -282,7 +282,6 @@ void Awb::process(IPAContext &context,\n> \tconst rkisp1_cif_isp_stat *params = &stats->params;\n> \tconst rkisp1_cif_isp_awb_stat *awb = ¶ms->awb;\n> \tIPAActiveState &activeState = context.activeState;\n> -\tRGB rgbMeans = calculateRgbMeans(frameContext, awb);\n\nRight. In that case we should also move the declaration of params and\nawb down after the check.\n\nReviewed-by: Stefan Klug \n\nBest regards,\nStefan\n\n> \n> \tmetadata.set(controls::AwbEnable, frameContext.awb.autoEnabled);\n> \tmetadata.set(controls::ColourGains, {\n> @@ -296,6 +295,8 @@ void Awb::process(IPAContext &context,\n> \t\treturn;\n> \t}\n> \n> +\tRGB rgbMeans = calculateRgbMeans(frameContext, awb);\n> +\n> \t/*\n> \t * If the means are too small we don't have enough information to\n> \t * meaningfully calculate gains. Freeze the algorithm in that case.\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01ED4C324E\n\tfor ;\n\tMon, 24 Feb 2025 09:40:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4B4B9686DC;\n\tMon, 24 Feb 2025 10:40:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62BDE686A6\n\tfor ;\n\tMon, 24 Feb 2025 10:40:48 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c02b:2ffa:8001:90d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0188E220;\n\tMon, 24 Feb 2025 10:39:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eG9uHeGX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740389962;\n\tbh=DHNKqq8g4S5CvFki1h+HupF8Z8vtH5gY1HSj/cCRCUA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eG9uHeGXkPEceuc356wne3DjP+n3Oo7o27dajV2NXjcpzAsca5URfe+Xks8AuymfR\n\ti974JC3rID1B3Q3DDKlN8JmTDGvgnX+w4wtTG2yp0I9RXvdf0ia/DxMBVaJnR/449I\n\t7TwvYVw9Fc3NLmB4noHOm1ElvPWq/EwRaug+wJeQ=","Date":"Mon, 24 Feb 2025 10:40:45 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 13/15] ipa: rkisp1: awb: Don't calculate RGB means if\n\tstats are missing","Message-ID":"<7bhuojistw7geerqdxddavnyakzqlqrkpmxvmnhe3xbkpex7gf@chjgmgd5ymgn>","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>\n\t<20250223230403.1226-14-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250223230403.1226-14-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]