[{"id":33439,"web_url":"https://patchwork.libcamera.org/comment/33439/","msgid":"","date":"2025-02-24T09:38:10","subject":"Re: [PATCH 12/15] libipa: awb_grey: Minor comment fixes","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn Mon, Feb 24, 2025 at 01:04:00AM +0200, Laurent Pinchart wrote:\n> Fix the top-level file description to mention the file contains an AWB\n> grey world implementation, not a base class, and fix a grammar mistake\n> in a documentation block.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/ipa/libipa/awb_grey.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp\n> index 0e6c5220c393..d3d2132b8869 100644\n> --- a/src/ipa/libipa/awb_grey.cpp\n> +++ b/src/ipa/libipa/awb_grey.cpp\n> @@ -2,7 +2,7 @@\n> /*\n> * Copyright (C) 2024 Ideas on Board Oy\n> *\n> - * Base class for grey world AWB algorithm\n> + * Implementation of grey world AWB algorithm\n> */\n> \n> #include \"awb_grey.h\"\n> @@ -61,10 +61,10 @@ int AwbGrey::init(const YamlObject &tuningData)\n> * \\param[in] stats The statistics to use for the calculation\n> * \\param[in] lux The lux value of the scene\n> *\n> - * Estimates the colour temperature based on the colours::estimateCCT function.\n> - * The gains are calculated purely based on the RGB means provided by the \\a\n> - * stats. The colour temperature is not taken into account when calculating the\n> - * gains.\n> + * The colour temperature is estimated based on the colours::estimateCCT()\n> + * function. The gains are calculated purely based on the RGB means provided by\n> + * the \\a stats. The colour temperature is not taken into account when\n> + * calculating the gains.\n> *\n> * The \\a lux parameter is not used in this algorithm.\n> *\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D57DCC32A9\n\tfor ;\n\tMon, 24 Feb 2025 09:38:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87EAD686DC;\n\tMon, 24 Feb 2025 10:38:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23D5C686A6\n\tfor ;\n\tMon, 24 Feb 2025 10:38:13 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c02b:2ffa:8001:90d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC588220;\n\tMon, 24 Feb 2025 10:36:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KbinJ7Ia\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740389807;\n\tbh=z5ronF0TW+mgdCqlqcmGdRptvER4WJrxQrqjnsXCB8U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KbinJ7IaWHjrQiuqsaoZ714yw51hFSN6cf3JE6Jlujnl4/T597fcxiJPjOGX4cJIn\n\tzSFSDpln7/uwCR9bZZrrk8tE9M1Hmdg3oAAthO4YMjr1t2gB/1i0FKum1upjug5Bfh\n\thF0faJz0IPIW7kSsrQBV1kAJDuZuw4NABEc+9EVM=","Date":"Mon, 24 Feb 2025 10:38:10 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 12/15] libipa: awb_grey: Minor comment fixes","Message-ID":"","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>\n\t<20250223230403.1226-13-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250223230403.1226-13-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]