[{"id":33438,"web_url":"https://patchwork.libcamera.org/comment/33438/","msgid":"<35wjylc4vfcb25fw36l3l5ldpmpncu2b3jqsk4eq3f324mt4rq@26cw4t3mt7a6>","date":"2025-02-24T09:36:58","subject":"Re: [PATCH 11/15] libipa: awb: Tidy up includes","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch. \n\nOn Mon, Feb 24, 2025 at 01:03:59AM +0200, Laurent Pinchart wrote:\n> Drop unneeded headers and add missing ones.\n> \n> The yaml_parser.h header is dropped from awb_grey.h as the classes it\n> provides are only used in virtual functions defined by the base class,\n> so any required definitions are guaranteed to be available already.\n\nYes, these slipped through.\n\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/ipa/libipa/awb_bayes.cpp | 5 +++++\n> src/ipa/libipa/awb_bayes.h | 8 --------\n> src/ipa/libipa/awb_grey.cpp | 2 +-\n> src/ipa/libipa/awb_grey.h | 3 ++-\n> 4 files changed, 8 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/ipa/libipa/awb_bayes.cpp b/src/ipa/libipa/awb_bayes.cpp\n> index 97bd256526a4..d2869610a25b 100644\n> --- a/src/ipa/libipa/awb_bayes.cpp\n> +++ b/src/ipa/libipa/awb_bayes.cpp\n> @@ -8,7 +8,12 @@\n> \n> #include \"awb_bayes.h\"\n> \n> +#include \n> #include \n> +#include \n> +#include \n> +#include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/ipa/libipa/awb_bayes.h b/src/ipa/libipa/awb_bayes.h\n> index b74201b542fb..a5790e69eed7 100644\n> --- a/src/ipa/libipa/awb_bayes.h\n> +++ b/src/ipa/libipa/awb_bayes.h\n> @@ -7,14 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> -#include \n> -#include \n> -#include \n> -\n> -#include \n> -\n> -#include \n> #include \n> \n> #include \"libcamera/internal/vector.h\"\n> diff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp\n> index 17b8598400e7..0e6c5220c393 100644\n> --- a/src/ipa/libipa/awb_grey.cpp\n> +++ b/src/ipa/libipa/awb_grey.cpp\n> @@ -7,7 +7,7 @@\n> \n> #include \"awb_grey.h\"\n> \n> -#include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/ipa/libipa/awb_grey.h b/src/ipa/libipa/awb_grey.h\n> index e3c34201dbc9..7ec7bfa5da9a 100644\n> --- a/src/ipa/libipa/awb_grey.h\n> +++ b/src/ipa/libipa/awb_grey.h\n> @@ -7,8 +7,9 @@\n> \n> #pragma once\n> \n> +#include \n> +\n> #include \"libcamera/internal/vector.h\"\n> -#include \"libcamera/internal/yaml_parser.h\"\n> \n> #include \"awb.h\"\n> #include \"interpolator.h\"\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC032C32A9\n\tfor ;\n\tMon, 24 Feb 2025 09:37:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A312686DB;\n\tMon, 24 Feb 2025 10:37:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BBE2686A6\n\tfor ;\n\tMon, 24 Feb 2025 10:37:01 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c02b:2ffa:8001:90d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 49726220;\n\tMon, 24 Feb 2025 10:35:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pg3gdyLs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740389735;\n\tbh=m6NivnVFZAFGwtH5TUG0J0DEaufq5foR9XkotoMNA84=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pg3gdyLsFFNwCCRZCURb36VHdj5qZYdd534QVxcOFLZkTlso3kKlWF1yy006Ff8D1\n\tTq0/ydAjNekAhcSSoLpg6Lg/n3EPlCk6OExYc166/80FC8to0cJQbFJsQR+e01lBvA\n\tS3aaM3wtit7EV9rMLqtlDFrG8HZxwDkCNGGausg4=","Date":"Mon, 24 Feb 2025 10:36:58 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 11/15] libipa: awb: Tidy up includes","Message-ID":"<35wjylc4vfcb25fw36l3l5ldpmpncu2b3jqsk4eq3f324mt4rq@26cw4t3mt7a6>","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>\n\t<20250223230403.1226-12-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250223230403.1226-12-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]