[{"id":33433,"web_url":"https://patchwork.libcamera.org/comment/33433/","msgid":"","date":"2025-02-24T09:23:54","subject":"Re: [PATCH 09/15] libipa: awb: Make controls_ member variable\n\tprivate","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch. \n\nOn Mon, Feb 24, 2025 at 01:03:57AM +0200, Laurent Pinchart wrote:\n> The AwbAlgorithm::controls_ member variable doesn't need to be accessed\n> by derived classes. Turn it from public to private.\n\nHow comes? I think that should be accessible by the derived classes as\nthey should be free to provide additional controls.\n\nAt the moment these are protected, so they are not publicly visible.\n\nRegards,\nStefan\n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/libipa/awb.cpp | 5 -----\n> src/ipa/libipa/awb.h | 4 +++-\n> 2 files changed, 3 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\n> index 925fac232709..04cf2d55ed00 100644\n> --- a/src/ipa/libipa/awb.cpp\n> +++ b/src/ipa/libipa/awb.cpp\n> @@ -249,11 +249,6 @@ int AwbAlgorithm::parseModeConfigs(const YamlObject &tuningData,\n> * \\brief The highest valid colour temperature of that mode\n> */\n> \n> -/**\n> - * \\var AwbAlgorithm::controls_\n> - * \\brief Controls info map for the controls provided by the algorithm\n> - */\n> -\n> /**\n> * \\var AwbAlgorithm::modes_\n> * \\brief Map of all configured modes\n> diff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h\n> index a86581adf43e..36c05c37f5e9 100644\n> --- a/src/ipa/libipa/awb.h\n> +++ b/src/ipa/libipa/awb.h\n> @@ -54,8 +54,10 @@ protected:\n> \t\tdouble ctLo;\n> \t};\n> \n> -\tControlInfoMap::Map controls_;\n> \tstd::map modes_;\n> +\n> +private:\n> +\tControlInfoMap::Map controls_;\n> };\n> \n> } /* namespace ipa */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B136C324E\n\tfor ;\n\tMon, 24 Feb 2025 09:24:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B036686D1;\n\tMon, 24 Feb 2025 10:23:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DADD4686CB\n\tfor ;\n\tMon, 24 Feb 2025 10:23:57 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c02b:2ffa:8001:90d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 70A59220;\n\tMon, 24 Feb 2025 10:22:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PQwI+AT0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740388951;\n\tbh=xYwVqyFgUeiE/Ba0Ty+6+qiXtyqilwDD0BPLrJaEjzU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PQwI+AT0izlCNUHFzBpMD/B2hnEVQ0rsKCdB4p3ikExW19SVijSKg3rWpcEq/ihKh\n\tkrmIYOiyYEDGVr/kcFnzzAZxfcSHZkegTqrY+pGSPI/my+WVPH1miFTJy9sZqsCuUV\n\trxnnaNt2TEk/eDXeae0cyw8iqAG/KpzfzePjvACs=","Date":"Mon, 24 Feb 2025 10:23:54 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 09/15] libipa: awb: Make controls_ member variable\n\tprivate","Message-ID":"","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>\n\t<20250223230403.1226-10-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250223230403.1226-10-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33436,"web_url":"https://patchwork.libcamera.org/comment/33436/","msgid":"<20250224093501.GC29646@pendragon.ideasonboard.com>","date":"2025-02-24T09:35:01","subject":"Re: [PATCH 09/15] libipa: awb: Make controls_ member variable\n\tprivate","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Feb 24, 2025 at 10:23:54AM +0100, Stefan Klug wrote:\n> On Mon, Feb 24, 2025 at 01:03:57AM +0200, Laurent Pinchart wrote:\n> > The AwbAlgorithm::controls_ member variable doesn't need to be accessed\n> > by derived classes. Turn it from public to private.\n> \n> How comes? I think that should be accessible by the derived classes as\n> they should be free to provide additional controls.\n> \n> At the moment these are protected, so they are not publicly visible.\n\nI don't foresee a need to do so, but I also can't rule it out, so I'm\nfine dropping this patch.\n\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/ipa/libipa/awb.cpp | 5 -----\n> > src/ipa/libipa/awb.h | 4 +++-\n> > 2 files changed, 3 insertions(+), 6 deletions(-)\n> > \n> > diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\n> > index 925fac232709..04cf2d55ed00 100644\n> > --- a/src/ipa/libipa/awb.cpp\n> > +++ b/src/ipa/libipa/awb.cpp\n> > @@ -249,11 +249,6 @@ int AwbAlgorithm::parseModeConfigs(const YamlObject &tuningData,\n> > * \\brief The highest valid colour temperature of that mode\n> > */\n> > \n> > -/**\n> > - * \\var AwbAlgorithm::controls_\n> > - * \\brief Controls info map for the controls provided by the algorithm\n> > - */\n> > -\n> > /**\n> > * \\var AwbAlgorithm::modes_\n> > * \\brief Map of all configured modes\n> > diff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h\n> > index a86581adf43e..36c05c37f5e9 100644\n> > --- a/src/ipa/libipa/awb.h\n> > +++ b/src/ipa/libipa/awb.h\n> > @@ -54,8 +54,10 @@ protected:\n> > \t\tdouble ctLo;\n> > \t};\n> > \n> > -\tControlInfoMap::Map controls_;\n> > \tstd::map modes_;\n> > +\n> > +private:\n> > +\tControlInfoMap::Map controls_;\n> > };\n> > \n> > } /* namespace ipa */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B0B3C324E\n\tfor ;\n\tMon, 24 Feb 2025 09:35:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90258686D1;\n\tMon, 24 Feb 2025 10:35:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8426D686A6\n\tfor ;\n\tMon, 24 Feb 2025 10:35:19 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0884D220;\n\tMon, 24 Feb 2025 10:33:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eUswiTcN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740389633;\n\tbh=uoF3K6nqCsIG7UOtzSDQ5jF2j1TO6PoKPTRIG48ovnU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eUswiTcN0Vm8Wj8Reo4BFG14Xq1nKWjQPxt1iJ1YpaZrvdIaVTrnmT/BZ9b18/ro0\n\tFIt1U43ZNNCeZnVBiMdvH7vdCSDsQQGPMCw9SF0Wui3r7+KAfCBU1uGC6bhZdjyjOp\n\tGSl8Zh1SOSiizKKkC9ViSPKceYzJzcpIciiH4RAw=","Date":"Mon, 24 Feb 2025 11:35:01 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 09/15] libipa: awb: Make controls_ member variable\n\tprivate","Message-ID":"<20250224093501.GC29646@pendragon.ideasonboard.com>","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>\n\t<20250223230403.1226-10-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]