{"id":22831,"url":"https://patchwork.libcamera.org/api/patches/22831/?format=json","web_url":"https://patchwork.libcamera.org/patch/22831/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250223230403.1226-10-laurent.pinchart@ideasonboard.com>","date":"2025-02-23T23:03:57","name":"[09/15] libipa: awb: Make controls_ member variable private","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"1534d305225d076094d8444409014b6a837e666d","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22831/mbox/","series":[{"id":5012,"url":"https://patchwork.libcamera.org/api/series/5012/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5012","date":"2025-02-23T23:03:48","name":"libipa: awb: Drive-by fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/5012/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22831/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22831/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01AB6BDB13\n\tfor ;\n\tSun, 23 Feb 2025 23:04:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 689A5686DF;\n\tMon, 24 Feb 2025 00:04:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E05CE686CD\n\tfor ;\n\tMon, 24 Feb 2025 00:04:32 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DD98B353\n\tfor ;\n\tMon, 24 Feb 2025 00:03:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tGP1fQcJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740351787;\n\tbh=iIyFbfWwBtq4D8Iz6sqmFu0J2dc23wVVy1rSX9npdok=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=tGP1fQcJBStW75Lzgq5WGNQ8ge1BDh76nrqUcBfI5n6ic09HG6co/6bejyLS7iNFE\n\tXka84gcOoPZe/cVFB2VVr2bqk0fnzwiIZL03R3LoeqAYz/1trJA2p3erKBwF6Rtioc\n\tn2PQyTXrWLkUsHn6DrM1BY8Af58p9i+FZqwj0P7o=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 09/15] libipa: awb: Make controls_ member variable private","Date":"Mon, 24 Feb 2025 01:03:57 +0200","Message-ID":"<20250223230403.1226-10-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.3","In-Reply-To":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The AwbAlgorithm::controls_ member variable doesn't need to be accessed\nby derived classes. Turn it from public to private.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/libipa/awb.cpp | 5 -----\n src/ipa/libipa/awb.h | 4 +++-\n 2 files changed, 3 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\nindex 925fac232709..04cf2d55ed00 100644\n--- a/src/ipa/libipa/awb.cpp\n+++ b/src/ipa/libipa/awb.cpp\n@@ -249,11 +249,6 @@ int AwbAlgorithm::parseModeConfigs(const YamlObject &tuningData,\n * \\brief The highest valid colour temperature of that mode\n */\n \n-/**\n- * \\var AwbAlgorithm::controls_\n- * \\brief Controls info map for the controls provided by the algorithm\n- */\n-\n /**\n * \\var AwbAlgorithm::modes_\n * \\brief Map of all configured modes\ndiff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h\nindex a86581adf43e..36c05c37f5e9 100644\n--- a/src/ipa/libipa/awb.h\n+++ b/src/ipa/libipa/awb.h\n@@ -54,8 +54,10 @@ protected:\n \t\tdouble ctLo;\n \t};\n \n-\tControlInfoMap::Map controls_;\n \tstd::map modes_;\n+\n+private:\n+\tControlInfoMap::Map controls_;\n };\n \n } /* namespace ipa */\n","prefixes":["09/15"]}