[{"id":33432,"web_url":"https://patchwork.libcamera.org/comment/33432/","msgid":"","date":"2025-02-24T09:15:20","subject":"Re: [PATCH 08/15] libipa: awb: Rename AwbStats::getRGBMeans() to\n\trgbMeans()","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn Mon, Feb 24, 2025 at 01:03:56AM +0200, Laurent Pinchart wrote:\n> The convention in libcamera is not to prefix getters with a 'get'\n> prefix. Rename the AwbStats::getRGBMeans() function accordingly.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/ipa/libipa/awb.cpp | 2 +-\n> src/ipa/libipa/awb.h | 2 +-\n> src/ipa/libipa/awb_grey.cpp | 2 +-\n> src/ipa/rkisp1/algorithms/awb.cpp | 2 +-\n> 4 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\n> index 1c4f2330ec6c..925fac232709 100644\n> --- a/src/ipa/libipa/awb.cpp\n> +++ b/src/ipa/libipa/awb.cpp\n> @@ -65,7 +65,7 @@ namespace ipa {\n> */\n> \n> /**\n> - * \\fn AwbStats::getRGBMeans()\n> + * \\fn AwbStats::rgbMeans()\n> * \\brief Get RGB means of the statistics\n> *\n> * Fetch the RGB means from the statistics. The values of each channel are\n> diff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h\n> index 5c298d3b6f69..a86581adf43e 100644\n> --- a/src/ipa/libipa/awb.h\n> +++ b/src/ipa/libipa/awb.h\n> @@ -26,7 +26,7 @@ struct AwbResult {\n> \n> struct AwbStats {\n> \tvirtual double computeColourError(const RGB &gains) const = 0;\n> -\tvirtual RGB getRGBMeans() const = 0;\n> +\tvirtual RGB rgbMeans() const = 0;\n> };\n> \n> class AwbAlgorithm\n> diff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp\n> index e979cc4d1a3e..17b8598400e7 100644\n> --- a/src/ipa/libipa/awb_grey.cpp\n> +++ b/src/ipa/libipa/awb_grey.cpp\n> @@ -73,7 +73,7 @@ int AwbGrey::init(const YamlObject &tuningData)\n> AwbResult AwbGrey::calculateAwb(const AwbStats &stats, [[maybe_unused]] unsigned int lux)\n> {\n> \tAwbResult result;\n> -\tauto means = stats.getRGBMeans();\n> +\tauto means = stats.rgbMeans();\n> \tresult.colourTemperature = estimateCCT(means);\n> \n> \t/*\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index 3d6737df801c..af34b81beb96 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -65,7 +65,7 @@ public:\n> \t\treturn delta2;\n> \t}\n> \n> -\tRGB getRGBMeans() const override\n> +\tRGB rgbMeans() const override\n> \t{\n> \t\treturn rgbMeans_;\n> \t}\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7C13C32A9\n\tfor ;\n\tMon, 24 Feb 2025 09:15:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8EB63686D1;\n\tMon, 24 Feb 2025 10:15:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 608E5686CB\n\tfor ;\n\tMon, 24 Feb 2025 10:15:23 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c02b:2ffa:8001:90d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A6DD220;\n\tMon, 24 Feb 2025 10:13:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g6J0lmx3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740388437;\n\tbh=gfwnCyIFMO+STGqE/CS37/9px8xHIIr2SWw6eQJe3hY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=g6J0lmx3fMVseFyhbZeKWxUvnewyxth+zNMb3OB5O19ksMDlrcakpyxcdraT9qwfH\n\tc4h32x54/9eDr/39ykCcu8CSUr7U4RgEsC0Z9TO2LwgBjgPBfwBqmq0P4p9lgsvrNm\n\tP/1CUfxd3IpeJ3y6astB63wiQk9jvgyYxUk2tM1Y=","Date":"Mon, 24 Feb 2025 10:15:20 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 08/15] libipa: awb: Rename AwbStats::getRGBMeans() to\n\trgbMeans()","Message-ID":"","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>\n\t<20250223230403.1226-9-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250223230403.1226-9-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]