[{"id":33431,"web_url":"https://patchwork.libcamera.org/comment/33431/","msgid":"","date":"2025-02-24T09:14:19","subject":"Re: [PATCH 07/15] ipa: rkisp1: awb: Fix wrong indentation in comment","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn Mon, Feb 24, 2025 at 01:03:55AM +0200, Laurent Pinchart wrote:\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index 51c49ba9ba01..3d6737df801c 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -55,9 +55,9 @@ public:\n> \tdouble computeColourError(const RGB &gains) const override\n> \t{\n> \t\t/*\n> -\t\t* Compute the sum of the squared colour error (non-greyness) as it\n> -\t\t* appears in the log likelihood equation.\n> -\t\t*/\n> +\t\t * Compute the sum of the squared colour error (non-greyness) as\n> +\t\t * it appears in the log likelihood equation.\n> +\t\t */\n> \t\tdouble deltaR = gains.r() * rg_ - 1.0;\n> \t\tdouble deltaB = gains.b() * bg_ - 1.0;\n> \t\tdouble delta2 = deltaR * deltaR + deltaB * deltaB;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3CA7C32A9\n\tfor ;\n\tMon, 24 Feb 2025 09:14:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5BE2B686CF;\n\tMon, 24 Feb 2025 10:14:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D29C6686A6\n\tfor ;\n\tMon, 24 Feb 2025 10:14:22 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c02b:2ffa:8001:90d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FEEA220;\n\tMon, 24 Feb 2025 10:12:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sEBaJcaj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740388376;\n\tbh=cXrQQT0AwlAMNim/yvAahiY1B0oIVaRZ16cadBexACw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sEBaJcajH/pNHBCxmEWUUoPCqBTdG2aI0Hf/0ohjiLA44mdCk/D45t5OeNPrWz1Vk\n\tMp5UPOE/F963MSxFFCQrn5ogBtBhmfB1PAzXDCa6bSwQxY0KynUVwUP31uDZTF/Pup\n\te5DlducYdMRbFa4140Fez+fN8jdfwr7awxPi4aMg=","Date":"Mon, 24 Feb 2025 10:14:19 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 07/15] ipa: rkisp1: awb: Fix wrong indentation in comment","Message-ID":"","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>\n\t<20250223230403.1226-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250223230403.1226-8-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]