[{"id":33429,"web_url":"https://patchwork.libcamera.org/comment/33429/","msgid":"","date":"2025-02-24T09:05:43","subject":"Re: [PATCH 05/15] libipa: awb: Replace reference to pipeline handle\n\twith IPA module","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch. \n\nOn Mon, Feb 24, 2025 at 01:03:53AM +0200, Laurent Pinchart wrote:\n> The AwbStats documentation incorrectly references pipeline handlers when\n> it means IPA modules. Fix it.\n\nThat was mentioned by Paul before. Ah no, that was on AwbAlgorithm and\nonly fixed there...\n\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/ipa/libipa/awb.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\n> index b5aeb472f1f1..1c4f2330ec6c 100644\n> --- a/src/ipa/libipa/awb.cpp\n> +++ b/src/ipa/libipa/awb.cpp\n> @@ -43,8 +43,8 @@ namespace ipa {\n> * \\class AwbStats\n> * \\brief An abstraction class wrapping hardware-specific AWB statistics\n> *\n> - * Pipeline handlers using an AWB algorithm based on the AwbAlgorithm class need\n> - * to implement this class to give the algorithm access to the hardware-specific\n> + * IPA modules using an AWB algorithm based on the AwbAlgorithm class need to\n> + * implement this class to give the algorithm access to the hardware-specific\n> * statistics data.\n> */\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54524C324E\n\tfor ;\n\tMon, 24 Feb 2025 09:05:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 652FE686CE;\n\tMon, 24 Feb 2025 10:05:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC938686A6\n\tfor ;\n\tMon, 24 Feb 2025 10:05:46 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c02b:2ffa:8001:90d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57360220;\n\tMon, 24 Feb 2025 10:04:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lo/GY5Hz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740387860;\n\tbh=n8EBWswscHnuODNpZazTSIe3Xyh9a2Ocv4vCVZDhQqA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lo/GY5HzzOALmofAxv44sxEtXmoo8T1vNBC0O+8wmDkTqTPq7JeSXA+npJq+Ypl4o\n\tAW60npbQSWqVQFkHqWHhwKgR8sEiDIfgBCCA5dRCAy4rTJEtHwYDCR4pm81YC3mSba\n\tWmmy2y8VT7I3l6U8e1e0N+uoMYR6OUXs38BathEk=","Date":"Mon, 24 Feb 2025 10:05:43 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 05/15] libipa: awb: Replace reference to pipeline handle\n\twith IPA module","Message-ID":"","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>\n\t<20250223230403.1226-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250223230403.1226-6-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]