[{"id":33426,"web_url":"https://patchwork.libcamera.org/comment/33426/","msgid":"","date":"2025-02-24T08:59:05","subject":"Re: [PATCH 02/15] libipa: awb: Capitalize AWB","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch. \n\nOn Mon, Feb 24, 2025 at 01:03:50AM +0200, Laurent Pinchart wrote:\n> AWB is an abbreviation, capitalize it in comments and log messages for\n> consistency.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/ipa/libipa/awb.cpp | 14 +++++++-------\n> src/ipa/libipa/awb_grey.cpp | 4 ++--\n> 2 files changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\n> index 2e78a4665509..dc672f129c4a 100644\n> --- a/src/ipa/libipa/awb.cpp\n> +++ b/src/ipa/libipa/awb.cpp\n> @@ -24,7 +24,7 @@ namespace ipa {\n> \n> /**\n> * \\class AwbResult\n> - * \\brief The result of an awb calculation\n> + * \\brief The result of an AWB calculation\n> *\n> * This class holds the result of an auto white balance calculation.\n> */\n> @@ -57,7 +57,7 @@ namespace ipa {\n> * applied. To keep the actual implementations computationally inexpensive,\n> * the squared colour error shall be returned.\n> *\n> - * If the awb statistics provide multiple zones, the average of the individual\n> + * If the AWB statistics provide multiple zones, the average of the individual\n> * squared errors shall be returned. Averaging/normalizing is necessary so that\n> * the numeric dimensions are the same on all hardware platforms.\n> *\n> @@ -94,7 +94,7 @@ namespace ipa {\n> \n> /**\n> * \\fn AwbAlgorithm::calculateAwb\n> - * \\brief Calculate awb data from the given statistics\n> + * \\brief Calculate AWB data from the given statistics\n> * \\param[in] stats The statistics to use for the calculation\n> * \\param[in] lux The lux value of the scene\n> *\n> @@ -102,7 +102,7 @@ namespace ipa {\n> * lux value of 0 means it is unknown or invalid and the algorithm shall ignore\n> * it.\n> *\n> - * \\return The awb result\n> + * \\return The AWB result\n> */\n> \n> /**\n> @@ -178,14 +178,14 @@ int AwbAlgorithm::parseModeConfigs(const YamlObject &tuningData,\n> \t\tif (controls::AwbModeNameValueMap.find(modeName) ==\n> \t\t controls::AwbModeNameValueMap.end()) {\n> \t\t\tLOG(Awb, Warning)\n> -\t\t\t\t<< \"Skipping unknown awb mode '\"\n> +\t\t\t\t<< \"Skipping unknown AWB mode '\"\n> \t\t\t\t<< modeName << \"'\";\n> \t\t\tcontinue;\n> \t\t}\n> \n> \t\tif (!modeDict.isDictionary()) {\n> \t\t\tLOG(Awb, Error)\n> -\t\t\t\t<< \"Invalid awb mode '\" << modeName << \"'\";\n> +\t\t\t\t<< \"Invalid AWB mode '\" << modeName << \"'\";\n> \t\t\treturn -EINVAL;\n> \t\t}\n> \n> @@ -235,7 +235,7 @@ int AwbAlgorithm::parseModeConfigs(const YamlObject &tuningData,\n> * \\class AwbAlgorithm::ModeConfig\n> * \\brief Holds the configuration of a single AWB mode\n> *\n> - * Awb modes limit the regulation of the AWB algorithm to a specific range of\n> + * AWB modes limit the regulation of the AWB algorithm to a specific range of\n> * colour temperatures.\n> */\n> \n> diff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp\n> index 49448976ed26..06ffd45618d8 100644\n> --- a/src/ipa/libipa/awb_grey.cpp\n> +++ b/src/ipa/libipa/awb_grey.cpp\n> @@ -57,7 +57,7 @@ int AwbGrey::init(const YamlObject &tuningData)\n> }\n> \n> /**\n> - * \\brief Calculate awb data from the given statistics\n> + * \\brief Calculate AWB data from the given statistics\n> * \\param[in] stats The statistics to use for the calculation\n> * \\param[in] lux The lux value of the scene\n> *\n> @@ -68,7 +68,7 @@ int AwbGrey::init(const YamlObject &tuningData)\n> *\n> * The \\a lux parameter is not used in this algorithm.\n> *\n> - * \\return The awb result\n> + * \\return The AWB result\n> */\n> AwbResult AwbGrey::calculateAwb(const AwbStats &stats, [[maybe_unused]] int lux)\n> {\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 591A3C324E\n\tfor ;\n\tMon, 24 Feb 2025 08:59:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08AC7686CA;\n\tMon, 24 Feb 2025 09:59:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B2B8686A6\n\tfor ;\n\tMon, 24 Feb 2025 09:59:08 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c02b:2ffa:8001:90d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E147A455;\n\tMon, 24 Feb 2025 09:57:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CiQIPlbZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740387462;\n\tbh=kXZJFPyLUepRz0JpY1PMfS499u0JeN1U9MJC7iFVkik=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CiQIPlbZCweBexxDUVGRXIOoluCpnG9ayCLMpFSJEJu8kfmvNyqOO5R8r6t2Y/Sko\n\tQoS3BIpOUa6hI6hagKo2nCauulZgbzPkEy81bFd5SiEsl+YD6QJ4u0kKaXAFdYJ46/\n\t3WYS0ojger/fxjjfDe1A9j5+STMwnDDNcZuVQu9w=","Date":"Mon, 24 Feb 2025 09:59:05 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 02/15] libipa: awb: Capitalize AWB","Message-ID":"","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>\n\t<20250223230403.1226-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250223230403.1226-3-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]