[{"id":33425,"web_url":"https://patchwork.libcamera.org/comment/33425/","msgid":"<5tmkhsg5n47ebk7f2npfxdwp6qusj6pds2eshiubqsibqoefnf@lzykik5qpef4>","date":"2025-02-24T08:58:15","subject":"Re: [PATCH 01/15] libipa: awb: Sort class member documentation\n\taccording to header order","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn Mon, Feb 24, 2025 at 01:03:49AM +0200, Laurent Pinchart wrote:\n> Sort the documentation of the class members in the same order as the\n> member declaration in the class definition, as is customary in\n> libcamera.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/ipa/libipa/awb.cpp | 58 +++++++++++++++++++++---------------------\n> 1 file changed, 29 insertions(+), 29 deletions(-)\n> \n> diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\n> index 6157bd436183..2e78a4665509 100644\n> --- a/src/ipa/libipa/awb.cpp\n> +++ b/src/ipa/libipa/awb.cpp\n> @@ -130,35 +130,6 @@ namespace ipa {\n> * \\brief Handle the controls supplied in a request\n> */\n> \n> -/**\n> - * \\var AwbAlgorithm::controls_\n> - * \\brief Controls info map for the controls provided by the algorithm\n> - */\n> -\n> -/**\n> - * \\var AwbAlgorithm::modes_\n> - * \\brief Map of all configured modes\n> - * \\sa AwbAlgorithm::parseModeConfigs\n> - */\n> -\n> -/**\n> - * \\class AwbAlgorithm::ModeConfig\n> - * \\brief Holds the configuration of a single AWB mode\n> - *\n> - * Awb modes limit the regulation of the AWB algorithm to a specific range of\n> - * colour temperatures.\n> - */\n> -\n> -/**\n> - * \\var AwbAlgorithm::ModeConfig::ctLo\n> - * \\brief The lowest valid colour temperature of that mode\n> - */\n> -\n> -/**\n> - * \\var AwbAlgorithm::ModeConfig::ctHi\n> - * \\brief The highest valid colour temperature of that mode\n> - */\n> -\n> /**\n> * \\brief Parse the mode configurations from the tuning data\n> * \\param[in] tuningData the YamlObject representing the tuning data\n> @@ -260,6 +231,35 @@ int AwbAlgorithm::parseModeConfigs(const YamlObject &tuningData,\n> \treturn 0;\n> }\n> \n> +/**\n> + * \\class AwbAlgorithm::ModeConfig\n> + * \\brief Holds the configuration of a single AWB mode\n> + *\n> + * Awb modes limit the regulation of the AWB algorithm to a specific range of\n> + * colour temperatures.\n> + */\n> +\n> +/**\n> + * \\var AwbAlgorithm::ModeConfig::ctLo\n> + * \\brief The lowest valid colour temperature of that mode\n> + */\n> +\n> +/**\n> + * \\var AwbAlgorithm::ModeConfig::ctHi\n> + * \\brief The highest valid colour temperature of that mode\n> + */\n> +\n> +/**\n> + * \\var AwbAlgorithm::controls_\n> + * \\brief Controls info map for the controls provided by the algorithm\n> + */\n> +\n> +/**\n> + * \\var AwbAlgorithm::modes_\n> + * \\brief Map of all configured modes\n> + * \\sa AwbAlgorithm::parseModeConfigs\n> + */\n> +\n> } /* namespace ipa */\n> \n> } /* namespace libcamera */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2185C324E\n\tfor ;\n\tMon, 24 Feb 2025 08:58:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E384C686C4;\n\tMon, 24 Feb 2025 09:58:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACC28686A6\n\tfor ;\n\tMon, 24 Feb 2025 09:58:18 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c02b:2ffa:8001:90d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57ED4455;\n\tMon, 24 Feb 2025 09:56:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p+nveCeU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740387412;\n\tbh=47z7xX2rgLrP2JUqOYs75rUX8bnAQ1G8brh2SgbILVA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=p+nveCeUPTXBycOAgFnjWMN3947S/itjreClV9BCWdOz2I075YuLuhqK1rIqj+Cgu\n\tP8OZ9LriNGaHQp5HpHqoLoWUiKrOo7ei9JofzJbvaLNUGTllY5Bn36Yg//2lvGOvhu\n\tFFvCrJuERQq7Sn7C+GWUh2yWQcBuPeCRu8qeanZk=","Date":"Mon, 24 Feb 2025 09:58:15 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 01/15] libipa: awb: Sort class member documentation\n\taccording to header order","Message-ID":"<5tmkhsg5n47ebk7f2npfxdwp6qusj6pds2eshiubqsibqoefnf@lzykik5qpef4>","References":"<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>\n\t<20250223230403.1226-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250223230403.1226-2-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]