[{"id":33414,"web_url":"https://patchwork.libcamera.org/comment/33414/","msgid":"<20250221140719.GA10674@pendragon.ideasonboard.com>","date":"2025-02-21T14:07:19","subject":"Re: [PATCH] libcamera: pipeline: Fix LIBCAMERA__TUNING_FILE\n\thandling","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Feb 21, 2025 at 02:57:02PM +0100, Stefan Klug wrote:\n> In f5da05ed03ee (\"libcamera: pipeline: Move tuning file override\n> handling to IPAProxy\") a incorrect comparison slipped through. That\n> broke the handling of LIBCAMERA__TUNING_FILE. Fix that.\n> \n> Fixes: f5da05ed03ee (\"libcamera: pipeline: Move tuning file override handling to IPAProxy\")\n> Signed-off-by: Stefan Klug \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> \n> This was merged 4 weeks ago. Unbelievable we didn't notice earlier :-/\n\n... Mea culpa. Maybe this needs a test in CI ?\n\n> ---\n> src/libcamera/ipa_proxy.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\n> index 25f772a41bf8..9907b9615ec7 100644\n> --- a/src/libcamera/ipa_proxy.cpp\n> +++ b/src/libcamera/ipa_proxy.cpp\n> @@ -115,7 +115,7 @@ std::string IPAProxy::configurationFile(const std::string &name,\n> \tipaEnvName = \"LIBCAMERA_\" + ipaEnvName + \"_TUNING_FILE\";\n> \n> \tchar const *configFromEnv = utils::secure_getenv(ipaEnvName.c_str());\n> -\tif (configFromEnv && *configFromEnv == '\\0')\n> +\tif (configFromEnv && *configFromEnv != '\\0')\n> \t\treturn { configFromEnv };\n> \n> \tstruct stat statbuf;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61CC2BEFBE\n\tfor ;\n\tFri, 21 Feb 2025 14:07:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5922E686AC;\n\tFri, 21 Feb 2025 15:07:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDC8A61857\n\tfor ;\n\tFri, 21 Feb 2025 15:07:35 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4FAFA2EC;\n\tFri, 21 Feb 2025 15:06:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gxcvqZuA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740146771;\n\tbh=bzsQJhB+5DubS2JpLR22xt9isR1i49Nk/GhT9HNDHHs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gxcvqZuAV7LOA2qYL+8zpXUPuu+wXIyT2QbY4pzUlkVq6Or7lmQz6N52a0GcE+fgV\n\tPdSkpDJtYHoV/3fQHbdgB7GXiJCpYgRCZHIo6Fkd2LoNeMykXfI+viKqB+0McDCjiF\n\tJrSmBw2v0SpEnxxJvXDkoSYO04Y9rq11CyUp7eFs=","Date":"Fri, 21 Feb 2025 16:07:19 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: pipeline: Fix LIBCAMERA__TUNING_FILE\n\thandling","Message-ID":"<20250221140719.GA10674@pendragon.ideasonboard.com>","References":"<20250221135836.450451-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250221135836.450451-1-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]