[{"id":33661,"web_url":"https://patchwork.libcamera.org/comment/33661/","msgid":"<174246908938.2025019.5801855127711656932@ping.linuxembedded.co.uk>","date":"2025-03-20T11:11:29","subject":"Re: [PATCH v1 2/4] ipa: rpi: Add support for Raspberry Pi 5","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2025-01-13 09:24:44)\n> Add the Raspberry Pi 5 ISP (PiSP) IPA to libcamera. To include this IPA\n> in the build, set the following meson option:\n> \n> meson configure -Dipas=rpi/pisp\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n> ---\n> meson_options.txt | 3 +-\n> src/ipa/rpi/pisp/data/imx219.json | 1187 ++++++++++++++++\n> src/ipa/rpi/pisp/data/imx219_noir.json | 1112 +++++++++++++++\n> src/ipa/rpi/pisp/data/imx290.json | 341 +++++\n> src/ipa/rpi/pisp/data/imx296.json | 1194 ++++++++++++++++\n> src/ipa/rpi/pisp/data/imx296_16mm.json | 1247 +++++++++++++++++\n> src/ipa/rpi/pisp/data/imx296_6mm.json | 1247 +++++++++++++++++\n> src/ipa/rpi/pisp/data/imx296_mono.json | 960 +++++++++++++\n> src/ipa/rpi/pisp/data/imx378.json | 634 +++++++++\n> src/ipa/rpi/pisp/data/imx415.json | 1159 ++++++++++++++++\n> src/ipa/rpi/pisp/data/imx462.json | 342 +++++\n> src/ipa/rpi/pisp/data/imx477.json | 1186 ++++++++++++++++\n> src/ipa/rpi/pisp/data/imx477_16mm.json | 1240 +++++++++++++++++\n> src/ipa/rpi/pisp/data/imx477_6mm.json | 1240 +++++++++++++++++\n> src/ipa/rpi/pisp/data/imx477_noir.json | 1148 ++++++++++++++++\n> src/ipa/rpi/pisp/data/imx477_scientific.json | 546 ++++++++\n> src/ipa/rpi/pisp/data/imx519.json | 634 +++++++++\n> src/ipa/rpi/pisp/data/imx708.json | 1270 +++++++++++++++++\n> src/ipa/rpi/pisp/data/imx708_noir.json | 1233 +++++++++++++++++\n> src/ipa/rpi/pisp/data/imx708_wide.json | 1293 ++++++++++++++++++\n> src/ipa/rpi/pisp/data/imx708_wide_noir.json | 1148 ++++++++++++++++\n> src/ipa/rpi/pisp/data/meson.build | 29 +\n> src/ipa/rpi/pisp/data/ov5647.json | 1186 ++++++++++++++++\n> src/ipa/rpi/pisp/data/ov5647_noir.json | 1121 +++++++++++++++\n> src/ipa/rpi/pisp/data/ov64a40.json | 1133 +++++++++++++++\n> src/ipa/rpi/pisp/data/ov9281_mono.json | 215 +++\n> src/ipa/rpi/pisp/data/se327m12.json | 639 +++++++++\n> src/ipa/rpi/pisp/data/uncalibrated.json | 135 ++\n> src/ipa/rpi/pisp/meson.build | 49 +\n\nStraight ack to all the existing tuning files, regardless of content.\n\n> src/ipa/rpi/pisp/pisp.cpp | 1068 +++++++++++++++\n> src/libcamera/control_ids_rpi.yaml | 13 +\n\nA quick check on these, though I also expect these to be easy, and have\nbeen well tested already!\n\n> create mode 100644 src/ipa/rpi/pisp/meson.build\n> create mode 100644 src/ipa/rpi/pisp/pisp.cpp\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index f19bca91f38e..4db05a68325f 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -32,7 +32,8 @@ option('gstreamer',\n> \n> option('ipas',\n> type : 'array',\n> - choices : ['ipu3', 'mali-c55', 'rkisp1', 'rpi/vc4', 'simple', 'vimc'],\n> + choices : ['ipu3', 'mali-c55', 'rkisp1', 'rpi/pisp', 'rpi/vc4', 'simple',\n> + 'vimc'],\n> description : 'Select which IPA modules to build')\n> \n\nFor core additions:\n\nReviewed-by: Kieran Bingham \n\n\n\nIn fact, the tuning files in here are so much data it breaks/doesn't\nmake it into patchwork!\n\nPerhaps if we need any updates we might be best to move to a PR, but I'm\nhoping we're ok without an update.\n\nAnd snipping the rest of this file now too, for all RPi additions,\nincluding RPi namespaced control addition:\n\nAcked-by: Kieran Bingham ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E2C1C3304\n\tfor ;\n\tThu, 20 Mar 2025 11:11:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D59E617F5;\n\tThu, 20 Mar 2025 12:11:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 970D4617F5\n\tfor ;\n\tThu, 20 Mar 2025 12:11:32 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB64B743;\n\tThu, 20 Mar 2025 12:09:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZCdpVcMg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742468989;\n\tbh=/efVnEfBOA9bnE2Uck1RonEI+NX+hj9RiGg/UAG9dxM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ZCdpVcMgNt9uzOR/sWsyQcaV7MCOok5LEtRC3/G0xkGXJlVoWAWrlh9vGLoU+ijWM\n\tMCgumdQTBPKMBjbeM3CUuB2LRpHi9cuQc/lgOXjxpRrf+yfc+MFzV9GB41CYYqWJSU\n\tZ7joe6YSjohZND7b0luz79iJv7LrbCec4rjUH8To=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250113093532.4054142-3-naush@raspberrypi.com>","References":"<20250113093532.4054142-1-naush@raspberrypi.com>\n\t<20250113093532.4054142-3-naush@raspberrypi.com>","Subject":"Re: [PATCH v1 2/4] ipa: rpi: Add support for Raspberry Pi 5","From":"Kieran Bingham ","Cc":"Naushir Patuck ,\n\tDavid Plowman ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 20 Mar 2025 11:11:29 +0000","Message-ID":"<174246908938.2025019.5801855127711656932@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]