[{"id":33373,"web_url":"https://patchwork.libcamera.org/comment/33373/","msgid":"<20250216174538.GA1136@pendragon.ideasonboard.com>","date":"2025-02-16T17:45:38","subject":"Re: [PATCH 1/1] gstreamer: Fix scaler-crop property get","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nerijus,\n\nThank you for the patch, and welcome to libcamera.\n\nOn Sun, Feb 16, 2025 at 09:21:31AM +0200, Nerijus Bendžiūnas wrote:\n\nA commit message would be nice. The explanation you provided in the\ncover letter would be a good fit:\n\nFix a copy/paste/replace typo. Without this fix, the last element (4th)\nis always zero.\n\n> Signed-off-by: Nerijus Bendžiūnas \n\nReviewed-by: Laurent Pinchart \n\nIf you're fine with the updated commit message there's no need to\nresend, I can update the patch when applying.\n\n> ---\n> src/gstreamer/gstlibcamera-controls.cpp.in | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera-controls.cpp.in b/src/gstreamer/gstlibcamera-controls.cpp.in\n> index ace36b71..d937b19e 100644\n> --- a/src/gstreamer/gstlibcamera-controls.cpp.in\n> +++ b/src/gstreamer/gstlibcamera-controls.cpp.in\n> @@ -39,7 +39,7 @@ static void value_set_rectangle(GValue *value, const Rectangle &rect)\n> \n> \tGValue height = G_VALUE_INIT;\n> \tg_value_init(&height, G_TYPE_INT);\n> -\tg_value_set_int(&x, size.height);\n> +\tg_value_set_int(&height, size.height);\n> \tgst_value_array_append_and_take_value(value, &height);\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 125F3C327D\n\tfor ;\n\tSun, 16 Feb 2025 17:45:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E66F68660;\n\tSun, 16 Feb 2025 18:45:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C33E760337\n\tfor ;\n\tSun, 16 Feb 2025 18:45:51 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C7081D53;\n\tSun, 16 Feb 2025 18:44:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ErcVv0ga\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739727871;\n\tbh=OqMoSnIelvp3LAW8/8PqfirQI/dh0DDtZc01sSN8sT4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ErcVv0galxf53P3+U7AwoXGGN8ZUuujK1bx4ZkQPIjaseNxb3exuW/ZwZvCPEg/Pi\n\tcrqX2eLVOYiWtraSraSr4QKjR95QDTR5u/T1EK3/BOLKcbTnTrzjGep1rmRQABFr9t\n\tA5APugCJ9gzt3gYE1phY6NfUyD1uYDkTCDyb6vfc=","Date":"Sun, 16 Feb 2025 19:45:38 +0200","From":"Laurent Pinchart ","To":"Nerijus =?utf-8?b?QmVuZMW+acWrbmFz?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/1] gstreamer: Fix scaler-crop property get","Message-ID":"<20250216174538.GA1136@pendragon.ideasonboard.com>","References":"<20250216072131.654725-1-nerijus.bendziunas@gmail.com>\n\t<20250216072131.654725-2-nerijus.bendziunas@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250216072131.654725-2-nerijus.bendziunas@gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33391,"web_url":"https://patchwork.libcamera.org/comment/33391/","msgid":"","date":"2025-02-17T16:25:17","subject":"Re: [PATCH 1/1] gstreamer: Fix scaler-crop property get","submitter":{"id":219,"url":"https://patchwork.libcamera.org/api/people/219/","name":"Nerijus Bendžiūnas","email":"nerijus.bendziunas@gmail.com"},"content":"Hello,\n\nI'm fine with your suggestion to reuse the cover later as message.\n\nOn Sun, Feb 16, 2025 at 7:45 PM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Nerijus,\n>\n> Thank you for the patch, and welcome to libcamera.\n>\n> On Sun, Feb 16, 2025 at 09:21:31AM +0200, Nerijus Bendžiūnas wrote:\n>\n> A commit message would be nice. The explanation you provided in the\n> cover letter would be a good fit:\n>\n> Fix a copy/paste/replace typo. Without this fix, the last element (4th)\n> is always zero.\n>\n> > Signed-off-by: Nerijus Bendžiūnas \n>\n> Reviewed-by: Laurent Pinchart \n>\n> If you're fine with the updated commit message there's no need to\n> resend, I can update the patch when applying.\n>\n> > ---\n> > src/gstreamer/gstlibcamera-controls.cpp.in | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/gstreamer/gstlibcamera-controls.cpp.in b/src/gstreamer/\n> gstlibcamera-controls.cpp.in\n> > index ace36b71..d937b19e 100644\n> > --- a/src/gstreamer/gstlibcamera-controls.cpp.in\n> > +++ b/src/gstreamer/gstlibcamera-controls.cpp.in\n> > @@ -39,7 +39,7 @@ static void value_set_rectangle(GValue *value, const\n> Rectangle &rect)\n> >\n> > GValue height = G_VALUE_INIT;\n> > g_value_init(&height, G_TYPE_INT);\n> > - g_value_set_int(&x, size.height);\n> > + g_value_set_int(&height, size.height);\n> > gst_value_array_append_and_take_value(value, &height);\n> > }\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4092BDE6B\n\tfor ;\n\tMon, 17 Feb 2025 16:25:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC0EF61865;\n\tMon, 17 Feb 2025 17:25:56 +0100 (CET)","from mail-lj1-x231.google.com (mail-lj1-x231.google.com\n\t[IPv6:2a00:1450:4864:20::231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE46161865\n\tfor ;\n\tMon, 17 Feb 2025 17:25:54 +0100 (CET)","by mail-lj1-x231.google.com with SMTP id\n\t38308e7fff4ca-3098088c630so17344351fa.1\n\tfor ;\n\tMon, 17 Feb 2025 08:25:54 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SfsCjOuz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1739809554; x=1740414354;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=h+bn/Lgp4fU9fFwBBDtIaZz7K1dj0D8/2FT/NGODBVc=;\n\tb=SfsCjOuzVcQiW3t8cN5pUNkXZ/e2q1UUrn1/MLkr1TdMoik38x3QsmVvveZkB+k2Kk\n\tUxcYuZo7g2gUR2PmCzbaFC0Uu2FCGu0P0RRO0m2DmzJyTXfNSsYA8Np6e6n0418qkLBG\n\t+yWbJafdfthZoN3/bXDODU2bLi7eGjAXQpokBANVtszF5h0bHjlLtnMu6F50MYs/8sX/\n\tYC7yAWJ21CKynbOF92/6474TygCE+Ie7N4/6F2+sciTBNQQ2P9PLhlOj5BeU94yRKdCl\n\tNCX/Jki6QcfN6ymhSaug9ojD1nFQJND+UYkr2gYckFrCUB7NAy8T7OG2DOzGBcgvbv18\n\tScoA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1739809554; x=1740414354;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=h+bn/Lgp4fU9fFwBBDtIaZz7K1dj0D8/2FT/NGODBVc=;\n\tb=RQaqoBVBZP4A53r0Snt//gGgokub5JOAx4ZmpihKgmiELjvZITwK5bKsJSRscmJLrw\n\tQ62zzPNdW+RzPcXRIOyArTCf1+VO94P4eUoHNk5bIpuJ5vmRqXxd8sW6nm8VMxTQj7F4\n\tBn8oVgT+5YRnFmFNa5TP6G7jDf1lylVOxo4hy+pKYVpnFmhycVPxQwIrEToU2/Io+RcK\n\t/1hf+Ch2j7hqX9Loea6u4lcoAxCTDujqeva//Gr5k2zAJSAvK777tF7TGjXpcYmywBhA\n\tt3jonH29HFI0f98Eq8eeYRRJKxSlOzUbI3XqzuY2QykJBIp+uI9De0Ekr+rwir7+6jLm\n\tU0OA==","X-Gm-Message-State":"AOJu0YwQJ7076+mGsp76aH7Vwq0sE0eI5hM944XUdLAZL8Ncs3OIREg4\n\teSf1VcLXao5jFnwVUarWGQ3lxU0ZDxZg9pWvnDrn8aOElri+oJzrLsvi9Gv8wcHn6lptWcLCCOe\n\tUEeXS0UH/oDspLfC4H5Puqk3GAQ==","X-Gm-Gg":"ASbGncu0P8ZQUmjJyuGK8M71yM/irBZA0xnysNno72EoG+700Ei+LFoGpLz+k9OfA1D\n\ti0DyRwG7vwzBNANJP3fAGaH16ag9fFLZy0BEzvs/G6rBO8Ka8FgpkBhWpAyce2HGFipcM8cqAwj\n\tlidD2kiVS2Q5sdV9NCWYlFDBjv","X-Google-Smtp-Source":"AGHT+IFvhK/ngtCPpzVZ0UOctxCdAUSFCevu0rdfCwpo8dts8JgKNcB78MCMeusrYDHEyHVD1cYTjEvEH7Qt4LtolNg=","X-Received":"by 2002:a2e:b60e:0:b0:308:f4cc:9505 with SMTP id\n\t38308e7fff4ca-30927a577c6mr25499831fa.2.1739809553480;\n\tMon, 17 Feb 2025 08:25:53 -0800 (PST)","MIME-Version":"1.0","References":"<20250216072131.654725-1-nerijus.bendziunas@gmail.com>\n\t<20250216072131.654725-2-nerijus.bendziunas@gmail.com>\n\t<20250216174538.GA1136@pendragon.ideasonboard.com>","In-Reply-To":"<20250216174538.GA1136@pendragon.ideasonboard.com>","From":"=?utf-8?q?Nerijus_Bend=C5=BEi=C5=ABnas?= ","Date":"Mon, 17 Feb 2025 18:25:17 +0200","X-Gm-Features":"AWEUYZkYUWp1yrVNf38YqDt7VN3VRc1S6Ow7zWDtijy4Tjhm3nL30pjJFG0XH9Y","Message-ID":"","Subject":"Re: [PATCH 1/1] gstreamer: Fix scaler-crop property get","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000698585062e58fa21\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33392,"web_url":"https://patchwork.libcamera.org/comment/33392/","msgid":"<173981094383.3771432.18013179442195440334@ping.linuxembedded.co.uk>","date":"2025-02-17T16:49:03","subject":"Re: [PATCH 1/1] gstreamer: Fix scaler-crop property get","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Nerijus Bendžiūnas (2025-02-17 16:25:17)\n> Hello,\n> \n> I'm fine with your suggestion to reuse the cover later as message.\n> \n> On Sun, Feb 16, 2025 at 7:45 PM Laurent Pinchart <\n> laurent.pinchart@ideasonboard.com> wrote:\n> \n> > Hi Nerijus,\n> >\n> > Thank you for the patch, and welcome to libcamera.\n> >\n> > On Sun, Feb 16, 2025 at 09:21:31AM +0200, Nerijus Bendžiūnas wrote:\n> >\n> > A commit message would be nice. The explanation you provided in the\n> > cover letter would be a good fit:\n> >\n> > Fix a copy/paste/replace typo. Without this fix, the last element (4th)\n> > is always zero.\n> >\n> > > Signed-off-by: Nerijus Bendžiūnas \n> >\n> > Reviewed-by: Laurent Pinchart \n> >\n> > If you're fine with the updated commit message there's no need to\n> > resend, I can update the patch when applying.\n\nIf it helps\n\n\nReviewed-by: Kieran Bingham \n\n> >\n> > > ---\n> > > src/gstreamer/gstlibcamera-controls.cpp.in | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > >\n> > > diff --git a/src/gstreamer/gstlibcamera-controls.cpp.in b/src/gstreamer/\n> > gstlibcamera-controls.cpp.in\n> > > index ace36b71..d937b19e 100644\n> > > --- a/src/gstreamer/gstlibcamera-controls.cpp.in\n> > > +++ b/src/gstreamer/gstlibcamera-controls.cpp.in\n> > > @@ -39,7 +39,7 @@ static void value_set_rectangle(GValue *value, const\n> > Rectangle &rect)\n> > >\n> > > GValue height = G_VALUE_INIT;\n> > > g_value_init(&height, G_TYPE_INT);\n> > > - g_value_set_int(&x, size.height);\n> > > + g_value_set_int(&height, size.height);\n> > > gst_value_array_append_and_take_value(value, &height);\n> > > }\n> > >\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >\n> \n> \n> -- \n> Nerijus","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC2BFC3200\n\tfor ;\n\tMon, 17 Feb 2025 16:49:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF8346867B;\n\tMon, 17 Feb 2025 17:49:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97A4B61865\n\tfor ;\n\tMon, 17 Feb 2025 17:49:06 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 079ACA98;\n\tMon, 17 Feb 2025 17:47:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TKJyp15i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739810865;\n\tbh=+K2qSrvzGYBay61G3YFxGn4ReoQGKEYyqlN2KRTHbFs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=TKJyp15ioU2q110Q/KScBStoVnEiMv43iktiSkQ656cq/ucuSmDBRwRI0r0gzESKR\n\tVC1hkrzjdv6ntzmWhBIGMG5iUb4vdp8qHhulCzuOGmvQGn/jt7c/QrwDm0+Akma86r\n\tMMRvdOAjMY520LizS80VQxLVblUf4/mqs0ZP1JCA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250216072131.654725-1-nerijus.bendziunas@gmail.com>\n\t<20250216072131.654725-2-nerijus.bendziunas@gmail.com>\n\t<20250216174538.GA1136@pendragon.ideasonboard.com>\n\t","Subject":"Re: [PATCH 1/1] gstreamer: Fix scaler-crop property get","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart , Nerijus\n\t=?utf-8?b?QmVuZMW+acWrbmFz?= ","Date":"Mon, 17 Feb 2025 16:49:03 +0000","Message-ID":"<173981094383.3771432.18013179442195440334@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]