{"id":22782,"url":"https://patchwork.libcamera.org/api/patches/22782/?format=json","web_url":"https://patchwork.libcamera.org/patch/22782/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250214161031.240481-2-stefan.klug@ideasonboard.com>","date":"2025-02-14T16:09:47","name":"[v2,1/2] libcamera: formats: Silence warning when creating a PixelFormatInfo from a null format","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5920baff51629005690dd4954ce2d0c6430c5010","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22782/mbox/","series":[{"id":5003,"url":"https://patchwork.libcamera.org/api/series/5003/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5003","date":"2025-02-14T16:09:46","name":"Silence warning when creating a PixelFormatInfo from a null format","version":2,"mbox":"https://patchwork.libcamera.org/series/5003/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22782/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22782/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 866BAC3272\n\tfor ;\n\tFri, 14 Feb 2025 16:10:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25CEF68650;\n\tFri, 14 Feb 2025 17:10:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C19D16862A\n\tfor ;\n\tFri, 14 Feb 2025 17:10:38 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:2ff9:b837:9e53:886e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 776C1710;\n\tFri, 14 Feb 2025 17:09:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ugX0qFLm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739549359;\n\tbh=m8DofvAuWViov47QG7Wt4lYGkBGqd+j3nVw/MjwTsUA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ugX0qFLmjXiQLoIlPvGZ5iHgc0U4UcTygZMJUJjYHePCKC1uho/mf5I8vuqeEMt4y\n\tF1/wYyYB7nmohg2tLua0MHtYashncAZgEirBh0k0Dis5nvInLHmpcSdDVg9YKJTaPL\n\tZ5gjLdiGZN4d1kRHwIhqfYyb0IJ53LtW2ZTlJ808=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tLaurent Pinchart ","Subject":"[PATCH v2 1/2] libcamera: formats: Silence warning when creating a\n\tPixelFormatInfo from a null format","Date":"Fri, 14 Feb 2025 17:09:47 +0100","Message-ID":"<20250214161031.240481-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250214161031.240481-1-stefan.klug@ideasonboard.com>","References":"<20250214161031.240481-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Calling PixelFormat().toString() correctly returns \"0x0-\" but it\nalso produces the following, possibly confusing, warning:\n\nWARN Formats formats.cpp:1006 Unsupported pixel format 0x00000000\n\nSilence the warning in PixelFormatInfo::info() in case the format is\ninvalid.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/formats.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex bfcdfc08960d..b4518e61d04a 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -1001,6 +1001,9 @@ const std::map pixelFormatInfo{\n */\n const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n {\n+\tif (!format.isValid())\n+\t\treturn pixelFormatInfoInvalid;\n+\n \tconst auto iter = pixelFormatInfo.find(format);\n \tif (iter == pixelFormatInfo.end()) {\n \t\tLOG(Formats, Warning)\n","prefixes":["v2","1/2"]}