[{"id":33348,"web_url":"https://patchwork.libcamera.org/comment/33348/","msgid":"<20250213194138.GM5888@pendragon.ideasonboard.com>","date":"2025-02-13T19:41:38","subject":"Re: [PATCH] ipa: rkisp1: algorithms: awb: Fix AWB means vector order\n\tin RGB mode","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Thu, Feb 13, 2025 at 08:35:56PM +0100, Stefan Klug wrote:\n> Fix the order of the rgbMeans vector that got broken accidentally\n> during refactoring. As there is currently no way to enable rgb mode at\n> runtime it went unnoticed.\n> \n> Fixes: 29892f1c56c6 (\"ipa: libipa: colour: Use the RGB class to model RGB values\")\n> Signed-off-by: Stefan Klug \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index cffaa06a22c1..16e829469313 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -245,8 +245,8 @@ void Awb::process(IPAContext &context,\n> \n> \tif (rgbMode_) {\n> \t\trgbMeans = {{\n> -\t\t\tstatic_cast(awb->awb_mean[0].mean_y_or_g),\n> \t\t\tstatic_cast(awb->awb_mean[0].mean_cr_or_r),\n> +\t\t\tstatic_cast(awb->awb_mean[0].mean_y_or_g),\n> \t\t\tstatic_cast(awb->awb_mean[0].mean_cb_or_b)\n> \t\t}};\n> \t} else {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A248BD7D8\n\tfor ;\n\tThu, 13 Feb 2025 19:41:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A7D968640;\n\tThu, 13 Feb 2025 20:41:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBB176185F\n\tfor ;\n\tThu, 13 Feb 2025 20:41:50 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD4356AF;\n\tThu, 13 Feb 2025 20:40:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lMVwgxy2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739475632;\n\tbh=angJWarwLojeiE5rheUH5sOa0LeNw+i97oDDRyTANN8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lMVwgxy2SmFYusLvauRB51XpbCGP7yjWgRkxtEQHK95zByDHASMlH5DGYNYoHyTeL\n\teSUk7+8zTuyPJEGD0kYbv0P++OS8XMZZOokkSmReDB/kx6V1w8kczj+/NAloTz6WtR\n\tANTvc/4nf7U9vBTsS2ZVu0RHGT81qyNAaaZujpzI=","Date":"Thu, 13 Feb 2025 21:41:38 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: rkisp1: algorithms: awb: Fix AWB means vector order\n\tin RGB mode","Message-ID":"<20250213194138.GM5888@pendragon.ideasonboard.com>","References":"<20250213193635.114097-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250213193635.114097-1-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33463,"web_url":"https://patchwork.libcamera.org/comment/33463/","msgid":"<174043062571.2821994.5335281098100261124@ping.linuxembedded.co.uk>","date":"2025-02-24T20:57:05","subject":"Re: [PATCH] ipa: rkisp1: algorithms: awb: Fix AWB means vector order\n\tin RGB mode","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-02-13 19:41:38)\n> Hi Stefan,\n> \n> Thank you for the patch.\n> \n> On Thu, Feb 13, 2025 at 08:35:56PM +0100, Stefan Klug wrote:\n> > Fix the order of the rgbMeans vector that got broken accidentally\n> > during refactoring. As there is currently no way to enable rgb mode at\n> > runtime it went unnoticed.\n> > \n> > Fixes: 29892f1c56c6 (\"ipa: libipa: colour: Use the RGB class to model RGB values\")\n> > Signed-off-by: Stefan Klug \n> \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> \n> > ---\n> > src/ipa/rkisp1/algorithms/awb.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> > index cffaa06a22c1..16e829469313 100644\n> > --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> > +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> > @@ -245,8 +245,8 @@ void Awb::process(IPAContext &context,\n> > \n> > if (rgbMode_) {\n> > rgbMeans = {{\n> > - static_cast(awb->awb_mean[0].mean_y_or_g),\n> > static_cast(awb->awb_mean[0].mean_cr_or_r),\n> > + static_cast(awb->awb_mean[0].mean_y_or_g),\n> > static_cast(awb->awb_mean[0].mean_cb_or_b)\n> > }};\n> > } else {\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 202F2C324E\n\tfor ;\n\tMon, 24 Feb 2025 20:57:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 213BC68706;\n\tMon, 24 Feb 2025 21:57:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A44D061856\n\tfor ;\n\tMon, 24 Feb 2025 21:57:08 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D06EA581;\n\tMon, 24 Feb 2025 21:55:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J9pkpZg+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740430541;\n\tbh=6NwXS1YQFWY5T8k49kt81UB5/R43+ENDMjuyF7eoatU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=J9pkpZg+iAcPvD86ldGK+ye1FjZNMcu0+9fICY1R21CQhClfCSAxxrawpzshYSeWY\n\tRHpPbuzbFL2jpeWxZe6WRk+ivY8723wd0OzYfMhjRzCt8LYfS0QrcTrR80vP2lNiC5\n\tQhWHNXzmKzQeRqmpcO3CwqGzseTkT/9/ZpJl7iY0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250213194138.GM5888@pendragon.ideasonboard.com>","References":"<20250213193635.114097-1-stefan.klug@ideasonboard.com>\n\t<20250213194138.GM5888@pendragon.ideasonboard.com>","Subject":"Re: [PATCH] ipa: rkisp1: algorithms: awb: Fix AWB means vector order\n\tin RGB mode","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart ,\n\tStefan Klug ","Date":"Mon, 24 Feb 2025 20:57:05 +0000","Message-ID":"<174043062571.2821994.5335281098100261124@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]