[{"id":2987,"web_url":"https://patchwork.libcamera.org/comment/2987/","msgid":"<20191029144201.GM20198@bigcity.dyn.berto.se>","date":"2019-10-29T14:42:01","subject":"Re: [libcamera-devel] [PATCH v2 5/9] libcamera: signal: Specify\n\tconnection type for signals","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-10-28 12:49:09 +0200, Laurent Pinchart wrote:\n> Add a connection type parameter to the Signal::connect() method to\n> control signal delivery.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/signal.h | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\n> index b8a60281cceb..57598335932c 100644\n> --- a/include/libcamera/signal.h\n> +++ b/include/libcamera/signal.h\n> @@ -55,11 +55,12 @@ public:\n> \n> #ifndef __DOXYGEN__\n> \ttemplate::value>::type * = nullptr>\n> -\tvoid connect(T *obj, void (T::*func)(Args...))\n> +\tvoid connect(T *obj, void (T::*func)(Args...),\n> +\t\t ConnectionType type = ConnectionTypeAuto)\n> \t{\n> \t\tObject *object = static_cast(obj);\n> \t\tobject->connect(this);\n> -\t\tslots_.push_back(new BoundMemberMethod(obj, object, func));\n> +\t\tslots_.push_back(new BoundMemberMethod(obj, object, func, type));\n> \t}\n> \n> \ttemplate::value>::type * = nullptr>\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E71AF6017E\n\tfor ;\n\tTue, 29 Oct 2019 15:42:02 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id y3so15590235ljj.6\n\tfor ;\n\tTue, 29 Oct 2019 07:42:02 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tm28sm8128398ljc.96.2019.10.29.07.42.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 29 Oct 2019 07:42:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=fYYBU6lXxmdxFc5kJzmcd9lKEXu3LRXTxkV5898UIvU=;\n\tb=kK73ojaS07Z0Ykcq7yUCFzsoN0tQrqcFJkyj5wSO2Y30R9j9aP8Rz1J01+AK/zu6pK\n\t+aGhQ9Yn1VvFMVPtAWwyTEX2eKfbeNmWf49k00mgGz5znOS4XkmybyT2e3AbZlvZBteF\n\tOhfMA7sFde6lcCtQeAdlXJF+N1UXn5UrhtRKAWWJlByIgyiCdshiskUVQ7gFUwbvKJU6\n\t5w2Hx56rekhMeprHp7KzYzBHRLT23/E8Zp/WDSpTffg/sbtzHmMF5yfI3mZioulDdx04\n\tBRyZOf9z5DM8uoGKVezFVTD5LqQ23BgQ4Qt0fm/2/LFo02Ae2uoMfl8SqFQMfuwJeJpG\n\tt1ZQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=fYYBU6lXxmdxFc5kJzmcd9lKEXu3LRXTxkV5898UIvU=;\n\tb=V9+Ndx9Q9gC4qAQKIvuInFP0GJk6Jue3828KkbD2jNC30iuBhYbG8+2rjpri28S1xG\n\tS/tiT0wBX/g5/s7xVY3BAcWZS1W+Ti/9m5erMfJ5PoJhxU2sf3g4HzfP2pqopHBZr/RG\n\tIO9CH8Ajfyu0Yo5JBRewE8+ewftovYw9KuamcUtTkHCNn0HUPB0PoiyGQY7tuwlpT8bT\n\tiS4BLe79hFd8ukjiZCR9Cnh+VozwAdHqCvDhLcWq/JDZMu7E6L7+zrnZ5DYDaa6dN/7A\n\tedyC2nR9nyXsSEAIT7v8qsmrEbNgyED+pSvrT9jbflAZstQ6mfK8D/8r0DaympjTTZCM\n\tobvw==","X-Gm-Message-State":"APjAAAW2FDRMLKXu6/AyqwO8tXeDIQfZRI9NAxSR+ocQay3eI4qjGrou\n\tjdBONRnz9aZot4CTFN4iKs+Mug==","X-Google-Smtp-Source":"APXvYqwXWcniHvAMbJhiE5SiCS3LLx+RWeORdeg9+o1V/1jySKjvvR/r3UQqXKnz4QtGF7D7Chh9uA==","X-Received":"by 2002:a2e:7d06:: with SMTP id y6mr2675964ljc.180.1572360122473;\n\tTue, 29 Oct 2019 07:42:02 -0700 (PDT)","Date":"Tue, 29 Oct 2019 15:42:01 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191029144201.GM20198@bigcity.dyn.berto.se>","References":"<20191028104913.14985-1-laurent.pinchart@ideasonboard.com>\n\t<20191028104913.14985-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191028104913.14985-6-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 5/9] libcamera: signal: Specify\n\tconnection type for signals","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 29 Oct 2019 14:42:03 -0000"}}]